commit-bot@chromium.org
|
c2e9db30d3
|
Fixed a few places where uninitialized memory could have been read
Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter.
BUG=326206,326197,326229
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/106943002
git-svn-id: http://skia.googlecode.com/svn/trunk@12544 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-12-06 20:14:46 +00:00 |
|
commit-bot@chromium.org
|
cd3b15ca63
|
Fixed bad bitmap size crashes
There were 2 issues :
1 ) If the size of an SkBitmap's underlying SkPixelRef's alocated memory is too small to fit the bitmap, then the deserialization will now check this and set an error appropriately.
2 ) If a device fails to allocate its pixels, the device will be deleted and NULL will be returned to avoid attempting to draw on a bad device.
BUG=
R=senorblanco@chromium.org, reed@google.com, sugoi@google.com, halcanary@google.com, mtklein@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/92793002
git-svn-id: http://skia.googlecode.com/svn/trunk@12484 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-12-04 17:06:49 +00:00 |
|
commit-bot@chromium.org
|
4b413c8bb1
|
remove SkFloatToScalar macro
BUG=
R=reed@google.com, djsollen@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/85463005
git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-11-25 19:44:07 +00:00 |
|
reed@google.com
|
4469938e92
|
Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning""
This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d.
BUG=
Review URL: https://codereview.chromium.org/54603004
git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-31 17:28:30 +00:00 |
|
reed@google.com
|
6fcbfcead5
|
Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"
This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497.
git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-31 16:31:11 +00:00 |
|
reed@google.com
|
081560e3ab
|
add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning
BUG=
R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org
Review URL: https://codereview.chromium.org/51033004
git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-31 16:24:08 +00:00 |
|
commit-bot@chromium.org
|
77e079af1a
|
Enabling validation code in serialization and adding serialization to fuzzer
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11968
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com, robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11981 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-28 15:52:02 +00:00 |
|
robertphillips@google.com
|
3721ee652a
|
Reverting r11968 (Enabling validation code in serialization and adding serialization to fuzzer - https://codereview.chromium.org/44573002) due to failure on Chromium AllQuads test.
git-svn-id: http://skia.googlecode.com/svn/trunk@11974 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-28 12:08:52 +00:00 |
|
commit-bot@chromium.org
|
d25d6c7b8e
|
Enabling validation code in serialization and adding serialization to fuzzer
BUG=
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11968 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-10-25 21:04:40 +00:00 |
|
skia.committer@gmail.com
|
f91e3d4f54
|
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11411 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-09-20 07:01:33 +00:00 |
|
robertphillips@google.com
|
191eaeb916
|
Fix for SampleFilterFuzz compiler warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@11408 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-09-19 22:02:37 +00:00 |
|
sugoi@google.com
|
bb8148b763
|
Fixed warnings as error
BUG=
R=edisonn@google.com, rmistry@google.com
Review URL: https://codereview.chromium.org/24246006
git-svn-id: http://skia.googlecode.com/svn/trunk@11398 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-09-19 19:51:27 +00:00 |
|
commit-bot@chromium.org
|
22d69f9973
|
I'm investigating how to make the IPC transfer a bit more secure on the
skia side by adding some safety checks. This cl is about brainstorming
and proposing possible solutions for type checking at different stages.
BUG=
R=senorblanco@google.com, sugoi@google.com, scroggo@google.com, reed@android.com, senorblanco@chromium.org, mtklein@google.com, reed@google.com
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22799007
git-svn-id: http://skia.googlecode.com/svn/trunk@11395 2bbb7eff-a529-9590-31e7-b0007b416f81
|
2013-09-19 18:40:49 +00:00 |
|