Commit Graph

60560 Commits

Author SHA1 Message Date
John Stiles
d259c5e4a2 Run SkSL unit tests with optimizations disabled.
We were already running unit tests twice--once with inlining on, and
once with inlining off, but always with optimization on. Now, the two
passes are instead "inliner + optimizer both on" and "inliner +
optimizer both off". (Testing the full 2x2 matrix of possibilities seems
like overkill.)

Change-Id: I73fb0932877c7b953c1f2e122125e5e7781a8582
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539396
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-11 14:38:07 +00:00
John Stiles
462dab699c Emit dead expressions when optimizations are off.
Fixes a minor issue discovered by http://review.skia.org/539198 .

Change-Id: I63f555cc005df33ce50c412796a8c773a501d271
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539199
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-05-11 13:37:48 +00:00
John Stiles
2f13b32f79 Add dedicated golden test for enabling/disabling fOptimize.
Previously we didn't have any mechanism for disabling the optimizer when
building golden outputs, so every golden output always had optimizations
applied.

Change-Id: I8f370b06daab6cb50bb4339eab0d39578621413b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539198
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 13:37:12 +00:00
Florin Malita
e1df5b2115 Update SkVideoEncode/Decoder for latest libavcodec
Some APIs have been const-ified.

Change-Id: I08699f219944057bd730d3f7a5f5466cdd829233
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539064
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-11 12:57:30 +00:00
skia-autoroll
8d3d0bcd4b Roll ANGLE from 2b8172b9b21e to a8ebdf2b5a8b (15 revisions)
2b8172b9b2..a8ebdf2b5a

2022-05-10 yuxinhu@google.com Basis Universal Texture Experiment
2022-05-10 geofflang@google.com Metal: Log the shader source when a shader fails to translate
2022-05-10 lexa.knyazev@gmail.com D3D: Mark images clean after syncing from storage
2022-05-10 johnstiles@google.com Fix crash when calling certain gl APIs before initialization.
2022-05-10 gert.wollny@collabora.com Capture/Replay: rename ANGLE_CAPTURE to ANGLE_CAPTURE_GL
2022-05-10 antonio.caggiano@collabora.com Re-land: "Vulkan: GBM platform"
2022-05-10 syoussefi@chromium.org Vulkan: Support wide lines
2022-05-10 jmadill@chromium.org Vulkan: Clean up flag passing in ImageView init.
2022-05-10 senorblanco@chromium.org D3D11: fix 3D texture blits.
2022-05-10 syoussefi@chromium.org Vulkan: Refactor UtilsVk dynamic state handling
2022-05-10 jmadill@chromium.org Vulkan: Determined sized-ness of format in initImageViews.
2022-05-10 romanl@google.com Switch deqp merge to python3
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: Ic670dd15a39dfe5abc5f009f9fc5aefbe80564fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539266
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 05:55:47 +00:00
skia-autoroll
39d6a68535 Roll vulkan-deps from 100b1c52ea66 to b768d03422ea (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/100b1c52ea66..b768d03422ea

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross from 0c8a79b0b5c7 to 940efca099af
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from ad3514b73237 to f74b85853c35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: lovisolo@google.com
Change-Id: Ic26f20409620b5cdbd4a43b9b31fb47e30ee2ec7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539278
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 05:45:16 +00:00
skia-autoroll
ddae049c23 Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4a6f2d74d3c..e0a1188d7652

2022-05-10 syoussefi@google.com Fix dynamic state for line width

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: Ife2d1a76865897441492633d3c96a1464a74970b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539267
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 04:53:16 +00:00
skia-autoroll
5761cae936 Roll Dawn from 824e824709a7 to b2004907a354 (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/824e824709a7..b2004907a354

2022-05-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9872c1d63f38 to a8ebdf2b5a8b (11 revisions)
2022-05-11 cwallez@chromium.org Fix gn check for dawn_unittests.
2022-05-11 cwallez@chromium.org Fix warning in dawn.node for the newly added shader-f16 extension.
2022-05-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 27ef4a0d9701 to b17c2c5b5b53 (6 revisions)
2022-05-10 kainino@chromium.org Revert "[chromium-style] Adding constructors and destructors."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Change-Id: I2c8b17a276c03c8cd2bf9e9207e813e06729694d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539265
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 04:37:00 +00:00
skia-autoroll
18c861675e Roll Dawn from be0abb611aed to 824e824709a7 (31 revisions)
https://dawn.googlesource.com/dawn.git/+log/be0abb611aed..824e824709a7

2022-05-10 bclayton@google.com tint: Rename float / int literal tokens
2022-05-10 bclayton@google.com tint: Add abstract AInt and AFloat typedefs
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
2022-05-10 dsinclair@chromium.org [warnings] Add Wsuggest-override and Wsuggest-destructor-override.
2022-05-10 enga@chromium.org Don't use incremental build in webgpu-cts/scripts/list.py
2022-05-10 bclayton@google.com tint: Replace all ProgramBuilder float literals with '_f' suffix
2022-05-10 cwallez@chromium.org DawnTest: Make error/device loss mocks StrictMocks
2022-05-10 bclayton@google.com tint: Add a negation operator to Number
2022-05-10 bclayton@google.com tint: Prevent Expr() implicit conversion to bool
2022-05-10 bclayton@google.com tint: Lex different tokens for float suffixes
2022-05-10 cwallez@chromium.org Triage WebGPU CTS expectations
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2b8172b9b21e to 9872c1d63f38 (4 revisions)
2022-05-10 dsinclair@chromium.org [warnings] Add -Wunused-macros
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7de4282f2446 to 27ef4a0d9701 (1 revision)
2022-05-10 jiawei.shao@intel.com tint: Support dot4I8Packed and dot4U8Packed in sem
2022-05-10 cwallez@chromium.org ShaderModule: Don't create an inspector just to reflect exts
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f5cda7835ab7 to e4a6f2d74d3c (1 revision)
2022-05-10 cwallez@chromium.org Vk: Run SingleEntryPoint before BindingRemapper.
2022-05-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 78d88796b44b to 2b8172b9b21e (12 revisions)
2022-05-10 dsinclair@chromium.org [chromium-style] Adding constructors and destructors.
2022-05-09 lokokung@google.com Remove NiceMock on device lost callback.
2022-05-09 dsinclair@chromium.org [chromium-style] Adding/moving constructors and destructors.
2022-05-09 bclayton@google.com tint: Add unary-ops to the intrinsic table
2022-05-09 brandon1.jones@intel.com Remove Unsafe API Toggle Check For Multiplane External Textures
2022-05-09 dsinclair@chromium.org [chromium-style] Adding/moving constructors and destructors.
2022-05-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 626b2fd72bde to 7de4282f2446 (1 revision)
2022-05-09 bclayton@google.com tint: Add binary-ops to the intrinsic table
2022-05-09 dsinclair@chromium.org [chromium-style] Split mock constructors/destructors to cpp files.
2022-05-09 bclayton@google.com tint: Add operator support to intrinsic-gen
2022-05-09 dsinclair@chromium.org [chromium-style] Fixup a few chromium-style issues.
2022-05-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1dd93361b1d9 to f5cda7835ab7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Test: Test: tint_unittests
Change-Id: Icac40429be0907c2677385a84289ecfa14d8850d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539217
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 23:56:49 +00:00
John Stiles
f54b4d5eb4 Revert "[infra] Remove old python scripts and urllib2 references"
This reverts commit 167e608bb3.

Reason for revert: breaking Housekeeper-CheckGeneratedFiles
(fetch-clang-format)

Original change's description:
> [infra] Remove old python scripts and urllib2 references
>
> I was searching for urllib2 while resolving issues with
> https://skia-review.googlesource.com/c/skia/+/538636
> when I found several old, apparently unused scripts.
>
> Rather than fix them, let's get rid of them. If they
> are still in use, the conversion to urllib.request is
> pretty easy.
>
> Change-Id: I27d419601e81c93a3d53e280188a379dfab927c4
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538936
> Auto-Submit: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

Change-Id: I139a3cd070da2e6fee2f8865138cf6a63441a8cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539201
Auto-Submit: John Stiles <johnstiles@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-05-10 22:48:08 +00:00
John Stiles
c2354396f0 Update comment about emitting static code snippets.
This comment fell out-of-date when the Graphite modules were added.
(I had tweaked it slightly at the time, but had missed some other places
that talked about injecting static code snippets.)

Change-Id: Ibbdf5ce14b8c77393f9da2ee22c82001e3bfd6c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539045
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-05-10 20:27:47 +00:00
Herb Derby
3612fdb811 Replace path count with the read failure line number
Make it easier to figure out READ_FAILURE is reporting a problem.

Bug: chromium:1287356
Change-Id: I3962932aed5c55efc2ded941cf218e5a8e75e972
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539044
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-10 20:05:56 +00:00
Antonio Maiorano
cd3200b7a4 Manually roll Dawn from 9483b741a..be0abb611 (36 commits; 1 trivial rolls)
https://dawn.googlesource.com/dawn.git/+log/9483b741a884..be0abb611aed

$ git log 9483b741a..be0abb611 --date=short --no-merges --format='%ad %ae %s'
2022-05-09 dawn-autoroll Roll ANGLE from e316203a6a2f to 78d88796b44b (1 revision)
2022-05-08 dawn-autoroll Roll ANGLE from 225d8f83af71 to e316203a6a2f (1 revision)
2022-05-07 dawn-autoroll Roll SwiftShader from 00efa1913863 to 1dd93361b1d9 (1 revision)
2022-05-07 dawn-autoroll Roll ANGLE from cadb933fdb12 to 225d8f83af71 (2 revisions)
2022-05-07 dawn-autoroll Roll vulkan-deps from e13072c54977 to 626b2fd72bde (2 revisions)
2022-05-07 dawn-autoroll Roll SwiftShader from 74e34ab97aeb to 00efa1913863 (2 revisions)
2022-05-06 dawn-autoroll Roll ANGLE from 1d5d09e4191a to cadb933fdb12 (14 revisions)
2022-05-06 dawn-autoroll Roll vulkan-deps from 4957ae734445 to e13072c54977 (21 revisions)
2022-05-06 dawn-autoroll Roll SwiftShader from 62c1af08ea4d to 74e34ab97aeb (5 revisions)
2022-05-06 bclayton tint: Rename and move builtin_table and builtin-gen
2022-05-06 bclayton dawn: Fix clang warning treated as error
2022-05-06 zhaoming.jiang dawn: Add shader module validation for WGSL extension
2022-05-06 dawn-autoroll Roll ANGLE from 2ce60b52a239 to 1d5d09e4191a (10 revisions)
2022-05-05 jrprice Surface Vulkan validation messages in errors
2022-05-05 bclayton tint: Change all ProgramBuilder literals to 'i' or 'u' suffix
2022-05-05 dawn-autoroll Roll ANGLE from 9865ed8b8117 to 2ce60b52a239 (4 revisions)
2022-05-05 bclayton tint: Castable - support non-default-constructable return types
2022-05-05 dawn-autoroll Roll SwiftShader from 2e793ae08002 to 62c1af08ea4d (1 revision)
2022-05-05 amaiorano tint: add --overrides flag to specify pipeline overrides
2022-05-05 pkasting Fixes for C++20 support.
2022-05-05 bclayton tint: Add Bitcast helper
2022-05-05 bclayton tint: Fix CFI error in BlockAllocator
2022-05-05 dawn-autoroll Roll ANGLE from 9053a641bf5d to 9865ed8b8117 (1 revision)
2022-05-04 senorblanco OpenGLES: disable some end2end tests which require reading from depth textures.
2022-05-04 bclayton tint/reader/spirv: Generate 'i' suffixed literals
2022-05-04 bclayton tint: Merge [S|U]intLiteralExpression
2022-05-04 dawn-autoroll Roll SwiftShader from 643179694ec7 to 2e793ae08002 (1 revision)
2022-05-04 bclayton tint: Lex three types of integer literal
2022-05-04 dsinclair Enable more `gn check` results.
2022-05-04 dawn-autoroll Roll ANGLE from 84e42c3b04da to 9053a641bf5d (12 revisions)
2022-05-04 bclayton webgpu-cts/expectations.txt: Remove expectations that now pass
2022-05-04 amaiorano Disable angle dependency on wayland
2022-05-04 bclayton tint: Chromium-style fixes
2022-05-04 jamessliu2020 AST fuzzer: Change unary expression operator
2022-05-04 dawn-autoroll Roll SwiftShader from c75846ead9a0 to 643179694ec7 (3 revisions)

Created with:
  roll-dep third_party/externals/dawn

Change-Id: I6656ab41573ce465e9ced94ad65731be9bc5dafe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538716
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
2022-05-10 19:01:49 +00:00
James Godfrey-Kittle
930a11e0e1 [graphite] Add sweep gradient shader
The comments in this shader are copied from
719239cd69:src/gpu/ganesh/gradients/GrGradientShader.cpp;l=806.
We could also link to that code in the comments themselves if that would
be helpful.

Bug: skia:13302
Change-Id: I8f0733bd02d519c603f62612b5299b6d1d56792a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538416
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
2022-05-10 18:32:54 +00:00
Brian Osman
8b3731b336 Move settings tweak for "generic" programs into the compiler
Change-Id: I4643cc4c1f75deab279625e752b9fee7da2e2779
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539039
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-10 17:49:36 +00:00
Greg Daniel
2eddf1a560 Set VMA version define to limit it to vulkan 1.1.
Bug: b/231953246
Change-Id: Ib2b6ae50bfd13c7aff0e0c656bc61e5f8a6e4345
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539038
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-05-10 17:43:56 +00:00
skia-autoroll
6079423e54 Roll ANGLE from e316203a6a2f to 2b8172b9b21e (13 revisions)
e316203a6a..2b8172b9b2

2022-05-09 cclao@google.com Vulkan: Add missing initialization for mTotalMemorySize
2022-05-09 syoussefi@chromium.org Vulkan: Remove suppressions and workarounds for old AMD/Windows
2022-05-09 ynovikov@chromium.org Revert "Vulkan: GBM platform"
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions)
2022-05-09 geofflang@chromium.org Reset the program executable if async linking fails.
2022-05-09 antonio.caggiano@collabora.com Vulkan: GBM platform
2022-05-09 cclao@google.com Vulkan: Fix VVL error for black desert mobile
2022-05-09 lexa.knyazev@gmail.com Add CopyTextureTest.ClearAfterCopySubTexture
2022-05-09 jmadill@chromium.org Vulkan: Use ImageView layer count functions in TextureVk.
2022-05-09 geofflang@chromium.org HLSL: Disambiguate functions that have int/uint parameters.
2022-05-09 jmadill@chromium.org Vulkan: Always init image views using image format.
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions)
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Change-Id: I5e012995f7315271cdfe78b8e786ae347805b512
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538977
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 17:20:31 +00:00
Brian Osman
d724c74a4f Ensure skia_gl_standard is correct when skia_use_angle is true
This simplifies the bot script slightly. More importantly, it means that
local developers don't need to remember to do this when building ANGLE
on Mac.

Cq-Include-Trybots: luci.skia.skia.primary:Test-Mac12-Clang-MacMini9.1-GPU-AppleM1-arm64-Release-All-ANGLE
Change-Id: Ia60cd07f15e3b447b58cfa1198ea26f68f72384b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539036
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2022-05-10 17:13:15 +00:00
skia-autoroll
d886bdc4f6 Roll vulkan-deps from 626b2fd72bde to 100b1c52ea66 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/626b2fd72bde..100b1c52ea66

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from ffc8f2d45566 to ad3514b73237
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers from 8ba8294c86d0 to 33d4dd987fc8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: lovisolo@google.com
Change-Id: I26efc982cfbd2e5d94ff343e6ca4e0d33277f1e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539016
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 17:05:08 +00:00
skia-autoroll
0cd16173b0 Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1dd93361b1d9..e4a6f2d74d3c

2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ f5cda783
2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ 1dd93361

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: I9c6d332064ee074acfb01c52be8400ab0aa2d8cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538978
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 16:59:59 +00:00
Herb Derby
14427f740d Enhance debug tracing
Use if constexpr so that tracing code does not bit rot.

Change-Id: Ib85f79b53c6a48bb1b80a51e5539dbdf077802d8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538898
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-10 16:59:47 +00:00
Kevin Lubick
167e608bb3 [infra] Remove old python scripts and urllib2 references
I was searching for urllib2 while resolving issues with
https://skia-review.googlesource.com/c/skia/+/538636
when I found several old, apparently unused scripts.

Rather than fix them, let's get rid of them. If they
are still in use, the conversion to urllib.request is
pretty easy.

Change-Id: I27d419601e81c93a3d53e280188a379dfab927c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538936
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2022-05-10 16:54:39 +00:00
Herb Derby
add4004be5 Extract the CPU code of SkGlyphRunPainter called SkGlyphRunPainterCPU
Simplify the fields used by each, and simplify the CTORs in
the original SkGlyphRunPainter.

TODO: come up with a better no gpu method. Eventually, this
should be pure Sk. There is no need for GPU to make and
serialize a slug only to draw them.

Change-Id: I446fe0c285ae778a14b30e09c8a2cff3cd1a56c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538896
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-10 16:54:33 +00:00
Herb Derby
ee0d15dc9f Move the SubRun buffers to the Canvas using the GlyphRunBuilder
Move the SubRun buffers from the Paint to the Builder that is held
by the Canvas. This allows better sharing of the buffers, and enables
splitting the Painter into CPU and GPU.

Change-Id: I860441732b4042be0534af3d002d63ece02de8c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538662
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-09 17:43:57 +00:00
Ben Wagner
638fcaea9f Keep SkStrike alive for its SkDrawables.
In theory all glyph representations including masks, paths and drawables
should keep a reference to the SkStrike which owns the actual data they
refer to. For paths this is worked around by always creating a copy of
the path (which is inexpensive) which itself simply reference counts the
underlying path data which is not directly owned by the SkStrike. For
masks it is impractical for every mask to hold a reference to the
SkStrike in any event as the pointer alone would often be larger than
the image. For drawables the implementation may be simply a pointer to
the scaler context and a glyph id. In theory each drawable could hold a
reference to the SkStrike, but potentially means a lot of references
when ensuring the SkStrike outlives any drawables it produces would be
more effecient.

This change ensures that the SkStrike is referenced while holding
references to drawables the SkStrike produced.

Bug: chromium:1322902
Change-Id: I6db8ae1bd614167da008caaff089e7d3e15aa9bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537980
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-05-09 17:23:49 +00:00
Brian Salomon
05d6d80743 SkImage_Raster::onMakeColorTypeAndColorSpace checks for alloc failure
Bug: chromium:1319093
Change-Id: Ie3e602538a9728d80e48f60507f73ca8c7f05f32
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534498
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-05-09 17:00:19 +00:00
Herb Derby
344a7a20c8 Isolate the buffers for generating SubRuns
Isolate the buffers to move them from the Painter, where they are
situated on the Device(CPU) or SurfaceDrawContext(GPU), to the
Canvas. This will allow better sharing of the buffers, and the
splitting out of the CPU and GPU parts of the Painter.

Change-Id: Ie2a99dc7f9e784c4f00012b71ece5ff482687a88
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538660
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-05-09 16:14:01 +00:00
Herb Derby
3e7e4e94b4 Manage buffers at the list level only
Now that the painter has moved from a GlyphRun to a GlyphRunList,
handle the buffers at the GlyphRunList level only.

Change-Id: I37416c8b2164bbde207ecab0a77b419775d58e66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538659
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-09 15:43:45 +00:00
James Godfrey-Kittle
cfe50e2e47 Update docs to reference python3
Also updates a script with 2to3 to be python3-compatible.

Change-Id: I45981349664aef4491e7ab20e49889d461f8bf3f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538417
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-05-09 15:07:22 +00:00
Michael Ludwig
072000b5d4 Do not disable tessellating path renderer over command buffer
Bug: skia:13263
Change-Id: I29e04ccc88a9ff2286c82302740e404aeba1b740
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534669
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-09 14:37:12 +00:00
Brian Salomon
f7082cb9fa Rename SkCustomMesh to SkMesh
Also rename associated files, types, functions, etc.

Bug: skia:12720
Change-Id: Ibebb4e7071fa19c5a81cd36d567c96a42cd824f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538040
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-09 13:36:21 +00:00
skia-autoroll
0b81e99101 Roll ANGLE from 1d5d09e4191a to e316203a6a2f (17 revisions)
1d5d09e419..e316203a6a

2022-05-08 zzyiwei@chromium.org Vulkan: add forceContinuousRefreshOnSharedPresent feature
2022-05-07 yuxinhu@google.com Tests: Add Mortal Kombat App Trace
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4ca7acf89869 to 626b2fd72bde (22 revisions)
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3bc34dd4d819 to 333c8248b125 (124 revisions)
2022-05-06 cnorthrop@google.com Tests: Add Basemark GPU trace
2022-05-06 abdolrashidi@google.com Revert "Remove limit_max_texture_size_to_4096 workaround"
2022-05-06 ynovikov@chromium.org [Fuchsia] Download the gn sdk instead of core
2022-05-06 cnorthrop@google.com Tests: Add Puzzles and Survival trace
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 106df4122297 to acf70aaf3fdb (12 revisions)
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 643179694ec7 to 74e34ab97aeb (7 revisions)
2022-05-06 cnorthrop@google.com Tests: Add Monument Valley trace
2022-05-06 cnorthrop@google.com Tests: Add Dead Cells trace
2022-05-06 chonggu@google.com Migrate Fuchsia sdk checkout from using script to CIPD
2022-05-06 jmadill@chromium.org Vulkan: Simplify external format Chroma code.
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 617cd3226543 to 3bc34dd4d819 (40 revisions)
2022-05-06 lubosz.sarnecki@collabora.com util/X11Window: Set PMinSize and PMaxSize hints.
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a60295b6324 to 617cd3226543 (278 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: lovisolo@google.com
Test: Test: angle_end2end_tests --gtest_filter="EGLSingleBufferTest*"
Test: Test: angle_perftests --gtest_filter="*basemark_gpu*"
Test: Test: angle_perftests --gtest_filter="*dead_cells*"
Test: Test: angle_perftests --gtest_filter="*monument_valley*"
Test: Test: angle_perftests --gtest_filter="*mortal_kombat*"
Test: Test: angle_perftests --gtest_filter="*puzzles_and_survival*"
Test: Test: smooth draw with gpu accelerated low latency stylus in ChromeOS
Change-Id: I3b2402677f5c34b2c3dee1a403793599a4276e22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538597
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-09 05:54:17 +00:00
skia-autoroll
1ae84d1a68 Roll SwiftShader from 2400435e05b1 to 1dd93361b1d9 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2400435e05b1..1dd93361b1d9

2022-05-07 capn@google.com Always enable MemorySanitizer instrumentation for vertex routines
2022-05-07 capn@google.com Don't make use of roundps in MSan builds
2022-05-07 capn@google.com Don't make use of cvtps2dq in MSan builds
2022-05-06 capn@google.com Override the SPIRV-Headers path to use local copy
2022-05-06 capn@google.com Fix SPIRV-Tools Android.bp build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: lovisolo@google.com
Change-Id: Ib3bbdb383963d2284fb06cc80545ba8343e95fb8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538596
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-09 04:46:25 +00:00
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
83739ee0da Update SKP version
Automatic commit by the RecreateSKPs bot.

Change-Id: Idcced8f213e46ea32ed5ef81a50e6055ef91e957
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538556
Commit-Queue: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Bot-Commit: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2022-05-08 08:21:17 +00:00
skia-autoroll
0820e69d7c Roll vulkan-deps from 65a0abb71586 to 626b2fd72bde (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/65a0abb71586..626b2fd72bde

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from 7014be600c7a to ffc8f2d45566

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: Id4621cce2cc9207f9103e0c9a36cd661a08f13a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538090
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 23:34:44 +00:00
Brian Osman
ea640e7579 Hack to suppress warnings from MSL compiler
Change-Id: I43ca73d208334c71b393a4b6352b758c8c45ce27
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538045
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-06 20:51:59 +00:00
James Godfrey-Kittle
eba022af78 [graphite] Add radial gradient shader
Bug: skia:13302
Change-Id: I6c8e8e9e6741862977a3d1b89fb58bff9cb76ee7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537981
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
2022-05-06 20:25:05 +00:00
skia-autoroll
aac8e4545a Roll SK Tool from 52605d78544b to 3cd767f7c947
https://skia.googlesource.com/buildbot.git/+log/52605d78544b..3cd767f7c947

2022-05-06 kjlubick@google.com [infra] Remove Python2 binaries from all Infra tasks.
2022-05-06 kjlubick@google.com Regenerate schema

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I0ec61566e151a13766f8b54d356d0addcc1b25ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538085
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 20:08:20 +00:00
Michael Ludwig
2ad7b3f65e Move src/gpu/tessellate/ types into skgpu::tess namespace
For usages of constants in classes outside of skgpu::tess (e.g. when
using tessellation in skgpu::v1 or skgpu::graphite), the constants are
accessed with tess::. This is just to help with clarity since it scopes
the constant name. However, functions and types are still referred to
without that, and using namespace skgpu::tess is used to keep those
references simpler.

In headers, tess:: is added when there are only a few usages of the
types, or it's brought in as an alias.

Change-Id: I12af595659fe791de419db0393482dae6cd238e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-06 19:57:42 +00:00
Brian Osman
2537af901d Replace SPIRV generator's intrinsic map with a simple switch
On a Linux x64 build, this saves ~17 KB of code size.
It also reliably makes all sksl_spirv_ benchmarks faster.

Change-Id: If4a0f7cc320eb73017791d2e09127f96addec629
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538044
Reviewed-by: Arman Uguray <armansito@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-05-06 19:27:10 +00:00
Herb Derby
9f44b7fa84 Have processGlyphRun take a glyphRunList, and rename function
Rename processGlyphRun to categorizeGlyphRunList. Change processing
a single glyph run to processing the entire list. By taking
an SkGlyphRunList the code will have access to the buffers it needs
for processing when I move the buffers to the builder.

Clean up - remove some unneeded includes.

Change-Id: I2ce66292b7e63b9cbc63610ba9653b255417d7c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538037
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-06 19:25:47 +00:00
James Godfrey-Kittle
5d553ed398 Fix presubmits for Python 3
Calls to "python" won't work on vanilla MacOS installs (nor many
distributions of Linux), and AFAICT we're assuming it refers to python3
anyways.

xreadlines was removed in Python 3, and the suggested equivalent is to
use the file directly as an iterator:
https://docs.python.org/2.7/library/stdtypes.html#file.xreadlines

Change-Id: Iae51e3923e38ea63f857a17b9ff80e79871efee5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537982
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
2022-05-06 18:48:47 +00:00
Robert Phillips
b346e421a7 Add FailFlushTimeCallbacks jobs
Bug: 1320964
Change-Id: I5f05ea469b824b1382f64c1eb3fb9be0498cf329
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537517
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-05-06 18:37:51 +00:00
Herb Derby
0dcb88b44c Encapsulate a pointer to the Builder in the GlyphRunList
The canvas contains the builder. By passing a pointer to the
builder with the GlyphRunList, we can add the machinety for
building SubRuns in future CLs.

Currently, all the buffers needed for building SubRuns are
maintained in the Device for CPU and the SurfaceDrawContext
for GPU. Because of the Layer mechanism in the API this means
we can have multiple sets of buffers. By moving the buffers to
the builder, there will be only one set, and the memory will
be hotter.

Change-Id: I47223b0dcfbab7d9b383d8410bb8d8e897706dd2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537776
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-06 18:17:48 +00:00
Kevin Lubick
3413ca474b [infra] Add BazelBuild task to build CanvasKit on the CI with Bazel
For additional context, see "Codifying Certain Build Options"
and "Building on the CI" in the design doc go/skia-bazel

Suggested review order:
 - builder_name_schema.json to see the three required and
   one optional part of BazelBuild jobs.
 - jobs.json to see one new BazelBuild job added. In an
   ideal world, this job would have been named
   BazelBuild-//modules/canvaskit:canvaskit_wasm-debug-linux_x64
   but Buildbucket (?) requires jobs match the regex
   ^[a-zA-Z0-9\\-_.\\(\\) ]{1,128}$
   so we use spaces instead of slashes or colons.
 - gen_tasks_logic.go; noting the makeBazelLabel function
   expands most of the spaces to / and the last one to a
   colon to make a single-target label. If there are three
   dots, then it is a multi-target label, and we do not
   need to add a colon.
 - bazel_build.go; This is a very simple task driver, and
   I do not anticipate getting too much more complex.
   The place where we decide which args to augment
   a build with depend on the host platform and thus
   should be set in gen_tasks_logic.go.
 - bazel/buildrc to see some initial configurations set,
   one of which, "debug", is used by the new job.
   The "release" version of CanvasKit probably works on
   3.1.10 which had a bugfix, but we are still on
   3.1.9
 - .bazelrc to see a rename of the linux-rbe config to
   linux_rbe (our configs should have no dashes if
   we want to specify them verbatim in our Job names).
   It also imports the Skia-specified build configs
   from //bazel/buildrc and supports the user-specified
   //bazel/user/buildrc file if it exists.
 - All other files in any order.

Change-Id: Ib954dd6045100eadcbbf4ffee0888f6fbce65fa7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537797
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2022-05-06 17:54:08 +00:00
Robert Phillips
4ff975ccd2 Make the old-skp job's output match the size of the DDL jobs' output (take 2)
Bug: skia:13278
Change-Id: I06d0551a2f2b50e584e6bb547c22bf6e76a9ea2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537800
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-05-06 16:31:45 +00:00
Kevin Lubick
2f576263e4 Reland "[infra] Use Python3 for our Presubmits"
This is a reland of commit 094bcdb9e5

Original change's description:
> [infra] Use Python3 for our Presubmits
>
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_support.py;l=319;drc=443d9135cc33f3156d5fe25ebec33f9adffbab65
>
> This also makes any errors from `make train -C infra/bots`
> look well formatted because check_output returns a bytestring
> in Python3 and when that is printed, the newlines et al are not
> rendered correctly. Thus we want the output of check_output
> to be encoded to UTF-8.
>
> Without setting the USE_PYTHON3 = True in PRESUBMIT.py,
> it appears that `git cl upload` would try to run our
> infra_tests.py in Python2 mode, which does not have
> the encoding argument for check_output.
>
> Apparently cipd_bin_packages/vpython3 does not have the
> "six" package installed (but cipd_bin_packages/vpython does)
> so I replaced the six.StringIO with io.StringIO, which
> is where that is located in Python3.
>
> Change-Id: Ic8f61bf943531583ba3d110a85260d69bdbf5eb2
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537677
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

Change-Id: Ia7fb2f3b6d8b70ca95cf10763782d4a0122053e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537978
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-05-06 14:01:35 +00:00
Robert Phillips
2f60656f83 Remove unused renderTask ID span parameter to pre- and post-Flush callbacks
I don't know if we ever actually used this feature. Removing it removes
and needless loop over all the render tasks.

Change-Id: Ife8014c45a34fdec743227dea09e440e0d1d9ea3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537516
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-05-06 13:57:51 +00:00
skia-autoroll
d77f5acbcd Roll vulkan-deps from 46b00d7bf03f to 65a0abb71586 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/46b00d7bf03f..65a0abb71586

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: I66743dc776ba20a52161a80d294f3b911dacd648
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/538056
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 10:55:47 +00:00
skia-autoroll
080fe3d744 Roll ANGLE from 9865ed8b8117 to 1d5d09e4191a (14 revisions)
9865ed8b81..1d5d09e419

2022-05-06 syoussefi@chromium.org Vulkan: Prefer MAILBOX over IMMEDIATE present mode
2022-05-05 cclao@google.com Vulkan: Reduce kMaxBufferToImageCopySize to 64M
2022-05-05 cclao@google.com Vulkan: Limit the total bytes of suballocation garbages in flight
2022-05-05 lubosz.sarnecki@collabora.com FramebufferTest: Add FramebufferChangeTest test.
2022-05-05 cnorthrop@google.com Scripts: Strip prebuilt debug APK from AOSP roll
2022-05-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1c301e690de1 to 7a60295b6324 (184 revisions)
2022-05-05 cclao@google.com Vulkan: Force prune when there are lots of suballocations destroyed
2022-05-05 boliu@google.com Remove limit_max_texture_size_to_4096 workaround
2022-05-05 cclao@google.com Vulkan: Use heuristic to decide how many empty buffers to keep
2022-05-05 lubosz.sarnecki@collabora.com Tests: Add Alto's Odyssey trace.
2022-05-05 pkasting@chromium.org Fixes for C++20 support.
2022-05-05 abdolrashidi@google.com Vulkan: Set timeout for MultiContextDrawWithSwap*
2022-05-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6db3a94387ed to 1c301e690de1 (550 revisions)
2022-05-05 ynovikov@chromium.org Decommission win7-x86-amd and win7-x64-nvidia

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: jlavrova@google.com
Test: Test: ./scripts/roll_aosp.sh and inspect //build
Test: Test: angle_end2end_tests --gtest_filter="FramebufferTest_ES3.FramebufferChangeTest/*"
Test: Test: angle_perftests --gtest_filter="*altos_odyssey*"
Change-Id: I9fb3e027c895be626e0385dcc533a8e56f71c582
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537900
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 05:55:46 +00:00