Commit Graph

795 Commits

Author SHA1 Message Date
Ben Wagner
ab909b5cd3 Add duplicate Valgrind tasks on QuadroP400.
Valgrind 3.13.0 only supports up to AVX2, so I used SK_CPU_LIMIT_SSE41
to avoid failing with "Unrecognised instruction." (The existing Valgrind
tasks run on a ShuttleA machine, whose CPU only supports AVX.)

Needed to enable verbose output on all Valgrind tasks to avoid Swarming
I/O timeout. Opportunistically removed verbose output for Linux Intel
bots that are no longer failing.

Bug: skia:6881
Change-Id: I2ffa6efe901c97bd2e0bbc9b26632aafbb3cf9a6
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/31143
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-08-09 21:46:46 +00:00
Eric Boren
bca3b8d8e0 Revert "Bring recipes up to date."
This reverts commit e4024d5dab.

Reason for revert: Breaking Win bots

Original change's description:
> Bring recipes up to date.
> 
>   * Move recipe_engine URL to new canonical URL
>   * Add README.recipes.md (auto-generated doc from docstrings in repo,
>     regenerated with `recipes.py test train`).
>   * Bring depot_tools up to date
> 
> recipe_engine:
> 464fc26 Update a couple more URLs.
> 38808d0 Switch recipes-py CQ to Gerrit
> c7cdc9c Update canonical URL.
> 6bac51f Fix urls to googlesource.
> 5cf5e58 Convert code review to Gerrit
> e92def4 Add source manifest proto to recipe_engine.
> e0ddd60 Move internal downstream recipe roll trybots to production
> 3cae8e9 Add file.filesizes to recipe engine core modules.
> 862f333 Vendor 'luci_context' library.
> 6de5241 Add add_json_log='on_failure' to json module.
> e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result.
> 3b99cdd Fix "recipes.py test diff" not raising a failure
> 8e8339a [path] Fix root path mocking.
> 00799cc Add experimental internal downstream recipe trybots
> 0ca88ae Pretty up all recipe_engine documentation.
> de3238c Fix UnboundLocalError in find_recipe.
> 9b47d24 Move downstream recipe roll trybots to production
> da3467b Recursively apply recipe overrides
> 3d76281 [uuid] Remove unused uuid module
> 9959b07 Remove shutil module.
> 26475d6 Add more experimental downstream trybots
> 5c349eb [file] allow glob to handle nested patterns
> 12e7ca4 recipes.py test: enforce recipe expectations literally
> 241ddc2 [file] fix glob_paths when NO paths match, add tests.
> 11d7598 [file] Allow placeholders in file.copy
> 9419a0e [doc] Put all external URLs in a single section.
> 4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names
> 3ac778e [recipe_autoroller] regen docs on trivial rolls too.
> c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files.
> 5873ef2 Fix "env_prefixes" rendering.
> 
> depot_tools:
> fb3fa785 Roll recipe dependencies (trivial).
> a643e9e3 Update patch_projects crap for googlesource repos in infra.
> fb391fcd [gclient config] Update luci project URLs (ugh)
> 590a4189 Roll recipe dependencies (trivial).
> 8e6a5e6e Roll recipe dependencies (trivial).
> 0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL.
> 704d6ad8 Roll recipe dependencies (trivial).
> f1205599 Roll recipe dependencies (trivial).
> 243c9643 Roll recipe dependencies (trivial).
> e866182f depot_tools: Fix executable bit for gerrit_*.py
> 4759fc62 Roll recipe dependencies (trivial).
> 7ab47354 Roll recipe dependencies (trivial).
> 554e2bff Roll recipe dependencies (trivial).
> 9e8c78d2 Roll recipe dependencies (trivial).
> b0ad16ee gclient flatten: do not recurse into deps not in recursedeps
> d9f97bc5 Use https for short URLs wherever applicable (MoarTLS).
> c9353605 gclient flatten: fixes for chromium/src
> ecdfa41d Fix quoting in update_depot_tools.
> 1407d00d gclient: make variables from parent DEPS scope override ones in inner scope
> 07a6bea9 Expose ast via InputApi
> e864a3f2 Remove presubmit check for DISALLOW_* macros
> e1054034 fetch_end_to_end_test: add recipe
> 8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label
> 8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref
> 5aeeb72c [bootstraps] Sync at gclient, suppress output (#2)
> eb1feb90 [cipd] Bump version, log at warning (#2).
> 9f9d82ac Revert "[cipd] Bump version, log at warning."
> 18aa2d93 [cipd] Bump version, log at warning.
> fc6196b3 gclient flatten: preserve variable placeholders (reland #1)
> 5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
> 56766f1d Add experimental downstream recipe trybots to depot_tools
> 44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
> 393ba066 Revert "gclient flatten: preserve variable placeholders"
> e79ddeaa gclient flatten: preserve variable placeholders
> 5a80eab0 Use -prerelease flag to vswhere when packaging VS
> 4d92fe43 [bootstraps] Sync at gclient, suppress output.
> 357415cb gclient flatten: fix a bug with some recursedeps not being processed
> 3d6363b3 Roll recipe dependencies (trivial).
> b396315c Bump led version.
> a3a515a4 Revert "Generalize git index refresh to bot_update."
> 06e1aa07 Generalize git index refresh to bot_update.
> 7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
> f7543cdd git-cl: accept --force for -f everywhere
> 642dd84c [win/bootstrap] Use "for" instead of "set".
> ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
> 290f5f56 Remove "create-ntfs-junction".
> ff9a5dec Roll recipe dependencies (trivial).
> d2dbea66 Roll recipe dependencies (trivial).
> fc62f768 Simplify notify behavior in git-cl
> cfbb775f Roll recipe dependencies (trivial).
> ae895075 Use doseq=True when re-encoding url query parameters
> 98681d11 Remove obsolete destination-branch-check flag
> 8aa774cf Fix bot_update example
> dd1bc7c0 [cipd] Generate other platform suffixes.
> 383ace4b Fix git-crrev-parse on Mac.
> e5adf612 Fix typo with --send-email [sic] flags
> 0ed616a4 Roll recipe dependencies (trivial).
> 636b13fc Let Changelist().AddComment() mark changes as Ready
> 68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
> f3d5a114 Enable Gerrit-destination-branch check by default
> 31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
> c4dd3e82 [bootstrap/win] Remove support for legacy installs
> cc27ecb0 Revert "[tryserver] Remove unused methods."
> 68f6f279 [bootstrap/win] Always use "cipd.bat".
> 3a8717e1 [bootstrap/win] Remove legacy Git support.
> 6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
> 4e5207d6 git-cl issue 0: Don't operate on empty description
> 22a9cf54 git_footers: fix bug stdin-based message input.
> 02e59414 Fix bot_update's usage of the destination branch
> 83eb1cd5 Roll recipe dependencies (trivial).
> 400e989b 'git cl issue 0': Remove Change-Id
> 133ac1ab [tryserver] Remove unused methods.
> b08ba657 git_footer: be more resilient to malformed footers
> 9d842bab [recipe_modules/git] Remove logging.
> 3d9b5881 [win_tools] Use bundled Python CIPD packages (#2).
> 209a681f [git] Remove hard-coded "depot_tools" Git.
> e8eed65f Always copy "python.bat".
> aab09ca6 Whitelist "python_bin_reldir.txt".
> af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
> 7dadf05d Query Gerrit for destination branch in bot_update
> bf144679 [win_tools] Use bundled Python CIPD packages.
> b80fac66 Roll recipe dependencies (trivial).
> 265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
> 24025d3e tryserver: add support for gerrit footers
> 903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
> 49b8147b Add support to query a CL's branch to gerrit recipe module
> 4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
> 13e88538 Ignore the ".bleeding_edge" file.
> c8173825 git cl creds-check: improve report and give better recommendation.
> 4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
> 9cb802ca Improve gerrit recipe_module example
> 79e897b0 [git_bootstrap] Support new Git bundles.
> 8af46469 Roll recipe dependencies (trivial).
> 1f767e17 Fix autoninja.py for ninja -t compatibility
> 7466d1a9 [cipd] Run client in .bat to preserve STDIN.
> 13f258bf Remove SVN bootstrapping and some tooling.
> b12c5256 Roll recipe dependencies (trivial).
> 016f92e6 Roll recipe dependencies (trivial).
> 68506985 Roll recipe dependencies (trivial).
> 215ded77 Fix testFlattenPinAllDeps
> 271a1680 gclient flatten: implement --pin-all-deps
> fb022017 gclient flatten: include vars
> e36a8431 Roll recipe dependencies (trivial).
> de37c012 Fix git-numberer swallowing of footers for Rietveld.
> 4e89144a git-cl: fix auth error message computation
> 7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
> aaf93f48 gclient flatten: refactor flatten code to a class
> 807caf84 gclient flatten: remove --require-pinned-revisions
> 6fbf12f2 Enable query for changes in gerrit recipe module
> c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
> 4baaa11c gclient: avoid adding potentially duplicate entries to work queue
> d3790251 gclient: apply custom_vars when evaluating conditions
> a8fdab96 Roll recipe dependencies (trivial).
> e82c0dec [cipd] Fail if setup has an error.
> b1ad2f04 Update CIPD client, vpython and "LUCI editor".
> 6a1ab843 Roll recipe dependencies (trivial).
> 32f0e5d7 Roll recipe dependencies (trivial).
> bc9c5ccf Roll recipe dependencies (trivial).
> 54adb2a3 Generate initial recipes README.
> 603545b7 Roll recipe dependencies (trivial).
> e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
> 6014b566 gclient flatten: also handle allowed_hosts
> 70b3f3aa [bot_update] Pass spec as file.
> 1af0a337 Roll recipe dependencies (trivial).
> dc598e82 [bot_update] Prefix PATH, cleanup.
> 
> Bug: skia:
> Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
> Reviewed-on: https://skia-review.googlesource.com/32420
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,iannucci@google.com

Change-Id: I6ed89db0757ffeb366da96d655372e9710aa589e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/32520
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 13:03:15 +00:00
Robert Iannucci
e4024d5dab Bring recipes up to date.
* Move recipe_engine URL to new canonical URL
  * Add README.recipes.md (auto-generated doc from docstrings in repo,
    regenerated with `recipes.py test train`).
  * Bring depot_tools up to date

recipe_engine:
464fc26 Update a couple more URLs.
38808d0 Switch recipes-py CQ to Gerrit
c7cdc9c Update canonical URL.
6bac51f Fix urls to googlesource.
5cf5e58 Convert code review to Gerrit
e92def4 Add source manifest proto to recipe_engine.
e0ddd60 Move internal downstream recipe roll trybots to production
3cae8e9 Add file.filesizes to recipe engine core modules.
862f333 Vendor 'luci_context' library.
6de5241 Add add_json_log='on_failure' to json module.
e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result.
3b99cdd Fix "recipes.py test diff" not raising a failure
8e8339a [path] Fix root path mocking.
00799cc Add experimental internal downstream recipe trybots
0ca88ae Pretty up all recipe_engine documentation.
de3238c Fix UnboundLocalError in find_recipe.
9b47d24 Move downstream recipe roll trybots to production
da3467b Recursively apply recipe overrides
3d76281 [uuid] Remove unused uuid module
9959b07 Remove shutil module.
26475d6 Add more experimental downstream trybots
5c349eb [file] allow glob to handle nested patterns
12e7ca4 recipes.py test: enforce recipe expectations literally
241ddc2 [file] fix glob_paths when NO paths match, add tests.
11d7598 [file] Allow placeholders in file.copy
9419a0e [doc] Put all external URLs in a single section.
4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names
3ac778e [recipe_autoroller] regen docs on trivial rolls too.
c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files.
5873ef2 Fix "env_prefixes" rendering.

depot_tools:
fb3fa785 Roll recipe dependencies (trivial).
a643e9e3 Update patch_projects crap for googlesource repos in infra.
fb391fcd [gclient config] Update luci project URLs (ugh)
590a4189 Roll recipe dependencies (trivial).
8e6a5e6e Roll recipe dependencies (trivial).
0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL.
704d6ad8 Roll recipe dependencies (trivial).
f1205599 Roll recipe dependencies (trivial).
243c9643 Roll recipe dependencies (trivial).
e866182f depot_tools: Fix executable bit for gerrit_*.py
4759fc62 Roll recipe dependencies (trivial).
7ab47354 Roll recipe dependencies (trivial).
554e2bff Roll recipe dependencies (trivial).
9e8c78d2 Roll recipe dependencies (trivial).
b0ad16ee gclient flatten: do not recurse into deps not in recursedeps
d9f97bc5 Use https for short URLs wherever applicable (MoarTLS).
c9353605 gclient flatten: fixes for chromium/src
ecdfa41d Fix quoting in update_depot_tools.
1407d00d gclient: make variables from parent DEPS scope override ones in inner scope
07a6bea9 Expose ast via InputApi
e864a3f2 Remove presubmit check for DISALLOW_* macros
e1054034 fetch_end_to_end_test: add recipe
8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label
8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref
5aeeb72c [bootstraps] Sync at gclient, suppress output (#2)
eb1feb90 [cipd] Bump version, log at warning (#2).
9f9d82ac Revert "[cipd] Bump version, log at warning."
18aa2d93 [cipd] Bump version, log at warning.
fc6196b3 gclient flatten: preserve variable placeholders (reland #1)
5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
56766f1d Add experimental downstream recipe trybots to depot_tools
44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
393ba066 Revert "gclient flatten: preserve variable placeholders"
e79ddeaa gclient flatten: preserve variable placeholders
5a80eab0 Use -prerelease flag to vswhere when packaging VS
4d92fe43 [bootstraps] Sync at gclient, suppress output.
357415cb gclient flatten: fix a bug with some recursedeps not being processed
3d6363b3 Roll recipe dependencies (trivial).
b396315c Bump led version.
a3a515a4 Revert "Generalize git index refresh to bot_update."
06e1aa07 Generalize git index refresh to bot_update.
7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
f7543cdd git-cl: accept --force for -f everywhere
642dd84c [win/bootstrap] Use "for" instead of "set".
ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
290f5f56 Remove "create-ntfs-junction".
ff9a5dec Roll recipe dependencies (trivial).
d2dbea66 Roll recipe dependencies (trivial).
fc62f768 Simplify notify behavior in git-cl
cfbb775f Roll recipe dependencies (trivial).
ae895075 Use doseq=True when re-encoding url query parameters
98681d11 Remove obsolete destination-branch-check flag
8aa774cf Fix bot_update example
dd1bc7c0 [cipd] Generate other platform suffixes.
383ace4b Fix git-crrev-parse on Mac.
e5adf612 Fix typo with --send-email [sic] flags
0ed616a4 Roll recipe dependencies (trivial).
636b13fc Let Changelist().AddComment() mark changes as Ready
68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
f3d5a114 Enable Gerrit-destination-branch check by default
31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
c4dd3e82 [bootstrap/win] Remove support for legacy installs
cc27ecb0 Revert "[tryserver] Remove unused methods."
68f6f279 [bootstrap/win] Always use "cipd.bat".
3a8717e1 [bootstrap/win] Remove legacy Git support.
6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
4e5207d6 git-cl issue 0: Don't operate on empty description
22a9cf54 git_footers: fix bug stdin-based message input.
02e59414 Fix bot_update's usage of the destination branch
83eb1cd5 Roll recipe dependencies (trivial).
400e989b 'git cl issue 0': Remove Change-Id
133ac1ab [tryserver] Remove unused methods.
b08ba657 git_footer: be more resilient to malformed footers
9d842bab [recipe_modules/git] Remove logging.
3d9b5881 [win_tools] Use bundled Python CIPD packages (#2).
209a681f [git] Remove hard-coded "depot_tools" Git.
e8eed65f Always copy "python.bat".
aab09ca6 Whitelist "python_bin_reldir.txt".
af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
7dadf05d Query Gerrit for destination branch in bot_update
bf144679 [win_tools] Use bundled Python CIPD packages.
b80fac66 Roll recipe dependencies (trivial).
265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
24025d3e tryserver: add support for gerrit footers
903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
49b8147b Add support to query a CL's branch to gerrit recipe module
4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
13e88538 Ignore the ".bleeding_edge" file.
c8173825 git cl creds-check: improve report and give better recommendation.
4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
9cb802ca Improve gerrit recipe_module example
79e897b0 [git_bootstrap] Support new Git bundles.
8af46469 Roll recipe dependencies (trivial).
1f767e17 Fix autoninja.py for ninja -t compatibility
7466d1a9 [cipd] Run client in .bat to preserve STDIN.
13f258bf Remove SVN bootstrapping and some tooling.
b12c5256 Roll recipe dependencies (trivial).
016f92e6 Roll recipe dependencies (trivial).
68506985 Roll recipe dependencies (trivial).
215ded77 Fix testFlattenPinAllDeps
271a1680 gclient flatten: implement --pin-all-deps
fb022017 gclient flatten: include vars
e36a8431 Roll recipe dependencies (trivial).
de37c012 Fix git-numberer swallowing of footers for Rietveld.
4e89144a git-cl: fix auth error message computation
7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
aaf93f48 gclient flatten: refactor flatten code to a class
807caf84 gclient flatten: remove --require-pinned-revisions
6fbf12f2 Enable query for changes in gerrit recipe module
c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
4baaa11c gclient: avoid adding potentially duplicate entries to work queue
d3790251 gclient: apply custom_vars when evaluating conditions
a8fdab96 Roll recipe dependencies (trivial).
e82c0dec [cipd] Fail if setup has an error.
b1ad2f04 Update CIPD client, vpython and "LUCI editor".
6a1ab843 Roll recipe dependencies (trivial).
32f0e5d7 Roll recipe dependencies (trivial).
bc9c5ccf Roll recipe dependencies (trivial).
54adb2a3 Generate initial recipes README.
603545b7 Roll recipe dependencies (trivial).
e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
6014b566 gclient flatten: also handle allowed_hosts
70b3f3aa [bot_update] Pass spec as file.
1af0a337 Roll recipe dependencies (trivial).
dc598e82 [bot_update] Prefix PATH, cleanup.

Bug: skia:
Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
Reviewed-on: https://skia-review.googlesource.com/32420
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 12:49:04 +00:00
Ravi Mistry
8d8b016f52 Fix config in run_ct_skps.py
This stopped working after https://skia-review.googlesource.com/c/9871

Bug: skia:6934
Change-Id: I5fe88518806ba68acf2315bf06ec845ce975cf7f
Reviewed-on: https://skia-review.googlesource.com/32185
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-08-08 22:13:40 +00:00
Brian Osman
04e4dd3eed Added new test image (ICC v4 CMYK) to colorimages
Image origin: https://github.com/flutter/flutter/issues/11521

Bug: skia:
Change-Id: I5af8b155a4979c83d3dd9c0bdd15e0052c6d1f88
Reviewed-on: https://skia-review.googlesource.com/32000
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-08 15:32:24 +00:00
Ravi Mistry
0ac06e4726 Bot updates for SkiaCT tasks.
Use gcc-4.8 when compiling for Ubuntu14. Rename the CT tasks to make it
clear their child tasks run on Ubuntu14.

Move to Debian-9.1 bots created with the changes in
https://skia-review.googlesource.com/c/31281 and
https://skia-review.googlesource.com/c/31820

Change the cache dir used by the ct_skps recipe so that changing the
bot name doesn't invalidate the cache.

Bug: skia:6921
Bug: skia:6818
No-Try: true
Change-Id: Idaac8187427b5c2c7bffe66ad6674496b8cd0c0e
Reviewed-on: https://skia-review.googlesource.com/31242
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-08-08 14:17:49 +00:00
Greg Daniel
e0996536a8 Add another blacklist for win Intel perf
Started happening after an SKP updated. This looks to be another bug
in the llvm compiler Intel is using for windows vulkan.

Bug: skia:6863
Change-Id: If2bf4c4b61d0958a21e1e56eae6497310fcff3f8
Reviewed-on: https://skia-review.googlesource.com/31640
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-08-07 19:14:25 +00:00
Ravi Mistry
0f5505bfa2 Add failing SKP from new SKP repository to the ImgDecode blacklist
Bug: skia:6818
Change-Id: I03efbba1e67ed9c5e55eda056985d1be5fda13b2
Reviewed-on: https://skia-review.googlesource.com/31464
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-08-07 17:28:50 +00:00
Greg Daniel
8eec2e3d2d Remove blacklist of win nvidia vulkan skimage test
Bug: skia:6554
Change-Id: I59aaf6115aa33d73078386ba8e0791ae9e334fe7
Reviewed-on: https://skia-review.googlesource.com/31421
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-08-07 17:03:10 +00:00
Ben Wagner
e08c6a90e5 Upgrade Valgrind to 3.13.0.
Bug: skia:6881
Change-Id: I8c1e4be16f4a79e9aa6fb663337476d0c0fe8c1c
Reviewed-on: https://skia-review.googlesource.com/31024
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-07 13:58:00 +00:00
UpdateSKPs
b2a5973d02 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ie921f06c2a4cfce69972f3e1a3896e6d3e9db188
Reviewed-on: https://skia-review.googlesource.com/31340
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-08-06 07:59:23 +00:00
Ben Wagner
21c3fb94de Add OS to SkiaCT dimensions.
This will make it much easier to experiment with upgrading the OS to
Debian-9.1 without causing failures on master.

No-Try: true
Change-Id: Id43b055841ec3ceb42133c9dd7b630f12d1b45c6
Reviewed-on: https://skia-review.googlesource.com/31001
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-04 19:21:18 +00:00
Ben Wagner
5698b001ea Update Win10 Haswell bots to latest Intel driver.
Bug: skia:6917
Change-Id: I381e4d16705317671ea3d27c88fd811687336bb0
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/31101
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-04 18:39:14 +00:00
Ben Wagner
6f08ece37f Add duplicate XSAN tasks on QuadroP400.
Bug: skia:6881
Change-Id: I53356a19aaa488f0f739f8ddb687bbe0ea4994fe
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/26365
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-04 16:27:44 +00:00
Ben Wagner
c274ec4d7e Add Linux QuadroP400 bots.
Bug: skia:6882
Change-Id: I9514af6aa710f1722be277a529acd1d88ed32bc9
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/26364
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-04 16:22:24 +00:00
Ravi Mistry
698edfecef Chromium lkgr is no longer updated. Use lkcr
Bug: skia:6916
Change-Id: I16badf80c3b34e517b8baab161150c9434f325aa
Reviewed-on: https://skia-review.googlesource.com/30100
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-03 12:41:36 +00:00
Ben Wagner
ae532f68a0 Add Win10 QuadroP400 bots.
Bug: skia:6883
Change-Id: I0812bc0715f10e3722535af2cfc6fdf812cc487f
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/26366
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-03 11:34:17 +00:00
Ben Wagner
82cbdba7be Update all Debian bots to 9.1.
Bug: skia:6890
Change-Id: I4534e6d2794e0b66ea8e21f3148772d14ea97de8
Reviewed-on: https://skia-review.googlesource.com/29562
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-02 16:41:46 +00:00
Mike Klein
f1aace23d4 Add Perf-Win2k8-Clang bots.
Change-Id: I8108f48bb55cfb39532ef05e8e263769ff8fb10f
Reviewed-on: https://skia-review.googlesource.com/29420
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-01 17:47:49 +00:00
Mike Klein
402e463877 add more win/clang bots
- add a Debug builder
  - add Debug and Release CPU testers on GCE

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Debug,Test-Win2k8-Clang-GCE-CPU-AVX2-x86_64-Debug,Test-Win2k8-Clang-GCE-CPU-AVX2-x86_64-Release

Change-Id: I4f2d7309b36a532683f68fbdde9c7a9aaaa861ea
Reviewed-on: https://skia-review.googlesource.com/29023
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-07-31 21:46:24 +00:00
Mike Klein
8e3c42b1ee add a Win/Clang build bot
BUG=skia:2679

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Release

Change-Id: I861366ae1340abcc67e87041904d08337b465bbe
Reviewed-on: https://skia-review.googlesource.com/28864
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-31 19:53:51 +00:00
Eric Boren
2aa9b7ba2d Add clang_win asset
Bug: skia:2679
Change-Id: I7abffae32102a69271b23834a121c51426813e27
Reviewed-on: https://skia-review.googlesource.com/28785
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-07-31 19:14:53 +00:00
Eric Boren
ba937a4366 Some bots should only run on the master branch
Bug: skia:6556
Change-Id: Iebe8b30de70685f56b795521ccc2242b0682000b
Reviewed-on: https://skia-review.googlesource.com/28660
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-07-31 16:55:03 +00:00
UpdateSKPs
c25437da5c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I42bf807fe84f84793a9ace7eee5e893c451a8c6a
Reviewed-on: https://skia-review.googlesource.com/28520
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-07-30 06:06:50 +00:00
Greg Daniel
293d9bd3c2 Add Metal build bot
Bug: skia:6896
Change-Id: If2ed083703e6300b9d2a86cfb298011bbf54e018
Reviewed-on: https://skia-review.googlesource.com/28180
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-28 18:41:43 +00:00
Eric Boren
f7928b4f33 Add a bot to verify that generated SKSL files have not been hand-edited
Bug: skia:6893
Change-Id: I54480ddd1ad1989661393500044f9164a99ce7b0
Reviewed-on: https://skia-review.googlesource.com/27700
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-07-28 12:20:47 +00:00
Ben Wagner
789966d8dd Update Debian GTX960 dimensions to match bot.
Bug: skia:6890
No-Try: true
Change-Id: I7dea98375b4a146ceca74e4b1913cb281a4a3149
Reviewed-on: https://skia-review.googlesource.com/26802
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-26 19:22:05 +00:00
Kevin Lubick
6de39c1e01 Remove Ci20 MIPS devices
Bug: skia:
NOTRY=true
Change-Id: I125154a1e217fcaf085bdac704e3e761bf1e61d2
Reviewed-on: https://skia-review.googlesource.com/26380
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-24 19:28:55 +00:00
Mike Klein
97d6a7af80 Don't write .pdfs in DM on the bots.
They take a long time to upload, and we don't do anything with them.

BUG=skia:6821

Change-Id: I16c5fc423953fa3e9d0dcb184ecbbe23f3918357
Reviewed-on: https://skia-review.googlesource.com/26142
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-07-24 15:48:12 +00:00
UpdateSKPs
91ff3c15df Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I9b4fe16ea3718789dcd1c02f3cac538eb147f101
Reviewed-on: https://skia-review.googlesource.com/25922
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-07-23 09:00:28 +00:00
Stephan Altmueller
e86af693dc Enable verbose output on iOS and Android
Bug: skia:
Change-Id: Ia2c40b01d78257dd7e30805a034a581b708d0b90
Reviewed-on: https://skia-review.googlesource.com/25563
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-07-21 14:43:03 +00:00
Eric Boren
fe40abc14b Add new Android builder which uses API_LEVEL 26
Bug: skia:6870
Change-Id: Idd9a27518c1123c0a729b4d07461047f5530aae3
Reviewed-on: https://skia-review.googlesource.com/24960
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-20 18:25:12 +00:00
Chris Dalton
80ace82be1 Only run GL congs on CCPR bots
Bug: skia:
Change-Id: Ief012869b740bbfb947a77c91c4478a851f2517e
Reviewed-on: https://skia-review.googlesource.com/25062
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2017-07-20 17:39:52 +00:00
Derek Sollenberger
edfe3dfb47 Add option to ignore SIGINT when running DM on Android.
Bug: skia:6856
Change-Id: Iaaad2c22988cf8058304b7396c7d24eacd2f3edb
Reviewed-on: https://skia-review.googlesource.com/24745
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2017-07-20 16:28:06 +00:00
Eric Boren
edfe4a5ca0 [infra] Add protoc asset
This is actually just needed for the infra repo, but that doesn't have
any of the mechanisms for creating assets, so it's simpler to do that
here.

NOTRY=true
Bug: skia:6866
Change-Id: I5d9810fc7440703090b55b13d06b39f92e85f172
Reviewed-on: https://skia-review.googlesource.com/24680
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-07-19 18:23:36 +00:00
Greg Daniel
139eb805ca Add blacklist to vk win intel for skp
This blacklist the desk_skbug6850overlay2 which is causing llvm to crash
on the intel win bot when running vulkan.

Bug: skia:6863
Change-Id: I2c3ca597a3312e6c0a1bacae0056fcb1c19679bf
Reviewed-on: https://skia-review.googlesource.com/24264
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-07-19 14:52:14 +00:00
Ravi Mistry
d81977f51b Download material design SVGs from Google Storage
NoTry: true
Bug: skia:6865
Change-Id: Id857d6ad0b5cdccbadb11810bf07a093467544ec
Reviewed-on: https://skia-review.googlesource.com/24086
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-19 13:44:34 +00:00
Brian Salomon
44acb5b09b Revert "Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp""
This reverts commit e3e9628ecf.

Adds blendmode_mask_* benchs to blacklist for Chromecast.
Otherwise a clean revert of the revert.

Bug: skia:
Change-Id: I9f64ae55804fa4aad97c1785834281039570c56c
Reviewed-on: https://skia-review.googlesource.com/24409
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-07-19 12:17:34 +00:00
UpdateSKPs
11f898f154 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I5a6701b2d2fae53bede23669a6c3ae7d668da23d
Reviewed-on: https://skia-review.googlesource.com/24500
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-07-18 22:56:24 +00:00
Ravi Mistry
312f4b24f9 Copy over private SKPs during SKP asset create command
Bug: skia:6850
Change-Id: Idaa92d2b4233b9f03a15d70cc185261f0090bab4
Reviewed-on: https://skia-review.googlesource.com/24404
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-18 19:59:33 +00:00
Chris Dalton
97598a5061 Add two test bots for coverage counting path renderer
Bug: skia:
Change-Id: Ib8e89e5e9a75d24b69c23873168fcc23f9eb5c45
Reviewed-on: https://skia-review.googlesource.com/24063
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-18 17:21:23 +00:00
UpdateSKPs
1fcd10aae4 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Id11d0a2d8e282a043ca3029d6640d9c42ff56306
Reviewed-on: https://skia-review.googlesource.com/23780
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2017-07-16 07:52:06 +00:00
UpdateSKPs
b7fcd31377 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I6625bf8978209ff55a4107ecc2fca2341f01618f
Reviewed-on: https://skia-review.googlesource.com/23600
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-07-14 15:52:24 +00:00
Ravi Mistry
cf79ee5626 Publish uploaded RecreateSKPs CL
Bug: skia:6797
Change-Id: I02e2a3d13a52bba66f4f9d2129aae5f094828329
Reviewed-on: https://skia-review.googlesource.com/23323
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-14 12:41:34 +00:00
Ravi Mistry
50cd9e9cd1 Revert "Re-enable uploading to partner bucket"
This reverts commit 4e91f16fdf.

Reason for revert: Still does not work

Original change's description:
> Re-enable uploading to partner bucket
> 
> This is a revert of
> https://skia.googlesource.com/skia/+/da066b865c1e2777a84a829486a7b37a984484b4
> 
> NoTry: true
> Bug: skia:6797
> Change-Id: I9eca7e4b2234c79e39b2c25aaf459512dd206acc
> Reviewed-on: https://skia-review.googlesource.com/23202
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

TBR=borenet@google.com,rmistry@google.com

Change-Id: If1abb65801ba93d409825e290e22d7a9eb3818fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:6797
Reviewed-on: https://skia-review.googlesource.com/23004
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-13 20:46:34 +00:00
Ravi Mistry
4e91f16fdf Re-enable uploading to partner bucket
This is a revert of
https://skia.googlesource.com/skia/+/da066b865c1e2777a84a829486a7b37a984484b4

NoTry: true
Bug: skia:6797
Change-Id: I9eca7e4b2234c79e39b2c25aaf459512dd206acc
Reviewed-on: https://skia-review.googlesource.com/23202
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-13 18:54:02 +00:00
Ravi Mistry
9d3e162703 Download gitcookies from GS for RecreateSKPs bot
NoTry: true
Bug: skia:6797
Change-Id: Id7005ba5252c5f1e3f85a8bff92371e0562ab87b
Reviewed-on: https://skia-review.googlesource.com/22726
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-13 18:44:22 +00:00
Ravi Mistry
da066b865c Revert "Revert "Temporarily stop uploading to partner bucket in RecreateSKPs bot""
This reverts commit 0f3942fc24.

Reason for revert: Still cannot upload to partner bucket

Original change's description:
> Revert "Temporarily stop uploading to partner bucket in RecreateSKPs bot"
> 
> This reverts commit 6945c946ea.
> 
> Reason for revert: Should be able to upload to partner bucket now
> 
> Original change's description:
> > Temporarily stop uploading to partner bucket in RecreateSKPs bot
> > 
> > Bug: skia:6797
> > Change-Id: I812837d02b90b78b6df3980649ccf6362e939afc
> > Reviewed-on: https://skia-review.googlesource.com/20820
> > Commit-Queue: Ravi Mistry <rmistry@google.com>
> > Reviewed-by: Eric Boren <borenet@google.com>
> 
> TBR=borenet@google.com,rmistry@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: skia:6797
> Change-Id: I145275da0050da01fca3e6e9c3c5efd84bdadea1
> Reviewed-on: https://skia-review.googlesource.com/21738
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:6797
Change-Id: I5114c2cacd239c45c6a60cb7aa795c96ef28439e
Reviewed-on: https://skia-review.googlesource.com/22840
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-13 01:37:32 +00:00
Leon Scroggins III
51b2f1b64c Stop adding Android-specific defines to SkUserConfig
Remove #defines that lived in gn_to_bp.py and
android_framework_defines.gni. These have been moved into a new file
in Android, SkUserConfigManual.h, in https://googleplex-android-review.git.corp.google.com/#/c/2519600/

Update gn_to_bp.py to include SkUserConfigManual.h, so it will still
result in using the same #defines.

Lately, we've found it difficult to guard changes behind a flag. e.g.
a change to drawing causes a CTS failure in Android, so we have to do
the following:
- put the change behind a flag, and add it to gn_to_bp.py or
android_framework_defines.gni
- generate new images on Android (by running CTS with external/skia
modified to not define the flag)
- create a CL in CTS that uses the new images
- land a CL in Skia that stops defining the flag
- when the Skia change lands, wait for the auto-roller to create a CL
that includes the change, stop the auto-roller, add the topic to the CTS
CL so the two can land at the same time
- land both Android changes (with TreeHugger)
- restart the Android auto-roller

With SkUserConfigManual.h (which lives in Android), the process will
be similar to Chromium:
- land a CL in Android's external/skia that defines a flag e.g.
SK_SUPPORT_LEGACY_FEATURE. Land without TreeHugger because it isn't used
in Skia and does not do anything
- land a change in Skia that changes behavior unless
SK_SUPPORT_LEGACY_FEATURE is defined. This will safely go through the
Android roll and not change any behavior for Android
- create two Android CLs - one in CTS to use the new images, and one in
external/skia to delete SK_SUPPORT_LEGACY_FEATURE. Set them to the same
topic and land them with TreeHugger

In the new process, there is no need to mess with the Android roll.

A downside to the new process is that we cannot test the android
framework defines without checking in to Android. But given how much
we've progressed in automating Android testing, this is fine.

Bug: b/63429612
Change-Id: Idfbaef2f4cae641a75fb6e7bf70428733a441336
Reviewed-on: https://skia-review.googlesource.com/22072
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-11 20:43:35 +00:00
Eric Boren
810c2b657e [infra] Golo bots have been upgraded to Ubuntu 17.04
Bug: skia:
Change-Id: Ia18c02660b2ab75559400f26ecf610dd610b6540
Reviewed-on: https://skia-review.googlesource.com/22202
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-07-11 13:09:43 +00:00