Commit Graph

8 Commits

Author SHA1 Message Date
Ravi Mistry
1c29ac9398 Make uploading to Gerrit the default for Skia
BUG=skia:5612

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4621
# Does not get tested with CQ.
NOTRY=true

Change-Id: I8d3fbfc6e557948cff7722f0b42ea09dc9be68e1
Reviewed-on: https://skia-review.googlesource.com/4621
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-09 19:07:56 +00:00
rmistry
d223fb21d6 Automatically add a docs preview link and NOTRY=true when there are only docs changes.
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:3474

Review URL: https://codereview.chromium.org/960203002
2015-02-26 10:16:13 -08:00
sheyang
7b2b29abdb Add Project to skia
BUG=374398
R=reed@google.com, bsalomon@google.com, rmistry@google.com, borenet@google.com

Author: sheyang@chromium.org

Review URL: https://codereview.chromium.org/346853004
2014-06-20 09:39:15 -07:00
mtklein
b8cd7c253f Code reviews -> reviews@skia.org.
BUG=skia:
R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/328613003
2014-06-11 07:12:10 -07:00
rmistry
5787c6f5f6 Use googlesource VIEW_VC in codereview.settings
BUG=skia:2613
NOTREECHECKS=true
NOTRY=true
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/309643005
2014-06-02 05:20:32 -07:00
commit-bot@chromium.org
b5a827ab1c Add BUG_PREFIX to codereview.settings
NOTRY=True
NOTREECHECKS=True

(SkipBuildbotRuns)

BUG=skia:1983
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/138863002

git-svn-id: http://skia.googlecode.com/svn/trunk@13075 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 21:19:21 +00:00
rmistry@google.com
9868e7cfd0 Removing blank lines from codereview.settings.
depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.

(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7388061

git-svn-id: http://skia.googlecode.com/svn/trunk@7865 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 16:01:21 +00:00
rmistry@google.com
2876a59078 Pointing CODE_REVIEW_SERVER to Chromium Rietveld.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7382058

git-svn-id: http://skia.googlecode.com/svn/trunk@7858 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 12:01:28 +00:00