Commit Graph

100 Commits

Author SHA1 Message Date
commit-bot@chromium.org
df79acdbab Revert of Rebaselining bleed GMs due to recent GPU blur changes. (https://codereview.chromium.org/138353002/)
Reason for revert:
the bleed_gpu GM is failing on all the test builders.

Original issue's description:
> Rebaselining bleed GMs due to recent GPU blur changes.
>
> BUG=skia:1998
>
> Committed: https://code.google.com/p/skia/source/detail?r=13063

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1998

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/138133003

git-svn-id: http://skia.googlecode.com/svn/trunk@13064 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 16:21:31 +00:00
bsalomon@google.com
3f88f4d5ad Rebaselining bleed GMs due to recent GPU blur changes.
BUG=skia:1998

Review URL: https://codereview.chromium.org/138353002

git-svn-id: http://skia.googlecode.com/svn/trunk@13063 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 15:28:24 +00:00
commit-bot@chromium.org
3e62ebf93b make ignored-tests.txt specify full test name, not partial name
BUG=skia:2022
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/136883006

git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
bsalomon@google.com
cd9175eddb remove _gpu suffix from tests in ignored-tests.txt that are changed on all gpu configs (msaa, ...).
Review URL: https://codereview.chromium.org/136713005

git-svn-id: http://skia.googlecode.com/svn/trunk@13049 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:26:14 +00:00
commit-bot@chromium.org
439ff1b9ca Use correct matrix to adjust blur radius for gpu
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/134973002

git-svn-id: http://skia.googlecode.com/svn/trunk@13047 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 16:39:39 +00:00
bsalomon@google.com
4db7a31678 Remove rects GM from ignored-tests.txt and rebaseline
BUG=skia:1882

Review URL: https://codereview.chromium.org/136803002

git-svn-id: http://skia.googlecode.com/svn/trunk@13045 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:54 +00:00
commit-bot@chromium.org
a7d89c83a4 Handle drawBitmapRect src_rect->dst_rect mapping as a local matrix rather than view matrix when there is a mask filter.
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131323004

git-svn-id: http://skia.googlecode.com/svn/trunk@13041 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:47:00 +00:00
commit-bot@chromium.org
c45ece5f7f NEON fast path for box blur
Calculate 8 channels in parallel by using 16-bits to store each channel. Due to the limitation of VQRDMULH, (int16 * int16 * 2 + 0x8000) >> 16, the fast path can only support kernelSize < 128.
8 significant bits are kept at least in each stage, the final error should less-equal than 1.

Pre-fetching memory for X-direction read. In fact pre-fetching memory doesn't help much for Y direction read, since it is a waste to load a cache line for only read 8 bytes.(I left it there to keep the symmetry. pre-fetch is cheap :) )

bench data on Nexus 10
before:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  25081.48
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  25038.04
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  25209.04
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  24928.01
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  17160.98
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  17924.11
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =  14609.19
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =  14625.91

after:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  14848.42
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  16037.29
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  14819.55
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  14563.69
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  11905.34
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  11883.85
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =   9576.51
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =   9793.84

BUG=
R=senorblanco@chromium.org, mtklein@google.com, reed@google.com, kevin.petit@arm.com, kevin.petit.arm@gmail.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/105893003

git-svn-id: http://skia.googlecode.com/svn/trunk@13036 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 08:16:45 +00:00
bsalomon@google.com
4fdf25e6cc rebaseline downsample_text and downsample_checkerboard GMs on gpu configs
BUG=skia:1879

Review URL: https://codereview.chromium.org/125463002

git-svn-id: http://skia.googlecode.com/svn/trunk@12930 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:31:14 +00:00
bsalomon@google.com
7b22744ff0 Rebaselines for filterbitmap_text GMs
BUG=skia:1879

Review URL: https://codereview.chromium.org/109403007

git-svn-id: http://skia.googlecode.com/svn/trunk@12929 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:00:04 +00:00
bsalomon@google.com
79c95324b1 Rebaselines for filterbitmap_checkerboard
BUG=skia:1879

Review URL: https://codereview.chromium.org/108653019

git-svn-id: http://skia.googlecode.com/svn/trunk@12928 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 21:48:23 +00:00
bsalomon@google.com
da0f7616e9 Rebaseline mandrill GMs
BUG=skia:1879

Review URL: https://codereview.chromium.org/114603008

git-svn-id: http://skia.googlecode.com/svn/trunk@12924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:18:15 +00:00
senorblanco@chromium.org
323cc26308 New baselines for tileimagefilter, imagefiltersgraph, and everything Nexus4.
TBR=

Review URL: https://codereview.chromium.org/101693010

git-svn-id: http://skia.googlecode.com/svn/trunk@12898 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 00:14:54 +00:00
senorblanco@chromium.org
c8c599269d Widen suppression to tileimagefilter-pdf.
TBR=

Review URL: https://codereview.chromium.org/122683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12897 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:27:05 +00:00
senorblanco@chromium.org
a502d60b93 Ignore failures on tileimagefilter-pdf_poppler.
TBR=

Review URL: https://codereview.chromium.org/124263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12896 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:18:12 +00:00
senorblanco@chromium.org
6776b82d46 Make SkImageFilter crop rects relative to the primitive origin, instead of relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway.
To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change.

This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour.

NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case.

NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it.

R=reed@google.com

Review URL: https://codereview.chromium.org/112803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 21:48:22 +00:00
bsalomon@google.com
3f2028e3e6 rebaselinedownsamplebitmap_image_high_mandrill_512.png
BUG=skia:1879

Review URL: https://codereview.chromium.org/101413010

git-svn-id: http://skia.googlecode.com/svn/trunk@12787 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 21:36:35 +00:00
bsalomon@google.com
cf95fbad6b rebaseline clipped-bitmap-shaders GMs for gpu
Review URL: https://codereview.chromium.org/119443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12784 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 20:44:04 +00:00
commit-bot@chromium.org
6d7296aaa0 Accept displacement with no displacement input
BUG=
R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com, bsalomon@google.com, bsalomon@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/104853005

git-svn-id: http://skia.googlecode.com/svn/trunk@12773 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 17:00:46 +00:00
senorblanco@chromium.org
144cba079c New baselines for xfermodeimagefilter post-r12652.
TBR=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/118803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12769 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 15:41:12 +00:00
vandebo@chromium.org
7e5d24c22e Update expectations for r12729
"[PDF] Fix clipping in xfermode improvement."

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/112343007

git-svn-id: http://skia.googlecode.com/svn/trunk@12761 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 22:20:16 +00:00
commit-bot@chromium.org
d20f9b7358 Rebaselining displacement gms
Rebaseline needed because of changes made in https://codereview.chromium.org/101623007/

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, bsalomon@google.com, bsalomon@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12741 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 16:50:13 +00:00
commit-bot@chromium.org
4e8f1e56b1 [PDF] Fix clipping in xfermode improvement.
In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.

BUG=chromium:328009
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/116423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:38:28 +00:00
bsalomon@google.com
d6c1d58763 Remove bleed from ignored-tests.txt
BUG=skia:1880

Review URL: https://codereview.chromium.org/103213011

git-svn-id: http://skia.googlecode.com/svn/trunk@12726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:27:39 +00:00
commit-bot@chromium.org
c7a8507e97 Perlin noise rebaseline
BUG=skia:1881

Committed: https://code.google.com/p/skia/source/detail?r=5f145c9

R=sugoi@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/99433007

git-svn-id: http://skia.googlecode.com/svn/trunk@12659 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 23:00:10 +00:00
commit-bot@chromium.org
5e79c2b707 Fixed a displacement issue
The displacement filter was assuming that both inputs were of the same size, which is true in blink, but not necessarily in a compromised stream.

BUG=327372
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, fmalita@chromium.org, fmalita@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101623007

git-svn-id: http://skia.googlecode.com/svn/trunk@12655 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 21:48:32 +00:00
senorblanco@chromium.org
0682019f21 Bounds fixes for SkXfermodeImageFilter:
1) Change the default bounds to the union of the foreground and background bounds.
2) Use a canvas translate instead of manually offsetting the foreground and background bounds by the union.
3) Apply the transfer mode to all pixels, including those outside the foreground rect by using a difference clip.

Covered by the offset test cases in the xfermodeimagefilter GM (will need rebaselines).

R=reed@google.com

Review URL: https://codereview.chromium.org/112683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12652 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 21:00:58 +00:00
commit-bot@chromium.org
7746c1c4c2 GM: stop ignoring pdf-poppler failures
BUG=skia:1657
NOTRY=True
R=vandebo@chromium.org

Author: epoger@google.com

Review URL: https://codereview.chromium.org/108813007

git-svn-id: http://skia.googlecode.com/svn/trunk@12643 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 16:34:50 +00:00
robertphillips@google.com
2e7958f8fb Add clipped-bitmap-shaders-*-hq_angle.png to ignore-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@12594 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-10 12:56:56 +00:00
bsalomon@google.com
bc8b1ff885 add hq clipped biptmap shader GMs to ignored-tests.txt
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/93633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12584 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:52:47 +00:00
epoger@google.com
7787f2128d expectations/gm/ignored-tests.txt: add links to tracking bugs
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/106643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12516 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:45:18 +00:00
jvanverth@google.com
5a1cb5b408 Finish rebaselines for https://codereview.chromium.org/102683002/
Review URL: https://codereview.chromium.org/106773002

git-svn-id: http://skia.googlecode.com/svn/trunk@12511 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:26:02 +00:00
jvanverth@google.com
e4b6e38b04 Update ignored tests.
BUG=

Review URL: https://codereview.chromium.org/105793002

git-svn-id: http://skia.googlecode.com/svn/trunk@12495 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 23:16:40 +00:00
commit-bot@chromium.org
f543fd9e8c Simplify matrix generation for convex path renderer
Addresses precision issues which were leading to asserts in Debug

R=bsalomon@google.com, mtklein@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/102683002

git-svn-id: http://skia.googlecode.com/svn/trunk@12494 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 21:33:08 +00:00
vandebo@chromium.org
2b7d463990 Rebaseline after r12473
Review URL: https://codereview.chromium.org/104783003

git-svn-id: http://skia.googlecode.com/svn/trunk@12483 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 16:52:15 +00:00
jvanverth@google.com
d9288322ad Last set of rebaselines for https://codereview.chromium.org/99993002
BUG=

Review URL: https://codereview.chromium.org/104733002

git-svn-id: http://skia.googlecode.com/svn/trunk@12480 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-04 15:04:11 +00:00
jvanverth@google.com
23d005669b Ignore colortype_msaa4 (for https://codereview.chromium.org/99993002)
Review URL: https://codereview.chromium.org/102713003

git-svn-id: http://skia.googlecode.com/svn/trunk@12474 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 21:30:16 +00:00
commit-bot@chromium.org
7542dc8897 [PDF] Fixes the cases where SkPDFDevice::finishContentEntry is called with empty content.
There are some cases (like drawing a completely transparent image) where the code tries to finish a content entry with no content and an xfermode other than clear.  This makes those cases work correctly.

This is likely what was happening in chromium:316546, but it wasn't clear what the core problem was. desk_techcrunch.skp tripped a debug only assert that exposed the core issue.

BUG=skia:1868,chromium:316546
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/92453002

git-svn-id: http://skia.googlecode.com/svn/trunk@12473 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 21:08:46 +00:00
commit-bot@chromium.org
f8cb184095 Add GPU support for color bitmap fonts
BUG=skia:1869
R=bungeman@google.com, robertphillips@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/99993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12471 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-03 19:45:22 +00:00
bsalomon@google.com
5da55510a6 Fix ignored-tests.txt
Review URL: https://codereview.chromium.org/100383002

git-svn-id: http://skia.googlecode.com/svn/trunk@12449 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-02 22:54:50 +00:00
commit-bot@chromium.org
dec61503d0 HQ filtering for tiled/bleed drawBitmap
sample at pix center in bicubic

R=senorblanco@chromium.org, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/83153006

git-svn-id: http://skia.googlecode.com/svn/trunk@12440 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-02 22:22:35 +00:00
robertphillips@google.com
9b9b04924f Remove suppression of blurrect_outer
git-svn-id: http://skia.googlecode.com/svn/trunk@12294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 18:52:52 +00:00
jvanverth@google.com
d296d315c0 Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, simpleaaclip_path, strokerect, strokes_round
git-svn-id: http://skia.googlecode.com/svn/trunk@12290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-14 16:35:35 +00:00
jvanverth@google.com
94f689afde Add rrect_aa and rrect_bw to ignore list
git-svn-id: http://skia.googlecode.com/svn/trunk@12282 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 22:00:11 +00:00
jvanverth@google.com
ef10b71d62 Ignore failures for blurrect_outer (needs rebaselining).
git-svn-id: http://skia.googlecode.com/svn/trunk@12281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 21:36:30 +00:00
jvanverth@google.com
6a9e0b0d11 Rebaseline and enable GMs: pathopsskpclip roundrects rrect rrect_clip samplerstress
git-svn-id: http://skia.googlecode.com/svn/trunk@12277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 20:54:49 +00:00
jvanverth@google.com
19caf6d41b Rebaseline and enable GMs: convexpaths mixed_xfermodes nested_aa ninepatch-stretch pathfill pathinterior
git-svn-id: http://skia.googlecode.com/svn/trunk@12274 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-13 19:09:48 +00:00
bungeman@google.com
d37a7dc814 The coloremoji GM should now look like it did before.
With r12224 we now check that a stream looks like a font
before trying to use it.


git-svn-id: http://skia.googlecode.com/svn/trunk@12225 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 19:59:40 +00:00
jvanverth@google.com
af35641762 Ignore coloremoji GM for now.
git-svn-id: http://skia.googlecode.com/svn/trunk@12223 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 19:48:14 +00:00
commit-bot@chromium.org
ec39b50f04 Update bleed GM to use HQ filtering.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/61133002

git-svn-id: http://skia.googlecode.com/svn/trunk@12188 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 15:09:22 +00:00