epoger@google.com
99a8ec9705
rebaseline.py: split image-based rebaselining, which will go away soon, into its own script
...
(part of step 3 in https://goto.google.com/ChecksumTransitionDetail )
also adds new --expectations-root option
R=scroggo@google.com , senorblanco@chromium.org
Review URL: https://codereview.chromium.org/17379004
git-svn-id: http://skia.googlecode.com/svn/trunk@9689 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:56:59 +00:00
epoger@google.com
27d302581a
fix https://code.google.com/p/skia/issues/detail?id=1356
...
('32-bit Mac compiler doesn't like https://code.google.com/p/skia/source/detail?r=9686 ')
git-svn-id: http://skia.googlecode.com/svn/trunk@9688 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:52:42 +00:00
epoger@google.com
6f7f14d061
Reland r9682, using new SkString::appendU64()
...
Review URL: https://codereview.chromium.org/17157005
git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:28:31 +00:00
epoger@google.com
d88a3d8336
Add SkString::appendU32() and SkString::appendU64()
...
as needed to re-land r9682
R=reed@google.com
Review URL: https://codereview.chromium.org/17448012
git-svn-id: http://skia.googlecode.com/svn/trunk@9686 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:27:20 +00:00
edisonn@google.com
afe5e9e417
Deal with ca and CA transparency operators in pdf. add comments to generated classes.
...
Review URL: https://codereview.chromium.org/16975013
git-svn-id: http://skia.googlecode.com/svn/trunk@9685 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 17:42:17 +00:00
epoger@google.com
628de5f1f4
Reverting r9682, which broke on some compilers
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:58:00 +00:00
epoger@google.com
6324ac5d81
GM: add --writeChecksumBasedFilenames option
...
as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen
R=scroggo@google.com
Review URL: https://codereview.chromium.org/17365002
git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:50:09 +00:00
borenet@google.com
5ec130524e
Use "Simple Chrome for Chrome OS Workflow" to build Skia for ChromeOS
...
(SkipBuildbotRuns) since this isn't used yet.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/17412007
git-svn-id: http://skia.googlecode.com/svn/trunk@9681 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:13:32 +00:00
commit-bot@chromium.org
afb0e9c7b1
Remove unused NormalizeBench::fUsePortable field.
...
To address build warnings:
../bench/MathBench.cpp:442:10: error: private field 'fUsePortable' is not used
[-Werror,-Wunused-private-field]
bool fUsePortable;
^
R=reed@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17463002
git-svn-id: http://skia.googlecode.com/svn/trunk@9677 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 13:28:44 +00:00
robertphillips@google.com
f3488427da
Performance trigger rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9673 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 11:50:18 +00:00
commit-bot@chromium.org
b4e200ec6b
Make GrGLConfigConversionEffect work on Intel GPUs
...
BUG=247664
R=noel@chromium.org , bsalomon@chromium.org , reed@google.com , tomhudson@chromium.org , bsalomon@google.com
Author: jun.a.jiang@intel.com
Review URL: https://chromiumcodereview.appspot.com/15719007
git-svn-id: http://skia.googlecode.com/svn/trunk@9672 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 11:41:02 +00:00
skia.committer@gmail.com
c32f1d46d4
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9671 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 07:01:12 +00:00
edisonn@google.com
59543d34df
Continue to contain podofo, shorter enums
...
Review URL: https://codereview.chromium.org/17395005
git-svn-id: http://skia.googlecode.com/svn/trunk@9670 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 22:00:40 +00:00
zachr@google.com
6ef5a85bf4
force linking inside of skdiff
...
Review URL: https://codereview.chromium.org/16879012
git-svn-id: http://skia.googlecode.com/svn/trunk@9669 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 21:23:31 +00:00
commit-bot@chromium.org
1f7928663f
Refactor: clean up some unused or mostly-unused API I saw here.
...
BUG=
R=bungeman@google.com , reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/17414003
git-svn-id: http://skia.googlecode.com/svn/trunk@9668 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:50:34 +00:00
commit-bot@chromium.org
7a11591e5e
Rename SkDrawCommand subclasses
...
SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:
../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {
This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".
R=robertphillips@google.com , bungeman@google.com , djsollen@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17101005
git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:20:55 +00:00
commit-bot@chromium.org
c41295d122
remove double including of libpng decoder
...
R=bungeman@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/17408002
git-svn-id: http://skia.googlecode.com/svn/trunk@9666 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:06:36 +00:00
commit-bot@chromium.org
3da6c56f14
Allow files, making ".skp files or directories are required." less of a lie.
...
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/17151008
git-svn-id: http://skia.googlecode.com/svn/trunk@9665 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 18:35:58 +00:00
edisonn@google.com
29247629b6
put each generated pdf api class in a file (step 1, add new files)
...
Review URL: https://codereview.chromium.org/17395005
git-svn-id: http://skia.googlecode.com/svn/trunk@9661 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 16:28:29 +00:00
commit-bot@chromium.org
7fa22f3329
Smallest possible desktop application that uses Skia to render stuff.
...
Small Hello World smaple. Subclasses SkOSWindow.
R=caryclark@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/16337012
git-svn-id: http://skia.googlecode.com/svn/trunk@9657 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 15:37:27 +00:00
edisonn@google.com
60533dc4bf
add value() functions to podofo wrapers to isolate the client from knowing it is using podofo internally
...
Review URL: https://codereview.chromium.org/17101011
git-svn-id: http://skia.googlecode.com/svn/trunk@9654 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 14:51:21 +00:00
robertphillips@google.com
e63296e5d6
Fuse skgr & gr targets in gyp files
...
https://codereview.chromium.org/17101010/
git-svn-id: http://skia.googlecode.com/svn/trunk@9653 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 14:43:53 +00:00
robertphillips@google.com
44f7c230a5
Performance trigger rebaselines after hard reboot
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9651 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 13:29:32 +00:00
skia.committer@gmail.com
a48595d863
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9648 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 07:00:52 +00:00
epoger@google.com
c7e1873c85
skimage: revert r9642
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 02:53:16 +00:00
edisonn@google.com
1277cf05cc
Pdfviewer: generate isAFoo() and getAsFoo() api for fields that can have multiple types.
...
Review URL: https://codereview.chromium.org/16968007
git-svn-id: http://skia.googlecode.com/svn/trunk@9646 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 23:36:45 +00:00
edisonn@google.com
bb2c7534de
fix typo in spec
...
Review URL: https://codereview.chromium.org/17124003
git-svn-id: http://skia.googlecode.com/svn/trunk@9644 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 21:06:22 +00:00
edisonn@google.com
68d15c81e5
few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used.
...
Review URL: https://codereview.chromium.org/17286007
git-svn-id: http://skia.googlecode.com/svn/trunk@9643 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 20:46:27 +00:00
epoger@google.com
e0433f1ad3
skimage: if --readPath points at an empty dir, create an empty expectations file
...
TBR=scroggo
Review URL: https://codereview.chromium.org/17294006
git-svn-id: http://skia.googlecode.com/svn/trunk@9642 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 19:34:58 +00:00
borenet@google.com
bb52288882
SkHello for NaCl
...
Not ready to submit.
R=reed@google.com
Review URL: https://codereview.chromium.org/16904003
git-svn-id: http://skia.googlecode.com/svn/trunk@9639 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 15:39:43 +00:00
commit-bot@chromium.org
344cf45a40
*** Perlin noise GM needs to be rebaselined ***
...
Enabling Perlin Noise on Android
I enabled the Perlin Noise shader on Android after doing some minor modifications to the shader, specifically for Android (and #ifdefed for Android, to make sure none of this affects other platforms).
For Tegra devices (Nexus 7, Xoom), a precision issue related to the color values read from textures caused the noise to read the wrong indices and produce bad noise. I fixed this by adding a founding of the values read by simply doing the equivalent of "colorValue = floor(colorValue * 255.0) / 255.0" to make sure we retrieve the colors that were written in the texture originally.
For non-Tegra devices (Nexus 10), dealing with values in the order of 4096.0 was problematic without using the "highp" precision setting. To solve this, a few variables were given the high precision setting.
Since both fixes don't seem to do considerable harm to the platforms that are not being targetted, I left both fixes on all android devices for now.
I also reduced the Perlin noise gm so that it takes less time to test it on the Xoom (Original time was about 20 seconds, this shold take less than 10, hopefully)
BUG=
R=senorblanco@google.com , bsalomon@google.com , sugoi@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16818013
git-svn-id: http://skia.googlecode.com/svn/trunk@9637 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 14:19:01 +00:00
caryclark@google.com
d892bd8ba6
convert pathops to use SkSTArray where possible.
...
Replace SkTDArray with SkTArray and use SkSTArray when
the probable array size is known.
In a couple of places (spans, chases) the arrays are
constructed using insert() so SkTArrays can't be used for
now.
Also, add an optimization to cubic subdivide if either end
is zero or one.
BUG=
Review URL: https://codereview.chromium.org/16951017
git-svn-id: http://skia.googlecode.com/svn/trunk@9635 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 14:10:36 +00:00
reed@google.com
acb3d88cf8
use select() so we can wait for XEvents or our timer
...
poll for xevents using XPending
BUG=
Review URL: https://codereview.chromium.org/17275003
git-svn-id: http://skia.googlecode.com/svn/trunk@9633 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 13:42:43 +00:00
epoger@google.com
c33b6e542f
whitespace change to trigger buildbots after master restart
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9632 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 04:43:05 +00:00
skia.committer@gmail.com
f85693d53a
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9631 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-15 07:00:53 +00:00
epoger@google.com
baafdec13c
whitespace change to trigger buildbots after skia-autogen reset
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9630 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 23:56:20 +00:00
scroggo@google.com
daaea2d51f
Fixes for unpremul decode.
...
SkImageDecoder_CG.cpp:
If a non opaque bitmap was decoded, and the caller wants
unpremultiplied, unpremultiply the colors.
Always use the RGB colorspace, since the other colorspaces
do not match the desired bitmap format.
ImageDecodingTest:
Allow for a difference of 1 in each color component when comparing
the result of premultiplying the unpremultiplied decode with the
premultiplied decode, since I found an image (in WEBP format) where
the unpremultiplied colors did not compare perfectly in my comparison.
R=reed@google.com
Review URL: https://codereview.chromium.org/17084012
git-svn-id: http://skia.googlecode.com/svn/trunk@9628 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 20:39:48 +00:00
reed@google.com
ae72f470e0
remove unused line of code (from xcode's analysis)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9627 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 20:22:13 +00:00
egdaniel@google.com
f1d7de788b
Change general fill rect shader code to match geometry vers
...
-Matches shader implemented for alligned rects
-Uses multiplication instead of min (used in geom version)
to combine width and height coverages
R=bsalomon@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/17035012
git-svn-id: http://skia.googlecode.com/svn/trunk@9626 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 19:25:53 +00:00
edisonn@google.com
a2fab9d35c
Object model generated from pdf spec 1.4, draft code
...
Review URL: https://codereview.chromium.org/17095004
git-svn-id: http://skia.googlecode.com/svn/trunk@9625 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 19:22:19 +00:00
reed@google.com
079813e2da
speculative fix in TransitionView. don't validate after detachFromParent (we may have been deleted)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9619 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 17:46:07 +00:00
robertphillips@google.com
07a052484f
Fix for r9609
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9618 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 17:45:30 +00:00
commit-bot@chromium.org
be19b9ef9a
add skpdiff tool to compare bitmaps
...
- start framework for pluggable algorithms
- implement simple number of pixels different OpenCL algo
R=djsollen@google.com , bsalomon@google.com , jvanverth@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/16284007
git-svn-id: http://skia.googlecode.com/svn/trunk@9616 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 17:26:54 +00:00
commit-bot@chromium.org
5a6c2d8208
Add skia_exceptinos gyp define
...
R=robertphillips@google.com
Author: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/17094003
git-svn-id: http://skia.googlecode.com/svn/trunk@9615 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 17:10:09 +00:00
scroggo@google.com
8e990eb440
Update SkBitmap::validate to respect Android flag.
...
Without this change, an SkBitmap with hardware mip will assert in
validate.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/16870002
git-svn-id: http://skia.googlecode.com/svn/trunk@9614 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 15:55:56 +00:00
scroggo@google.com
24d6454cb8
Prototype for build warning as error.
...
BUG=
Review URL: https://codereview.chromium.org/17060004
git-svn-id: http://skia.googlecode.com/svn/trunk@9613 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 15:44:11 +00:00
scroggo@google.com
2bbc2c945b
Add an option to create unpremultiplied bitmaps.
...
Currently they cannot be used directly by Skia, but
the pixels can be used elsewhere.
SkImageDecoder:
Add functions to require unpremultiplied output
and query the presence of the requirement
SkImageDecoder_libpng:
SkImageDecoder_libwebp:
SkImageDecoder_WIC:
Respect the requirement for unpremultiplied output.
TODO: Fix SkImageDecoder_CG.
SkScaledBitmapSampler:
Add procs to skip premultiplication and a boolean
parameter to use those procs.
ImageDecodingTest:
Test unpremultiplied bitmap decoding.
SampleUnpremul:
Add a sample which allows visually comparing between the
unpremultiplied version (copied into a premultiplied bitmap,
since drawing unpremultiplied is not currently supported)
and a premultiplied version of image files.
gm.h:
Add a getter for the resource path, so Samples can use it.
As of patch set 13, https://codereview.chromium.org/16816016/
and https://codereview.chromium.org/16983004/ , which were
approved separately.
R=reed@google.com
Review URL: https://codereview.chromium.org/16410009
git-svn-id: http://skia.googlecode.com/svn/trunk@9612 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 15:33:20 +00:00
commit-bot@chromium.org
99e0d08113
Update Alligned Rect Shader to match geometry version
...
-Also update to combine width and height coverage using multiplication
instead of using min
R=bsalomon@google.com , robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://chromiumcodereview.appspot.com/16854012
git-svn-id: http://skia.googlecode.com/svn/trunk@9609 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 14:58:50 +00:00
commit-bot@chromium.org
459104ceea
Add MESA detection to GrContextInfo and use to decide whether to use GL_ALPHA or GL_RED.
...
Based on yunchao.he@intel.com's original change here: https://codereview.chromium.org/15994006/
R=yunchao.he@intel.com , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/16955005
git-svn-id: http://skia.googlecode.com/svn/trunk@9608 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 14:42:56 +00:00
commit-bot@chromium.org
61c49f357a
Improve the performance of SkConvertConfig8888Pixels using Array lookup
...
BUG=242097
R=kbr@chromium.org , vangelis@chromium.org , zmo@chromium.org , gman@chromium.org , bsalomon@google.com , reed@google.com , tomhudson@chromium.org , noel@chromium.org
Author: jun.a.jiang@intel.com
Review URL: https://chromiumcodereview.appspot.com/15402003
git-svn-id: http://skia.googlecode.com/svn/trunk@9605 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-14 13:38:56 +00:00