Commit Graph

5658 Commits

Author SHA1 Message Date
rmistry@google.com
44737654c3 Fixed some compilation problems with debugger with robertphillips
git-svn-id: http://skia.googlecode.com/svn/trunk@6534 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 18:37:58 +00:00
reed@google.com
c19468e4bb add default: to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@6533 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 18:34:15 +00:00
robertphillips@google.com
6dec8fcb44 Add drawing of paths to debugger
https://codereview.appspot.com/6850082/



git-svn-id: http://skia.googlecode.com/svn/trunk@6532 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 17:11:02 +00:00
sugoi@google.com
5347de1611 Simple change to remove unnecessary #define statement.
BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6845071

git-svn-id: http://skia.googlecode.com/svn/trunk@6531 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 16:44:45 +00:00
reed@google.com
b2e138c2bf fix typo: must use modified join in case the miterlimit forces us to use bevel
git-svn-id: http://skia.googlecode.com/svn/trunk@6530 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 16:36:34 +00:00
reed@google.com
04fdaa1afe use direction from isRect in strokeRect, and only stroke if it is closed
Review URL: https://codereview.appspot.com/6846086

git-svn-id: http://skia.googlecode.com/svn/trunk@6528 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 15:48:20 +00:00
sugoi@google.com
7775fd5779 Deferred canvas can now be flushed if an image is beyond a certain size to avoid a costly image copy.
BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6852071

git-svn-id: http://skia.googlecode.com/svn/trunk@6527 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 15:47:04 +00:00
caryclark@google.com
f68154a3cf Add isRect variant that returns path closure and direction.
Add path test to verify that when isRect() returns false,
output parameters are unchanged.
Review URL: https://codereview.appspot.com/6855074

git-svn-id: http://skia.googlecode.com/svn/trunk@6524 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 15:18:06 +00:00
reed@google.com
f276fa74f5 limit the rects width/height as well as its coords, when avoiding too-large
rects for blur special-case.
Review URL: https://codereview.appspot.com/6850084

git-svn-id: http://skia.googlecode.com/svn/trunk@6523 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 14:14:10 +00:00
caryclark@google.com
bfe90370ea detect wrapped rect in path
Allow a rect to start in the middle of a span, and
wrap all the way around.

Initialize variable to suppress warning.

Add tests to detect rects constructed from a stroked
path.
Review URL: https://codereview.appspot.com/6847082

git-svn-id: http://skia.googlecode.com/svn/trunk@6522 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 13:56:20 +00:00
skia.committer@gmail.com
b0a327e939 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6521 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 02:02:25 +00:00
reed@google.com
158c59524c add SK_IGNORE_NEW_STROKERECT guard
temp workaround for bug in isRect when I'm stroking and the rect isn't closed.



git-svn-id: http://skia.googlecode.com/svn/trunk@6520 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 23:01:35 +00:00
reed@google.com
b9971cb666 fix regression from 6510 -- respect kStrokeAndFill setting for stroked rects
git-svn-id: http://skia.googlecode.com/svn/trunk@6516 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 21:33:05 +00:00
reed@google.com
9903395a5a test for StrokeAndFill as well in this GM
git-svn-id: http://skia.googlecode.com/svn/trunk@6515 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 21:32:30 +00:00
reed@google.com
6bb92bc0b5 detect gigantoid matrices, and do nothing to avoid wacky overflows from float -> int
https://code.google.com/p/chromium/issues/detail?id=156231
Review URL: https://codereview.appspot.com/6842075

git-svn-id: http://skia.googlecode.com/svn/trunk@6513 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 19:45:16 +00:00
bungeman@google.com
4e7ba6ae4a Correct A8 gamma on Mac.
This fixes https://code.google.com/p/chromium/issues/detail?id=161728 .
https://codereview.appspot.com/6851086/


git-svn-id: http://skia.googlecode.com/svn/trunk@6511 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 19:40:23 +00:00
reed@google.com
603dbedf29 add specialty strokeRect() to SkStroke, which can return much cleaner results
Review URL: https://codereview.appspot.com/6843093

git-svn-id: http://skia.googlecode.com/svn/trunk@6510 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 19:00:28 +00:00
bungeman@google.com
a544f29496 Additional OpenType tables.
https://codereview.appspot.com/6850075/


git-svn-id: http://skia.googlecode.com/svn/trunk@6509 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 18:52:23 +00:00
senorblanco@chromium.org
336b4da6b0 Separable mask blurs: Add compile-time flag. Fix reversed offsets in asymmetrical blurs (this bug cancels itself out, but I thought it might be confusing for future readers). Use correct stride in asymmetrical blurs (this is a real bug).
Review URL: https://codereview.appspot.com/6782089

git-svn-id: http://skia.googlecode.com/svn/trunk@6508 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 17:09:40 +00:00
tfarina@chromium.org
2cda3871cb Fix clang warning in GMSampleView.h
../../samplecode/GMSampleView.h:23:7: warning: field 'fGM' will be initialized after field 'fShowSize' [-Wreorder]

R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6856063

git-svn-id: http://skia.googlecode.com/svn/trunk@6507 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 16:36:20 +00:00
reed@google.com
f6c9a5ba5c add restore() to SkAutoCanvasRestore
git-svn-id: http://skia.googlecode.com/svn/trunk@6505 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 15:12:21 +00:00
caryclark@google.com
7ba591eb7a shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6503 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 14:21:54 +00:00
skia.committer@gmail.com
3458716b52 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6500 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 02:01:23 +00:00
robertphillips@google.com
866ff8787a Reverting r6489 to fix compiler error in Chrome
143>  LINK : program database E:\b\build\slave\win_layout\build\src\build\Debug\ui.dll.pdb missing; performing full link
143>     Creating library ..\build\Debug\lib\ui.lib and object ..\build\Debug\lib\ui.exp
143>throb_animation.obj : error LNK2001: unresolved external symbol "private: static void (__cdecl*const * const SkMatrix::gMapXYProcs)(class SkMatrix const &,float,float,struct SkPoint *)" (?gMapXYProcs@SkMatrix@@0QBQ6AXABV1@MMPAUSkPoint@@@ZB)

etc 



git-svn-id: http://skia.googlecode.com/svn/trunk@6499 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-20 01:40:45 +00:00
reed@google.com
07784a0419 skip very large rects (for now) until we can pre-clip them to avoid floating
point precision errors.



git-svn-id: http://skia.googlecode.com/svn/trunk@6497 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 21:09:14 +00:00
vollick@chromium.org
f11cf9ff88 Add SkMatrix44::setColMajord, etc.
We have accessors for efficiently getting the matirx data, and it would be nice
if we had similar methods for setting the matrix entries.

Review URL: https://codereview.appspot.com/6851063

git-svn-id: http://skia.googlecode.com/svn/trunk@6494 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 21:02:06 +00:00
robertphillips@google.com
8a1cdaece7 Breakdown profile time by command type in the overview pane
https://codereview.appspot.com/6851073/



git-svn-id: http://skia.googlecode.com/svn/trunk@6492 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 20:44:29 +00:00
senorblanco@chromium.org
e0d44ff614 Add support for new glShaderSource() signature from Khronos. Disabled by default.
Review URL: https://codereview.appspot.com/6853068

git-svn-id: http://skia.googlecode.com/svn/trunk@6491 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 20:43:10 +00:00
tfarina@chromium.org
15393c7f34 Add missing SK_API define.
For a detailed explanation of this, please refer to Nico Weber description
here: https://chromiumcodereview.appspot.com/10386108

R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6849075

git-svn-id: http://skia.googlecode.com/svn/trunk@6489 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 19:43:18 +00:00
djsollen@google.com
276a2956f5 Add support for SkImageRef_ashmem.
This requires copying the ashmem utility wrapper functions from a
private android library into our source tree in order to be NDK
compliant.

Review URL: https://codereview.appspot.com/6846076

git-svn-id: http://skia.googlecode.com/svn/trunk@6488 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 19:34:23 +00:00
robertphillips@google.com
d163636ec6 Added Reload icon
https://codereview.appspot.com/6849079/



git-svn-id: http://skia.googlecode.com/svn/trunk@6486 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 18:25:09 +00:00
robertphillips@google.com
8e41a168b0 Add original resources back and update code to match
https://codereview.appspot.com/6842061/



git-svn-id: http://skia.googlecode.com/svn/trunk@6484 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 17:39:18 +00:00
reed@google.com
dab9b4fe03 use SkPath::isNestedRects() to apply blurred nine-patch
Review URL: https://codereview.appspot.com/6855063

git-svn-id: http://skia.googlecode.com/svn/trunk@6483 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 16:45:14 +00:00
scroggo@google.com
4f65a77a1f Fix a memory leak in skdiff that happens when the
directories do not contain the same files.

Only create the bitmaps when we need to use them.

Review URL: https://codereview.appspot.com/6850066

git-svn-id: http://skia.googlecode.com/svn/trunk@6481 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 16:30:08 +00:00
robertphillips@google.com
e099bc403c 3 minor fixes for debugger
https://codereview.appspot.com/6842062/



git-svn-id: http://skia.googlecode.com/svn/trunk@6480 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 16:26:40 +00:00
reed@google.com
808b70f869 modify gm to have a non-uniform donut for testing
git-svn-id: http://skia.googlecode.com/svn/trunk@6477 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 16:14:02 +00:00
bsalomon@google.com
8e2999fd24 Protect against unref/ref of stencil buffer.
Over the shoulder review from robertphillips@google.com



git-svn-id: http://skia.googlecode.com/svn/trunk@6476 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 14:36:31 +00:00
caryclark@google.com
56f233ab54 add two nested rect detector to path
Tease apart existing one rect path detector so
that a new variant can detect two nested rects as well.

Add tests to verify that both one and two rect
detectors both work and return the correct results.

Suppress other warnings in PathTest.
Review URL: https://codereview.appspot.com/6850059

git-svn-id: http://skia.googlecode.com/svn/trunk@6475 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 13:06:06 +00:00
senorblanco@chromium.org
1542354487 Revert r6469, "Turn on separable blur."
git-svn-id: http://skia.googlecode.com/svn/trunk@6474 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-17 15:08:29 +00:00
skia.committer@gmail.com
e7a709aa27 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6473 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-17 02:01:23 +00:00
borenet@google.com
ec7bf37412 Whitespace change to trigger rebuild after network hiccup
git-svn-id: http://skia.googlecode.com/svn/trunk@6472 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 22:26:33 +00:00
scroggo@google.com
013c5d9107 In SkBitmapHeap, defer adding owners for new bitmaps.
When using an SkFlatDictionary to flatten shaders, the
dictionary can try to insert a duplicate bitmap shader
that uses a bitmap which has been removed from the
bitmap heap.

This change was originally suggested by junov in
https://codereview.appspot.com/6713048/.

Add a test to verify that deferring the owners works.
Without the change to bitmap heap the test would fail
(and crash in debug mode).

Also remove an unused function from SkFlatDictionary.

BUG=http://code.google.com/p/chromium/issues/detail?id=143923

Review URL: https://codereview.appspot.com/6842051

git-svn-id: http://skia.googlecode.com/svn/trunk@6471 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 20:34:37 +00:00
caryclark@google.com
6ec1526680 shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6470 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 20:16:50 +00:00
senorblanco@chromium.org
2c48c5eefc Turn on separable blur.
git-svn-id: http://skia.googlecode.com/svn/trunk@6469 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 19:26:22 +00:00
epoger@google.com
4ce738b98e Extract transform_scanline_XXXX functions into transform_scanline.h for code-sharing
Review URL: https://codereview.appspot.com/6849065

git-svn-id: http://skia.googlecode.com/svn/trunk@6468 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 18:44:18 +00:00
skia.committer@gmail.com
886b25f14c Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6466 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 18:15:12 +00:00
senorblanco@chromium.org
c438130964 Separable blur: subpixel blurring. We approximate intermediate values of blur for even kernel sizes by using a kernel of size N offset to the left in the first pass, a kernel of size N offset to the right in the second pass, and a centered kernel of size N + 1 in the third pass. This required adding support for asymmetrical radii to the box blur.
Since this can only be done in the 3-pass blur for separable blurs, we turn off the optimization that drops to low quality for blurs of < 3 pixels.

Review URL: https://codereview.appspot.com/6843072

git-svn-id: http://skia.googlecode.com/svn/trunk@6464 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 17:22:33 +00:00
reed@google.com
59d968fb29 use correct blend proc instead of fourbyteinterp, since the src may not be opaque
fixes DumpRenderTree failure



git-svn-id: http://skia.googlecode.com/svn/trunk@6457 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 14:46:00 +00:00
reed@google.com
aef73617d1 flag the GM if we're in deferred-canvas mode, to work-around bug trying to
get the context from its device.



git-svn-id: http://skia.googlecode.com/svn/trunk@6452 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 13:41:45 +00:00
reed@google.com
13201e74f4 fold kClear_Mode into kSrc_Mode, and make kSrc_Mode go faster
Review URL: https://codereview.appspot.com/6851054

git-svn-id: http://skia.googlecode.com/svn/trunk@6451 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-16 13:20:41 +00:00