Commit Graph

58852 Commits

Author SHA1 Message Date
skia-autoroll
37b80849a8 Roll Chromium from c6a8ac7c2c02 to 1e7fbc0c4688 (483 revisions)
c6a8ac7c2c..1e7fbc0c46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: Icd9bc65a7d111d4c14a5179da419a9609d236de6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491621
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-06 04:58:18 +00:00
skia-autoroll
e883115c58 Roll Dawn from 1f3ad49cbcd5 to ef80b0908a13 (11 revisions)
https://dawn.googlesource.com/dawn.git/+log/1f3ad49cbcd5..ef80b0908a13

2022-01-06 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5c99ed046a44 to 7dc901fa4f87 (4 revisions)
2022-01-06 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c984dad5fd52 to ccabfd1407c9 (12 revisions)
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4beeaea9daf2 to 5c99ed046a44 (1 revision)
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 760dcbc9cc52 to f3e00128933f (5 revisions)
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c73969d73ff9 to 16f4b38bdc03 (3 revisions)
2022-01-05 bajones@chromium.org Prevent negative error message ranges
2022-01-05 cwallez@chromium.org Roll build dependencies to enable C++17
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cfc4db34643f to c984dad5fd52 (3 revisions)
2022-01-05 cwallez@chromium.org CMake: enable C++17
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a22e4a155383 to 760dcbc9cc52 (6 revisions)
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d0de9dcaaa44 to c73969d73ff9 (3 revisions)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 4beeaea9daf2 to 7dc901fa4f87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ia04fff63c4b71cb6c9d628716ca007063cb63d65
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491623
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-06 04:35:21 +00:00
Brian Osman
88c5af7ecd Spruce up SkSL slide with a much nicer editor
Pulls in a new GitHub repo that implements a syntax-highlighting code
editor ImGui widget.

Change-Id: I968e5eb827c226259eaaad2996eeaad9de592e37
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491444
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-01-05 20:19:49 +00:00
Ethan Nicholas
eb12454f57 Re-added SkSL REHYDRATE flag
The REHYDRATE flag was removed at some point, but it was a useful means
of temporarily disabling rehydration for debugging and the like.

Change-Id: I28f7fbaed6003f384509f5848e8bbf4f06697bc9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491440
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-05 20:15:40 +00:00
Brian Osman
576de89810 Add support for multiple child nodes to SkImageFilters::RuntimeShader
Bug: skia:12766
Change-Id: I9dfe07a71961ab952c1593b9cc68c61191fbc13c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489536
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-01-05 20:07:00 +00:00
Ethan Nicholas
84d6cf9b5b Removed SkSL SymbolTable aliases
Now that we have first class Type aliases, we no longer need this
obsolete SymbolTable mechanism.

Change-Id: Ibfb21ed153d1cbca59679659254e4d58d18f5c7c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491441
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-05 18:59:14 +00:00
Herb Derby
44e712a6a9 simplify drawingType calculation
Simplify determining which method used to draw text. This will make
inlining it into the processGlyphRun code easier.

Bug: chromium:1280180

Change-Id: I69241a9c198904334c012ab301e80d0cf9fd45d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491437
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-01-05 18:05:54 +00:00
Derek Sollenberger
5d7ef77a35 Reduce duplication of sources for tests in Android.bp
Instead of both dm and nanobench both listing all of the
GM sources this CL consolidates the GMs into a single target that
both executables can depend on.  This also paves the way for an
SkQP build target to depend on the same target.

Bug: skia:12777
Change-Id: I4bb7236612b04d42c01334f42e569c7f66893617
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491042
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2022-01-05 17:40:17 +00:00
Jason Simmons
53bf2fa77a Remove obsolete SkBidiIterator_icu::getBidiRegions method
Change-Id: I9afbb79d6538f40d4f1fe06d91b7d5790124bfe5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487478
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Jason Simmons <jsimmons@google.com>
2022-01-05 17:31:54 +00:00
Michael Ludwig
0cdd5d7828 [graphite] Implement middle-out triangle stencil RenderStep
Cq-Include-Trybots: luci.skia.skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Release-All-Graphite,Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite,Build-Mac-Clang-arm64-Release-iOS_Graphite,Build-Mac-Clang-arm64-Release-Graphite,Build-Mac-Clang-arm64-Debug-iOS_Graphite,Build-Mac-Clang-arm64-Debug-Graphite_NoGpu,Build-Mac-Clang-arm64-Debug-Graphite,Build-Mac-Clang-arm64-Debug-ASAN_Graphite
Bug: skia:12703
Change-Id: I1e0d004d5688b78f0cdaa9df31b27831415fba6c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/484561
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-01-05 16:36:46 +00:00
Greg Daniel
60bd1cf8fb Re-enable blend micro benchs for non raster backends.
Change-Id: Ie23b2b96988a527ad035a3160a408f9d754395e5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491436
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-01-05 16:24:48 +00:00
Ethan Nicholas
f393067c37 Made SkSL type aliases into first-class objects
Previously, type aliases ('vec2') were just an additional name which
could be used to refer to a type ('float2'). This was simple and worked,
except that error messages would be wrong - any type-related error
message would refer to the type as 'float2' rather than the 'vec2' that
the user actually typed.

This CL adds an AliasType class so that we can track which name was
used to refer to an aliased type and report messages using the correct
type name.

Bug: skia:12737

Change-Id: I40e234239ab47557033e0695e4fbbd5f01da354e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490256
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-05 16:20:19 +00:00
Kevin Lubick
ec2e8f11b9 [infra] Deploy debugger with Bazel
Housekeeper-PerCommit-PushAppsFromWASMDockerImage would be a no-op
so it has been deleted.

Requires https://skia-review.googlesource.com/c/buildbot/+/490898/
to land first

Change-Id: I7db91363bba714fb0c1685fc332cd424f72786a9
Bug: skia:10614
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491038
Reviewed-by: Ravi Mistry <rmistry@google.com>
2022-01-05 13:18:15 +00:00
skia-autoroll
d7771857e9 Roll ANGLE from 5bd4596187e3 to cfc4db34643f (2 revisions)
5bd4596187..cfc4db3464

2022-01-04 kpiddington@apple.com Metal: Provoking vertex support for Metal DrawArrays
2022-01-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 04d22dcbc0f6 to 1a9dad30c65b (190 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Change-Id: I7ae17e993fbec6a7e65932192d5101650112f98f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491317
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-05 05:24:19 +00:00
skia-autoroll
732ddb7191 Roll Chromium from 45dd58c4bf06 to c6a8ac7c2c02 (503 revisions)
45dd58c4bf..c6a8ac7c2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: I5756587ff30012ed96c9a51b79599e10ccb1bfb9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491316
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-05 04:44:19 +00:00
skia-autoroll
4981c921c6 Roll Dawn from 67c11575d1d1 to 1f3ad49cbcd5 (14 revisions)
https://dawn.googlesource.com/dawn.git/+log/67c11575d1d1..1f3ad49cbcd5

2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 137222221539 to 4beeaea9daf2 (2 revisions)
2022-01-05 hao.x.li@intel.com Implement depth24unorm-stencil8 and depth32float-stencil8 formats
2022-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a00b6ca46f18 to cfc4db34643f (1 revision)
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f09a23a3f734 to 137222221539 (2 revisions)
2022-01-04 dneto@google.com Add -DDAWN_USE_X11=OFF for dawn.node build
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 00957032e9fb to a22e4a155383 (1 revision)
2022-01-04 cwallez@chromium.org Add missing space in a toggle description
2022-01-04 cwallez@chromium.org Preliminary fixes for upgrading the MSVC toolchain
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 09c49b34d9d9 to f09a23a3f734 (1 revision)
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 433b1bf9bff2 to d0de9dcaaa44 (1 revision)
2022-01-04 bclayton@google.com dawn_node: Error if the specified backend is not found
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7913982f8734 to 09c49b34d9d9 (1 revision)
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5bd4596187e3 to a00b6ca46f18 (1 revision)
2022-01-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5d16a1ce9e6d to 00957032e9fb (2 revisions)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 7913982f8734 to 4beeaea9daf2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: alanbaker@google.com
Change-Id: If2e15fa9922fb22638b6f38444f10c235e4db681
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491318
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-05 04:37:22 +00:00
Herb Derby
61d0fbbca7 inline drawingType facilitating future refactoring
Inline the control back into this code to facilitate future refactoring
to make size calculation more precise.

Bug: chromium: 1280180

Change-Id: If66174ab1d28571a7b84d4ab4bd7fa09ce86c3af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/491043
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-01-04 18:16:49 +00:00
Derek Sollenberger
1afa5fb64b Reduce scope of SkQP to pass/fail runs of GMs and UnitTests
Going forward specific GMs can be added to the rendertest.txt
in order to do a basic pass/fail run based on whether the GM
can successfully complete without crashing.

The output of the executable was also updated to print one test
per line in order to make following its execution more readable.

Bug: skia:12777
Change-Id: I98f6fa7af765130ddf68203d62c972659fd4e325
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489617
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2022-01-04 18:07:48 +00:00
Brian Salomon
c29454d1c9 Allow custom mesh to use positions for local coordinates.
This will make it possible for drawVertices and drawCustomMesh to share
implementation in Ganesh.

Bug: skia:12720
Change-Id: I8b84119a29b47071ef389879bb5287873629ed3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487978
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-01-04 18:01:47 +00:00
Brian Osman
735ff421bb Reject #extension in runtime-effect mode
Bug: oss-fuzz:43062
Change-Id: I10d8fa40c81c5b1595d30221d89c84f5cc3478fd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490857
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-04 16:12:50 +00:00
Ethan Nicholas
c4b95b2dbe Renamed SkSLType operator== to 'matches'
This change is in anticipation of a followup CL which adds formal type
aliases. operator=='s behavior in the face of aliases would not be
obvious (does float4 == vec4?), whereas hopefully it is unsurprising
that float4.matches(vec4).

Change-Id: I23ad732a9a9084883a55be4e1d6f3529d567de89
Bug: skia:12737
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489921
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-04 15:31:15 +00:00
Brian Salomon
5726d457cf Allow inlining of custom mesh code.
Also remove unnecessary scope block when using shared compiler.

Bug: skia:12720
Change-Id: I67f9579fbd273d5b5102b25576a2721ad9ef01df
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490116
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-01-04 14:48:23 +00:00
skia-autoroll
6bebf036a5 Roll ANGLE from aad7ddb28c0e to 5bd4596187e3 (1 revision)
aad7ddb28c..5bd4596187

2022-01-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 70ce2f66c417 to 04d22dcbc0f6 (183 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Change-Id: Ib3364e7be20735043c9e7822f62013e1751a6682
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490658
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-04 05:23:49 +00:00
skia-autoroll
783a7dfbcc Roll Dawn from ba709bfc6072 to 67c11575d1d1 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/ba709bfc6072..67c11575d1d1

2022-01-03 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from aad7ddb28c0e to 5bd4596187e3 (1 revision)
2022-01-03 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ccb6a4009fa to 5d16a1ce9e6d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ib8aca24922b954bbe37ac2dbc80dc53cea7bcd30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490657
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-04 04:42:53 +00:00
skia-autoroll
45f64bd528 Roll Chromium from 4221b2158843 to 45dd58c4bf06 (163 revisions)
4221b21588..45dd58c4bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: I36d896e6761fb5ac8158e21cf5503ecdd75d927f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490656
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-04 04:36:51 +00:00
skia-autoroll
0e597a5a4c Roll ANGLE from 9aca4285f84c to aad7ddb28c0e (4 revisions)
9aca4285f8..aad7ddb28c

2022-01-02 ynovikov@chromium.org Skip VulkanPerformanceCounterTest.InvalidateDrawDisable
2022-01-02 lexa.knyazev@gmail.com Add macOS support to update_chrome_angle.py
2022-01-01 syoussefi@chromium.org Re-skip MSRTT tests on Linux/AMD/Vulkan
2021-12-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c764378a1f24 to 70ce2f66c417 (145 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Change-Id: I55511e3cd8bf3fc2afb4e52f0569a1f4fa13adf1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490518
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-03 05:24:49 +00:00
skia-autoroll
3f7f60dcdc Roll Chromium from b98a0ee41978 to 4221b2158843 (182 revisions)
b98a0ee419..4221b21588

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: I6ed9232ac497675e5dd0cfecd5d09da5b4eca57a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490516
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-03 04:43:49 +00:00
skia-autoroll
06ed367451 Roll Dawn from 1a7779ca321e to ba709bfc6072 (6 revisions)
https://dawn.googlesource.com/dawn.git/+log/1a7779ca321e..ba709bfc6072

2022-01-03 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a6b7897451b to aad7ddb28c0e (1 revision)
2022-01-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4b3e3ed5f0da to 0a6b7897451b (1 revision)
2022-01-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 39810def0b01 to 4b3e3ed5f0da (1 revision)
2022-01-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b1049d5f19cc to 0ccb6a4009fa (3 revisions)
2021-12-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2f2497d5ea38 to b1049d5f19cc (1 revision)
2021-12-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fed9ba44f024 to 39810def0b01 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: I43f43634fc643c729c53936bd49dec29b2e72abb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490517
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-03 04:39:20 +00:00
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
8453d60189 Update SKP version
Automatic commit by the RecreateSKPs bot.

Change-Id: I0336f2d4b6ef5144688329464a9e64246863efe3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490419
Commit-Queue: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Bot-Commit: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2022-01-02 07:56:20 +00:00
skia-autoroll
f6c3217822 Roll SK Tool from 153a72e4c063 to c64b58ba841a
https://skia.googlesource.com/buildbot.git/+log/153a72e4c063..c64b58ba841a

2022-01-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I87d2fea188dedbb795a367b8b27d2b6798211f90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490417
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-01-02 06:08:19 +00:00
skia-autoroll
d88df695a5 Roll ANGLE from a400e76d02df to 9aca4285f84c (7 revisions)
a400e76d02..9aca4285f8

2021-12-30 jmadill@chromium.org Traces: Fix path in retrace script.
2021-12-30 jmadill@chromium.org Fix extension download script, and update data.
2021-12-30 jmadill@chromium.org Capture/Replay: GN cleanups.
2021-12-30 jmadill@chromium.org Capture/Replay: Fix TODO in test utils.
2021-12-30 jmadill@chromium.org Traces: Finish writing restricted trace doc updates.
2021-12-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c32df39c11ce to 09edcd7c680b (1 revision)
2021-12-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e45e6e1a55ae to c764378a1f24 (157 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: I35fcd6d9e2887db9964ae4c5966c48a42dbe4c9a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490318
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-31 05:23:49 +00:00
skia-autoroll
dc0f314a9f Roll Chromium from 3fb49d6ae3d0 to b98a0ee41978 (152 revisions)
3fb49d6ae3..b98a0ee419

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I339bf61b3dc69b121b616a61e7a6ff2b8beebe4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490316
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-31 04:37:51 +00:00
skia-autoroll
45e536f825 Roll Dawn from a0eca4a3e4ff to 1a7779ca321e (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/a0eca4a3e4ff..1a7779ca321e

2021-12-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 09edcd7c680b to 2f2497d5ea38 (1 revision)
2021-12-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a400e76d02df to fed9ba44f024 (2 revisions)
2021-12-30 dneto@google.com Fix dawn.node compilation
2021-12-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b7d2f4478cb2 to a400e76d02df (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: Ic35d656b2179f82d0fd1e449d72a085926c65256
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490317
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-31 04:34:50 +00:00
Leon Scroggins III
13f244c95c Add more debugging info for backend texture failure
Print out information regarding the GrBackendTexture, along with the max
render target size, when we crash.

Add another crash in another file which may be responsible for the
failure.

Consolidate RENDERENGINE_ABORTF into a header file so it can be shared.

Bug: b/206415266
Change-Id: I2cceb847bc913a43c5341a26558e74ac13cc7b7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490277
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-12-30 22:30:27 +00:00
skia-autoroll
dcf2710c89 Roll ANGLE from 6f1c39b52b4f to a400e76d02df (3 revisions)
6f1c39b52b..a400e76d02

2021-12-30 syoussefi@chromium.org Vulkan: Don't expose MSRTT without VK_KHR_depth_stencil_resolve
2021-12-30 ynovikov@chromium.org Skip angle_end2end_tests failing on Linux AMD RX 5500 XT
2021-12-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d09758fa672c to e45e6e1a55ae (153 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: I6a51e0c2bf98b41eea458143a799603dc1d7f2a8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490138
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-30 05:24:19 +00:00
skia-autoroll
03803cd0e1 Roll Dawn from 3c3929abb191 to a0eca4a3e4ff (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/3c3929abb191..a0eca4a3e4ff

2021-12-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c32df39c11ce to 09edcd7c680b (1 revision)
2021-12-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6f1c39b52b4f to b7d2f4478cb2 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: If42af73b4eb369d8bf02f13d160324537774b18e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490137
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-30 04:41:48 +00:00
skia-autoroll
82fec5a506 Roll Chromium from 43dfb5d2bb06 to 3fb49d6ae3d0 (149 revisions)
43dfb5d2bb..3fb49d6ae3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I4219e618ca78165d141eb63db8a484b7973dbd28
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/490136
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-30 04:38:45 +00:00
John Stiles
65aae8a51a Disable SkSL optimization when SkRuntimeEffect::MakeTraced is called.
SkRuntimeEffect::MakeForXxxxx compiles its shaders before MakeTraced()
is invoked, with optimizations enabled. When MakeTraced() is called,
we recompile the shader with optimizations disabled; this allows us to
present the user with a shader that is as close to the original as
possible. (This obviously costs time, but debug trace generation isn't
focused on speed.)

Note that in some rare instances, disabling optimizations can cause
compilation to fail (e.g. optimization can simplify control flow and
eliminate "unreachable" paths). In those cases, we fall back to the
existing behavior of debugging an optimized shader.

Change-Id: Iba0f31bc42374c7048694fde5415b122177a9a68
Bug: skia:12666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489716
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-29 18:54:19 +00:00
John Stiles
d67f1f8f50 Provide bit-casted slot values from DebugTracePlayer.
Previously, the VariableData returned from a DebugTracePlayer contained
values in an int32_t, regardless of the slot's NumberKind. We had a
helper function which could stringize the bits, but otherwise the caller
was responsible for bit-casting the value manually.

Now, the DebugTracePlayer will automatically manage bit-casting for the
caller. The value returned in the VariableData is now a double (so it
is able to store an int32, uint32, or float at full precision).

This change was inspired by the recent Typescript port. (The value in
the Typescript VariableData uses a compound `number | boolean` type, so
it is able to fully represent any slot value natively.)

Change-Id: I5eec414236f76ad0ff51b0b19974e4a0025c4d62
Bug: skia:12666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489896
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-29 18:30:19 +00:00
skia-autoroll
0ada61c87e Roll ANGLE from 0a28c6c61b2f to 6f1c39b52b4f (3 revisions)
0a28c6c61b..6f1c39b52b

2021-12-28 lfy@google.com Vulkan: Restore color attachment mask-related blend states
2021-12-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 87c78ac5eb86 to 433b1bf9bff2 (2 revisions)
2021-12-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0635acc4de22 to d09758fa672c (93 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: Ic14b71e61dd075cbec4b503e2fce7310e48972e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489758
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 07:13:19 +00:00
skia-autoroll
8dc6d1eee6 Roll Dawn from 5657f89f4489 to 3c3929abb191 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/5657f89f4489..3c3929abb191

2021-12-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 95f6e6865fa6 to 6f1c39b52b4f (1 revision)
2021-12-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a28c6c61b2f to 95f6e6865fa6 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: I7a9bad855356f657eb8b467aee7f7040d1d9a6ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489760
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 06:08:46 +00:00
skia-autoroll
b409f78083 Roll Chromium from c657707aead4 to 43dfb5d2bb06 (153 revisions)
c657707aea..43dfb5d2bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: Id3b60d5866f9e4c5ff594c7199cb7c2f6f27349b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489759
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 05:33:49 +00:00
John Stiles
bab224e1c2 Prevent interface block members from using invalid names.
Interface blocks now guard against naming their member variables with
built-in type names like "float" or "bool".

Change-Id: Ia767542ace76fb8fbc2d50c81772b7f54b1bf973
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489616
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 20:57:18 +00:00
John Stiles
aa09c782a8 Add test for structs/interface-blocks with invalid member names.
Structs already handled this appropriately, but interface blocks did not
guard against naming their member variables built-in type names like
"float" or "bool".

Change-Id: I12ec054b3f158b83e35031449cf2a088ff8d0dc2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489596
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-12-28 20:55:32 +00:00
John Stiles
f604efbeb4 Add support for anonymous function parameters in SkSL.
Anonymous function parameters are now automatically assigned a name,
"_skAnonymousParamN", where N is the parameter index.

Change-Id: I87adcd51ed025c76ae2b333317f21b523a4632b4
Bug: skia:12769
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489538
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 20:47:05 +00:00
Leon Scroggins III
2cc656a89c ANDROIDFRAMEWORK_DEBUGF -> RENDERENGINE_ABORTF
Bug: b/206415266

We added ANDROIDFRAMEWORK_DEBUGF logs to help diagnose a crash, but the
bugreports start with the crash, which occurs after these logs. Change
the logs to ABORTs so the bugreports will contain this new information.

Only turn on the new abort statements when in RenderEngine. Add a new
define so that we can distinguish between the version of Skia used in
RenderEngine from the one in HWUI.

Change-Id: Ib096fc0b09741ec73ddedaa7cfdd21c5584d74cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489476
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-12-28 20:22:11 +00:00
John Stiles
1c7d442b52 Add test containing anonymous function parameters.
SkSL will reject ES2-compatible code because function parameters always
require a name in SkSL. (A followup CL relaxes this restriction and
allows anonymous parameters in SkSL.)

Change-Id: Ifdcf0fcbe0f52d16007c018b545631ca4033a8c4
Bug: skia:12769
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489537
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-28 20:08:56 +00:00
John Stiles
106776364d Prevent structs/interface-blocks from claiming builtin types.
Structs and interface blocks allow a trailing identifier which is added
to the symbol table. This identifier is now prohibited from
overlapping built-in types.

Change-Id: I33b9d6156a27ce017e6744a05979748c04a04767
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489516
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 19:32:22 +00:00
John Stiles
48432e133e Add test demonstrating struct/interface-block name conflict.
Structs and interface blocks allow a trailing identifier which is added
to the symbol table. This identifier should be prohibited from
overlapping built-in types; at present, this is not checked. Add a test
demonstrating the issue.

Change-Id: I99aa915c1715c468cc369c97b7f12e031b86ea4a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489496
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-12-28 19:26:17 +00:00
John Stiles
1a746070ac Fix overzealous debug trace generation.
When the SkVM interpreter is operating in "stride=1" mode, we should
only look at the first lane of the trace/execution masks. The other
lanes are not being actively used, but the "index" opcode still fills
all the lanes, so it's entirely possible for the trace coordinate to
match in an unused lane.

Change-Id: I7f04f5c59431b3c50b4b072bc3ea4f52f8aa1a1b
Bug: skia:12752
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488796
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 15:39:16 +00:00