Commit Graph

13 Commits

Author SHA1 Message Date
Eric Boren
2697d14ac6 Reland "[recipes] Assert that Git is obtained from CIPD"
This reverts commit 491eba5f1d.

Reason for revert: Should be fixed

Original change's description:
> Revert "[recipes] Assert that Git is obtained from CIPD"
> 
> This reverts commit 6751f171c6.
> 
> Reason for revert: Missed at least one
> 
> Original change's description:
> > [recipes] Assert that Git is obtained from CIPD
> > 
> > Bug: skia:9538
> > Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Eric Boren <borenet@google.com>
> 
> TBR=borenet@google.com,kjlubick@google.com
> 
> Change-Id: Ic90ae5672ce605f1667d7f961026303905824032
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:9538
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252190
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,kjlubick@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:9538
Change-Id: I2dfbd66c75e6b41a5f63b3f89bf8988827a639d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252480
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-04 16:40:29 +00:00
Eric Boren
491eba5f1d Revert "[recipes] Assert that Git is obtained from CIPD"
This reverts commit 6751f171c6.

Reason for revert: Missed at least one

Original change's description:
> [recipes] Assert that Git is obtained from CIPD
> 
> Bug: skia:9538
> Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,kjlubick@google.com

Change-Id: Ic90ae5672ce605f1667d7f961026303905824032
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9538
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252190
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 18:57:59 +00:00
Eric Boren
6751f171c6 [recipes] Assert that Git is obtained from CIPD
Bug: skia:9538
Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 18:47:08 +00:00
Kevin Lubick
513109e9de Remove skiaserve as build output
Bug: skia:7399

Change-Id: I0cabc3c04f1b1af3277c35e2d16712d821be2c5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246300
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-10-04 16:41:19 +00:00
Kevin Lubick
9e951cd782 Reduce bandwidth to RPIs
PS1 refactors to make copying more explicit.

Change-Id: I35c3aecd10bbdb5ab2a462c72b062d979f48fce8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246099
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-04 14:50:49 +00:00
Ben Wagner
ba36ee7826 Update to XCode 10.3
Bug: skia:9194
Change-Id: Ideecb40fc4f30a8ffac64877431332886d95045a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230578
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-11 17:00:13 +00:00
recipe-roller
a47836e01a Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f362dc019e5cedc0e5ce334039a16afcbc95dcb4 Reland "[fileutil] Add support for recursive glob" (atyfto@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c1a79eb1f1fc8a23bf02ac25f17b8673d7dd199
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240416
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-10 11:50:47 +00:00
recipe-roller
e7c1b99e63 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e7fec5ccb9e70bf17b7878e63052a874afa06856 Change is_luci default to True. (mmoss@google.com)


R=jcgregorio@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If60c02932df26d29f1aea14cea4a342c4f4f211a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234330
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-08-14 11:16:56 +00:00
Mike Klein
e6d800ac0e disable false-postive Wthread-safety-analysis
Some of these compilers seem to misdiagnose correct use of

    if (tryAcquire()) {

       release()
    }

as releasing a lock that hadn't been acquired, but newer compilers
seem just fine.  Let's just turn it off until they can be upgraded.

No bug for the Chromecast builders I can see, but here's the Macs.

Bug: skia:9194
Change-Id: I009a142d4a248dc9d9d085e033b5c7303d732c5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233057
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-08-07 17:10:23 +00:00
Ben Wagner
2891b87844 Set mac_sdk_min=10.13 for CommandBuffer builds
The default SDK version was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/1711106, but
our bots don't have that version yet. This is causing failed rolls,
e.g. https://skia-review.googlesource.com/c/skia/+/231071.

The DEPS change was cherry-picked from
https://skia-review.googlesource.com/c/skia/+/231071.

Change-Id: Iddfa0c7cb8ef676bf6f6b2093c120afdd33513f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231097
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-31 16:35:25 +00:00
Eric Boren
58d1f76fc0 Reland "[infra] Make most builds idempotent"
This reverts commit de71a74fc4.

Reason for revert: Reland with fixes

Original change's description:
> Revert "[infra] Make most builds idempotent"
> 
> This reverts commit 57aa178dea.
> 
> Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail
> 
> Original change's description:
> > [infra] Make most builds idempotent
> > 
> > Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> > Commit-Queue: Eric Boren <borenet@google.com>
> > Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> 
> TBR=borenet@google.com,benjaminwagner@google.com
> 
> Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: Ie5462e06da06ec835eaa49778111afa063f9404a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228556
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-07-19 12:11:27 +00:00
Ben Wagner aka dogben
de71a74fc4 Revert "[infra] Make most builds idempotent"
This reverts commit 57aa178dea.

Reason for revert: Causes Build-Debian9-Clang-x86-devrel-Android_SKQP to fail

Original change's description:
> [infra] Make most builds idempotent
> 
> Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: I886483a01c53da2cb7816651a02b35b780ffcf67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228441
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 21:30:22 +00:00
Eric Boren
57aa178dea [infra] Make most builds idempotent
Change-Id: I084645a46feda183747e9d7fc3b40b1aa56c5f78
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211103
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-07-18 19:32:34 +00:00