AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
23,486 Commits 1 Branch 0 Tags 544 MiB
d0c38315e8
Commit Graph

23486 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
mtklein
dc90b53350 Silence -Wclobbered in each file that needs it. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009

Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86-Release-Trybot

Review-Url: https://codereview.chromium.org/2184823009
 2016-07-28 14:45:28 -07:00
halcanary
00450f1ae5 SkPDF: drawText makes use of SkPaint.measureText() for alignment. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188303003

Review-Url: https://codereview.chromium.org/2188303003
 2016-07-28 14:33:13 -07:00
reed
9b84f8c812 turn bitmaps into images during recording 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185563003

Review-Url: https://codereview.chromium.org/2185563003
 2016-07-28 14:26:13 -07:00
mtklein
2b6870ccb2 GN: nanobench 
Add nanobench, and while we're at it monobench to show off how cool
source_sets are... the bench files are only built once then linked
into both binaries.  With GYP we build them twice. :/  Same deal
for GMs between nanobench and DM... build once, link twice.

nanobench uses SkImageEncoder to encode its .pngs, which requires
we link in the image encoders, which requires we get them all in.
That's the bulk of this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193513002

Review-Url: https://codereview.chromium.org/2193513002
 2016-07-28 14:17:33 -07:00
mtklein
2f428966c6 Revert of Silence -Wclobbered in each file that needs it. (patchset #2 id:20001 of https://codereview.chromium.org/2184823009/ ) 
Reason for revert:
Jpeg strategy seems to be leading to crashes.  Gonna go back to warning squelch.

Original issue's description:
> Silence -Wclobbered in each file that needs it.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009
>
> Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5

TBR=msarett@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2188313003
 2016-07-28 13:59:59 -07:00
bsalomon
4d516a6903 Serialize SkColorSpace into DeferredTextureImage 
This fixes a memory leak that occurs when DeferredTextureImage is deallocated without being destroyed. It is intended to be stored in discarable memory and thus this has to be safe.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010

Review-Url: https://codereview.chromium.org/2184823010
 2016-07-28 13:37:31 -07:00
mtklein
03f704a343 Silence -Wclobbered in each file that needs it. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009

Review-Url: https://codereview.chromium.org/2184823009
 2016-07-28 11:57:31 -07:00
jcgregorio
50d1847815 Fix expectations for GN bot. 
BUG=skia:

Review-Url: https://codereview.chromium.org/2191933002
 2016-07-28 11:55:51 -07:00
bsalomon
4484d6ac78 Remove unused render target members from GL and VK sk_app::WindowContext classes 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191673002

Review-Url: https://codereview.chromium.org/2191673002
 2016-07-28 11:49:12 -07:00
csmartdalton
a26efc9bad Include NVPR configs in dm runs on TegraX1 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174353008

Review-Url: https://codereview.chromium.org/2174353008
 2016-07-28 11:48:13 -07:00
mtklein
f05c2c22a7 GN: add abbreviated versions of the command line as descriptions. 
This should help make the bot logs a little easier to read.  (On the console
this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an
interactive console.)

As usual, Ninja will print the full command when a task fails.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188263002

Review-Url: https://codereview.chromium.org/2188263002
 2016-07-28 11:42:34 -07:00
fmenozzi
17e829794d Add HardStopGradientBench_ScaleNumHardStops.cpp 
Rename HardStopGradientBench.cpp to HardStopGradientBench_ScaleNumColors.cpp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178913003

Review-Url: https://codereview.chromium.org/2178913003
 2016-07-28 10:59:49 -07:00
borenet
f49d9d77bb Add swarmbucket_wrapper recipe 
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003

Review-Url: https://codereview.chromium.org/2185203003
 2016-07-28 10:50:54 -07:00
msarett
a0605bf9d1 Add writeToMemory() API to SkColorSpace 
New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.

This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002

Review-Url: https://codereview.chromium.org/2192903002
 2016-07-28 10:47:50 -07:00
mtklein
0634317cbe GN: fix mac build again 
Hoping to land these using the other GN bots as trybots.

Don't know what magic was letting us get to webp's headers yesterday on Linux.  Might have been using /usr/include's ?

The other change is the difference between some setups using #define SK_BUILD_FOR_MAC and others #define SK_BUILD_FOR_MAC 1.  We want either to mean "we're Mac".

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190713004

Review-Url: https://codereview.chromium.org/2190713004
 2016-07-28 09:58:44 -07:00
fmalita
eae6a91277 SkPaint intercept API for SkTextBlob and horizontal text 
Add getPosTextHIntercepts(), getTextBlobIntercepts().

Consolidate the implementation in GetTextIntercepts<> template.

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004

Review-Url: https://codereview.chromium.org/2186663004
 2016-07-28 09:47:24 -07:00
mtklein
fa84d94bb0 Make both SK_API definition points identical and order independent. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189983002

Review-Url: https://codereview.chromium.org/2189983002
 2016-07-28 09:45:15 -07:00
jcgregorio
ba59595ea3 recipes: Add a GN flavor. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003

Review-Url: https://codereview.chromium.org/2189713003
 2016-07-28 09:38:59 -07:00
robertphillips
a408c8fb6d Add SkGammaColorFilter 
WDYT about this as a means of replacing GrContext::applyGamma with a normal SkCanvas::drawImage?

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190573002

Review-Url: https://codereview.chromium.org/2190573002
 2016-07-28 09:20:33 -07:00
borenet
9c18546b78 Fixes for SwarmBucket bot 
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002

Review-Url: https://codereview.chromium.org/2190933002
 2016-07-28 08:58:38 -07:00
dvonbeck
bba4cfebca Added API for Bevel NormalSource. 
This CL adds an API  for Bevel normal source and a dummy implementation that returns a normal (0, 0, 1) every time.

This CL's base is the CL for accepting nullptrs: https://codereview.chromium.org/2132113002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2080993002

Review-Url: https://codereview.chromium.org/2080993002
 2016-07-28 08:58:19 -07:00
bsalomon
1c58696112 Remove unused sk_app::WindowContext::presentRenderSurface 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184273002

Review-Url: https://codereview.chromium.org/2184273002
 2016-07-28 08:53:13 -07:00
egdaniel
b4021cfd66 Don't call finish on GrDrawTarget if we drew no batches 
This might give us some minor perf gains in vulkan since we won't be submitting
command buffers that we've added to batch draws to. Running nanobench this does
seem to happen pretty often.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179903008

Review-Url: https://codereview.chromium.org/2179903008
 2016-07-28 08:53:07 -07:00
tomhudson
92772222bf Revert of align cap hairline first point (patchset #2 id:20001 of https://codereview.chromium.org/2189583003/ ) 
Reason for revert:
Speculative revert in case this is blocking our roll.

Original issue's description:
> align cap hairline first point
>
> Hairlines with square caps move the endpoints out by 1/2 pixel.
> The last point needs to be the first adjusted point, instead
> of the point supplied to move to.
>
> R=fmalita@chromium.org
> TBR=reed@google.com
> BUG=617658
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003
>
> Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05

TBR=fmalita@chromium.org,reed@google.com,caryclark@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617658

Review-Url: https://codereview.chromium.org/2188483007
 2016-07-28 07:36:28 -07:00
mtklein
8796ff1fbc Turn on flags to enforce SK_API. 
These flags hide symbols that are not marked with SK_API when linked into a
shared library.  There's nominally no effect on static linking, but I'm
pretty sure the Mac linker takes some advantage of this too to run faster.

This makes component-build DM no longer link: it uses many non SK_API APIs.
Fiddle in contrast is just fine with our public APIs, so no need to restrict that.

It'll be fun finding out which of our other tools go which ways.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180383003

Review-Url: https://codereview.chromium.org/2180383003
 2016-07-27 14:59:08 -07:00
halcanary
4b1e17edc7 SkPdf: SkPDFFormXObject de-class-ified. 
We don't need an object, just a few standard fields on the
base class; the change lets us get rid of a bunch of
boilerplate code.

I think this also reduces the cognitive load of the SkPDF
internals.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185803003

Review-Url: https://codereview.chromium.org/2185803003
 2016-07-27 14:49:46 -07:00
jcgregorio
4b9ebab04d upload_bench_results - fix GS upload path. 
_UploadJSONResults does '/'.join() so the trailing / is unnecessary.

BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003

Review-Url: https://codereview.chromium.org/2187903003
 2016-07-27 14:34:06 -07:00
jvanverth
b8794ccea2 Enable backend switching for Windows Viewer 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184163003

Review-Url: https://codereview.chromium.org/2184163003
 2016-07-27 14:29:18 -07:00
halcanary
fe8f0e0d31 SkPDF: refactor font subset: fewer copies 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190643002

Review-Url: https://codereview.chromium.org/2190643002
 2016-07-27 14:14:04 -07:00
borenet
151aee4220 Fix silently-failing compile 
Ouch...

TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002

Review-Url: https://codereview.chromium.org/2191663002
 2016-07-27 14:05:54 -07:00
mtklein
25c81d4e65 GN: dm 
This builds, links, and runs on Linux.  Have not tried Mac.

I've tested is_debug={true,false} and is_component_build.
It's neat that the component build DM works, but it's also an indication I've missed an essential flag or two... it shouldn't work. :)

The GPU backend isn't working yet, but all the software configurations I've tried look good.

This fleshes out all the other parts of SkCodec too... I noticed we weren't able to decode gifs or webp.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188643002

Review-Url: https://codereview.chromium.org/2188643002
 2016-07-27 13:55:27 -07:00
msarett
7b9b541af8 Expose more gamma info for UMA statistics 
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188633003

Review-Url: https://codereview.chromium.org/2188633003
 2016-07-27 13:51:46 -07:00
csmartdalton
34ee0c950e Fix GrDrawContextPriv::stencilRect 
Updates stencilRect to call drawNonAAFilledRect instead of
drawFilledRect. drawFilledRect can use coverage AA, which isn't
appropriate for stencil draws. Also modifies drawNonAAFilledRect to
take a "useHWAA" argument instead of trying to deduce whether it
should be used.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187583002

Review-Url: https://codereview.chromium.org/2187583002
 2016-07-27 13:22:27 -07:00
kjlubick
e772aeea08 Add Vulkan runtime dll 
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002

Review-Url: https://codereview.chromium.org/2188543002
 2016-07-27 12:59:12 -07:00
caryclark
52f85d4d09 align cap hairline first point 
Hairlines with square caps move the endpoints out by 1/2 pixel.
The last point needs to be the first adjusted point, instead
of the point supplied to move to.

R=fmalita@chromium.org
TBR=reed@google.com
BUG=617658
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003

Review-Url: https://codereview.chromium.org/2189583003
 2016-07-27 12:50:09 -07:00
borenet
9913dfca2a Make the experimental SwarmBucket bot use the SkiaTriggers pool 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187023002

Review-Url: https://codereview.chromium.org/2187023002
 2016-07-27 12:45:35 -07:00
halcanary
95860ad400 DEPS: sfntly 468cad5 → b18b09b 
SfntlyWrapper::SubsetFont now takes TTC index, needed for SkPDF.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186103002

Review-Url: https://codereview.chromium.org/2186103002
 2016-07-27 12:28:56 -07:00
robertphillips
6738c70242 Rename GrContext's newDrawContext & drawContext to makeDrawContext 
These both return sk_sp.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186073002

Review-Url: https://codereview.chromium.org/2186073002
 2016-07-27 12:13:51 -07:00
bsalomon
81ce4a9c55 Make the yasm copy target be type 'none' rather than type 'executable' 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182873005

Review-Url: https://codereview.chromium.org/2182873005
 2016-07-27 12:07:43 -07:00
caryclark
d6562000ef require semi at the end of SkASSERT and friends 
R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002

Review-Url: https://codereview.chromium.org/2185063002
 2016-07-27 12:02:07 -07:00
mtklein
7d10b9f6e6 GN: fixes for Mac 
- Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002

NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.

Review-Url: https://codereview.chromium.org/2184133002
 2016-07-27 11:17:18 -07:00
halcanary
ac0e00dcec SkPDF: SkPDFStream takes a unique_ptr 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188623004

Review-Url: https://codereview.chromium.org/2188623004
 2016-07-27 11:12:23 -07:00
benjaminwagner
cb571e1148 Rename textual includes as *.inc. 
This makes it easier to distinguish source files that can stand on their own vs files meant to be #included into other source files.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184143002

Review-Url: https://codereview.chromium.org/2184143002
 2016-07-27 11:12:12 -07:00
halcanary
89da693035 DEPS: ICU c291cde → ec9c113 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189643003

Review-Url: https://codereview.chromium.org/2189643003
 2016-07-27 10:13:25 -07:00
halcanary
aa7f67c76b DEPS: harfbuzz 1.2.7 → 1.3.0 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179963005

Review-Url: https://codereview.chromium.org/2179963005
 2016-07-27 10:08:39 -07:00
halcanary
81a9ce1944 DEPS: sfntly 130f832 → 468cad5 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189643002

Review-Url: https://codereview.chromium.org/2189643002
 2016-07-27 10:08:18 -07:00
borenet
b53a886924 Include "revision" tag for all Swarming tasks 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002

Review-Url: https://codereview.chromium.org/2186993002
 2016-07-27 09:36:17 -07:00
brianosman
577e025ca6 Fix ParseConfigs_ViaParsing test when skia_angle=1 
The handling of angle-gl changes with SK_ANGLE. We don't have any bots
that test this particular combination, but I see it all the time while
running DM for other things.

Previously considered changing things so that the config parsing results
are consistent, regardless of GYP_DEFINES, but this is much simpler (and
more consistent with the other code we already have for testing config
parsing).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183323004

Review-Url: https://codereview.chromium.org/2183323004
 2016-07-27 09:21:52 -07:00
bsalomon
bb0ab4df70 Fix leak of srgb/adobesrgb colorspace objects 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185043002

Review-Url: https://codereview.chromium.org/2185043002
 2016-07-27 08:58:31 -07:00
borenet
7b2ed4c649 Fix Perf data upload 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005

Review-Url: https://codereview.chromium.org/2187603005
 2016-07-27 08:51:55 -07:00