AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
42,468 Commits 1 Branch 0 Tags 544 MiB
d3e75a7a1c
Commit Graph

2095 Commits

Author SHA1 Message Date
skia-recreate-skps
65872c5b4a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Iea2f05ba9e9c2d199db8056d3084b2707f6cbc7f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199540
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-10 05:37:54 +00:00
skia-recreate-skps
66c4cda393 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I847e3bb22e27a104d27c763583099e2f32404a53
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199415
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-09 05:42:33 +00:00
Ben Wagner
fc9cb4dfce Add CMake asset for macOS. 
Bug: skia:8784
Change-Id: I2e07e9213ed1cad074ed5f56a4a80562e8c139e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/198825
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2019-03-08 13:18:08 +00:00
skia-recreate-skps
3d1b941f3a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ifc18dac8945c60d6bad4ffcefaae9f0014952994
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199165
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-08 05:43:28 +00:00
skia-recreate-skps
52e620ffd0 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6cc8a90b6fc524496fd40a6654017ab8e2e23d6c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/198331
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-07 05:47:58 +00:00
Eric Boren
2a889a84a2 [infra] Remove bookmaker bots 
We've decided to move in a different direction for Skia documentation.

Bug: skia:
Change-Id: I4acfe06e412006cdd3d692d017e51ecf3e98f4c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/198162
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2019-03-06 15:40:36 +00:00
skia-recreate-skps
47a5055333 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib7fb961e4a898e5bd22e045e5a9dab93da6e089c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/198080
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-06 05:45:16 +00:00
Ben Wagner
bd66269c5b [infra] Upgrade Debian GCE bots to 9.8. 
Change-Id: I4996779ad7a634bce6e39eb6defa4bc0cea026d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197203
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-03-05 17:42:23 +00:00
skia-recreate-skps
e1d3a28ed2 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I006d9e296705dc5f3495dcb598ef8db53f6434ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197480
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-05 11:30:40 +00:00
skia-recreate-skps
e3e80b7edf Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie6af3c493df45dda589956005c835efe4a0d5a05
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196961
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-04 21:33:48 +00:00
skia-recreate-skps
1b9f889628 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I5e321e403da17668eee0e933541e8245594f05ba
Reviewed-on: https://skia-review.googlesource.com/c/196960
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-03 08:39:32 +00:00
skia-recreate-skps
c97b0672a7 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Iefc82929a002c274d77df6586fe1ccf89a12d286
Reviewed-on: https://skia-review.googlesource.com/c/196471
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-03 05:39:52 +00:00
skia-recreate-skps
a232cd4482 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia3ea48b3138bbf0fc57ef282281ad3f88d54a9fa
Reviewed-on: https://skia-review.googlesource.com/c/196860
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-03-02 05:35:21 +00:00
Ben Wagner
b8a3f9d6b8 Remove OS condition from isolate files 
Change-Id: Ib8e7d4dd40bb8e59b0901ef40351ccae924749d2
Reviewed-on: https://skia-review.googlesource.com/c/196384
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2019-02-28 17:40:00 +00:00
Kevin Lubick
78cb455f82 [canvaskit][pathkit] Remove flaky/low-utility Debug tests 
Bug: skia:
NOTRY: true
Change-Id: I316a341bdd6a108281e4a1a897c9b59793f270ad
Reviewed-on: https://skia-review.googlesource.com/c/196382
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-02-28 17:34:30 +00:00
Eric Boren
113cba82e7 [recipes] Plumb task ID through to DM results 
Bug: skia:
Change-Id: If5b71aba04964b61a634ccda7115c9f37a777468
Reviewed-on: https://skia-review.googlesource.com/c/195367
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2019-02-27 18:24:00 +00:00
skia-recreate-skps
ab3f8674c9 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I7e16c7d3cff1396766c182e62073bf2c0315f8cb
Reviewed-on: https://skia-review.googlesource.com/c/195721
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-27 05:38:19 +00:00
skia-recreate-skps
fe23736201 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia1678080061a0441e6d13bcf326c473c2c7b48e3
Reviewed-on: https://skia-review.googlesource.com/c/195260
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-26 05:47:24 +00:00
Leon Scroggins III
06eaef8589 Add a wuffs Release bot 
Bug: skia:8235

This way we can track performance in perf.

Change-Id: I0e1b6101d5642d3f22080abc1077215ca43b3aae
Reviewed-on: https://skia-review.googlesource.com/c/194421
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2019-02-25 18:00:38 +00:00
Eric Boren
b8960d0535 [infra] Make the presubmit bot use recipes from CIPD 
Bug: skia:
Change-Id: I28f118521fc4f1f27c2601d70e855fb7f5623ba2
Reviewed-on: https://skia-review.googlesource.com/c/194861
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2019-02-25 16:04:59 +00:00
skia-recreate-skps
5bbd02d6bb Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6347b8949c194ee39ee8ab77f0f2c9c8381136c7
Reviewed-on: https://skia-review.googlesource.com/c/194504
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-25 05:37:25 +00:00
skia-recreate-skps
52d8a5976a Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I87597e667aaa7901d20f028de4db4a9fd4e17db5
Reviewed-on: https://skia-review.googlesource.com/c/194503
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-24 08:39:34 +00:00
skia-recreate-skps
33c1b31526 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4110ccf509e87ecbf91ed21694cbc6c114bb0ee6
Reviewed-on: https://skia-review.googlesource.com/c/194502
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-24 05:34:54 +00:00
Kevin Lubick
867da4b96e Allow system harfbuzz. 
This should allow shaper to run on the no-deps bot.

Change-Id: I2515875d4e9b428681c20877630b904c3229ecc5
Reviewed-on: https://skia-review.googlesource.com/c/194420
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
 2019-02-23 12:14:30 +00:00
skia-recreate-skps
72f6f044cc Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ief708528717ab9e156ade7fce2daca6761ab0e25
Reviewed-on: https://skia-review.googlesource.com/c/194501
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-23 05:55:30 +00:00
Jim Van Verth
8fc1eb2893 Disable fontscaler GM on Intel Vulkan 
Bug: skia:
Change-Id: Iec4eb15a070aa26a5ccb741bbf80eb49b594d340
Reviewed-on: https://skia-review.googlesource.com/c/194426
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
 2019-02-22 23:02:29 +00:00
Jim Van Verth
3bc37fd63b Disable tests on more Vulkan bots 
Bug: skia:8659, skia:7959
Change-Id: I952f7b3d91be4e1952045d291bcf97c217208da9
Reviewed-on: https://skia-review.googlesource.com/c/194380
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
 2019-02-22 19:54:36 +00:00
Ben Wagner
1d9f378ec3 [infra] Remove Ubuntu17 jobs 
These have been replaced with Ubuntu18 or IntelIris640 jobs in various
earlier CLs.

Bug: chromium:837351
Change-Id: Id8ce54219e971c1645dc09c81b3031ee1d85c284
Reviewed-on: https://skia-review.googlesource.com/c/192682
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
 2019-02-22 18:43:25 +00:00
Brian Salomon
587e41938d Skip newly added TextureIdleProcFlushTest test on Mac/Metal. It crashes. 
It does not crash on iOS.

https://logs.chromium.org/logs/skia/RmWNhdlMctRJ4z8e4v1h/+/steps/dm/0/stdout

    0   dm                                  0x00000001071eeb6d _ZL13crash_handleri + 509
    1   libsystem_platform.dylib            0x00007fff6343df5a _sigtramp + 26
    2   ???                                 0x00007fd549bb8a20 0x0 + 140554041788960
    3   IOAccelerator                       0x00007fff5550cfe9 ioAccelResourceGroupAddNewResource + 134
    4   IOAccelerator                       0x00007fff5550d0de ioAccelResourceListAddNewGroupAndResource + 201
    5   IOAccelerator                       0x00007fff5550cc21 IOAccelResourceListAddResource + 304
    6   AMDMTLBronzeDriver                  0x000000010a5c564d _Z28amdMtlBronzeCmdBufUpdateRsrcP19BronzeCmdBufInfoRecP18MTLIOAccelResourcejj + 65
    7   AMDMTLBronzeDriver                  0x000000010a5c83f6 _ZL22amdMtlBronzeSetTextureP32BronzeRenderCmdEncoderMembersRecjPU21objcproto10MTLTexture11objc_objectjjj + 88
    8   dm                                  0x0000000107d527cd _ZN39MVKGraphicsResourcesCommandEncoderState10encodeImplEv + 653
    9   dm                                  0x0000000107d34cef _ZN17MVKCommandEncoder17finalizeDrawStateEv + 63
    10  dm                                  0x0000000107d33309 _ZN10MVKCmdDraw6encodeEP17MVKCommandEncoder + 25
    11  dm                                  0x0000000107d3421c _ZN17MVKCommandEncoder15encodeSecondaryEP16MVKCommandBuffer + 44
    12  dm                                  0x0000000107d36f1b _ZN21MVKCmdExecuteCommands6encodeEP17MVKCommandEncoder + 43
    13  dm                                  0x0000000107d33f6b _ZN17MVKCommandEncoder6encodeEP31MVKQueueCommandBufferSubmission + 107
    14  dm                                  0x0000000107d33e9c _ZN16MVKCommandBuffer7executeEP31MVKQueueCommandBufferSubmissionRK29MVKCommandBufferBatchPosition + 124
    15  dm                                  0x0000000107d4666e _ZN31MVKQueueCommandBufferSubmission7executeEv + 94
    16  dm                                  0x0000000107d45b2c ___ZN8MVKQueue6submitEP18MVKQueueSubmission_block_invoke + 28
    17  libdispatch.dylib                   0x00007fff630fd5fa _dispatch_call_block_and_release + 12
    18  libdispatch.dylib                   0x00007fff630f5db8 _dispatch_client_callout + 8
    19  libdispatch.dylib                   0x00007fff6310a217 _dispatch_queue_serial_drain + 635
    20  libdispatch.dylib                   0x00007fff630fd166 _dispatch_queue_invoke + 373
    21  libdispatch.dylib                   0x00007fff6310af0d _dispatch_root_queue_drain_deferred_wlh + 332
    22  libdispatch.dylib                   0x00007fff6310ed21 _dispatch_workloop_worker_thread + 880
    23  libsystem_pthread.dylib             0x00007fff63446fd2 _pthread_wqthread + 980
    24  libsystem_pthread.dylib             0x00007fff63446be9 start_wqthread + 13

Bug: skia:8243
Change-Id: Iea6aecece9cfb8e8e8cb7a7232e441248172720b
Reviewed-on: https://skia-review.googlesource.com/c/194191
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-02-22 17:47:15 +00:00
Jim Van Verth
6674077f46 Blacklist fontregen on IntelIris655-Vulkan 
Bug: skia:8659
Change-Id: I48645518b16a1e467832c192aebb97c9ba9762e8
Reviewed-on: https://skia-review.googlesource.com/c/194192
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
 2019-02-22 17:35:35 +00:00
Ben Wagner
b1f5d619e8 Upgrade MacBookAir7.2 to macOS 10.14; rename jobs to include OS version 
Also add a NativeFonts job for this bot so we have coverage of 10.14.

Change-Id: I8536d7725eb3492b59318695dd3ecadad76b68ff
Reviewed-on: https://skia-review.googlesource.com/c/194022
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-02-22 16:25:05 +00:00
Kevin Lubick
1ba9c4df77 [canvaskit] JS API in place for shaped text 
Depends on https://skia-review.googlesource.com/c/skia/+/186870

It's optional at build time, which is good given that
it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB)

Bug: skia:
Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe
Reviewed-on: https://skia-review.googlesource.com/c/187924
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
 2019-02-22 15:39:55 +00:00
skia-recreate-skps
1d4d3d5e07 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia7da5988f47c044779ac9ccffc3e85ce26c56820
Reviewed-on: https://skia-review.googlesource.com/c/194120
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-22 05:52:34 +00:00
skia-recreate-skps
755552f390 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icf97a0ecd599fd7118fe695651d3741e2e11b887
Reviewed-on: https://skia-review.googlesource.com/c/193900
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-21 05:42:41 +00:00
Brian Salomon
9a1d77ee30 Blacklist desk_techcrunck.skp_1_mpd on Iris655 and Iris540 
Bug: skia:8706
Change-Id: I53623d5834b8d2548f825d4e3b40ca0147496f60
Reviewed-on: https://skia-review.googlesource.com/c/193463
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-02-20 20:29:00 +00:00
Mike Klein
8245d86c72 update NDK to r19b 
Nothing interesting.  We were already on r19's beta.

Change-Id: I4d58e7f82317427d06ef5b138681c00b476ecd9a
Reviewed-on: https://skia-review.googlesource.com/c/193469
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
 2019-02-20 15:45:14 +00:00
skia-recreate-skps
07b8188016 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia33bfb33180b0fabe835b6412251b547e4850206
Reviewed-on: https://skia-review.googlesource.com/c/193490
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-20 05:44:18 +00:00
Ben Wagner
9883def4f8 [infra] Add back valgrind dimension for Valgrind tasks 
In https://skia-review.googlesource.com/c/skia/+/191741, I was hopeful
that this wouldn't be necessary, but it is.

Change-Id: I8904d5c324372e6623431db781a7a4c67a18641c
Reviewed-on: https://skia-review.googlesource.com/c/193174
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2019-02-19 12:34:59 +00:00
skia-recreate-skps
ef2489f8b0 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4bf389ddec920500ebdf478c6117bbeb26430672
Reviewed-on: https://skia-review.googlesource.com/c/192783
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-19 05:39:08 +00:00
Robert Iannucci
f4d4b87269 [recipes] Manual roll. 
Update package_repo_resource usage.

depot_tools:
  https://crrev.com/2b14855de938012c055713a2943dc10ca1a730d3 [cipd] Update CIPD 2.2.15 -> 2.2.16. (vadimsh@chromium.org)
  https://crrev.com/efc7e91fa76494f7f134926a384f4c0101ae982c [recipes] Manual roll. (iannucci@chromium.org)
  https://crrev.com/6344e8c6379b7eb5f05676e5489fff0c19eff894 [recipes] Manual roll (iannucci@chromium.org)
  https://crrev.com/9255c4f22809b69d9ca6c75727d3cc472c1e5518 Manual roll to unstick autoroller (iannucci@chromium.org)

recipe_engine:
  https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org)
  https://crrev.com/a30783346dbde9e790f38cab3d2bb132382e9341 [recipe_deps] Fix slash-separated recipe names on windows. (iannucci@chromium.org)
  https://crrev.com/7e953fd1856282691c74d0b32791e2cdd090803e [recipe_engine] Fix autoroll json output. (iannucci@chromium.org)

R=rmistry@google.com

Bug: 914992
Change-Id: I600be66b7a2663375f3e823e9a1fd4a2acfda65b
Reviewed-on: https://skia-review.googlesource.com/c/192922
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Robbie Iannucci <iannucci@google.com>
 2019-02-17 21:24:01 +00:00
skia-recreate-skps
880b6ea52b Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ibb0f8b2b11d56a2b41ee30cc9ab9b2b65ef1b54c
Reviewed-on: https://skia-review.googlesource.com/c/192925
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-17 09:11:40 +00:00
skia-recreate-skps
21950b9e92 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2bb05575e0ad16780e25b9f6d1aa3aa7cdbc832c
Reviewed-on: https://skia-review.googlesource.com/c/192924
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-17 06:27:40 +00:00
skia-recreate-skps
82d4515c7b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Idd1b551141b83c3879d6b439156baa5fa8c1a399
Reviewed-on: https://skia-review.googlesource.com/c/192923
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-16 14:07:48 +00:00
skia-recreate-skps
154acd7a13 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I7c7c7e98ec8d5cb5d84857da67004db843289f1c
Reviewed-on: https://skia-review.googlesource.com/c/192921
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-15 13:39:02 +00:00
Ravi Mistry
126ac6365c Bring back PerCommit-Bookmaker to the waterfall 
NoTry: true
Bug: skia:
Change-Id: I67f3cfe516cee4db22efecf4ac910c4c88be5552
Reviewed-on: https://skia-review.googlesource.com/c/192402
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-14 14:46:14 +00:00
skia-recreate-skps
6152470dc6 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I32eab7353a624c3b0e38743d95fd1e3bb7a12457
Reviewed-on: https://skia-review.googlesource.com/c/192240
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-14 06:02:34 +00:00
Ravi Mistry
09c01e9df2 Make Housekeeper-PerCommit-Bookmaker a tryjob only bot 
NoTry: true
Bug: skia:8770
Change-Id: Iec19708f6ae82df43d2e7a7d02360ace4cc31d5f
Reviewed-on: https://skia-review.googlesource.com/c/192106
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-14 00:23:20 +00:00
Mike Klein
da5e03954d add Windows -Wuffs builders 
Should help us figure out the build warnings and errors.

I figure we probably don't need any more than the existing one Linux
test bot until we're looking to make the big switch?

Bug: skia:8764
Change-Id: I7a8b427e3ac7278907e67f140d9e067161cd2123
Reviewed-on: https://skia-review.googlesource.com/c/192027
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
 2019-02-13 17:27:31 +00:00
Leon Scroggins III
30d15e6ca0 Blacklist Codec tests on Wuffs bot 
Bug: skia:8235
Bug: skia:8750
Bug: skia:8762

With these tests skipped, we can run the 'image' tests, meaning that we
will decode tests images at various scales and upload them to Gold. This
will help prevent us from introducing new bugs while we fix the
existing ones. It will also turn the Wuffs bot green.

Change-Id: Idf42abb170ede0944106116b9c4dbb60edafe91a
Reviewed-on: https://skia-review.googlesource.com/c/191740
Reviewed-by: Nigel Tao <nigeltao@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
 2019-02-13 15:25:47 +00:00
skia-recreate-skps
9cee184aaa Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.


TBR=borenet@google.com

Change-Id: I3df99f9cc5fdbe61a472cc285b09c0a9b783526e
Reviewed-on: https://skia-review.googlesource.com/c/191920
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-13 13:11:42 +00:00
Ben Wagner
94a5328e0e Add Ubuntu18 Calmbench and Valgrind jobs 
Change-Id: Ie12013d2a337727d4a170863be7b124ef8d36ad6
Reviewed-on: https://skia-review.googlesource.com/c/191741
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2019-02-13 12:32:12 +00:00
Ben Wagner
7ad9b96d7c Upgrade to Mesa 18.3.3 
This seems to resolve the leak in libxcb, but introduces a new leak in
VkTestUtils.

Bug: skia:8710
Change-Id: I71482d8f1c5eebfffd211a4124bd2db01283741b
Reviewed-on: https://skia-review.googlesource.com/c/186862
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
 2019-02-12 16:42:30 +00:00
Kevin Lubick
402bf74ea8 Build code size treemaps for skottie_tool 
Bug: skia:
Change-Id: I3364fa6b89674f65bf493467198740e1862d215e
Reviewed-on: https://skia-review.googlesource.com/c/191291
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2019-02-12 13:54:00 +00:00
skia-recreate-skps
217acf58d0 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If7655286d056a9975bd59ef0c413b9dd41e9c175
Reviewed-on: https://skia-review.googlesource.com/c/191520
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-12 06:15:39 +00:00
Mike Klein
17593ae5aa add a -Wuffs bot 
Change-Id: Idec98e922e81e062b78403bb83473e20a49dd13e
Reviewed-on: https://skia-review.googlesource.com/c/191292
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
 2019-02-11 21:02:33 +00:00
Mike Klein
103288b50f add Mac OpenCL bots 
Change-Id: Ib078676bfe4de033c878f3007b4581d37e7b759b
Reviewed-on: https://skia-review.googlesource.com/c/191288
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
 2019-02-11 19:40:52 +00:00
skia-recreate-skps
136cd7018a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If3e4fad8335d275cfa6f8abfff8ddfe3cefd4d32
Reviewed-on: https://skia-review.googlesource.com/c/191066
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-11 05:37:21 +00:00
skia-recreate-skps
475134f2de Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1d4d30d055b801255f7ec6fae29eda1ccfc2ebb0
Reviewed-on: https://skia-review.googlesource.com/c/190992
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-10 08:45:29 +00:00
skia-recreate-skps
1e1bc8de56 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I29eefb089937c595c02232db5562a1d78ebb4878
Reviewed-on: https://skia-review.googlesource.com/c/190988
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-10 05:41:52 +00:00
skia-recreate-skps
87461aad72 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icdbdfcbf89094115c0144cc8d503783881eaa423
Reviewed-on: https://skia-review.googlesource.com/c/190565
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-09 05:52:27 +00:00
Ben Wagner
58a2e3d7ff Distinguish DDL in Gold results. 
Bug: skia:8749
Change-Id: I2b21130dc0b81d605122504e7ea5c253c3f50212
Reviewed-on: https://skia-review.googlesource.com/c/190668
Commit-Queue: Stephan Altmueller <stephana@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
 2019-02-08 19:24:20 +00:00
Eric Boren
56bf8ce97b Roll third_party/externals/angle2 a54104803d72..52d861bd49cc (8 commits) 
a54104803d..52d861bd49


git log a54104803d72..52d861bd49cc --date=short --no-merges --format='%ad %ae %s'
2019-02-02 syoussefi@chromium.org Disable -Wextra-semi-stmt
2019-02-02 ianelliott@google.com Implement EGL_ANDROID_recordable for Vulkan back-end.
2019-02-01 jonahr@google.com Fix unnecessary copy of for loop variables in ANGLE
2019-02-01 syoussefi@chromium.org Use env variable to select default backend
2019-02-01 jmadill@chromium.org Enable -Wextra-semi and -Wextra-semi-stmt.
2019-02-01 syoussefi@chromium.org Initial support for compiler AST validation
2019-02-01 jmadill@chromium.org Roll glslang.
2019-02-01 ckulakowski@opera.com Fix for linking of non-component angle_unittests


Created with:
  gclient setdep -r third_party/externals/angle2@52d861bd49cc

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=borenet@google.com

Change-Id: I008df064f6301658404c371cf47a5656d8c11621
Reviewed-on: https://skia-review.googlesource.com/c/188852
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2019-02-08 12:34:36 +00:00
skia-recreate-skps
26490759e4 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Id37b2e7de2fdc4ab8a3cb0c2049d5ce689b03f29
Reviewed-on: https://skia-review.googlesource.com/c/190561
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-08 06:08:26 +00:00
Ben Wagner
f439600429 [infra] Update Win10 in Skolo. 
Change-Id: Icb1876fd7a3b74050493d9e0044a1124b98f817a
Reviewed-on: https://skia-review.googlesource.com/c/190223
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-02-07 23:26:46 +00:00
Jim Van Verth
6bc650e9d7 Fix Metal bots. 
Disables some invalid tests and re-enables others.
Fixes up a shader issue.

Bug: skia:8243
Change-Id: I03c3685c1f0bc55c435121d659e52115f114ca7f
Reviewed-on: https://skia-review.googlesource.com/c/190300
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
 2019-02-07 21:00:20 +00:00
Robert Phillips
c1bee13e13 Add support for Mtl backend to DeferredDisplayListTest 
Change-Id: Ie576bc8442e5a646c33191100be1be5f89d72290
Reviewed-on: https://skia-review.googlesource.com/c/189483
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
 2019-02-07 16:34:50 +00:00
Ben Wagner
9564bf44e5 Upgrade NVIDIA driver on Ubuntu18 QuadroP400 bots. 
Remove Test-Ubuntu18-Clang-Golo-GPU-QuadroP400-x86_64-(Debug|Release)
-All-DDL3_ASAN_Vulkan jobs because they fail with an unidentifiable
memory leak in the NVIDIA driver. These were replaced with Intel jobs
in https://skia-review.googlesource.com/c/skia/+/184071.

Bug: skia:8709
Change-Id: I0c849537e65402a472e674193b0652b80263289c
Reviewed-on: https://skia-review.googlesource.com/c/182262
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
 2019-02-07 15:08:21 +00:00
skia-recreate-skps
859db6b5a0 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ifc899813684593b9a6b7086f4bef210b9a06468d
Reviewed-on: https://skia-review.googlesource.com/c/190120
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-07 05:40:29 +00:00
Ravi Mistry
2b1d179860 Have the RecreateSKPs bot upload to partner bucket 
It will upload to a directory that specifies the day the SKPs were created on:
gs://chrome-partner-telemetry/skps/2019-02-05

Bug: skia:8738
Change-Id: Ic6b719770e16408d580e552af41c1a41c682935a
Reviewed-on: https://skia-review.googlesource.com/c/188300
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-06 18:35:12 +00:00
Ravi Mistry
4b261eac8c Remove PerCommit-Bookmaker 
Requested by reed@

NoTry: true
Bug: skia:
Change-Id: Iba7e1f838a6a2d7004dacd59186481208a6dd66d
Reviewed-on: https://skia-review.googlesource.com/c/189849
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2019-02-06 18:12:03 +00:00
Ben Wagner
6c30e74dd0 Add DDL jobs for Intel 
To work around skia:8709, I'm moving the DDL tests to IntelIris640. The
ASAN jobs still show memory leaks in the driver, but at least I can
identify which calls are leaking and suppress the LSAN warnings.

Adds an SK_ENABLE_SCOPED_LSAN_SUPPRESSIONS define that indicates that
the LSAN header files are available, which is set in recipes for the
Linux ASAN builds. Adds __lsan::ScopedDisabler in four locations for
two Vulkan API calls:
 - CreateGraphicsPipelines in GrVkPipeline::Create and
   GrVkCopyPipeline::Create
 - CreateDescriptorSetLayout in
   GrVkDescriptorSetManager::DescriptorPoolManager::DescriptorPoolManager
   constructor (2 calls)

Also adds a regular suppression for libxcb.so.

See bugs listed below for more details on the leaks.

Bug: skia:8710, skia:8712, skia:8713
Change-Id: I55c6e5d483b4aeed5cd44c64219539ca7214187f
Reviewed-on: https://skia-review.googlesource.com/c/184071
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
 2019-02-06 15:53:32 +00:00
skia-recreate-skps
3abdd7a90e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I60054af4e7a340605427acdfa52d0888e3f50428
Reviewed-on: https://skia-review.googlesource.com/c/189760
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-06 05:45:19 +00:00
Brian Osman
5b4f2d5364 Add "MSRTC" bots that build/test with MSVC runtime checks enabled 
Bug: skia:
Change-Id: I125466990b01b2fb1c9c30b2437a6bac134dda96
Reviewed-on: https://skia-review.googlesource.com/c/189302
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2019-02-05 17:13:24 +00:00
skia-recreate-skps
0783aca7ba Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I230a280cebae3a3ca239e3170dcd5d9ed8a80fd5
Reviewed-on: https://skia-review.googlesource.com/c/189501
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-05 05:57:54 +00:00
skia-recreate-skps
50fe557b55 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2b023f93e36f1317890d8d16ffe2a112c1babb0b
Reviewed-on: https://skia-review.googlesource.com/c/189125
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-04 06:15:43 +00:00
Robert Phillips
b45f47dc3e Add isTextureable parameter to GrContextThreadSafeProxy::createCharacterization (take 2) 
TBR=bsalomon@google.com
Change-Id: Iee9d64dd39d5f3269428822582b754c4981812d7
Reviewed-on: https://skia-review.googlesource.com/c/188825
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
 2019-02-03 23:06:13 +00:00
skia-recreate-skps
71e434dc9d Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I14463c1cdfca3777f4abebaf72b4641bca369b5c
Reviewed-on: https://skia-review.googlesource.com/c/188655
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-03 09:13:52 +00:00
skia-recreate-skps
d6a45a8aee Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3899d8f52160772130bc6a15586d49aa3650e509
Reviewed-on: https://skia-review.googlesource.com/c/189021
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-02 06:31:11 +00:00
Kevin Lubick
9a2bb09202 CMake: distinguish between file and dir copies by presence of '.' in src path 
ANGLE's build requires a file copy. Nema's build requires a dir copy. CMake
uses a different command for each. gn does not distinguish which. We make
a guess that happens to work for these two use cases based on the whether
the base file name of the src contains a '.'


Change-Id: I3503fd9d632abda3f8f952d0eef964019d932bea
Reviewed-on: https://skia-review.googlesource.com/c/188626
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
 2019-02-01 18:58:46 +00:00
skia-recreate-skps
0ac0413a6e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I109a1b4c10a1dc42b821a492ba9ea5136c27b09f
Reviewed-on: https://skia-review.googlesource.com/c/188546
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-02-01 06:08:53 +00:00
Kevin Lubick
3105238ed5 Add CMake bot 
It uses a docker container to handle the installation of CMake.

Depends on https://skia-review.googlesource.com/c/skia/+/188305/

Bug: skia:8732
Change-Id: Ib84a46b4f0ca7f88fca4e6123c1517a84f3444b2
Reviewed-on: https://skia-review.googlesource.com/c/188036
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
 2019-01-31 22:05:22 +00:00
Brian Salomon
6f59443c9c Update Metal unit test blacklist after adding new promise image tests 
Bug: skia:8736
TBR: robertphillips@google.com

Change-Id: I13b49909d62b0f4c685ded3345e9e9cd35363554
Reviewed-on: https://skia-review.googlesource.com/c/188304
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-01-31 17:20:22 +00:00
skia-recreate-skps
0b0731e91c Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I9d210bcd2f730ed8cbdde5a5fb2058116e600de3
Reviewed-on: https://skia-review.googlesource.com/c/188240
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-31 06:09:11 +00:00
Ben Wagner
95cbd06b9e Update Linux Vulkan SDK to 1.1.97.0 
Rewrite asset creation script to be automated. Replace
create_and_upload.py with the universal version.

Change-Id: I5a4c54281e9476b0d48b35c4e706c1d52c56ca4d
Reviewed-on: https://skia-review.googlesource.com/c/187384
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
 2019-01-30 14:29:21 +00:00
Ben Wagner
71e0197a3c [infra] Increase post-ASAN-setup sleep time. 
Pixels are still failing after ASAN setup, e.g.:
https://chromium-swarm.appspot.com/task?id=42b050e90e06a210
https://chromium-swarm.appspot.com/task?id=42b054a2d05dec10

Change-Id: Ife04b894ad01de69fa4639e97eba578f058cad0c
Reviewed-on: https://skia-review.googlesource.com/c/187788
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
 2019-01-29 17:59:58 +00:00
skia-recreate-skps
a09731e5cf Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8e8801d5d5655a100eadc9fcf2f487eaa2f17c98
Reviewed-on: https://skia-review.googlesource.com/c/187722
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-29 12:45:57 +00:00
skia-recreate-skps
7f54fdc434 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Id6a4e676ac4762150d9af63819633431e42b1dd8
Reviewed-on: https://skia-review.googlesource.com/c/187222
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-28 13:41:06 +00:00
skia-recreate-skps
27e5125dbc Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I7106c1bcfceeb4a8822208aa075b097836eb74ac
Reviewed-on: https://skia-review.googlesource.com/c/187221
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-27 09:12:39 +00:00
skia-recreate-skps
02edccb024 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I64af3d56a0ba74842d60d40f786b55f60ca13f51
Reviewed-on: https://skia-review.googlesource.com/c/187220
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-27 06:06:14 +00:00
skia-recreate-skps
d3a6a8162c Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2902d84ee182a38bf04f7e97a6873b93dae1f9ec
Reviewed-on: https://skia-review.googlesource.com/c/187180
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-26 06:06:26 +00:00
Eric Boren
d41c1876d8 Add chromium_revision tag to SKP CIPD package 
Bug: skia:8680
Change-Id: Ic84f33bc9c864005369e94a9d0039f92eb1bc17d
Reviewed-on: https://skia-review.googlesource.com/c/184922
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
 2019-01-25 17:30:27 +00:00
Brian Salomon
9bc76d96f9 Change the meaning of GrBudgetedType::kUnbudgetedUncacheable. 
kUnbudgetedCacheable now means that the resource is never purged
until its unique key is removed.

This fixes an issue where a cached texture for a promise image
might get purged by cache pressure. This in turn could cause
Skia to call the promise image's Fulfill proc multiple times with
no intervening Release calls. The balancing Release calls would
occur, but the policy is that each Fulfill should be balanced by
Release *before* another Fulfill.

Update/add unit tests.

Bug: chromium:922851
Change-Id: I6411e413b3104721ca4bb6e7f07b3b73d14cbcf9
Reviewed-on: https://skia-review.googlesource.com/c/186361
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
 2019-01-25 14:13:00 +00:00
skia-recreate-skps
74b6cf3a72 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I0dc22ed3a236b26f97244539a6e93630796a2bf1
Reviewed-on: https://skia-review.googlesource.com/c/186960
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-25 06:09:55 +00:00
skia-recreate-skps
094ab18b45 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic8e6f66e9ab26dbf14b795f377e49d08ecf811b5
Reviewed-on: https://skia-review.googlesource.com/c/186463
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-24 06:11:59 +00:00
skia-recreate-skps
a6ab2bdd8c Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Iebb47ff028aad784eeef8b0f5897cf30a4a8bc49
Reviewed-on: https://skia-review.googlesource.com/c/186460
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-24 02:59:45 +00:00
Ben Wagner
325778b888 Update android-skqp Docker image to accept licenses 
Set DOCKER_CONFIG env var for all docker commands so that the Swarming
task uses the config created here:
https://skia.googlesource.com/buildbot/+/06aaf21b5d91a68de7c02aafc0fdee8531ba0c21/scripts/run_on_swarming_bots/install_docker.py#65

Bug: skia:8698
Change-Id: I731a99abc274caa498af8dde5142a7e6a6b6eca3
Reviewed-on: https://skia-review.googlesource.com/c/185690
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
 2019-01-22 23:34:58 +00:00
skia-recreate-skps
ebc22e0030 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icb2ba63298a6aba9c1a21316361be008fd278a2f
Reviewed-on: https://skia-review.googlesource.com/c/185760
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-22 14:42:33 +00:00
skia-recreate-skps
7d81f6fd6f Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I18210c0ee1197f6f13d57e4ec88182416829fab5
Reviewed-on: https://skia-review.googlesource.com/c/185527
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-20 06:13:07 +00:00
skia-recreate-skps
60bff2366e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I01c519d96576d14d32c23af249cf5442579d30b2
Reviewed-on: https://skia-review.googlesource.com/c/185421
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-19 06:10:02 +00:00
Ben Wagner
5c7a3ac0e2 [infra] Update Win2016 image 
Change-Id: I3edaae31995991a5cf7a67927594714136ad49c7
Reviewed-on: https://skia-review.googlesource.com/c/184923
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-18 21:44:35 +00:00
Ben Wagner
64b894b98c Try a workaround for the Pixel ASAN push failure 
There have been many recent instances where ASAN tasks running on Pixel
devices have failed to push resources to the device due to
"secure_mkdirs failed: No such file or directory." The theory is that
because the "Setting up device to run ASAN" step reboots the device, the
device isn't actually ready at the time it reports being ready. This CL
adds a sleep to the ASAN setup to work around this problem.

Here are recent examples of this failure:
https://chromium-swarm.appspot.com/task?id=4279aeb78961de10
https://chromium-swarm.appspot.com/task?id=42765d9f44ca4610
https://chromium-swarm.appspot.com/task?id=427a66499846e910
https://chromium-swarm.appspot.com/task?id=4276d85a8f270d10
https://chromium-swarm.appspot.com/task?id=42765cb3ff062a10

Change-Id: Iddf78622de3cd88ea28a532380762baafe479eb7
Reviewed-on: https://skia-review.googlesource.com/c/185320
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-18 19:58:11 +00:00
skia-recreate-skps
b84f90df6f Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I84b5d377daaf9e8b7d34479abae818c763bb8cd4
Reviewed-on: https://skia-review.googlesource.com/c/185100
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-18 06:16:18 +00:00
skia-recreate-skps
33b4b4908b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I1a040f136065e0afd104259e2c6c667a17e3b2b4
Reviewed-on: https://skia-review.googlesource.com/c/184651
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-17 06:11:57 +00:00
Brian Salomon
157997696b Exclude PromiseImageTextureReuseDifferentConfig from Metal bots 
TBR=robertphillips@google.com

Change-Id: I4729364745cfe216423948df4a9f209a8d987059
Reviewed-on: https://skia-review.googlesource.com/c/184740
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-01-17 02:02:30 +00:00
recipe-roller
1ce80fb351 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ed32454c59ca7ba6d05f313f32f75c1b8157d66e Remove unused features of package.proto. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id8ca0286d4d3fde0d6126cdab3fde9974795f53f
Reviewed-on: https://skia-review.googlesource.com/c/184620
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 2019-01-16 23:42:16 +00:00
skia-recreate-skps
a8694cc150 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic63d5d3e3cb8fb2b6984603965d0d25f704243a5
Reviewed-on: https://skia-review.googlesource.com/c/184320
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-16 06:10:54 +00:00
skia-recreate-skps
d5fcf4d83c Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1966d643fe34a336fb892a11b85b16629615aa8b
Reviewed-on: https://skia-review.googlesource.com/c/184266
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-16 02:24:32 +00:00
Eric Boren
69d199cf6a [infra] Update upstream CIPD dependencies, roll recipes 
Bug: skia:
Change-Id: I232223c785ce28a8d1548c94ae6618ebafe0a739
Reviewed-on: https://skia-review.googlesource.com/c/184183
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2019-01-15 20:18:04 +00:00
Mike Klein
98dea7b11c remove superfluous skia_vulkan_sdk 
We don't actually need the SDK to build anymore.

If you previously set skia_vulkan_sdk or relied on VULKAN_SDK
in the environment, now set skia_use_vulkan = true instead.

We still need the linux_vulkan_sdk asset for Test/Perf bots.

Change-Id: I70ad9c5181ae61725b9dc25cc887dd0640beeed6
Reviewed-on: https://skia-review.googlesource.com/c/184065
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
 2019-01-15 18:53:02 +00:00
skia-recreate-skps
1b45db6642 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3635d243a05acbe1e701eb24c5d0cb628ef79aba
Reviewed-on: https://skia-review.googlesource.com/c/184044
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-15 06:16:08 +00:00
skia-recreate-skps
33f58abef2 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I17500ccde234c7a7596464133f29d8ad28c92bde
Reviewed-on: https://skia-review.googlesource.com/c/183640
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-14 06:13:52 +00:00
skia-recreate-skps
60a2f675dd Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Id0476324a5aeb6e11e5650c730a2ea19cb96ae09
Reviewed-on: https://skia-review.googlesource.com/c/183604
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-13 12:12:03 +00:00
skia-recreate-skps
3395f00ef6 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic1014204975ebc264bee4c43a4b7e98be3cd382a
Reviewed-on: https://skia-review.googlesource.com/c/183600
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-13 06:15:37 +00:00
skia-recreate-skps
45eec068b9 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2d1de2bcfe6d6aa7ae610bffdb6a1e8607d77126
Reviewed-on: https://skia-review.googlesource.com/c/183376
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-12 09:23:18 +00:00
Ben Wagner
59fceb2f2f Omit another gm for IntelIris655 vk. 
Several tasks timed out while running tilemodes:
https://chromium-swarm.appspot.com/task?id=4233ae843798d510
https://chromium-swarm.appspot.com/task?id=424ee573d7db8810
https://chromium-swarm.appspot.com/task?id=4250ab11f112bb10

Bug: skia:8659
Change-Id: Ic2e968c842c1c9cd27150ea06c96d303d7fb6d78
Reviewed-on: https://skia-review.googlesource.com/c/182964
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
 2019-01-11 15:51:59 +00:00
skia-recreate-skps
cb42fc0dc5 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4629381e0ceacf6bb650aff1972641d1989e7084
Reviewed-on: https://skia-review.googlesource.com/c/183167
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-11 06:15:51 +00:00
Brian Salomon
cdd8a0a0e8 Revert "Revert "Reuse GrTexture instances when the same GrBackendTexture is used to"" 
This reverts commit 426ba463d5.

Bug: skia:8613
Change-Id: Iacaf40549369110aa95015e8d4579ec41db22d13
Reviewed-on: https://skia-review.googlesource.com/c/182963
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-01-10 17:51:21 +00:00
Brian Salomon
426ba463d5 Revert "Reuse GrTexture instances when the same GrBackendTexture is used to" 
This reverts commit 559c617137.

Reason for revert: breaking things

Original change's description:
> Reuse GrTexture instances when the same GrBackendTexture is used to
> repeatedly fulfill a promise SkImage.
> 
> Bug: skia:8613
> 
> Change-Id: I35c76435d630d2daa034e0c3efb59666bfd6882a
> Reviewed-on: https://skia-review.googlesource.com/c/175820
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I7548809945d0a875fdb9387398bbc45e733c0846
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8613
Reviewed-on: https://skia-review.googlesource.com/c/182960
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-01-10 16:33:11 +00:00
Brian Salomon
559c617137 Reuse GrTexture instances when the same GrBackendTexture is used to 
repeatedly fulfill a promise SkImage.

Bug: skia:8613

Change-Id: I35c76435d630d2daa034e0c3efb59666bfd6882a
Reviewed-on: https://skia-review.googlesource.com/c/175820
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
 2019-01-10 16:10:59 +00:00
Eric Boren
ccb0a307c1 Update upstream CIPD packages 
Bug: skia:
Change-Id: I51834b34b0ebb00c1b6f6b8797a14237a4814856
Reviewed-on: https://skia-review.googlesource.com/c/182812
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2019-01-10 14:01:32 +00:00
skia-recreate-skps
ab45886f64 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie62f86939027ba57861a3477a85ae471dbfde5b7
Reviewed-on: https://skia-review.googlesource.com/c/182860
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-10 06:17:23 +00:00
skia-recreate-skps
c0321a8461 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib0178f9cf1695d479406aa86a469f8fc58ba51e2
Reviewed-on: https://skia-review.googlesource.com/c/182420
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-09 06:10:58 +00:00
Ben Wagner
78c16efa76 Add Ubuntu18 jobs. 
Ubuntu18 will now run all jobs currently on Ubuntu17 except Valgrind.

Change-Id: Icfdf798d43917beed0bfa1c96763d5b8ff6eb7c9
Reviewed-on: https://skia-review.googlesource.com/c/182200
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
 2019-01-08 19:11:29 +00:00
skia-recreate-skps
b20e68e2a9 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I9d1657a5f936cdaaa89bab28029c42ded20d2bed
Reviewed-on: https://skia-review.googlesource.com/c/182100
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-08 06:21:56 +00:00
Brian Salomon
8f40b66afb Run ddl2-vk and ddl2-gl on bots 
Change-Id: Id5807bbabe1f9bd762d93f6eb569c0610441bdc5
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/179881
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2019-01-07 15:39:28 +00:00
skia-recreate-skps
a47eb45536 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If9f516119308a8ea348816062e242aae16c61fa4
Reviewed-on: https://skia-review.googlesource.com/c/181538
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-07 05:52:34 +00:00
skia-recreate-skps
41a5eaca8b Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I27cd43ca0046d17ff2ce2fea63e1bbce32d363a6
Reviewed-on: https://skia-review.googlesource.com/c/181522
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-06 08:45:53 +00:00
skia-recreate-skps
d6f349750b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I411eae202cdcdc7864ae5d8fac3bc22293d6fdc7
Reviewed-on: https://skia-review.googlesource.com/c/181497
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-06 06:06:27 +00:00
skia-recreate-skps
125f767901 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If62d676668794c528b2ad98da3d71ad6e8922f52
Reviewed-on: https://skia-review.googlesource.com/c/181458
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-05 06:15:23 +00:00
Ben Wagner
b73cb3f98e Add IntelIris655 Win10 jobs. 
Bug: skia:8587, skia:8659
Change-Id: I6dfe3635db264fc46d23daf662a87b98ed07066f
Reviewed-on: https://skia-review.googlesource.com/c/173082
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
 2019-01-04 21:24:59 +00:00
Ben Wagner
1cefc0990d Reland "Remove win_vulkan_sdk." 
This reverts commit 532c05fec1.

Reason for revert: Fixed by https://skia-review.googlesource.com/c/skia/+/181163

Original change's description:
> Revert "Remove win_vulkan_sdk."
>
> This reverts commit 876dc81f2a.
>
> Reason for revert: Breaking everything
>
> Original change's description:
> > Remove win_vulkan_sdk.
> >
> > We only needed this for the Vulkan headers, which we now have in
> > src/third_party.
> >
> > Change-Id: I453ed73c73b3304520b628527102607d848bcd37
> > Reviewed-on: https://skia-review.googlesource.com/c/180775
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,benjaminwagner@google.com
>
> Change-Id: I0ae35fddfc112631a47db9775d790f999abf26f8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/180779
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=egdaniel@google.com,benjaminwagner@google.com

Change-Id: I11a96646cd8f5d9ba9b617243ad4375c6037dbb8
Reviewed-on: https://skia-review.googlesource.com/c/181173
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2019-01-04 17:07:27 +00:00
Greg Daniel
7d06735443 Set skia_use_vulkan on our vulkan bots. 
Bug: skia:
Change-Id: Ia7cdab1223ae3eb788e46e2cc4af552b03a2065f
Reviewed-on: https://skia-review.googlesource.com/c/181163
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2019-01-04 15:49:09 +00:00
skia-recreate-skps
c519fed6dd Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I0ac8051e6ea6caf6471b553b0d2ee7214eec9da2
Reviewed-on: https://skia-review.googlesource.com/c/181184
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-04 05:55:54 +00:00
Ben Wagner
532c05fec1 Revert "Remove win_vulkan_sdk." 
This reverts commit 876dc81f2a.

Reason for revert: Breaking everything

Original change's description:
> Remove win_vulkan_sdk.
> 
> We only needed this for the Vulkan headers, which we now have in
> src/third_party.
> 
> Change-Id: I453ed73c73b3304520b628527102607d848bcd37
> Reviewed-on: https://skia-review.googlesource.com/c/180775
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,benjaminwagner@google.com

Change-Id: I0ae35fddfc112631a47db9775d790f999abf26f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/180779
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-03 22:32:07 +00:00
Ben Wagner
b62fc90706 [infra] Upgrade Win10 in Skolo. 
Change-Id: I686629f5ad5278d7965e634e169b555f0c2b15c9
Reviewed-on: https://skia-review.googlesource.com/c/179731
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-03 22:30:06 +00:00
Ben Wagner
876dc81f2a Remove win_vulkan_sdk. 
We only needed this for the Vulkan headers, which we now have in
src/third_party.

Change-Id: I453ed73c73b3304520b628527102607d848bcd37
Reviewed-on: https://skia-review.googlesource.com/c/180775
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
 2019-01-03 21:51:25 +00:00
skia-recreate-skps
aae6ae39a3 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I0d036fe150ba50eee9d21b4c0679ef977a6f08e4
Reviewed-on: https://skia-review.googlesource.com/c/180862
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-03 06:08:20 +00:00
Ben Wagner
2e342cd52c [infra] Uninstall ASAN when cleaning up Android device. 
Change-Id: I417f87aefe3c5684366d05703f1065c6e7c77ea0
Reviewed-on: https://skia-review.googlesource.com/c/180379
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-02 20:49:23 +00:00
Kevin Lubick
40654f2ee0 Add docker caches in more places 
Bug: skia:
Change-Id: I15c78a1b8f5c4b90f9ca80e7827b66d1f5a7c797
Reviewed-on: https://skia-review.googlesource.com/c/180369
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2019-01-02 15:29:56 +00:00
skia-recreate-skps
f6e3983d9b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia00e0f1bc26f824df1b6866dd7f8b8c66d520f90
Reviewed-on: https://skia-review.googlesource.com/c/180446
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-02 05:56:49 +00:00
skia-recreate-skps
4f050fb819 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I5ef59e7ac4ee5f2d2424ff93291a9fd3bb656c9f
Reviewed-on: https://skia-review.googlesource.com/c/180445
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2019-01-01 06:09:30 +00:00
skia-recreate-skps
61b3d1d000 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic04683519a576e2c65b7ca9fc3804a0cdc12776c
Reviewed-on: https://skia-review.googlesource.com/c/180443
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-31 06:11:57 +00:00
skia-recreate-skps
197b1f7900 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I596039d46d9bcf267400e46ec7a7dffe0451b40b
Reviewed-on: https://skia-review.googlesource.com/c/180442
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-30 08:18:20 +00:00
skia-recreate-skps
db929efc32 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3ecf4924a446252933af4fe90ca50e1347623827
Reviewed-on: https://skia-review.googlesource.com/c/180441
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-30 06:08:54 +00:00
skia-recreate-skps
3dc21675b0 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If1665ee3e7bec336756d7f7f282fb0bae9cf8961
Reviewed-on: https://skia-review.googlesource.com/c/180440
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-29 06:09:02 +00:00
skia-recreate-skps
3e7ba8fa7e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib8031ddc598dcc1f006c941f944a91e8dc85e366
Reviewed-on: https://skia-review.googlesource.com/c/180240
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-28 05:52:50 +00:00
skia-recreate-skps
31c1bf8965 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2ae794de58e0dd700bfab8a4fb1ebec2b9a56a82
Reviewed-on: https://skia-review.googlesource.com/c/180050
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-27 06:12:37 +00:00
skia-recreate-skps
3605fde88b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ifcdae9df9635e9df35c9f94e9dc767c0bf5a840f
Reviewed-on: https://skia-review.googlesource.com/c/180046
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-26 05:51:08 +00:00
skia-recreate-skps
2772ea397e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I9a5a04e2e0745269f77ee9426eaee6d47abba905
Reviewed-on: https://skia-review.googlesource.com/c/180045
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-25 06:11:57 +00:00
skia-recreate-skps
481dd46cc3 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I64e76db7d42bc7c41a23bf86505aaba2823c3dff
Reviewed-on: https://skia-review.googlesource.com/c/180043
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-24 06:05:59 +00:00
skia-recreate-skps
f16825ed3c Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I99120ae453f64dca88b0ea0e28962167cdb4170e
Reviewed-on: https://skia-review.googlesource.com/c/180042
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-23 08:21:57 +00:00
skia-recreate-skps
ddf145b762 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I5e02c273e25ddc6fed546d96a266a6d8d132aab5
Reviewed-on: https://skia-review.googlesource.com/c/180041
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-23 06:04:26 +00:00
skia-recreate-skps
c983480b11 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I5c34a86bb490b3db7af541c3619bd002e0269d11
Reviewed-on: https://skia-review.googlesource.com/c/180040
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-22 06:12:38 +00:00
skia-recreate-skps
b9c2b6663d Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4b5c539c401db7d4751e602a65f5bff0d7b6c1a7
Reviewed-on: https://skia-review.googlesource.com/c/179781
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-21 05:52:51 +00:00
skia-recreate-skps
2bcad71cc8 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I509ed3ed6c3023df16958acf1f8744e285039f34
Reviewed-on: https://skia-review.googlesource.com/c/179370
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-20 06:04:01 +00:00
Ben Wagner
bb7d3813d3 [infra] Set GOCACHE in tasks that use go. 
Bug: skia:8423
Change-Id: If079c958cb9d0d82fe13da44aaebd5913b40b9d1
Reviewed-on: https://skia-review.googlesource.com/c/179065
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2018-12-19 15:09:59 +00:00
Ben Wagner
435880277e [infra] Use go_deps asset for Bookmaker tasks 
Fix PATH to point to go_deps/bin.

Bug: skia:8423
Change-Id: I853a0741238442e7fd5b3c23cacb3d2f9c6893fa
Reviewed-on: https://skia-review.googlesource.com/c/179064
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
 2018-12-19 14:41:32 +00:00
Ben Wagner
c59caa4060 Remove Go asset from tasks that don't need it. 
Bug: skia:8423
Change-Id: I4827e0f261cb300a0699cbf590bac8786a5c36a1
Reviewed-on: https://skia-review.googlesource.com/c/179062
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2018-12-19 13:34:11 +00:00
Ben Wagner
1a237195b5 Omit SKP that might cause MacBook10.1 to die. 
Bug: skia:8643
Change-Id: I491b67680eae4ee400cadb9afebaab4f9a9def9e
Reviewed-on: https://skia-review.googlesource.com/c/179061
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
 2018-12-19 12:36:38 +00:00
skia-recreate-skps
192d664409 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I7bbcfef8ca526830a5222ef33dc4e63c5cfad073
Reviewed-on: https://skia-review.googlesource.com/c/179120
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-19 05:48:35 +00:00
skia-recreate-skps
79c3decf0c Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Idd59c93ead22abc8d19e980a1a9b1275a88c1fd7
Reviewed-on: https://skia-review.googlesource.com/c/178800
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-18 06:12:12 +00:00
Mike Klein
fe64e00997 bump NDK packages to r19-beta2 
Originally this started as a bump to r18, the latest stable release.
That's why each packages goes up two versions, from r17 -> r18 ->
r19-beta2.

But our ASAN bots started failing with r18, and despite quite a bit of
investigating, I've been unable to find anything wrong with our code.

Luckily, r19 is coming soon, and it looks like its beta2 works fine.
I think we should just skip r18.

Original change's description:
> bump NDK packages to r18
>
> Newer Clang, GCC is gone.
>
> Clang now supports half-float math on ARMv8, which is pretty neat.
>
> They've dropped support for everything below NDK version 16,
> which happens to be what we target for 32-bit ARM.
>
> Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
> Reviewed-on: https://skia-review.googlesource.com/157260
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Cq-Include-Trybots: skia.primary:Test-Android-Clang-Pixel-CPU-Snapdragon821-arm64-Release-All-Android_ASAN
Change-Id: I0736558fc9b732113854b1b295642e1708b04581
Reviewed-on: https://skia-review.googlesource.com/c/157761
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
 2018-12-17 20:07:36 +00:00
Ben Wagner
73e2ced5f8 [infra] Do not retry xSAN and Valgrind failures 
As a side-effect, explicitly specify MaxAttempts for all "kitchen"
tasks.

Change-Id: Ia0ac825a4364952f0cda678d2cd6462a30a4912e
Reviewed-on: https://skia-review.googlesource.com/c/177883
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-17 19:48:56 +00:00
recipe-roller
32def82f12 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/143872d11b6f4faa095be0f8c2615bd681eb485b Update git recipes to use buildbucket API. (jsca@google.com)
recipe_engine:
  https://crrev.com/5e53d73e9bcec42830e10b835bc328eb75c9423f [path] Use 'cleanup' dir in mkdtemp and mkstemp (sergeyberezin@google.com)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9e038e4eedad70f1d4133c98c591a09459823a84
Reviewed-on: https://skia-review.googlesource.com/c/177077
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-17 12:46:15 +00:00
skia-recreate-skps
18f71ab037 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3825374002bc4b14e90df0c7776d59c9a7c246b6
Reviewed-on: https://skia-review.googlesource.com/c/178025
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-17 06:01:20 +00:00
Ravi Mistry
a067690acf Revert "[infra] Flutter bot should sync to origin/skia-master" 
This reverts commit 8061053b73.

Reason for revert: skia-master branch no longer exists

Original change's description:
> [infra] Flutter bot should sync to origin/skia-master
> 
> Bug: skia:
> Change-Id: I223bef522ff8605674f4ecabcbd0624cfc92cb06
> Reviewed-on: https://skia-review.googlesource.com/c/173224
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I3a40a0c6f4a354650d354f2eb4f9d20defe70a0a
Reviewed-on: https://skia-review.googlesource.com/c/178023
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2018-12-16 22:09:11 +00:00
skia-recreate-skps
e6f635476d Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ied237476748416db5c24a0e81507b35901f3b7cc
Reviewed-on: https://skia-review.googlesource.com/c/178022
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-16 08:19:11 +00:00
skia-recreate-skps
cb8157e626 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6b17baf024cfe8cbe608f0660bbda0bf5d7a70e9
Reviewed-on: https://skia-review.googlesource.com/c/178020
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-16 06:04:11 +00:00
skia-recreate-skps
8b78d70b9a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic6568aee66cd573ceb2184f9b54540cecc0aa7ae
Reviewed-on: https://skia-review.googlesource.com/c/177980
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-15 05:49:11 +00:00
skia-recreate-skps
e45a83d7ab Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia0f5808cc0ff0a1cdc817381b1f8d086e5e8cf35
Reviewed-on: https://skia-review.googlesource.com/c/177740
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-14 06:03:14 +00:00
Greg Daniel
561b872e1f Add blacklist for vulkan intel 405. 
Bug: skia:7322
Change-Id: I1a5139f44d9aa9e0aab3faf53643350cbb765045
Reviewed-on: https://skia-review.googlesource.com/c/177500
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
 2018-12-13 18:40:55 +00:00
skia-recreate-skps
5f47971ca8 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib9f48333c9a62c99e4a694f9624cd90733f6a009
Reviewed-on: https://skia-review.googlesource.com/c/177175
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-13 06:14:44 +00:00
Kevin Lubick
8243988e01 Blacklist 'deprecated' color test 
Bug: skia:8470
Change-Id: I53b24372da689e860a880fd84d0fecf6b6517c0a
Reviewed-on: https://skia-review.googlesource.com/c/177070
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-12 20:50:30 +00:00
Brian Osman
f31f64ef2d Add Windows MSVC arm64 builders 
Bug: skia:8569
Change-Id: I0d2e54191f4ad0a2cc7c22f6740fe0f81ca359a8
Reviewed-on: https://skia-review.googlesource.com/c/177064
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2018-12-12 19:52:09 +00:00
Brian Osman
ef3d04e796 Use descriptive path name for win_toolchain on the bots 
Also includes an update of the go_deps asset from
https://skia-review.googlesource.com/c/skia/+/176996

Bug: skia:
Change-Id: I3b7abf746793d6a4883e1703d705847cadfe97e9
Reviewed-on: https://skia-review.googlesource.com/c/176973
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-12 19:03:08 +00:00
Kevin Lubick
001d1bafb3 Update expectations for internal bot 
May be fixed in https://skia-review.googlesource.com/c/internal_test/+/177023

Bug: skia:8470
Change-Id: I4eef92a0109ce215acab84ef80aa52a0d191ccef
Reviewed-on: https://skia-review.googlesource.com/c/177024
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-12 17:50:20 +00:00
Mike Klein
8a0d0460e6 add -Tidy bot 
Change-Id: Ia8d942735cdd1c52a78be02b53f532433abacbc4
Reviewed-on: https://skia-review.googlesource.com/c/176977
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
 2018-12-12 17:13:10 +00:00
Mike Klein
bdc011dc9b add clang-tools-extra to clang_linux 
This should get us clang-tidy, among other tools.

Change-Id: If58aa059eea025b46e43a3178f25a90120678c2c
Reviewed-on: https://skia-review.googlesource.com/c/176972
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
 2018-12-12 16:47:39 +00:00
Brian Osman
044044f5a2 Update win_toolchain, and refactor how it's built 
The old win_toolchain script required a Chromium checkout, and
extracted portions of the win_toolchain from that to build the
Skia asset. Instead, use the depot_tools script that assembles
a toolchain from a locally installed MSVC.

The create script doesn't do that, but relies on the user to
run that script first. Automating everything would be a nice
follow-up.

With the new strategy, the toolchain directory is simpler, and
no longer contains the depot_tools kruft or extra directories.
Adjust the bot scripts accordingly. (Renaming the directory to
win_toolchain from 't' would be a nice touch, too).

Finally, I built the new toolchain with the updated process,
and included the ARM64 compiler and libraries, so we can set
up a bot to build Windows ARM64.

Docs-Preview: https://skia.org/?cl=176968
Bug: skia:8569
Change-Id: I4bdf3cfb29d50f4464853445d0226241e70c33b4
Reviewed-on: https://skia-review.googlesource.com/c/176968
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2018-12-12 15:50:16 +00:00
skia-recreate-skps
8a193dc7e2 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3b66a05b557505e95d18094a03f3410f0542058f
Reviewed-on: https://skia-review.googlesource.com/c/176840
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-12 06:02:22 +00:00
Michael Ludwig
7bd58d96f9 Add additional test to blacklist for 405 
Bug: skia:7322
Change-Id: If51e9b3cf253bc357ecc102b2e244b589d02ab12
Reviewed-on: https://skia-review.googlesource.com/c/176591
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
 2018-12-11 22:22:06 +00:00
Michael Ludwig
ea83fcbd18 Update 405 vk blacklist 
Bug: skia: 7322
Change-Id: If4dcb5400a9e8bc0a9a98a95b79d79650fd28d20
Reviewed-on: https://skia-review.googlesource.com/c/176586
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
 2018-12-11 19:13:54 +00:00
skia-recreate-skps
264843e307 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4825167b1e33a08b7a27524187c1c6f3a1f7aaf1
Reviewed-on: https://skia-review.googlesource.com/c/176341
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-11 06:14:43 +00:00
Mike Klein
926a91b595 roll clang_win 
No particular reason.  Was just poking around
in here and figured we might as well roll.

Change-Id: Ib161a4b94cb4f272573047e4bd4fd8b59cee79e4
Reviewed-on: https://skia-review.googlesource.com/c/175985
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
 2018-12-10 15:49:23 +00:00
Robert Iannucci
e1c2354d08 [recipes] Manually roll recipes 
This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

  https://crrev.com/095f4b84e4c62983829973f51f0c46f95022806a

R=borenet@google.com, rmistry@google.com

Bug: chromium:913102
Change-Id: Ic6405fbe5ebd00e453677c5050d089e678153d00
Reviewed-on: https://skia-review.googlesource.com/c/175813
Auto-Submit: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2018-12-10 12:54:53 +00:00
skia-recreate-skps
1a592c2a3d Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Iadd0efab2e11e4c2fc7e6f5bc87a2ab5f86a85d9
Reviewed-on: https://skia-review.googlesource.com/c/175926
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-09 08:44:48 +00:00
skia-recreate-skps
27d5e81234 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic1bb633ef58987c53d1e23dddb6fbe9cee5414cd
Reviewed-on: https://skia-review.googlesource.com/c/175923
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-09 06:02:19 +00:00
skia-recreate-skps
2d8789ded9 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icf0d50ef95144af2449600731fc76e0f1f07a6f5
Reviewed-on: https://skia-review.googlesource.com/c/175817
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-08 06:10:42 +00:00
Ravi Mistry
4f76db1534 [Android compile bot] Fix path to GS file name 
Bug: skia:8388
Change-Id: Ifb9654439abf252c6e466d568329b151a4915e3f
Reviewed-on: https://skia-review.googlesource.com/c/175588
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2018-12-07 18:02:12 +00:00
skia-recreate-skps
bba465b982 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Iecdc3bcfd6d63cb2e173d67da69a55f2b281f82c
Reviewed-on: https://skia-review.googlesource.com/c/175494
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-07 06:10:06 +00:00
Brian Osman
23885d2133 Add glenarrow to GPU BonusConfigs bots 
This tests F16 surfaces, and F16 vertex colors (because the sRGB paint
colors used in GMs are often outside the narrow gamut).

Bug: skia:
Change-Id: Ic11840df0c9919a6cca78ab3786ba7a11e879a07
Reviewed-on: https://skia-review.googlesource.com/c/175245
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2018-12-06 15:22:11 +00:00
skia-recreate-skps
7c4a9b7c7e Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib1152d1b1146dab23d72af5728ed33a32195011a
Reviewed-on: https://skia-review.googlesource.com/c/175180
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-06 06:01:41 +00:00
skia-recreate-skps
ef211e600c Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6723b01caa75b96358281ecf4f525793b46fdc93
Reviewed-on: https://skia-review.googlesource.com/c/174470
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-05 05:50:06 +00:00
recipe-roller
d5cf51da90 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/793d8faa696f62fa2c774b8c854bbf4d64dff24e Separate InfraFailure behavior from StepFailure behavior. (jchinlee@chromium.org)


R=jcgregorio@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I324b1d8b7a0d4c0fb8bc4c059a34b3e75ccbd8fd
Reviewed-on: https://skia-review.googlesource.com/c/173434
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-12-04 21:43:35 +00:00
Ben Wagner
a2785cc94c [infra] Upgrade Windows in Skolo 
Change-Id: Ifec8a600c645833e55d8b7bbd58181ad541fc8d8
Reviewed-on: https://skia-review.googlesource.com/c/174069
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-12-04 18:59:13 +00:00
skia-recreate-skps
5021cd6531 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie7ef406eb70632243d053ed470daae3325fab08a
Reviewed-on: https://skia-review.googlesource.com/c/174161
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-04 05:59:39 +00:00
Ben Wagner
7b069fa73e Upgrade Win10 Intel Skylake GPU driver. 
Affects IntelIris540.

Change-Id: I1b846cfac90227c250109ef7a7190e3a674211e0
Reviewed-on: https://skia-review.googlesource.com/c/173992
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-12-03 22:47:39 +00:00
skia-recreate-skps
ec95ac2955 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I460b45937d64a856d6f84faf45f7080f8959163f
Reviewed-on: https://skia-review.googlesource.com/c/173843
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-03 06:04:02 +00:00
skia-recreate-skps
683e649249 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I4c75b6badc6ce1a0023f7831d6b9c61c42d39607
Reviewed-on: https://skia-review.googlesource.com/c/173842
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-02 08:34:41 +00:00
skia-recreate-skps
bce67cad86 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia29b6c9fe44d375570e7adf3212cb16ada399914
Reviewed-on: https://skia-review.googlesource.com/c/173840
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-02 05:59:44 +00:00
skia-recreate-skps
f31f74a250 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Id65947fc90810dbe124abbc51596565304a24454
Reviewed-on: https://skia-review.googlesource.com/c/173801
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-12-01 05:56:06 +00:00
Greg Daniel
0e5a0ef2ab Add blacklist for intel 405 vulkan perf bot. 
Bug: skia:7322
Change-Id: I46e9a1169a30b8b0ed5033c4ab9d877c43f4e59e
Reviewed-on: https://skia-review.googlesource.com/c/173643
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
 2018-11-30 16:38:31 +00:00
skia-recreate-skps
62f64b5a05 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ic72d0deea0a49e8eb03852e7f18693330cbd606a
Reviewed-on: https://skia-review.googlesource.com/c/173560
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-30 05:54:17 +00:00
Ben Wagner
9e9723137f Add jobs for GalaxyS9 
Change-Id: I039eb2050edc2570287c331a3f7743b4a3748f3e
Reviewed-on: https://skia-review.googlesource.com/c/173239
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
 2018-11-29 19:32:04 +00:00
skia-recreate-skps
a815267833 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6d92c7b54005ccf8587451a0a59dc06765d71df2
Reviewed-on: https://skia-review.googlesource.com/c/173344
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-29 05:58:01 +00:00
Eric Boren
8061053b73 [infra] Flutter bot should sync to origin/skia-master 
Bug: skia:
Change-Id: I223bef522ff8605674f4ecabcbd0624cfc92cb06
Reviewed-on: https://skia-review.googlesource.com/c/173224
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2018-11-28 17:34:05 +00:00
Eric Boren
a2e613c999 Use LUCI trybots in update_meta_config 
Bug: skia:
Change-Id: If7f9f3f4f79544484eb0fb406fea6772a9ca7722
Reviewed-on: https://skia-review.googlesource.com/c/171909
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
 2018-11-28 16:09:00 +00:00
skia-recreate-skps
600ed12666 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3053b126cf56a860c81bf1778fafcc52890e0629
Reviewed-on: https://skia-review.googlesource.com/c/173133
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-28 05:58:05 +00:00
Ravi Mistry
a23de1d5c8 [Android compile bots] Make lunch target part of the GS file name 
This is to make sure compile bots on the same change do not use the same name.

NoTry: true
Bug: skia:8560
Change-Id: I8de6a6831a84f26b62b89e2af80878b09e8ea8e4
Reviewed-on: https://skia-review.googlesource.com/c/173100
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-11-27 20:49:27 +00:00
Eric Boren
ad5f069490 [infra] Blacklist another SKP for IntelHD405 Vulkan perf bot 
Bug: skia:7322
Change-Id: I2b50478e85c42beacbe67a8c7eaf46a487cf6f86
Reviewed-on: https://skia-review.googlesource.com/c/172973
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2018-11-27 15:56:35 +00:00
skia-recreate-skps
b95780e3e6 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8e0efdf20b19b0641599be60df915cdd13de552c
Reviewed-on: https://skia-review.googlesource.com/c/173034
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-27 06:13:47 +00:00
Ravi Mistry
65523c5555 Make lunch/mmma targets configurable and add new Android compile bot 
Bug: skia:8560
Change-Id: I9287d8286a49d067c14a4cc560220c08d3c0c040
Reviewed-on: https://skia-review.googlesource.com/c/172865
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2018-11-26 18:56:39 +00:00
Eric Boren
1b70d8c857 [infra] Blacklist crashing SKP on IntelHD405 Vulkan bot 
Bug: skia:7322
Change-Id: I337653006783910f806560a78018e4a291e2869d
Reviewed-on: https://skia-review.googlesource.com/c/172862
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
 2018-11-26 17:21:12 +00:00
Brian Osman
368895b0da Remove gamut GM 
This was based on old ideas about color management. We have better
mechanisms for testing this now.

Bug: skia:
Change-Id: If59b5039f31ab0ebbdbed4205c941dd9266f67c1
Reviewed-on: https://skia-review.googlesource.com/c/172860
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
 2018-11-26 15:45:35 +00:00
skia-recreate-skps
bc97432f4f Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3139c7e3a3cac6fe880e9ee732439e9644db359c
Reviewed-on: https://skia-review.googlesource.com/c/172764
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-26 05:55:58 +00:00
skia-recreate-skps
88deeb1d92 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I0735a01d22ec61acad707630ba4b3c5c4479a1fd
Reviewed-on: https://skia-review.googlesource.com/c/172763
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-25 08:38:41 +00:00
skia-recreate-skps
7806890baf Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I861b7e5157bc6b9b41e67f86aa141fff884cd8d3
Reviewed-on: https://skia-review.googlesource.com/c/172761
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-25 05:55:06 +00:00
skia-recreate-skps
28795bac45 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I1c231eff29d5e42e1e4ace52b602863d94e6d300
Reviewed-on: https://skia-review.googlesource.com/c/172680
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-24 05:54:44 +00:00
skia-recreate-skps
9b61866c69 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I3aadf24555b7250e30b23717cc88b6f1239bcf44
Reviewed-on: https://skia-review.googlesource.com/c/172620
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-23 05:44:07 +00:00
skia-recreate-skps
c64a2ec654 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I68e4d259bc79bed7b75a0100f986e1ea95a4d103
Reviewed-on: https://skia-review.googlesource.com/c/172560
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-22 05:56:33 +00:00
Ben Wagner
95dec69511 Upgrade Windows in Skolo. 
Change-Id: Ic6613e5d922f3addd31030c28540797238451a75
Reviewed-on: https://skia-review.googlesource.com/c/172404
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-11-21 19:57:43 +00:00
skia-recreate-skps
0f995fbb48 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8df06bdd33f743f1d7b893fdc021314c088f5f41
Reviewed-on: https://skia-review.googlesource.com/c/172240
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-21 05:57:00 +00:00
skia-recreate-skps
f1b35f428a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I01c23f9843e6234ef9615b589bbd35957f5fe012
Reviewed-on: https://skia-review.googlesource.com/c/171952
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-20 05:55:35 +00:00
skia-recreate-skps
0197913213 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia0329a32a906e9b987e6eb435a44c946e8ffb490
Reviewed-on: https://skia-review.googlesource.com/c/171710
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-19 05:40:39 +00:00
skia-recreate-skps
def9bcecd9 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I2f94cd27342433495b6ebff9c5178b7c18bf7a4f
Reviewed-on: https://skia-review.googlesource.com/c/171706
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-18 08:20:36 +00:00
skia-recreate-skps
66b91e4afb Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I9ffca76764503f896eca182e7d86fd12af0241dc
Reviewed-on: https://skia-review.googlesource.com/c/171702
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-18 06:00:03 +00:00
skia-recreate-skps
cc76f16a8c Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia0e4c8aa4c08809c9d603a5ee41f592fe6817d59
Reviewed-on: https://skia-review.googlesource.com/c/171689
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-17 06:11:39 +00:00
skia-recreate-skps
c735b4f9dc Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I56fca45eb5679a3a4df30f57b510b753700593a9
Reviewed-on: https://skia-review.googlesource.com/c/171406
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-16 05:55:24 +00:00
Ben Wagner
ce7a16b318 Upgrade NVIDIA driver on Win10 QuadroP400 bots. 
Bug: 905062
Change-Id: Ib5e742003b64ad8314544605590f5b0bf09742c7
Reviewed-on: https://skia-review.googlesource.com/c/171009
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-11-15 19:30:43 +00:00
skia-recreate-skps
1315333b6b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I00eddd5c9b63c0ec023e6924a92e2dff7e1cf0b3
Reviewed-on: https://skia-review.googlesource.com/c/171205
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-15 05:53:17 +00:00
skia-recreate-skps
e347abd4f5 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2be54775127584a9f0985da135173357095d546b
Reviewed-on: https://skia-review.googlesource.com/c/170942
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-14 05:54:35 +00:00
skia-recreate-skps
13b099f898 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie4211cb0c6ce2afb2e00ae8e25de7cb7e053d0fd
Reviewed-on: https://skia-review.googlesource.com/c/170680
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-13 05:52:35 +00:00
skia-recreate-skps
33d7dca037 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I52388c9dc3720ac30eed62daa12a219e8094b717
Reviewed-on: https://skia-review.googlesource.com/c/170369
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-12 13:58:35 +00:00
skia-recreate-skps
6f182e34be Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ic05de443353590ddaacd38974cab26d43e87c5a2
Reviewed-on: https://skia-review.googlesource.com/c/170338
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2018-11-11 22:17:14 +00:00
skia-recreate-skps
c7a34cae21 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8a2a30579c2ba4dc787b5b662c2b27dd3c9ddb58
Reviewed-on: https://skia-review.googlesource.com/c/170325
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-10 05:54:53 +00:00
skia-recreate-skps
88e15bdaf5 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie2491925d168b5e8a17a1eaedc6a9043d093e965
Reviewed-on: https://skia-review.googlesource.com/c/170042
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-09 05:57:17 +00:00
Ben Wagner
a1b4306966 Update Win10 in Skolo. 
Change-Id: I5847b25fea9a470bcaa32ca21831a22c46bd5451
Reviewed-on: https://skia-review.googlesource.com/c/169980
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-11-09 03:08:56 +00:00
skia-recreate-skps
23d1f94faa Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I1c0c8becfd614b34355f6f26b9b2ef56b86db866
Reviewed-on: https://skia-review.googlesource.com/c/169582
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-08 05:56:12 +00:00
Mike Klein
66fec0e289 remove -Mini bot, enabled effects in -NoDEPS bot 
Now that we've got Flutter builds I'm not very interested in the old
-Mini bot, which was always a proxy for something like Flutter's build.

The NoDEPS bot shouldn't have to disable effects, I think.

Change-Id: I57abca5935b7da3917eb804cda10967af0a18f41
Reviewed-on: https://skia-review.googlesource.com/c/169221
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
 2018-11-07 16:59:56 +00:00
skia-recreate-skps
67f5c0ceac Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I11bb0315b4fb35ff1ddf110d76e734ceb192ee5a
Reviewed-on: https://skia-review.googlesource.com/c/169020
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-07 06:12:31 +00:00
Ben Wagner
2aa9a22fe1 Add subset of Ubuntu18 jobs. 
We currently have only one bot for these jobs, so we should treat them
as experimental for now.

Bug: 837351
Change-Id: I1ea9f1bf1635c36895eede80df6709509a85df90
Reviewed-on: https://skia-review.googlesource.com/c/168489
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2018-11-06 19:54:01 +00:00
Kevin Lubick
e70c6b13dd Update emsdk-release image 
Bug: skia:
Change-Id: I780912e1c481765d2d17d2ce66a27470ee8b4912
Reviewed-on: https://skia-review.googlesource.com/c/168483
Reviewed-by: Kevin Lubick <kjlubick@google.com>
 2018-11-06 13:21:34 +00:00
skia-recreate-skps
8042bc2e0b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If344f21f6f54fc963cc07cbd7213c1a68bbf110c
Reviewed-on: https://skia-review.googlesource.com/c/168520
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-06 06:11:46 +00:00
skia-recreate-skps
51916083e7 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I1e656df584dbbac44aa64e669270c1b8a28913c0
Reviewed-on: https://skia-review.googlesource.com/c/168144
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-05 05:57:49 +00:00
skia-recreate-skps
99485ace81 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Idf05d32b7198086318c1e104522314020155997c
Reviewed-on: https://skia-review.googlesource.com/c/168120
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-04 08:30:57 +00:00
skia-recreate-skps
2b21e88ed6 Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I66a1f1b2d540a6153bb0e9db0c70ff0382740f28
Reviewed-on: https://skia-review.googlesource.com/c/168107
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-04 05:58:27 +00:00
skia-recreate-skps
b3babd683a Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Icbb8572642198d096e7d5f88f7d57901d52bfd51
Reviewed-on: https://skia-review.googlesource.com/c/168050
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-03 06:03:15 +00:00
Ben Wagner
1a174236da [Infra] Switch to latest Win10 in Skolo. 
Change-Id: I2ff4dec21a134c29ec2ee2158a8f90aeb6500ebe
Reviewed-on: https://skia-review.googlesource.com/c/167942
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2018-11-02 21:27:48 +00:00
skia-recreate-skps
e1abea653b Update go_deps asset 
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib8b8c17e21e8899a9a41d3c733911479bc1a0666
Reviewed-on: https://skia-review.googlesource.com/c/167620
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
 2018-11-02 05:59:48 +00:00
Ben Wagner
21d4b4c50d Un-omit Win10 IntelIris540 Vulkan tests. 
I suspect these were fixed by the driver upgrade in
https://skia-review.googlesource.com/c/skia/+/166621

Bug: skia:6398, skia:6863
Change-Id: I9079454b385b209e0c4bf416063ec01883045ab1
Reviewed-on: https://skia-review.googlesource.com/c/167390
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
 2018-11-01 19:26:18 +00:00