Commit Graph

92 Commits

Author SHA1 Message Date
Kevin Lubick
eccf352a28 Promote S6 Job to CQ, demote N5 Job to experimental
Galaxy S6 was way quicker on average: 19 min vs 33 min
https://docs.google.com/spreadsheets/d/1tO1YA3RL36FBGgrfpV-cr1v9srFMowBtlwywSG0frYI/edit#gid=0

We'll only keep the Nexus 5 on for a few weeks, in case we decide to go back.

Bug: skia:
NOTRY=true
Change-Id: I36cc617d4ea274bfaf5b54e9c6d73715d40d65a8

Change-Id: I36cc617d4ea274bfaf5b54e9c6d73715d40d65a8
Reviewed-on: https://skia-review.googlesource.com/13982
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-04-20 19:06:35 +00:00
Ben Wagner
67cadde35b Add Galaxy S6 to CQ as an experimental bot.
BUG=skia:

Change-Id: I8455d5595c0d0700d23fde6171c578fcf3be9270
Reviewed-on: https://skia-review.googlesource.com/13100
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-04-10 20:49:18 +00:00
Eric Boren
e2a3f5fdb8 Add Windows tester to the CQ
This will likely be followed up by an increase in number
of Win VMs.

Bug: skia:6462
Change-Id: If22d934c43c57d4ad3a20730e91caed0d4848cd4
Reviewed-on: https://skia-review.googlesource.com/11440
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-06 14:21:44 +00:00
Andrii Shyshkalov
1f5e139ffd Reland "CQ config: add gerrit CQAbility verifier."
This reverts commit 02241e976b.

Reason for revert: cq proto has been rolled to depot_tools.

Original change's description:
> Revert "CQ config: add gerrit CQAbility verifier."
> 
> This reverts commit 0462822132.
> 
> Reason for revert: Lets revert until the proto is rolled into Skia.
> 
> Original change's description:
> > CQ config: add gerrit CQAbility verifier.
> > 
> > Goal is to ensure that unreviewed and untrusted code isn't sent through
> > CQ to try bots, by accident or through malicious intent.
> > 
> > R=​rmistry@google.com
> > BUG=chromium:692613
> > NOTRY=True
> > 
> > Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0
> > Reviewed-on: https://skia-review.googlesource.com/8620
> > Reviewed-by: Ravi Mistry <rmistry@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@google.com>
> > 
> 
> TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:692613
> 
> Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165
> Reviewed-on: https://skia-review.googlesource.com/8663
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> 

R=rmistry@google.com,reviews@skia.org,tandrii@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=chromium:692613

Change-Id: Icefcd69b4608e5294f358de66a9ce014c9950ede
Reviewed-on: https://skia-review.googlesource.com/8740
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-02-22 16:06:01 +00:00
Ravi Mistry
02241e976b Revert "CQ config: add gerrit CQAbility verifier."
This reverts commit 0462822132.

Reason for revert: Lets revert until the proto is rolled into Skia.

Original change's description:
> CQ config: add gerrit CQAbility verifier.
> 
> Goal is to ensure that unreviewed and untrusted code isn't sent through
> CQ to try bots, by accident or through malicious intent.
> 
> R=​rmistry@google.com
> BUG=chromium:692613
> NOTRY=True
> 
> Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0
> Reviewed-on: https://skia-review.googlesource.com/8620
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> 

TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:692613

Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165
Reviewed-on: https://skia-review.googlesource.com/8663
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-02-17 17:41:41 +00:00
Andrii Shyshkalov
0462822132 CQ config: add gerrit CQAbility verifier.
Goal is to ensure that unreviewed and untrusted code isn't sent through
CQ to try bots, by accident or through malicious intent.

R=rmistry@google.com
BUG=chromium:692613
NOTRY=True

Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0
Reviewed-on: https://skia-review.googlesource.com/8620
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-02-17 17:31:32 +00:00
Eric Boren
c486f73be3 Move presubmit bot to skia.swarmbucket
BUG=skia:6183

Change-Id: Ib678c83f46f453b561101cdc12ee637a4e51fb17
Reviewed-on: https://skia-review.googlesource.com/7863
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-02-01 13:16:34 +00:00
Hal Canary
a2ca8ed771 Commit Queue: Add NoGPU build bot.
BUG=skia:6040

Change-Id: Iaf0684b844234c6331f6ca8d97769abf566c18d7
Reviewed-on: https://skia-review.googlesource.com/5749
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2016-12-09 15:29:55 +00:00
Mike Klein
2afffbda66 Remove redundant -GN bot suffixes.
The GN in the name only matters for iOS bots now.  All the others are GN-only.

This revealed a couple redundant build bots: we had two each of Win x86_64 Debug and Release builders, one with -GN and one not.

I have intentionally not resorted gen_tasks.go to keep the diff looking somewhat sane.  I'd be happy to sort here or to follow up with a re-sort CL.

Change-Id: I2f8a136a1fbde416739966e27685b52b94b50cf6
Reviewed-on: https://skia-review.googlesource.com/5545
Reviewed-by: Eric Boren <borenet@google.com>
2016-12-06 00:49:45 +00:00
Eric Boren
b91cf1c3c0 [nobuildbot] Replace presubmit bot with swarmbucket version
BUG=skia:

Change-Id: I40d46e3a8a5c6c6fa77075c94d6bd290f764a41c
Reviewed-on: https://skia-review.googlesource.com/5512
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-12-02 17:54:15 +00:00
Eric Boren
cb4feeb7db [nobuildbot] Win GCE bots
BUG=skia:

Change-Id: Id0d0319f68a1c6d970c13bb5b6006786ae04ffec
Reviewed-on: https://skia-review.googlesource.com/5265
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-29 12:05:31 +00:00
Eric Boren
b409c6ae56 [nobuildbot] Mac bots
BUG=skia:

Change-Id: I089a21941b65d4bb53e803c4d5081b26bda30f14
Reviewed-on: https://skia-review.googlesource.com/5210
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-28 12:22:43 +00:00
Eric Boren
bd488f886d [nobuildbot] Remaining (non-CT) Linux bots
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5187

Change-Id: Ibce633b602623510f3c43cca2862a97b41d45b52
Reviewed-on: https://skia-review.googlesource.com/5187
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-23 19:08:31 +00:00
Eric Boren
508313064b [nobuildbot] Migrate all Linux GCE bots
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4994

Change-Id: Ib63f36b3803117d5357c8e70c572653afd151abe
Reviewed-on: https://skia-review.googlesource.com/4994
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-23 14:49:14 +00:00
Eric Boren
860fc6662d [nobuildbot] Nexus 5
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4870

Change-Id: Id8bcb72926155d8754e99e5ec5b3ae2461b22e0f
Reviewed-on: https://skia-review.googlesource.com/4870
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-16 12:15:34 +00:00
Eric Boren
fa2c4788ce Make the infra tests part of the CQ
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4550

Change-Id: I3ed720e5608282cd9fa14365e6f4fa4338c81ef0
Reviewed-on: https://skia-review.googlesource.com/4550
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-08 19:49:18 +00:00
borenet
9598c2fbc2 Add the new buildbotless infra-tests bot to the CQ as an experiment
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2421483004

Review-Url: https://codereview.chromium.org/2421483004
2016-11-04 08:48:30 -07:00
mtklein
d5724b0356 Add FrameworkDefs bot to the CQ.
Word is that this bot only exists so it can be on the CQ...
but we forgot to actually put it on the CQ until last week.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352703002

Review-Url: https://codereview.chromium.org/2352703002
2016-09-19 12:34:14 -07:00
mtklein
9f262811b7 To prep for removing CMake bots, take them off the CQ and presubmit.
GN is now far more capable than our CMake builds.
Time to officially end that experiment.

Reminder how this lands:
  1) this CL
  2) remove the bots from the masters
  3) remove the CMake recipe files
  4) remove the CMake files

I'm willing to wait on 4) until we can do GN -> CMake generation, but I don't want the bots to hold us back.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350073002

Review-Url: https://codereview.chromium.org/2350073002
2016-09-19 09:08:07 -07:00
mtklein
9b6c58cf67 Promote the N5 to the CQ for real.
The experiment was a great success.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345263002

Review-Url: https://codereview.chromium.org/2345263002
2016-09-16 11:34:08 -07:00
mtklein
88e670ff6a CQ update
- swap the N5 experiment over to the new GN N5 bot

  - cut down on the Windows build duplication: the other two bots
    cover x86, x86-64, Release, Debug, _and_ Vulkan already.

  - remove the Release-Shared tester: I added this bot to act as a proxy
    for the also Shared-build Android bots, but 1) they're fast enough
    to no longer need a proxy (see N5 above) and 2) they're no longer
    Shared builds.  I intend to completely drop support for dm and
    nanobench in Shared builds, so this bot will not just drop from the
    CQ but completely disappear.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346463002

Review-Url: https://codereview.chromium.org/2346463002
2016-09-14 11:20:59 -07:00
kjlubick
f06e518300 Add Nexus5 to CQ as an experiment
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332353002

Review-Url: https://codereview.chromium.org/2332353002
2016-09-13 08:48:27 -07:00
mtklein
982e7c502f switch CQ over to GN_Android compile bots
These are going to replace the old compile bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294303002

Review-Url: https://codereview.chromium.org/2294303002
2016-08-31 08:42:06 -07:00
rmistry
93f366d675 Add gerrit config lines to cq.cfg
Needed for the CQ to see Gerrit. Eg:
https://cs.chromium.org/chromium/tools/depot_tools/infra/config/cq.cfg?q=cq.cfg&sq=package:chromium&dr=C&l=9

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251643005

Review-Url: https://codereview.chromium.org/2251643005
2016-08-17 07:51:57 -07:00
mtklein
691b78423e Slim the CQ down to the GN bots, where they exist.
If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2207073002
2016-08-04 09:47:38 -07:00
mtklein
f6593a68d9 Add some GN builders to the CQ.
This parallels the set of bots we use to gate commits already.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003

Review-Url: https://codereview.chromium.org/2189283003
2016-07-29 10:41:37 -07:00
egdaniel
725266a9b1 Add vulkan compile bot to CQ
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166353003

Review-Url: https://codereview.chromium.org/2166353003
2016-07-21 09:29:01 -07:00
tandrii
23e9f7c501 Make bucket names explicit in cq.cfg.
Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627
R=rmistry@google.com,sergiyb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096733005

Review-Url: https://codereview.chromium.org/2096733005
2016-06-24 11:27:29 -07:00
rmistry
9afccaaf8e Reland of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2087913003/ )
Reason for revert:
Will watch this after it is in.

Original issue's description:
> Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
>
> Reason for revert:
> Reverting due to purple trybots in https://codereview.chromium.org/2087343002/
>
> We will have to investigate..
>
> Original issue's description:
> > add a Chrome builder to the CQ
> >
> > This appears to be the fastest Chrome builder, averaging 8-9 minutes.
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
> >
> > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
>
> TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1afb8f8965b0549525c1ad8d8baa885ccdb48f6d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2096613002
2016-06-23 04:16:38 -07:00
rmistry
1afb8f8965 Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
Reason for revert:
Reverting due to purple trybots in https://codereview.chromium.org/2087343002/

We will have to investigate..

Original issue's description:
> add a Chrome builder to the CQ
>
> This appears to be the fastest Chrome builder, averaging 8-9 minutes.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
>
> Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2087913003
2016-06-22 10:41:02 -07:00
mtklein
cb4efa90ab add a Chrome builder to the CQ
This appears to be the fastest Chrome builder, averaging 8-9 minutes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002

Review-Url: https://codereview.chromium.org/2085333002
2016-06-22 10:22:55 -07:00
rmistry
12135f50bd Add dry_run_access_list to Skia's cq.proto
This will give all users who have access to our trybots access to our dry run CQ as well.

BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002
2016-04-27 09:43:21 -07:00
borenet
8749cfa2ca Add CMake builder to CQ
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810523002

Review URL: https://codereview.chromium.org/1810523002
2016-03-16 07:07:25 -07:00
stephana
7c0b9feee9 Temporarily disable ios compile bot
BUG=skia:
TBR=rmistry
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757053002

Review URL: https://codereview.chromium.org/1757053002
2016-03-02 12:45:04 -08:00
mtklein
3f20f511dc update CQ with new bot names
NOTRY=true
NOTREECHECKS=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675643002

Review URL: https://codereview.chromium.org/1675643002
2016-02-05 06:10:38 -08:00
borenet
4894565528 Add Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release to the CQ
BUG=skia:4758
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564743003

Review URL: https://codereview.chromium.org/1564743003
2016-01-06 10:54:50 -08:00
borenet
258ade521b Add iOS compile bot to the CQ
BUG=skia:4252

Review URL: https://codereview.chromium.org/1501453005
2015-12-04 10:19:21 -08:00
sergiyb
613f20aa4b Moved committer list to chrome-infra-auth and deleted it from the repo
R=rmistry@chromium.org
BUG=chromium:511311

Review URL: https://codereview.chromium.org/1314153006
2015-09-02 13:37:54 -07:00
rmistry
a3710c3262 Specify try_job_retry_config for Skia try jobs
Retry config support was added to the CQ in https://chromereviews.googleplex.com/240527013/
This CL uses the retry config in Skia's cq.cfg file.

CQ's default failure_retry_weight is 1. We set it to 2 which will immediately go beyond the try job quota and will not retry for failures. It will retry for transient errors.

BUG=chromium:522460
TBR=mtklein
NOTRY=true

Review URL: https://codereview.chromium.org/1330473002
2015-09-02 05:23:23 -07:00
mtklein
a981e74097 Add a 64-bit ARM builder to the CQ.
It's possible this rarely breaks, but I do write ARMv8 code frequently
enough that it'll help prevent broken trees.

BUG=skia:

Review URL: https://codereview.chromium.org/1209763003
2015-06-24 14:52:24 -07:00
sheyang
12555d7efb Add signcla verifier to skia.
This verifier is just informative now.

BUG=457428

Review URL: https://codereview.chromium.org/1193433003
2015-06-17 09:15:52 -07:00
sergiyb
2baef5a1e1 Added CQ config to skia repo
This must land in sync with https://chromereviews.googleplex.com/204307013 and
revert in sync.

R=rmistry@chromium.org, tandrii@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=chromium:471767

Review URL: https://codereview.chromium.org/1153093004
2015-06-08 05:12:56 -07:00