robertphillips@google.com
fe830a4641
Fix debugger crash when SK_PICTURE_PROFILING_STUBS isn't defined
...
https://codereview.appspot.com/6850060/
git-svn-id: http://skia.googlecode.com/svn/trunk@6433 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-15 16:33:31 +00:00
robertphillips@google.com
2bde91dcb6
Add profiling to debugger
...
https://codereview.appspot.com/6817114/
git-svn-id: http://skia.googlecode.com/svn/trunk@6430 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-15 14:57:57 +00:00
djsollen@google.com
c3c8216949
Fix linux compiler error with the debugger app.
...
Review URL: https://codereview.appspot.com/6848045
git-svn-id: http://skia.googlecode.com/svn/trunk@6398 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-13 18:35:10 +00:00
robertphillips@google.com
d26c70688f
Update debugger GUI to have profile button & list widget to optionally display time
...
https://codereview.appspot.com/6813117/
git-svn-id: http://skia.googlecode.com/svn/trunk@6385 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-12 20:42:12 +00:00
skia.committer@gmail.com
72b2e6fff3
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6344 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-08 02:03:56 +00:00
scroggo@google.com
b4467e642e
Decode images during deserialization in the picture debugger.
...
Necessary now that our checked in SKPs have encoded bitmaps in them (since https://code.google.com/p/skia/source/detail?r=6317 )
Review URL: https://codereview.appspot.com/6812093
git-svn-id: http://skia.googlecode.com/svn/trunk@6322 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 23:10:09 +00:00
robertphillips@google.com
30d35f23ae
Enhanced debugger with command indenting and Path Bound print out
...
https://codereview.appspot.com/6820099/
git-svn-id: http://skia.googlecode.com/svn/trunk@6309 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 16:45:36 +00:00
bsalomon@google.com
16e3ddea6a
Platform/Engine -> Backend
...
createPlatform -> wrapBackend
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6785044
git-svn-id: http://skia.googlecode.com/svn/trunk@6123 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-25 18:43:28 +00:00
skia.committer@gmail.com
1e34ff7030
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6067 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-24 02:01:24 +00:00
robertphillips@google.com
195952f0ae
Make Debugger print out more information (mainly w.r.t. SkBitmap)
...
https://codereview.appspot.com/6709069/
git-svn-id: http://skia.googlecode.com/svn/trunk@6042 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-23 12:13:35 +00:00
skia.committer@gmail.com
6a748ad8d8
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6013 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-19 02:01:19 +00:00
robertphillips@google.com
872017694b
Make debugger print more information for paths
...
https://codereview.appspot.com/6727052/
git-svn-id: http://skia.googlecode.com/svn/trunk@5993 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-18 13:30:18 +00:00
tfarina@chromium.org
e8d29f5058
debugger: Remove obsolete TODO comment.
...
std::string usage was already replaced by SkString.
R=chudy@google.com , tomhudson@google.com
Review URL: https://codereview.appspot.com/6596043
git-svn-id: http://skia.googlecode.com/svn/trunk@5738 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-29 13:17:16 +00:00
skia.committer@gmail.com
1e9c987c69
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5721 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-28 02:01:16 +00:00
fmalita@google.com
bacfcfb11c
Generate debugger MOCs on the fly
...
Added gyp rules to generate Qt MOC files at build time, and removed the pre-packaged versions.
Tested on Mac with Qt 4.6.4 & 4.8.3, and on Linux with Qt 4.8.1.
R=caryclark@google.com ,robertphillips@google.com,djsollen@google.com
BUG=
Review URL: https://codereview.appspot.com/6561054
git-svn-id: http://skia.googlecode.com/svn/trunk@5707 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-27 13:34:34 +00:00
skia.committer@gmail.com
44d498812a
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5705 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-27 02:01:04 +00:00
robertphillips@google.com
af99d5595f
Added Qt 4.8.3 moc files for the debugger
...
http://codereview.appspot.com/6570055/
git-svn-id: http://skia.googlecode.com/svn/trunk@5701 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-26 18:04:51 +00:00
reed@google.com
6ae24e0f5f
remove uses of setBitmapDevice (DEPRECATED)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5689 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-26 13:44:13 +00:00
scroggo@google.com
a0c2bc2438
Make flattenables no longer depend on global static initializers.
...
Instead, force all builds to call InitializeFlattenables.
Remove the make_debugger script, which was created to force
rebuilding without global static initializers so that all flattenables
would be linked. It is no longer necessary since all flattenables
will be linked thanks to InitializeFlattenables, which now can (and
must) be called when global static initializers are turned on.
BUG=https://code.google.com/p/skia/issues/detail?id=903
BUG=https://code.google.com/p/skia/issues/detail?id=902
Review URL: https://codereview.appspot.com/6548044
git-svn-id: http://skia.googlecode.com/svn/trunk@5642 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-21 17:54:46 +00:00
robertphillips@google.com
84d320e258
Got debugger compiling again after SkCanvas API change
...
http://codereview.appspot.com/6543047/
git-svn-id: http://skia.googlecode.com/svn/trunk@5616 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-20 19:09:17 +00:00
reed@google.com
7112173c3c
re-re-land 5578
...
will follow w/ new .skp files to keep the waterfall green (I hope)
git-svn-id: http://skia.googlecode.com/svn/trunk@5584 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 15:14:33 +00:00
reed@google.com
10f9f4a844
revert 5580
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5581 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 14:04:54 +00:00
reed@google.com
eab16dea1c
re-land 5578 w/ pipe fix
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5580 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 13:47:20 +00:00
reed@google.com
c75c36a14b
revert 5578 -- broke pipe
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5579 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 13:20:52 +00:00
reed@google.com
f1ab723033
Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
...
allows the client more control over the scaling. Because of virtual overrides
and wanting to keep the old call-sites up and running, this CL renames the
virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to
a non-virtual helper function.
The implementation is to use the float-rect for computing the matrix, but still
cons-up an integer rect for the purposes of subsetting the original bitmap. We
do this by calling float_src->roundOut(&int_src) so that we include all
(partially) covered src pixels.
No change needed on SkDevice, since that signature is explicitly passed the
computed matrix.
Review URL: https://codereview.appspot.com/6501140
git-svn-id: http://skia.googlecode.com/svn/trunk@5578 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 12:59:44 +00:00
skia.committer@gmail.com
f0c1e0f56d
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5477 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-11 02:01:14 +00:00
robertphillips@google.com
2f5db885d7
Added Qt 4.8.1 moc files for precise builds
...
http://codereview.appspot.com/6488108/
git-svn-id: http://skia.googlecode.com/svn/trunk@5473 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-10 19:24:47 +00:00
skia.committer@gmail.com
04ba448579
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5425 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-07 02:01:30 +00:00
robertphillips@google.com
94acc70312
Fixed Windows compiler complaints (esp. in debugger)
...
https://codereview.appspot.com/6497090/
git-svn-id: http://skia.googlecode.com/svn/trunk@5419 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-06 18:43:21 +00:00
robertphillips@google.com
8b62c60e96
Added 4.6.2 prefix to existing debugger moc files
...
http://codereview.appspot.com/6488090/
git-svn-id: http://skia.googlecode.com/svn/trunk@5416 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-06 18:04:07 +00:00
robertphillips@google.com
a56b706e29
Adding 4.8.2 moc files for debugger
...
http://codereview.appspot.com/6494092/
git-svn-id: http://skia.googlecode.com/svn/trunk@5415 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-06 18:02:52 +00:00
rmistry@google.com
fbfcd56021
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/ )
...
This CL is part I of IV (I broke down the 1280 files into 4 CLs).
Review URL: https://codereview.appspot.com/6485054
git-svn-id: http://skia.googlecode.com/svn/trunk@5262 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 18:09:54 +00:00
chudy@google.com
4c7962e0a8
Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested clips not being cleared.
...
Review URL: https://codereview.appspot.com/6462060
git-svn-id: http://skia.googlecode.com/svn/trunk@5095 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:38:31 +00:00
chudy@google.com
b8ec32e050
Bug Fix: Fixes incremental drawing in conjunction with the highlighting filter for the OpenGL widget.
...
Review URL: https://codereview.appspot.com/6441141
git-svn-id: http://skia.googlecode.com/svn/trunk@5094 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:36:09 +00:00
chudy@google.com
6bd109a393
Refactored inspector widget such that creating custom tabs for information is straightforward for future developers.
...
Review URL: https://codereview.appspot.com/6463046
git-svn-id: http://skia.googlecode.com/svn/trunk@5093 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:34:13 +00:00
chudy@google.com
686e680193
Bug Fix: Resets the users zoom and translation every picture load. Was acting inconsistently between different viewing widgets, now forces a redraw every new picture.
...
Review URL: https://codereview.appspot.com/6450130
git-svn-id: http://skia.googlecode.com/svn/trunk@5083 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 16:00:32 +00:00
chudy@google.com
bbad34de3b
Effects Bug Fix
...
Certain compilers in an effort to optimize code chop off files that are never
used. By adding a flag to common conditions and variables we can force skia to
recompile with global static initializers off. By making a call to
SkGraphics::Init we now register all those functions that had been previously
automatically excluded by the compiler.
Review URL: https://codereview.appspot.com/6443112
git-svn-id: http://skia.googlecode.com/svn/trunk@5057 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-13 14:26:36 +00:00
chudy@google.com
97cee97353
Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia code
...
Review URL: https://codereview.appspot.com/6445088
git-svn-id: http://skia.googlecode.com/svn/trunk@4995 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-07 20:41:37 +00:00
chudy@google.com
607357fde8
Refactoring into a public facing facing SkDebugger class first pass.
...
Review URL: https://codereview.appspot.com/6450096
git-svn-id: http://skia.googlecode.com/svn/trunk@4986 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-07 16:12:23 +00:00
chudy@google.com
9cda6f753c
Quick mem fix for debug canvas leaking when loading new pics.
...
Review URL: https://codereview.appspot.com/6454096
git-svn-id: http://skia.googlecode.com/svn/trunk@4975 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-07 15:08:33 +00:00
chudy@google.com
a9e937c7b7
Moved the ownership of the current clip and current matrix into the debug canvas as part of the upcoming general refactor to everything living in debug canvas.
...
Review URL: https://codereview.appspot.com/6447077
git-svn-id: http://skia.googlecode.com/svn/trunk@4950 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-03 17:32:05 +00:00
chudy@google.com
92b11f6103
Added more DrawPoints debugging info for inspector
...
Review URL: https://codereview.appspot.com/6441084
git-svn-id: http://skia.googlecode.com/svn/trunk@4893 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-01 16:10:06 +00:00
chudy@google.com
830b8793bb
Optimization: SkDebugCanvas is capable of pausing and drawing incrementally instead of redrawing all commands.
...
Review URL: https://codereview.appspot.com/6458056
git-svn-id: http://skia.googlecode.com/svn/trunk@4891 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-01 15:57:52 +00:00
chudy@google.com
751961d471
Getting rid of compile-time warnings
...
Review URL: https://codereview.appspot.com/6447071
git-svn-id: http://skia.googlecode.com/svn/trunk@4868 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-31 20:07:42 +00:00
chudy@google.com
0b5bbb0f82
Optimized hit testing feature, refactored into seperate function from canvas draw calls
...
Review URL: https://codereview.appspot.com/6443068
git-svn-id: http://skia.googlecode.com/svn/trunk@4867 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-31 19:55:32 +00:00
chudy@google.com
2d537a18f4
Fixed numerous mem errors
...
Review URL: https://codereview.appspot.com/6441070
git-svn-id: http://skia.googlecode.com/svn/trunk@4849 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-31 12:49:52 +00:00
chudy@google.com
80a4a60f96
Canvas size initializes correctly when drawing from a skia picture
...
Review URL: https://codereview.appspot.com/6450065
git-svn-id: http://skia.googlecode.com/svn/trunk@4837 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-30 18:54:07 +00:00
chudy@google.com
38b08ce020
Added missing files to fix build.
...
TBR
Review URL: https://codereview.appspot.com/6455058
git-svn-id: http://skia.googlecode.com/svn/trunk@4822 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-28 23:26:10 +00:00
chudy@google.com
0ab03397af
Skia Debugger can now save modified pictures.
...
Review URL: https://codereview.appspot.com/6442055
git-svn-id: http://skia.googlecode.com/svn/trunk@4821 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-28 20:16:11 +00:00
chudy@google.com
a1226319b7
Key Shortcuts for Zooming. Refactored some event propogation.
...
Review URL: https://codereview.appspot.com/6452052
git-svn-id: http://skia.googlecode.com/svn/trunk@4794 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-26 20:26:44 +00:00
chudy@google.com
ea5488b965
GL Widget Alpha
...
Review URL: https://codereview.appspot.com/6422060
git-svn-id: http://skia.googlecode.com/svn/trunk@4789 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-26 19:38:22 +00:00
chudy@google.com
ea79aba75b
Fixed glaring typo in SkDebuggerGUI.cpp, unreviewed.
...
BUG=
TEST=
Review URL: https://codereview.appspot.com/6423052
git-svn-id: http://skia.googlecode.com/svn/trunk@4669 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 13:48:14 +00:00
chudy@google.com
d3058f5fd8
Quick bug fix that was rendering debugger unusable.
...
Review URL: https://codereview.appspot.com/6422050
git-svn-id: http://skia.googlecode.com/svn/trunk@4668 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 13:41:27 +00:00
chudy@google.com
7e4cfbf144
Added more features to deletes and breakpoints
...
Review URL: https://codereview.appspot.com/6406050
git-svn-id: http://skia.googlecode.com/svn/trunk@4637 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-17 15:40:51 +00:00
chudy@google.com
e504de0a50
Cleaned up icons, added keyboard shortcuts to everything
...
Keyboard Shortcuts and Menu reordering
Review URL: https://codereview.appspot.com/6400051
git-svn-id: http://skia.googlecode.com/svn/trunk@4630 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-16 18:35:23 +00:00
chudy@google.com
9ca9bfe9f6
Feature, HitBox selects current command
...
Review URL: https://codereview.appspot.com/6345091
git-svn-id: http://skia.googlecode.com/svn/trunk@4588 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 21:58:14 +00:00
chudy@google.com
233e4b80e0
Bug Fix: Delete redraws correctly when redraw command execution is paused
...
Review URL: https://codereview.appspot.com/6392053
git-svn-id: http://skia.googlecode.com/svn/trunk@4567 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:38:49 +00:00
chudy@google.com
e606d6e210
SkHitBox added.
...
SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.
Review URL: https://codereview.appspot.com/6350098
git-svn-id: http://skia.googlecode.com/svn/trunk@4565 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:31:25 +00:00
chudy@google.com
e565de4fad
Seperated Space for displaying breakpoint and deletion icons
...
Review URL: https://codereview.appspot.com/6356094
git-svn-id: http://skia.googlecode.com/svn/trunk@4563 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:15:54 +00:00
chudy@google.com
f927f44a29
Bug Fix: Pause drawing execution feature works due to fixed typo
...
Review URL: https://codereview.appspot.com/6349086
git-svn-id: http://skia.googlecode.com/svn/trunk@4505 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 14:36:14 +00:00
chudy@google.com
b9ddd4e9f1
Bug Fix: Current command mask now dynamically changes based on bounds of window.
...
Review URL: https://codereview.appspot.com/6384044
git-svn-id: http://skia.googlecode.com/svn/trunk@4504 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 14:14:50 +00:00
chudy@google.com
c432f00a84
Made everything in SkDebuggerGUI live on the stack
...
Review URL: https://codereview.appspot.com/6389043
git-svn-id: http://skia.googlecode.com/svn/trunk@4502 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 13:19:25 +00:00
chudy@google.com
7dcae67cae
Added stubs for zoom info panel.
...
Review URL: https://codereview.appspot.com/6350071
git-svn-id: http://skia.googlecode.com/svn/trunk@4493 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 20:26:53 +00:00
chudy@google.com
f14143226a
Adds missing function
...
Review URL: https://codereview.appspot.com/6346067
git-svn-id: http://skia.googlecode.com/svn/trunk@4459 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-03 20:28:14 +00:00
chudy@google.com
2f89179395
Adds functionality to the matrix and clip widget.
...
Review URL: https://codereview.appspot.com/6348058
git-svn-id: http://skia.googlecode.com/svn/trunk@4453 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-03 16:05:59 +00:00
chudy@google.com
902ebe5eb4
clt debugger
...
Review URL: https://codereview.appspot.com/6267043
git-svn-id: http://skia.googlecode.com/svn/trunk@4404 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-29 14:21:22 +00:00