AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
21,921 Commits 1 Branch 0 Tags 544 MiB
e0c1d285a0
Commit Graph

21921 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
lsalzman
8dea4e41a1 add header guard to SkPM4fPriv.h to prevent accidental multiple inclusion 
This works around some issues with Firefox's unified sources build system.

BUG=skia:5173
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869613003

Review URL: https://codereview.chromium.org/1869613003
 2016-04-07 14:04:32 -07:00
egdaniel
5f3b0e00fb Limit the size of descriptor pools in vulkan 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1867973002

Review URL: https://codereview.chromium.org/1867973002
 2016-04-07 13:49:01 -07:00
fmalita
eadf3cf899 [4fGradient] Veto blitters for non-opaque paints 
The current blitters don't support SrcOver, so we must ensure the colors
are opaque.  Checking shader.colorsAreOpaque() is not enough as it
doesn't reflect the paint alpha.

Instead we should check for context flags & kOpaqueAlpha_Flag, which is
only set when both the color stops AND the paint are opaque.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870773002

Review URL: https://codereview.chromium.org/1870773002
 2016-04-07 13:16:13 -07:00
halcanary
78daeff1f9 SkPDF Fix PDF/A to be more valid 
Some produced PDFs are recognized by veraPDF 0.13.2
(http://verapdf.org/software/) as valid PDF/A-2B.

BUG=skia:4535

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864173004

Review URL: https://codereview.chromium.org/1864173004
 2016-04-07 12:35:00 -07:00
jvanverth
3d6ed3ae75 Some more improvements/fixes to the VulkanViewer 
* display GM name in title bar
* add ms timer for update loop
* add ms/frame meter
* fix vsync
* add some notes for later

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1873453002

Review URL: https://codereview.chromium.org/1873453002
 2016-04-07 11:09:51 -07:00
kjlubick
312398159c Add support for pyadb to setup_adb.sh 
BUG=skia:5156
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869813002

Review URL: https://codereview.chromium.org/1869813002
 2016-04-07 10:57:27 -07:00
egdaniel
8af936d304 Fix a bunch of memory issues in Vulkan 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1867883002

Review URL: https://codereview.chromium.org/1867883002
 2016-04-07 10:17:47 -07:00
benjaminwagner
93dc33972c For *ToFixed, in debug mode, assert that the value is in range. 
Use SkFloatPinToFixed in SkTwoPointConicalGradient.cpp because it is failing in DM. fmalita is working on replacing this code with the 4f version, so I'm not bothering to fix it. (The beginnings of a real fix are in https://codereview.chromium.org/1767163003, which I do not plan to commit.)

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824733002

Review URL: https://codereview.chromium.org/1824733002
 2016-04-07 09:52:19 -07:00
benjaminwagner
70f1a6c64e Add pinned versions of *ToFixed. 
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707023002

Review URL: https://codereview.chromium.org/1707023002
 2016-04-07 09:23:12 -07:00
robertphillips
73add93a9c Appease valgrind wrt testing code initialization 
The new swarming valgrind bot appears to be higher maintenance. These changes seem harmless and will, hopefully, unblock the bot.

TBR=bsalomon@google.com

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-SwarmingValgrind/builds/57

BUG=skia:5164
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1867053002

Review URL: https://codereview.chromium.org/1867053002
 2016-04-07 09:01:20 -07:00
halcanary
8cd4a24236 SkPDF: fix PDF/A 
TODO: get a bot to start testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864163004

Review URL: https://codereview.chromium.org/1864163004
 2016-04-07 08:56:15 -07:00
benjaminwagner
6c71e0a065 Reverse dependency between SkScalar.h and SkFixed.h. 
The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1841123002

Review URL: https://codereview.chromium.org/1841123002
 2016-04-07 08:49:31 -07:00
robertphillips
6f01104b1d Revert conversion of SkColorFilterImageFilter to new API 
BUG=598028

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864263002

Review URL: https://codereview.chromium.org/1864263002
 2016-04-07 08:10:45 -07:00
herb
303c979b82 Use a faster repeat tiler when translate only matrix. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861253003

Review URL: https://codereview.chromium.org/1861253003
 2016-04-07 07:56:12 -07:00
egdaniel
ef0c10cffe Fix vulkan layer callback bug 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870673002

Review URL: https://codereview.chromium.org/1870673002
 2016-04-07 07:51:23 -07:00
robertphillips
11171f3b66 Update MagnifierImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864843002

Review URL: https://codereview.chromium.org/1864843002
 2016-04-07 07:34:15 -07:00
brianosman
32f7782706 sRGB text fake-gamma progress: 
Determine if we should use fake-gamma based on the render target format
and paint parameters (ie will gamma-correct blending happen?). Plumb that
down to the appropriate places in the bitmap text rendering for now.

Still need to alter the behavior of the DF text renderer (using the same
cue, most likely?). Also, this still doesn't account for the contrast
hack. The end result of this change is a pleasant normalizing of weight
when viewing text in the gpusrgb config. (Dark text gets heavier, light
text gets lighter).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865953003

Review URL: https://codereview.chromium.org/1865953003
 2016-04-07 06:25:45 -07:00
mtklein
044d3c1858 Revert of Track GL buffer state based on unique resource ID (patchset #6 id:100001 of https://codereview.chromium.org/1854283004/ ) 
Reason for revert:
Chrome roll's broken, seems to be missing fTarget:

https://codereview.chromium.org/1861473005

Original issue's description:
> Track GL buffer state based on unique resource ID
>
> Reworks GrGLGpu to track GL buffer state based on the unique
> GrGpuResource ID. This eliminates the need to notify the gpu object
> whenever a buffer is deleted.
>
> This change also allows us to remove the type specifier from GrBuffer.
> At this point a buffer is just a chunk of memory, and the type
> given at creation time is just a suggestion to the GL backend about
> which target to bind to for updates.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854283004
>
> Committed: https://skia.googlesource.com/skia/+/deacc97bc63513b5eacaf21f858727f6e8b98ce5

TBR=bsalomon@google.com,jvanverth@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1870553002
 2016-04-06 18:24:34 -07:00
msarett
6e077e140a Mark webps as sRGB 
This may cause some diffs in Gold.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838603002

Review URL: https://codereview.chromium.org/1838603002
 2016-04-06 15:45:41 -07:00
mtklein
11064dfeb4 Fix lazy coding in ViaSingletonPictures. 
I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing spurious quick rejects in drawPatch().  I didn't really
look much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.

This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865143002

Review URL: https://codereview.chromium.org/1865143002
 2016-04-06 15:01:57 -07:00
cdalton
deacc97bc6 Track GL buffer state based on unique resource ID 
Reworks GrGLGpu to track GL buffer state based on the unique
GrGpuResource ID. This eliminates the need to notify the gpu object
whenever a buffer is deleted.

This change also allows us to remove the type specifier from GrBuffer.
At this point a buffer is just a chunk of memory, and the type
given at creation time is just a suggestion to the GL backend about
which target to bind to for updates.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854283004

Review URL: https://codereview.chromium.org/1854283004
 2016-04-06 14:26:34 -07:00
mtklein
48156ed412 path_stroke_with_zero_length: turn off drawFat() by default. 
The replay modes cannot readback, and so cannot draw the fat parts, which
means we've had to exempt them from checking that they draw identically.

I don't mind if we leave it alone, but I thought I'd check to see your opinion.

BUG=skia:4095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862113004

Review URL: https://codereview.chromium.org/1862113004
 2016-04-06 14:25:35 -07:00
bsalomon
758586c7f1 Make existing unit tests only run on GL contexts 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869503002

Review URL: https://codereview.chromium.org/1869503002
 2016-04-06 14:02:39 -07:00
mtklein
9e65f9399e alternate textblobgeometrychange fix... just make our own surface if needed 
This should decopple fixing the replay modes from revising the API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868553005

Review URL: https://codereview.chromium.org/1868553005
 2016-04-06 13:57:38 -07:00
egdaniel
b4aa36211c Switch uniforms to be descriptor set 0 in Vulkan 
This (plus some cleanup) gives us some minor perf gains and as a side effect
the perf debug layer no longer complains when we bind certain descriptor sets.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864303002

Review URL: https://codereview.chromium.org/1864303002
 2016-04-06 13:47:08 -07:00
cdalton
a957b8a114 Fix null context GenBuffers 
Fixes the null context to not return 0 for GenBuffers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1863923003

Review URL: https://codereview.chromium.org/1863923003
 2016-04-06 13:36:38 -07:00
mtklein
3d72c099c7 Remove conditional flavor text on blend GM. 
This was breaking replay modes for no good reason.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864253002

Review URL: https://codereview.chromium.org/1864253002
 2016-04-06 12:42:49 -07:00
mtklein
083b869f50 Register SkLocalMatrixImageFilter for serialization. 
This fixes one of the zillions of serialize-8888 backlisted tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868453003

Review URL: https://codereview.chromium.org/1868453003
 2016-04-06 12:27:07 -07:00
jvanverth
9fab59d3a6 Clean up input handling in VulkanViewer 
Sets up proper handling of characters and keycodes, and event modifiers.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865553005

Review URL: https://codereview.chromium.org/1865553005
 2016-04-06 12:08:51 -07:00
borenet
b0070197ff More iOS swarming bot fixes 
- Copy the packaged app into xcodebuild/...
- Isolate ios/bin directory

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002

Review URL: https://codereview.chromium.org/1860333002
 2016-04-06 11:38:55 -07:00
bsalomon
3ddf967ffe Alter dm_flags.py logic flow for certain configs to be subtractive 
Replace msaa4 on Shield Tablet with glmsaa4.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868473003

Review URL: https://codereview.chromium.org/1868473003
 2016-04-06 09:22:36 -07:00
caryclark
4693a1748f cubic stroke fix 
Normally parallel tangents means that the stroke can
be represented with a line. But looping cubics can
have parallel tangents if the loop is 180 degrees.

Check to see if the tangents direction is opposite
to subdivide further.

R=reed@google.com
BUG=skia:5099
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862753002

Review URL: https://codereview.chromium.org/1862753002
 2016-04-06 08:54:06 -07:00
robertphillips
c416912da4 Update DropShadowImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861843002

Review URL: https://codereview.chromium.org/1861843002
 2016-04-06 08:40:59 -07:00
bsalomon
885b677b10 Add exclusion for keymobi_shop_mobileweb_ebay_com.skp on N5 
BUG=skia:5178
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1857123005

Review URL: https://codereview.chromium.org/1857123005
 2016-04-06 08:35:15 -07:00
robertphillips
fc0f44a5f0 Update DownSampleImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864583005

Review URL: https://codereview.chromium.org/1864583005
 2016-04-06 07:44:01 -07:00
brianosman
898235c486 SkSurfaceProps now has a gamma-correct ("AllowSRGBInputs") flag. That's propagated in a few places so that the backend can do the right thing for L32 vs S32 mode. 
Also added SkSurfaceProps to SkSpecialImage, so that Image -> Surface conversion can preserve the desired behavior during filtering.

Many small changes, including a bunch of comments about places where we may be losing information right now. My approach was to ensure that if anything fails, it will always fall back to "legacy" mode - gamma-correctness is opt-in, so I'll just have to feed things through as missing cases are exposed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838953007

Review URL: https://codereview.chromium.org/1845283003
 2016-04-06 07:38:23 -07:00
brianosman
1817d282cd Add mipmap procs for F16 format. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831353002

Review URL: https://codereview.chromium.org/1831353002
 2016-04-06 07:32:08 -07:00
yujieqin
4334ff29b4 Enable RAW codec for Windows 
BUG=skia:4890 b/26973157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853093002

Review URL: https://codereview.chromium.org/1853093002
 2016-04-06 06:47:15 -07:00
mtklein
8c13cd1aba Another NDK release. Still just bug fixes. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864073002

Review URL: https://codereview.chromium.org/1864073002
 2016-04-06 06:12:01 -07:00
jvanverth
9f37246d68 First pass at VulkanViewer 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848833005

Review URL: https://codereview.chromium.org/1848833005
 2016-04-06 06:08:59 -07:00
robertphillips
52b88cc617 "Fix" compiler issue in SkRandomScalerContext 
BUG=skia:5164
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862643002

Review URL: https://codereview.chromium.org/1862643002
 2016-04-05 16:55:41 -07:00
robertphillips
ae8c933ca8 Update SkMatrixImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858353002

Review URL: https://codereview.chromium.org/1858353002
 2016-04-05 15:09:00 -07:00
mtklein
77304a5b76 Get back on mainline libpng 1.6 now that 3bpp perf patches are merged. 
Checked manually in Instruments that we're still running our SSE filters for both RGB and RGBA PNGs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865633002

Review URL: https://codereview.chromium.org/1865633002
 2016-04-05 13:46:00 -07:00
bsalomon
f2f1c17e33 One signature for creating unit tests that run on premade GrContexts 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860593002

Review URL: https://codereview.chromium.org/1860593002
 2016-04-05 12:59:06 -07:00
kjlubick
4319593988 Do an in-place replacement of SkRandom with Fuzz for FilterFuzz 
This feels rather clunky, because we aren't using the full potential of the
fuzzer, but it works, it seems.

BUG=skia:4969
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710183002

Review URL: https://codereview.chromium.org/1710183002
 2016-04-05 12:48:47 -07:00
robertphillips
8c0326df5f Update SkXfermodeImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002

Committed: https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8

Review URL: https://codereview.chromium.org/1852123002
 2016-04-05 12:48:34 -07:00
borenet
d32eac278e Set 'device_cfg' parameter for iOS bots 
For https://codereview.chromium.org/1859993003/

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862723002

Review URL: https://codereview.chromium.org/1862723002
 2016-04-05 12:14:59 -07:00
msarett
be243d4737 Revert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of https://codereview.chromium.org/1861013002/ ) 
Reason for revert:
See sugoi's comment.

Original issue's description:
> Delete SkFlattenable::Type (part 1)
>
> This should allow me to delete uses of SkFlattenable::Type in Chrome.
> Then I'll follow up with the full delete.
> https://codereview.chromium.org/1834303003/
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002
>
> Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce

TBR=reed@google.com,mtklein@google.com,sugoi@chromium.org,senorblanco@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1860693005
 2016-04-05 12:00:49 -07:00
robertphillips
5605b56afa Update SkColorFilterImageFilter to sk_sp 
TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858813002

Review URL: https://codereview.chromium.org/1858813002
 2016-04-05 11:50:42 -07:00
brianosman
235cbf23c4 Create output directory in skdiff 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865563002

Review URL: https://codereview.chromium.org/1865563002
 2016-04-05 11:37:49 -07:00