Commit Graph

54599 Commits

Author SHA1 Message Date
skia-autoroll
301449e4d0 Roll Dawn from a0bdba1dfc52 to f759264387ae (7 revisions)
https://dawn.googlesource.com/dawn.git/+log/a0bdba1dfc52..f759264387ae

2021-04-02 bajones@chromium.org Finish conversion to RenderPipelineDescriptor2
2021-04-02 cwallez@chromium.org DEPS: Only add vulkan-deps in dawn_standalone.
2021-04-02 cwallez@chromium.org DEPS: don't recurse in buildtools.
2021-04-02 rharrison@chromium.org Split top-level reflection code into either Tint or SPIRV-Cross
2021-04-02 enga@chromium.org Remove D3D12 live object reporting
2021-04-02 cwallez@chromium.org Remove unnecessary check for null TextureDescriptor.
2021-04-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from b4275c870ec2 to 2f04dc94ce25 (6 revisions)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from b4275c870ec2 to 2f04dc94ce25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: I60e5c4a7cf662e48d01b55e08431d5c9afa4f1d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392598
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-05 04:42:46 +00:00
skia-autoroll
e9244938d2 Roll ANGLE from 67e4aff55ed2 to 323c5f246480 (3 revisions)
67e4aff55e..323c5f2464

2021-04-03 timvp@google.com Validate PPO sampler uniforms
2021-04-03 jmadill@chromium.org Add GL_ANGLE_get_serialized_context_string.
2021-04-02 cnorthrop@google.com Tests: Add Dragon Raja trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: mtklein@google.com
Test: Test: ProgramPipelineTest31.DifferentTextureTypes
Change-Id: I3b8664e46f9cd3a060a48f6d19d48942d0ba5c57
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392516
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-03 23:22:35 +00:00
Brian Salomon
ea1d39b35c updateBackendTexture uses GrSurfaceContext to write pixmaps.
Bug: skia:11786

Change-Id: I1c70b7152a69b2bb976aec2ed1dc9d5f96cad7ab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/348185
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-04-02 22:08:25 +00:00
skia-autoroll
e4427fe9a2 Roll ANGLE from eac2397bcf94 to 67e4aff55ed2 (59 revisions)
eac2397bcf..67e4aff55e

2021-04-02 jmadill@chromium.org Fix rapidjson build error in Skia.
2021-04-02 cnorthrop@google.com Capture/Replay: Support multi-digit context
2021-04-02 cclao@google.com Vulkan: Add baseLevel and generateMipmap test for immutable texture
2021-04-02 m.maiya@samsung.com Vulkan: Add YUV G8_B8R8_2PLANE_420_UNORM support.
2021-04-02 cclao@google.com Vulkan: Add test render to immutable texture will flush
2021-04-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a0d5b9653a91 to 61083c4a2ae0 (4 revisions)
2021-04-02 gert.wollny@collabora.com JsonSerializer: use stubs when building without rapidjson
2021-04-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cc20ce29e7a7 to 9c9ca054e2bc (391 revisions)
2021-04-02 cnorthrop@google.com Tests: Add Aztec Ruins trace
2021-04-02 cnorthrop@google.com Tests: Add League of Legends: Wild Rift trace
2021-04-02 kainino@chromium.org Revert "Metal: Support importing external metal textures"
2021-04-02 xinghua.cao@intel.com D3D: fix uniform block alignment error
2021-04-02 ynovikov@chromium.org Fix and re-enable component build of angle_apks
2021-04-01 ynovikov@chromium.org Add Linux, Ozone and Fuchsia chromium.angle bots to CQ
2021-04-01 lehoangq@gmail.com Metal: Support importing external metal textures
2021-04-01 jonahr@google.com Don't append newline to empty InfoLog stream.
2021-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0a4b29c05e71 to a0d5b9653a91 (6 revisions)
2021-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e4067deef470 to cc20ce29e7a7 (104 revisions)
2021-04-01 jonahr@google.com Revert "Reland "Add support for Linux GPU info with Vulkan backend""
2021-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c181ac047c8b to e4067deef470 (350 revisions)
2021-04-01 lehoangq@gmail.com Metal: implement ANGLE_device_metal extension.
2021-03-31 ynovikov@chromium.org Reland "Link angle_util statically into angle_system_info_test"
2021-03-31 jonahr@google.com GLX: Always call XSync on creation/destruction of WindowSurfaces
2021-03-31 syoussefi@chromium.org Add a gl-d3d-only target for the translator
2021-03-31 cclao@google.com Vulkan: Split fragment shader from ColorAttachmentAndAllShadersRead
2021-03-31 jmadill@chromium.org Enable messenger_lite trace on SwiftShader.
2021-03-31 syoussefi@chromium.org Vulkan: Remove spam output regarding pipeline cache
2021-03-31 chonggu@google.com [Fuchsia] Use manifest fragments for Cr-Fuchsia binaries
2021-03-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b3769b941e6 to 0a4b29c05e71 (2 revisions)
2021-03-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8599134e632f to c181ac047c8b (466 revisions)
2021-03-31 timvp@google.com Detach separable shaders
2021-03-31 timvp@google.com Support linking PPOs without attached Shaders
2021-03-31 syoussefi@chromium.org Vulkan: Temporarily use GOOGLEX instead of EXT for MSRTSS
2021-03-30 rafael.cintron@microsoft.com Check return value of allocateResource instead of asserting
2021-03-30 timvp@google.com Update PPO's executable when attached program is re-linked
2021-03-30 ynovikov@chromium.org Replace Win x86 dEQP GPU.FYI bot with chromium.angle bot
2021-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e0d8a486f6d5 to 4b3769b941e6 (3 revisions)
2021-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fb53aa2bb7da to 4c0f888d7ef8 (1 revision)
2021-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 26bf9bb622f1 to 8599134e632f (396 revisions)
2021-03-30 timvp@google.com Reland "Save/Load missing members"
2021-03-29 syoussefi@chromium.org Don't link with SPIR-V repos if !vulkan && !metal
2021-03-29 gert.wollny@collabora.com Capture/Replay: serialize context to JSON
2021-03-29 gert.wollny@collabora.com Capture/Replay: Enable GetTexImage tests
2021-03-29 gert.wollny@collabora.com capture/replay: impl CaptureGetRenderbufferImageANGLE_pixels
2021-03-29 penghuang@chromium.org Only enable framebufferMultisample with framebufferBlitANGLE
2021-03-29 gert.wollny@collabora.com capture/replay: implement CaptureGetTexImageANGLE_pixels
2021-03-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7079d8df17da to e0d8a486f6d5 (7 revisions)
2021-03-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e0abc3035c46 to 26bf9bb622f1 (218 revisions)
2021-03-28 jmadill@chromium.org Capture/Replay: add frontend feature to force capture limits
2021-03-26 gert.wollny@collabora.com libAngle: Add Json context serializer library
2021-03-26 lubosz.sarnecki@collabora.com context: Remove endl, since INFO already adds them.
2021-03-26 lubosz.sarnecki@collabora.com capture_replay_expectations: Don't skip passing.
2021-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8969f861fc24 to fb53aa2bb7da (2 revisions)
2021-03-26 lubosz.sarnecki@collabora.com capture_gles_3_2: Set read buffer for glGetPointerv.
2021-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3f4383f1d450 to 7079d8df17da (2 revisions)
2021-03-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a30f2f0e630 to e0abc3035c46 (431 revisions)
2021-03-25 lubosz.sarnecki@collabora.com capture_gles_1_0: Implement capture functions.
2021-03-25 ynovikov@chromium.org Remove old Win x86 bots from CQ
2021-03-25 syoussefi@chromium.org Vulkan: Call glslang at compile time

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: mtklein@google.com
Test: Test: FramebufferTest_ES3.RenderImmutableTextureWithSubImageWithBeyondMaxLevelTest: Test: ProgramPipelineTest31.DetachAndModifyShaderTest: Test: ProgramPipelineTest31.ModifyAndRelinkShaderTest: Test: ProgramPipelineTest31.ProgramBinaryTest: Test: Texture2DBaseMaxTestES3.GenerateMipmapAfterRebaseTest: Test: Texture2DBaseMaxTestES3.GenerateMipmapAfterRebaseImmutableTest: Test: Texture2DBaseMaxTestES3.PingPongBaseLevelImmutableTest: Test: angle_perftests --gtest_filter="*aztec_ruins*"Test: Test: angle_perftests --gtest_filter=*league_of_legends_wild_rift*
Change-Id: Ib87ee0996b2400a4514e60a932d4ebc6df4635c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392261
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-02 21:42:46 +00:00
Herb Derby
ef094235dc clean up drawTextUTF8 and rename to textToGlyphRunList
Pull out the glyph positioning code in anticipations of removing
simplifyDrawText.

This is part of a larger CL:
https://skia-review.googlesource.com/c/skia/+/388719

Change-Id: I935fd91f70d708a7a30785b6eea8e4e7c1f9c739
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392416
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-04-02 21:07:25 +00:00
Brian Osman
42de99b8e5 Add MakeSpecialType to replace several one-off Type factories
An upcoming change adds more of these "special" types, this pattern
seems just as easy to follow?

Change-Id: Ib652c8f11a98d33c14300294e521a1378345bc2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392379
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-04-02 21:00:35 +00:00
Brian Salomon
7cde6c36f4 fix parentheses warning
Bug: skia:11786
Change-Id: I2ded1f1cbd486e1710f1ebbb326844258cfeac64
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392436
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-04-02 20:55:45 +00:00
Jim Van Verth
ffeee9bfde Fix lost precision case in SkComputeRadialSteps.
With large offsets, we can end up with a tiny change in angle at each
radial step, so that rotSin and rotCos can get truncated to 0 and/or 1,
respectively. This means that we won't sweep the entire radial distance,
throwing future calculations off. Instead in this case we should fail.

Bug: oss-fuzz:21826
Change-Id: I24f5b1ac315a3697d2ea00ee4bd73652ec3e16dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392377
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-04-02 20:42:35 +00:00
Mike Klein
3144a1e698 have fm mkdir -p
This allows directories in sources, e.g.

    $ fm -b cpu -s skimage/dm/01_original.jpg -w foo
        skimage/dm/01_original.jpg  f181c4655d0f55d7000dd04a4d28d407      330ms

    $ find foo
        foo
        foo/skimage
        foo/skimage/dm
        foo/skimage/dm/01_original.jpg.png

where previously,

    $ fm -b cpu -s skimage/dm/01_original.jpg -w foo
        sk_fopen: fopen("foo/skimage/dm/01_original.jpg.png", "wb") returned nullptr
        (errno:2): No such file or directory
        libpng error: HashAndEncode::encodePNG() failed writing stream

        Signal 6:
        _sigtramp (+0x1d)

Change-Id: I6950d77cacba16363315fb8d5c6d866d207c9a25
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392198
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-04-02 20:35:35 +00:00
Robert Phillips
2307058294 Enforce that the recordTimeArena is only available for DDLRecordingContexts
Bug: b/182959903
Change-Id: If57aaa3067cfe441fd080892e6e5aa933251380d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391440
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-04-02 20:31:45 +00:00
Brian Salomon
d5e61572d0 Enable SurfaceContextWritePixels on iOS Metal
Bug: skia:11130
Change-Id: I3a39e32dc2e19bdfaf7799c689e6a4820b5a4cfc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391976
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-04-02 20:13:15 +00:00
Brian Salomon
2c673409ef Expose writing to mip levels via GrSurfaceContext::writePixels
Bug: skia:11786
Change-Id: Id17952db0aede56fa39845d9d371cf0a141f9dd7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391836
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-04-02 19:16:15 +00:00
Chris Dalton
f8d75c687d Don't use the recordTimeAllocator in GrOpsTask
This is a stopgap for dealing with OOM issues.

Bug: b/182959903
Change-Id: I25855b6fc1c9d8d270c1cb3fcbdc1c7f93623214
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391956
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Adlai Holler <adlai@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-04-02 18:04:35 +00:00
John Stiles
87011df3cf Allow ConstructorSplat to accept a scalar dest type.
Since the input must be a scalar argument of equivalent type, this is
just a no-op cast in practice (`float` to `float`, `int` to `int`). It
is harmless to allow it, and allows some call sites to be simplified.

Change-Id: I5a1a213fa3cf8c4afaabbbce3b34ab504792a267
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392340
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-04-02 17:09:05 +00:00
Derek Sollenberger
396cd1dfab Revert "Lift atlas clip FP creation out of GrClip::apply"
This reverts commit 92b35673c5.

Reason for revert: breaking the android roll (see ag/14076257)

Original change's description:
> Lift atlas clip FP creation out of GrClip::apply
>
> Atlas clips always had a potential point of failure: If the SDC's
> opsTask ever got closed between GrClip::apply and
> GrOpsTask::addDrawOp, their mask would have gotten sent to the wrong
> opsTask. It didn't _look_ like this could happen with the current
> code, but it could have also been inadvertently changed quite easily.
>
> This CL adds a "pathsForClipAtlas" array for GrClip::apply to fill out
> instead of creating FPs. The SDC then generates the actual clip atlas
> FPs once it knows exactly which opsTask they will belong in.
>
> Bug: chromium:928984
> Change-Id: I507ab13b2b5e8c3c3c1916d97611297dbbd8a522
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389926
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>

TBR=robertphillips@google.com,csmartdalton@google.com,michaelludwig@google.com,adlai@google.com

Change-Id: I9597d822a9f31b7070aee691ddf3a52f4f424a24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:928984
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392339
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2021-04-02 15:44:47 +00:00
Ben Wagner
348ee387a9 SkScalerContext::getImage less brittle.
Properly handle edge cases like
 * the temporary glyph being a different size than expected
 * filters which reduce in size
 * filters which return false to indicate no filtering has been done

Bug: chromium:1190525
Change-Id: Ibc53eb1d7014210019e96cd6bae3e256d967be54
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392156
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2021-04-02 14:52:45 +00:00
John Stiles
0cbd45421f Add enumerators for several additional constructor types.
This renumbers all the dehydrated data.

Change-Id: I8b39db576303c96e9b5b321fa2eb5fb2243920ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392298
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-04-02 14:15:05 +00:00
John Stiles
2938eea68c Represent splat constructors with a dedicated ConstructorSplat class.
Change-Id: Ic9c3d688b571591d057ab6a4e998f1f9712a1b58
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392117
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-04-02 13:14:05 +00:00
skia-autoroll
1b20cf0fe9 Roll Chromium from 24595a75dfc6 to f87374baeea3 (398 revisions)
24595a75df..f87374baee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: mtklein@google.com
Change-Id: Iedfab41ac812912b7040a2d8335a3c3780ae5689
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392216
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-02 05:12:04 +00:00
skia-autoroll
d4897f0d12 Roll Dawn from 3ceb65443c14 to a0bdba1dfc52 (6 revisions)
https://dawn.googlesource.com/dawn.git/+log/3ceb65443c14..a0bdba1dfc52

2021-04-01 cwallez@chromium.org Make Dawn's Tint version visible when recursedepsing in Dawn
2021-04-01 yunchao.he@intel.com Implement 3D texture copy on D3D12 backend: copy to entire 3DTexture
2021-04-01 cwallez@chromium.org Remove marking of CreatePipelineAsync as unsafe.
2021-04-01 brandon1.jones@intel.com Add GPUExternalTexture Types
2021-04-01 bryan.bernhart@intel.com D3D12: Improve NV12 checkerboard test image.
2021-04-01 cwallez@chromium.org SubresourceTrackingPerf: use the result of textureDimensions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: Ib8a1da7bdfcfff543df267dfc884eeec3ae39b51
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392140
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-02 04:58:04 +00:00
Ravi Mistry
42d753031d Display a Docs-Preview link for each modified MD file
Bug: skia:11824
Change-Id: I6bd557affca5ccf9f2936d86e2b0da168ceb2670
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/390577
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-04-02 01:08:04 +00:00
John Stiles
988b7043e5 Add rehydration enumerator for ConstructorSplat.
This renumbers all the dehydrated data.

Change-Id: I94c58c7f0b36e9832f47151b9d350e66f9fa01cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392118
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 22:57:34 +00:00
John Stiles
4118f14ab9 Add rehydration support for ConstructorArray.
This was accidentally overlooked during the initial migration.

Change-Id: I8d50207ecfdc5228e5f2b34bf0ed1bee33b5d650
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392116
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-04-01 22:57:06 +00:00
Chris Dalton
92b35673c5 Lift atlas clip FP creation out of GrClip::apply
Atlas clips always had a potential point of failure: If the SDC's
opsTask ever got closed between GrClip::apply and
GrOpsTask::addDrawOp, their mask would have gotten sent to the wrong
opsTask. It didn't _look_ like this could happen with the current
code, but it could have also been inadvertently changed quite easily.

This CL adds a "pathsForClipAtlas" array for GrClip::apply to fill out
instead of creating FPs. The SDC then generates the actual clip atlas
FPs once it knows exactly which opsTask they will belong in.

Bug: chromium:928984
Change-Id: I507ab13b2b5e8c3c3c1916d97611297dbbd8a522
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389926
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-04-01 20:21:18 +00:00
John Stiles
7384b37576 Represent array constructors with a dedicated ConstructorArray class.
Change-Id: Ia8c8a3476202257ecc100f9cb31e6d0095135aa1
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391919
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-04-01 18:52:43 +00:00
Brian Osman
358858fe4c Fix bots that don't like std::is_integral_v
Change-Id: I37202f26bd1d990f80528f490ccd7e99cbc2139f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/392056
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-04-01 18:49:43 +00:00
John Stiles
92f2d9340e Add new Rehydrator enum for Array constructors.
These changes cause massive ripple effects in the dehydrated code, so
they're being landed in their own CL.

Change-Id: Ia66bbe02dd58ed50da303f40480d396d75fa6ecd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391300
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 18:44:28 +00:00
Mike Reed
b09aaa2df4 Change filtering in drawPatch to linear.
This is mostly just to work around bug in raster backend.

Bug: skia:11822
Change-Id: I7c5af9dca36dac3eee4948f2a127fee6d314cf55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391916
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-04-01 17:41:13 +00:00
John Stiles
d8eb875e96 Add AnyConstructor base for all constructors.
Using an SkSpan, we can make a base class which encompasses every type
of Constructor while still letting the subclasses choose how their
storage is laid out.

Change-Id: I6faa3456acfb7e9e76725512bbe932935d17e017
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391778
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 17:38:13 +00:00
Joe Gregorio
786379f9bf [docsyserver] Turn on mermaid support.
Bug: skia:11799
Change-Id: Ic3ecdb31b0833285a72c1d9f8be03a89eb8be7ac
No-Try: true
Docs-Preview: https://skia.org/?cl=391821
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391821
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-04-01 17:36:08 +00:00
Joe Gregorio
5fa3b130fe [docsyserver] Add more documentation on Hugo/Docsy capabilities.
Bug: skia:11799
Change-Id: I504fd0cd65dd4dbf31d77b4b0efc692f072d94e8
No-Try: true
Docs-Preview: https://skia.org/docs/dev/tools/markdown/?cl=391876
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391876
Reviewed-by: Heather Miller <hcm@google.com>
2021-04-01 17:27:37 +00:00
Brian Osman
d18967c67d Add integer uniforms to runtime effects
Bug: skia:11803
Change-Id: I925f14be282b96355721986de6049090b35adf3d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391856
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2021-04-01 17:20:03 +00:00
Brian Osman
8b8ce4aa98 Add support for int uniforms to Metal and Vulkan
Bug: skia:11803
Change-Id: If4c2280585e192eec1b1588dfe022149543584bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391917
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-04-01 17:16:43 +00:00
Julia Lavrova
141b0aec13 Ignore \n metrics so it does not affect the layout
Bug: skia:11370
Change-Id: I17bf1304750be2c98f037bb8aebd65c525d836de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/388445
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-04-01 16:25:33 +00:00
skia-autoroll
c16efbd66e Roll skcms from c8a56c57ab7c to 411e27776f5c (1 revision)
https://skia.googlesource.com/skcms.git/+log/c8a56c57ab7c..411e27776f5c

2021-04-01 mtklein@google.com fix fuzzer bug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: mtklein@google.com
Change-Id: I2d0c3ad72746561bb5329e9ede53688be0b7882f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391817
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-01 16:00:03 +00:00
John Stiles
87fc657101 Revert "Run the inliner on GLES devices only."
This reverts commit 759bbf7b60.

Reason for revert: Pinpoint regressions when the inliner is off
http://go/crb/1194808#c7

Original change's description:
> Run the inliner on GLES devices only.
>
> We've found that the inliner only gives tangible gains in draw
> performance on GLES devices. (See go/optimization-in-sksl-inliner)
> On other devices, we can skip it and still get the same draw performance
> regardless. A caps bit has been added to indicate a device that will
> benefit from inlining, and the inliner is now disabled on platforms that
> don't set this bit.
>
> Change-Id: I61dfafd7e919deabf81529cea832bb11496410cc
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/390300
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,johnstiles@google.com

Change-Id: Ia9ab4db3c3e8a088afa84d4ad3105aa089bf5084
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391858
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 14:56:44 +00:00
John Stiles
7cbc0f9206 Revert "Enable the inliner on Intel Windows GPUs."
This reverts commit 6f67278428.

Reason for revert: Pinpoint regressions when the inliner is off
http://go/crb/1194808#c7

Original change's description:
> Enable the inliner on Intel Windows GPUs.
>
> Disabling it has caused regressions in some test slides.
> Example: http://screen/5dpPVnJukBAcyKb
>
> Change-Id: If302ffd39cd28215c557bbba444d9c8669dea1c8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391298
> Commit-Queue: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,johnstiles@google.com

Change-Id: Ida073fd2d467e6167564b8d019578910b9062e2a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391857
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 14:56:16 +00:00
John Stiles
626b62e09f Factor out MultiArgumentConstructor base class.
This is intended to reduce boilerplate across various constructors which
take a variable number of arguments (vector, array, matrix, etc.).
Today's "universal" Constructor class is now implemented as a subclass
of MultiArgumentConstructor.

Change-Id: Ie4ab601c0c1fb9d9e4d3e77f3346b203d8a62913
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391657
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 14:28:13 +00:00
John Stiles
933043b0e8 Factor out SingleArgumentConstructor base class.
This is intended to reduce boilerplate across future constructors which
can only take a single argument (matrix-resize, typecasting, etc).

Change-Id: I3f55928d83925d0770934dcb4bece193c5d51605
Bug: skia:11032
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391304
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-04-01 14:27:43 +00:00
skia-autoroll
7f38a89654 Roll Dawn from 864a36474205 to 3ceb65443c14 (11 revisions)
https://dawn.googlesource.com/dawn.git/+log/864a36474205..3ceb65443c14

2021-04-01 bajones@chromium.org Create RenderPipeline blueprints w/ RenderPipelineDescriptor2
2021-03-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 285b8b6e7522 to b4275c870ec2 (3 revisions)
2021-03-31 yunchao.he@intel.com Implement 3D texture copy: preparation
2021-03-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 55bc5409c297 to 285b8b6e7522 (8 revisions)
2021-03-31 cwallez@chromium.org Remove the ConvertTimestampToNanoseconds toggle.
2021-03-31 cwallez@chromium.org DeviceBase: Make object creation use ResultOrError<Ref<T>>
2021-03-31 cwallez@chromium.org Reassign some TODOs to a new bug for OpenGL buffer OOM
2021-03-31 yunchao.he@intel.com Move T2B copy helpers for D3D12 backend to UtilsD3D12.h|cpp
2021-03-31 cwallez@chromium.org Propagate more errors from reentrant calls
2021-03-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 02571d15e882 to 55bc5409c297 (7 revisions)
2021-03-31 bajones@chromium.org Implement validation for RenderPipelineDescriptor2

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 02571d15e882 to b4275c870ec2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: I3501a5a841d856b885a1e684505d943f0686f57f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391680
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-01 04:55:43 +00:00
skia-autoroll
f1126836f9 Roll Chromium from de65860ffd71 to 24595a75dfc6 (443 revisions)
de65860ffd..24595a75df

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: mtklein@google.com
Change-Id: I5737728cdc9c77f1bb4b9d5e9fcf70d2078df8e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391679
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-01 04:52:43 +00:00
skia-autoroll
3d358fe2e5 Roll skcms from 170996808234 to c8a56c57ab7c (1 revision)
https://skia.googlesource.com/skcms.git/+log/170996808234..c8a56c57ab7c

2021-04-01 mtklein@google.com B2A part 2, CLUT refactoring

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: mtklein@google.com
Change-Id: Ib8f02751a45beeb47e79dc33776761affbd5d71f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391344
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-04-01 03:23:03 +00:00
Herb Derby
bba1880625 allocate GrAtlasTextOp::Geometry on heap
I was mistaken about the life time of the RecordTimeAllocator.
Just allocate the geometries in the heap until an allocator can
be put on the GrSurfaceDrawContext.

Bug: b/182959903

Change-Id: I2378bf3c225acf3dfc153daf6eebb6cbf8ebbaff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391556
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-03-31 21:43:13 +00:00
Kevin Lubick
3d3562912f [gold] Update data produced by canvaskit and pathkit
New alerts realized CanvasKit and PathKit's data has not
been ingested after a change to validation.

Change-Id: I4648beec6a5c10e71959be79389193409991d15b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391439
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-03-31 21:26:27 +00:00
skia-autoroll
1e7e14ba34 Roll skcms from 5b3a2ab8be02 to 170996808234 (1 revision)
https://skia.googlesource.com/skcms.git/+log/5b3a2ab8be02..170996808234

2021-03-31 mtklein@google.com roundtrip any profiles we can

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: mtklein@google.com
Change-Id: I6cb7c09e7c1457bcecde24544b0efb744fbac992
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391340
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-03-31 21:06:43 +00:00
Brian Osman
3967588d75 SkSL: Add TypeKind::kFragmentProcessor
Change-Id: I1d77b9e10f9c92712f01473d3ae87b191cabb135
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391303
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-03-31 20:53:32 +00:00
Jim Van Verth
006fc6a2cd Use recycled transfer buffer for Metal readPixels.
Creating a new transfer buffer for each readPixels invocation can lead
to huge slowdowns as we progress through tests -- this should speed
things up considerably.

Change-Id: I8e2c2dd78c39d7b8724323637692e4ac185aba59
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391305
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-03-31 20:42:42 +00:00
Brian Salomon
d8db5884de ComparePixels helper takes GrCPixmaps
Change-Id: I56d902b652663df7893626d19bc88d18f980c02c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391301
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-03-31 20:38:22 +00:00
Mike Klein
0b4cc6d06c fix up skp versions on new M1 bots
Change-Id: If90e332f0979e8420365b88d440d0d3f7ce5e86a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391438
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-03-31 20:24:53 +00:00
skia-autoroll
a4d85e708b Roll skcms from 4e8691e28194 to 5b3a2ab8be02 (1 revision)
https://skia.googlesource.com/skcms.git/+log/4e8691e28194..5b3a2ab8be02

2021-03-31 mtklein@google.com dump src->xyz transform as %.2f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Tbr: mtklein@google.com
Change-Id: I4a3ef0bd1e5f687d2ec6fb1929fdffcfc22e72bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391337
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-03-31 19:44:12 +00:00