Commit Graph

3 Commits

Author SHA1 Message Date
Eric Boren
9d78afdd3d Revert "[infra] Move commands from isolates to gen_tasks.go"
This reverts commit 66db75da67.

Reason for revert: Breaking PDFium/Flutter

Original change's description:
> [infra] Move commands from isolates to gen_tasks.go
> 
> This has the side effect of bundling recipes for all tasks,
> which will be required anyway to run recipes in the future.
> 
> Bug: skia:7050
> Change-Id: Ia30a95c750f2a237a8bf60263b2981682673c043
> Reviewed-on: https://skia-review.googlesource.com/81300
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>

TBR=borenet@google.com,bungeman@google.com,rmistry@google.com,kjlubick@google.com

Change-Id: I38e00294f098ac91285a5cc464414654fc79a9e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/81741
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-12-07 14:54:11 +00:00
Eric Boren
66db75da67 [infra] Move commands from isolates to gen_tasks.go
This has the side effect of bundling recipes for all tasks,
which will be required anyway to run recipes in the future.

Bug: skia:7050
Change-Id: Ia30a95c750f2a237a8bf60263b2981682673c043
Reviewed-on: https://skia-review.googlesource.com/81300
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-12-07 14:45:30 +00:00
rmistry
eff1920deb Add new coverage_skia.isolate
Coverage is different from the other recipes because it needs both skia_repo and test artifacts. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined.

The isolate file will be used from the updated coverage recipe in https://codereview.chromium.org/1862713002/

BUG=skia:5159
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1893503003
2016-04-18 04:13:48 -07:00