scroggo@google.com
e490420efc
Ensure that SkMemoryStream does not crash dereferencing fData.
...
SkMemoryStream attempts to dereference fData in multiple places.
Instead of allowing it to be NULL, resulting in a crash, set it
to SkData::NewEmpty().
Add a test for SkStream that will crash when its SkData is set to NULL.
Review URL: https://codereview.appspot.com/7061059
git-svn-id: http://skia.googlecode.com/svn/trunk@7111 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 22:02:58 +00:00
jvanverth@google.com
74dda9018e
This takes the convex path tesselator from the Android code and hooks it into a
...
GrPathRenderer. GrAndroidPathRenderer is activated by gyp flag 'skia_android_path_rendering'.
A few changes to get this to work:
- Had to change SkPaint* param to SkStrokeRec& in ConvexPathVertices()
- Had to copy the vertex buffer created by the Android code to GrDrawTarget-generated vertex buffer, and convert float alpha to GrColor for AA paths
git-svn-id: http://skia.googlecode.com/svn/trunk@7110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 21:04:52 +00:00
jvanverth@google.com
a543b604e4
Add clear after each image save, so that GPU images won't end up progressively compositing on top of one another.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 18:22:53 +00:00
reed@google.com
b6c933cc9b
fix iOS build after adding modifierKeys to click events
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 16:36:30 +00:00
rmistry@google.com
e760445970
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7100 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 13:33:22 +00:00
skia.committer@gmail.com
4e73aa1566
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 02:01:30 +00:00
mike@reedtribe.org
732fbee1cb
speculative change to speedup blurrect bench for large radius, to see if the bots are timing out
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7098 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-09 00:59:11 +00:00
bsalomon@google.com
57585fa2c4
Turn off WarnAsError when building ANGLE projects on windows.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7096 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 21:46:05 +00:00
bsalomon@google.com
1d03ba98d3
Turn off warnings-as-error on 64bit windows build due to many size_t-related warnings.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7095 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 20:40:22 +00:00
bsalomon@google.com
50c79d886b
Enable warnings-as-errors on Windows.
...
Review URL: https://codereview.appspot.com/7066054
git-svn-id: http://skia.googlecode.com/svn/trunk@7094 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 20:31:53 +00:00
epoger@google.com
15655b241b
gm: remove --diffPath option and all other pixel diff functionality.
...
If you want pixel diffs, you need to run skdiff instead; from now on,
gm will only tell you WHETHER the images differed (not HOW they differed).
Review URL: https://codereview.appspot.com/7064047
git-svn-id: http://skia.googlecode.com/svn/trunk@7093 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 18:47:31 +00:00
bsalomon@google.com
5f429b098f
Fix signed/unsigned comparison in PictureTest.cpp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7092 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 18:42:20 +00:00
rmistry@google.com
14306e6802
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7091 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 17:59:54 +00:00
rmistry@google.com
57451ce27e
Rebaselined webpage image GMs for %s on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7090 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 17:57:12 +00:00
rmistry@google.com
fcf4a699b6
Rebaselined webpage image GMs for %s on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7089 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 17:52:58 +00:00
bsalomon@google.com
c3d753e345
Fix signed/unsigned comparison warning in PictureTest.cpp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7088 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 17:24:44 +00:00
reed@google.com
e378d83348
translate modifier keys for xevents
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7087 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:50:52 +00:00
bsalomon@google.com
6f47663000
Fix macro redefinition warning on 10.6 bots in mesa code.
...
R=humper@google.com
Review URL: https://codereview.appspot.com/7063050
git-svn-id: http://skia.googlecode.com/svn/trunk@7086 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:33:41 +00:00
reed@google.com
3792418358
fix linux build
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7085 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:25:42 +00:00
reed@google.com
72708fa18d
fix win build
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7084 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:22:44 +00:00
reed@google.com
4d5c26de0a
pass modifier keys to click events (e.g. control | shift etc.)
...
Review URL: https://codereview.appspot.com/7062054
git-svn-id: http://skia.googlecode.com/svn/trunk@7082 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:17:50 +00:00
humper@google.com
9aaf36de60
fix GPU drawing for 8 bit alpha bitmaps
...
BUG=
Review URL: https://codereview.appspot.com/7070052
git-svn-id: http://skia.googlecode.com/svn/trunk@7081 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 16:08:01 +00:00
rmistry@google.com
7492f4ea13
$(SVN_VERSION) -> $SVN_VERSION in build-tot-chromium.sh
...
Review URL: https://codereview.appspot.com/7071053
git-svn-id: http://skia.googlecode.com/svn/trunk@7080 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 15:56:15 +00:00
rmistry@google.com
6b69cbf98c
Script to checkout and build ToT chromium with ToT skia
...
Review URL: https://codereview.appspot.com/7036049
git-svn-id: http://skia.googlecode.com/svn/trunk@7079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 14:43:40 +00:00
robertphillips@google.com
eb928ea49a
Proposed fix to new stroking/path render selection system
...
https://codereview.appspot.com/7075043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7076 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 13:45:09 +00:00
reed@google.com
2b57dc6bb2
fix warings. add SkTAbs()
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 13:23:32 +00:00
reed@google.com
b5715a1c80
fix spelling: cannonical -> canonical
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 13:07:25 +00:00
rmistry@google.com
b54a5d6fb9
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 02:11:58 +00:00
skia.committer@gmail.com
4e8ef337bc
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7072 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 02:01:29 +00:00
reed@google.com
89d15a28b5
fix warnings
...
Review URL: https://codereview.appspot.com/7060053
git-svn-id: http://skia.googlecode.com/svn/trunk@7070 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 22:26:05 +00:00
reed@google.com
cb88d32b9f
fix warnings (float to int), and convert to skia-style
...
style examples:
- use const: (const SkRect&) instead of (SkRect&)
- spacing: (Type& r) instead of ( Type &r )
- use SK_OVERRIDE
Review URL: https://codereview.appspot.com/7066051
git-svn-id: http://skia.googlecode.com/svn/trunk@7069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 21:54:25 +00:00
reed@google.com
4cbb3a181e
disable warnings-as-error for JSON code, which has warnings (at least on mac)
...
Review URL: https://codereview.appspot.com/7064053
git-svn-id: http://skia.googlecode.com/svn/trunk@7068 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:51:13 +00:00
humper@google.com
fe0d680bcc
disable werror on 64 bit
...
BUG=
Review URL: https://codereview.appspot.com/7057057
git-svn-id: http://skia.googlecode.com/svn/trunk@7066 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:28:16 +00:00
reed@google.com
070dcd8ad3
abandon SK_IGNORE_TREAT_AS_SPRITE as a flag, and use SK_IGNORE_TRANS_CLAMP_FIX
...
for the fixes in SkDraw.cpp and SkBitmapProcState.cpp
Also, change the call in SkDraw.cpp to pass 0 for subpixel bits, to match the
old logic.... we should have a runtime fix for this in the future, so a caller
*can* get subpixel-filtered images w/ just translate.
git-svn-id: http://skia.googlecode.com/svn/trunk@7065 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:27:52 +00:00
reed@google.com
140d7286c5
fix warnings
...
Review URL: https://codereview.appspot.com/7073044
git-svn-id: http://skia.googlecode.com/svn/trunk@7064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:25:04 +00:00
humper@google.com
f286329ad1
fix warning in render pdf tool
...
BUG=
Review URL: https://codereview.appspot.com/7033056
git-svn-id: http://skia.googlecode.com/svn/trunk@7063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:08:56 +00:00
robertphillips@google.com
a7830dc6d8
Revert part of r7047 to check Xoom failures
...
https://codereview.appspot.com/7070049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7062 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:07:48 +00:00
humper@google.com
0e51577a14
fix warning from scalar --> int32 conversion
...
BUG=
Review URL: https://codereview.appspot.com/7065050
git-svn-id: http://skia.googlecode.com/svn/trunk@7061 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 19:54:40 +00:00
humper@google.com
af2bd7bdf5
hopefully fix gyp mistake for iOS
...
BUG=
Review URL: https://codereview.appspot.com/7065052
git-svn-id: http://skia.googlecode.com/svn/trunk@7058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 19:02:46 +00:00
jvanverth@google.com
9c4e5ac5b7
Cleaned up warnings in Windows build.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 18:41:28 +00:00
bsalomon@google.com
57313f6472
Fix warning-as-error for var used only in an assert (and therefore not in the release build).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7054 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 17:35:10 +00:00
bsalomon@google.com
21cbec4870
Remove GrTDArray.
...
Two dynamic array classes is enough.
R=reed@google.com
Review URL: https://codereview.appspot.com/7069047
git-svn-id: http://skia.googlecode.com/svn/trunk@7053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 17:23:00 +00:00
bsalomon@google.com
674a3a2ffd
Attempt to fix NULL to intptr_t warning-as-error on mac build.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7052 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 17:21:07 +00:00
humper@google.com
05af1afd42
eliminate all warnings in non-thirdparty code on mac
...
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.
Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.
Lots of unused variables removed, and one nasty const issue handled.
There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.
BUG=
Review URL: https://codereview.appspot.com/7067044
git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:47:43 +00:00
rmistry@google.com
30454293fd
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:30:35 +00:00
rmistry@google.com
97c982db07
Rebaselined webpage image GMs for %s on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:27:33 +00:00
humper@google.com
f515ffc3d4
Show the paint's typeface information in the details pane of the debugger.
...
Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Review URL: https://codereview.appspot.com/7065045
git-svn-id: http://skia.googlecode.com/svn/trunk@7048 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 15:48:19 +00:00
sugoi@google.com
e3453cbd20
This CL introduces a new path renderer.
...
Here are the characteristics :
- It uses the original path, before stroking
- It supports traight lines only (no curves)
- It supports butt or square caps only
- It supports miter or bevel joins only
- No AA support
Support for these will be added step by step later on.
A first pass at the benchmarks on my linux machine gave me these approximate speed improvements (running all bench with the option '--forceAA 0') :
path_stroke_small_long_line 4X
path_stroke_small_sawtooth 4X
path_stroke_big_rect 4X
path_stroke_small_rect 6X
path_stroke_big_triangle 4X
path_stroke_small_triangle 10X
lines_1_BW 1.5X
dashline_2_square 1.5X
dashline_1_square 1.5X
Also note that I can't submit this code until GrDrawTarget::isOpaque() is implemented, unless I just disable my renderer completely for now.
BUG=chromium:135111
TEST=The following gms are affected and may require rebaselining : lineclosepath, linepath, strokes_poly
Review URL: https://codereview.appspot.com/7026049
git-svn-id: http://skia.googlecode.com/svn/trunk@7047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 14:26:40 +00:00
caryclark@google.com
d68bc309bb
shape ops work in progress
...
cubic to quadratic experiment
git-svn-id: http://skia.googlecode.com/svn/trunk@7046 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 13:17:18 +00:00
robertphillips@google.com
2b4e5445d2
re-add SkRefPtr to SkRefCnt.h until all uses of it have been removed from Chrome
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7044 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 00:58:00 +00:00