Currently benches that set fIsRendering = false are run as part of the first config run. This is problematic for several reasons.
1) Which config they are run as depends on the --config options passed to bench. If I run bench --config GPU --config 8888 then they will be run in the GPU config and not the 8888 config.
2) Their presence makes bench take longer to run when testing rendering changes or comparing one rendering config to another (e.g. GPU v 8888). This is especially true on Android.
3) When comparing runs of a single config across multiple bench runs (typically with code changes) it isn't obvious from the output which benchs to ignore because they say are listed under as being part of the config.
This CL adds NONRENDERING as a config (open to name suggestions). Non-rendering tests are run in and only in the NONRENDERING config.
Will this screw up our bench bots/scripts/graphs? If so I think we should change them since running non-rendering tests separately makes a lot more sense than the current madness.
Review URL: https://codereview.chromium.org/12475012
git-svn-id: http://skia.googlecode.com/svn/trunk@8174 2bbb7eff-a529-9590-31e7-b0007b416f81
Some bots have lower speed sending http data out, and this will make it less likely to timeout.
Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions.
Current Skia data on our app instance: https://skiadash.appspot.com/report
Review URL: https://codereview.chromium.org/12703008
git-svn-id: http://skia.googlecode.com/svn/trunk@8133 2bbb7eff-a529-9590-31e7-b0007b416f81
There were only a few warnings left, so I fixed them and enabled the unused variable warning by removing the "-Wno-unused" flag. Only the -Wno-unused-parameter remains for now (could be removed later).
Review URL: https://codereview.chromium.org/12480002
git-svn-id: http://skia.googlecode.com/svn/trunk@8030 2bbb7eff-a529-9590-31e7-b0007b416f81
Share common code between bench_ and render_ to set up the PictureRenderer.
Fix an include error in SkPictureRenderer.h.
Simplified parameter passing in render_pictures_main.
Switch to using an SkAutoTUnref for the PictureRenderer.
I also changed the input format somewhat, so the buildbots need to be updated as well: https://codereview.appspot.com/7441044/
Fixed a bug in PictureBenchmark where calling setTimeIndividualTiles(false) sets the member variable to true.
Removed setDeviceType from PictureBenchmark, since only the PictureRenderer needs to know which device type to use.
Some changes to the input format:
'--logPerIter' no longer takes a 1 or 0. Instead, '--logPerIter'
turns it on and '--nologPerIter' turns it off (with off as the
default). (Note that this is for bench_pictures; bench still uses the old format)
Change '--device' to '--config' and 'bitmap' to '8888' to be
the same as gm.
Requires '--r' before inputs (to match gm), though there can be multiple inputs following it.
Changed --enable-deferred-image-decoding (which no one uses but me yet anyway) to --deferImageDecoding, since the former is incompatible with the flag parser.
Changes to behavior:
Show a short error message on failure (rather than the explanation of all
flags).
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.appspot.com/7230053
git-svn-id: http://skia.googlecode.com/svn/trunk@7961 2bbb7eff-a529-9590-31e7-b0007b416f81
Currently viewport bot data are only available for Android bots.
Please go to http://go/skia-buildbot to pick a green revision (-r) for an Android platform (-p). This can take a few minutes because Google Storage stores files in a flat structure instead of in directories.
Alternatively, download the bot data of interest into a local directory (or generate them from your machine) and set the script to read from there (-d).
Review URL: https://codereview.appspot.com/7093065
git-svn-id: http://skia.googlecode.com/svn/trunk@7729 2bbb7eff-a529-9590-31e7-b0007b416f81
