Hal Canary
c60dea17d8
style nit: s/RIGHT SINGLE QUOTATION MARK/APOSTROPHE/g when apropriate
...
Change-Id: If834febee09266cad6a7a2fb64b06adc25790e33
Reviewed-on: https://skia-review.googlesource.com/73742
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-11-20 19:09:18 +00:00
Hal Canary
7cbf5e3e03
SkPDF: simplify drawImage/Bitmap/Sprite code.
...
- SkImageSubset becomes SkKeyedImage
- SkPDFCanvas::onDraw{Bitmap, Image} go away
- Remove SkPDFCanvas: base classes now do the right thing.
- SkPDFDevice::draw{Bitmap,Image}{Rect,}() simplified
- 244 fewer SLOC.
All but a few PDFs are identical, those rasterize almost the same.
Change-Id: I3ceb3b8935c689719cedf1ad544b0407b5c1733e
Reviewed-on: https://skia-review.googlesource.com/22218
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-07-12 20:41:41 +00:00
halcanary
ca9654e4c6
documentation: update PDF design doc
...
NOTRY=true
Review-Url: https://codereview.chromium.org/2295373002
2016-09-28 11:19:52 -07:00
pdr
c42475cea2
Update markdown to use absolute image paths, fixing broken images
...
Markdown can be served with or without a trailing slash but when a
trailing slash is present, relative image links were broken.
The following example works as expected:
url: https://skia.org/dev/design/pdftheory
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png
The following example was broken before this patch:
url: https://skia.org/dev/design/pdftheory/
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png
The PdfLogicalDocumentStructure.png file lives in /dev/design/, not
/dev/design/pdftheory/. This patch updates all images in our markdown
files to be served with the full path so a trailing slash no longer
breaks images.
I hit this bug when promoting the new Skia debugger:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2128013003
Review-Url: https://codereview.chromium.org/2128013003
2016-07-07 14:48:53 -07:00
halcanary
3eac8d1b23
Doc: pdf illustration
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/1807963002
2016-03-16 10:19:33 -07:00
halcanary
6950de6c41
Comments Style: s/skbug.com/bug.skia.org/
...
DOCS_PREVIEW= https://skia.org/?cl=1432503003
Review URL: https://codereview.chromium.org/1432503003
2015-11-07 05:29:00 -08:00
halcanary
1139889eb3
Doc: update dev/design/pdftheory with new function call
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/967873002
2015-02-28 08:04:33 -08:00
halcanary
9ec0ffb77d
prettify site/dev/design/pdftheory
...
NOTRY=true
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/868473006
2015-01-26 07:45:47 -08:00
halcanary
211fcc6831
convert pdf design document to markdown
...
Review URL: https://codereview.chromium.org/849133002
2015-01-20 10:39:06 -08:00