Commit Graph

646 Commits

Author SHA1 Message Date
recipe-roller
c0b32b3355 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b5922385482112ce31df891af71854c81662d69e Remove jsonResult defaulting to null (martiniss@google.com)
  https://crrev.com/8eb708a2d5545c549ee462a193891ed7e30d430e [archive] Append file permissions stored in extra attributes (smut@google.com)


R=jcgregorio@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2077c009f11e0e2901c24489d04dcbe5633506f4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/217581
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-06-03 11:25:16 +00:00
recipe-roller
51ab616bcf Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c2ae1f8b058dc210e2f8b1753aa7184973da36a6 Remove stdout and stderr from expectation files. (gbeaty@chromium.org)


R=stephana@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc32b8c2c426c0bc60b0c57476258b649d9620d1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216355
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-28 19:24:02 +00:00
Joe Gregorio
2961ddb9ea Add Huawei P30 to the tree.
First bot is here:
   https://chromium-swarm.appspot.com/bot?id=skia-rpi-064

Bug: skia:
Change-Id: I60a4eb11a6aa187450c513c544ef5a3938695024
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215097
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-22 12:26:29 +00:00
Robert Iannucci
a848c3b829 Manual recipe roll
Changelog:

recipe_engine:
  https://crrev.com/125d102e429465dc3468b4b235f9e3a5df4b252c Reland: Refactor recipe engine step execution. (iannucci@chromium.org)
  https://crrev.com/13fa883dbdc89e258d7ef300035e4bba67bffc9f Replace paths in simulations sorted by -len. (iannucci@chromium.org)
  https://crrev.com/0aae08882d042675016c1f44da43457958fe8054 Treat any cmd0 containing path sep as relative. (iannucci@chromium.org)
  https://crrev.com/107d545f22f4f6923e46655032afb050c1945bd6 Roll swarming client (maruel@chromium.org)
  https://crrev.com/2e9624d2c517e450eb2d896171d9a058d9829989 [swarming] Start exposing new containment flags (maruel@chromium.org)
  https://crrev.com/b2103d4eb1f8a9380ec37299db6d0898bd014d12 Remove subprocess42 everywhere except the actual recipe step runner. (iannucci@chromium.org)
  https://crrev.com/41c54934d664b4034e5a42655a42e866f6ba8485 swarming: fix aliasing in dimensions, env_vars and env_prefixes (maruel@chromium.org)
  https://crrev.com/55fabf49b398f40fe4561f37ca5bac0eb9352e7e Move simulator stream engine to its own file. (iannucci@chromium.org)
  https://crrev.com/c262e24ab6137157a6c834fc38a127a886ba959a Extract debug command from the test subcommand. (iannucci@chromium.org)
  https://crrev.com/cc6f5c718d9336bc98b85a820d04bdefd6dfe2b8 Improve cmd0 resolution to account for absolute base paths. (iannucci@chromium.org)

depot_tools:
  https://crrev.com/6a9b00e433cff68ea348a22a9f46483fe9f1c197 scm: Replace invalid UTF-8 in Git output (raul@tambre.ee)
  https://crrev.com/09e64b49ee394043da081356be15e85e2ca86c08 Make presubmit scripts not inherit the executor script's context (raul@tambre.ee)
  https://crrev.com/25eb8e4680acaa931f1987557513bd5f35537333 Update colorama to 0.4.1 (raul@tambre.ee)


R=borenet@google.com

Change-Id: I77625c1620df3ef1b4c6ae05c172bb52bfefafbd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214692
Commit-Queue: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-20 18:02:05 +00:00
recipe-roller
622e36f783 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/43c083d5a4289d0f470be79c9d78b5b9916de3e5 Add missing options to git_rebase_update man page (dmcardle@chromium.org)
  https://crrev.com/5f6b911ad015b2660547353753bcfe50ae932fe2 Roll vpython. (iannucci@chromium.org)
  https://crrev.com/ccd2b4da9a7e6ddf126c0b4437db75201836154c Pruning old directories/ready files. (karenqian@google.com)
  https://crrev.com/80ee78e7fa9f84c3b36cc57e02034dc726d782af Convert print statements to Python 3 style (raul@tambre.ee)
recipe_engine:
  https://crrev.com/ec34fcd3b421c95e45a22bec90e9e676cd84928c Update implementation notes with information about magic_check_fn. (gbeaty@chromium.org)
  https://crrev.com/f95f160ff4e99f7c6b2e4cce06923e75cc158e26 Add beefier access control to StepData, remove StepDataAttributeError. (iannucci@chromium.org)
  https://crrev.com/a71df95b9d2348c680f05746607e12822d34517e Final simplification to RecipeResult. (iannucci@chromium.org)
  https://crrev.com/b4dac2345a45f448221fba393266fbcf541619db [buildbucket] Add search limit (nodir@google.com)
  https://crrev.com/a9d4612406b19eb642d31bff5b5a0705a783b5b0 Move StepData to its own file. (iannucci@chromium.org)


R=rmistry@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia9a9245089fb8cb46369f31b4acf5c3138a68e7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214660
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-05-20 12:33:25 +00:00
Eric Boren
ebc21f64cd [infra] Pin infra code using Go modules
Change-Id: I005740aef6ab8ba78f3da4d3b9d744ce3fb326e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211982
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-05-06 17:53:19 +00:00
Ben Wagner
4ed61653c4 Don't use tty in win_ssh_cmd.py
Fixes https://skia-review.googlesource.com/c/skia/+/204264. I should
have realized before that the '-t -t' option to ssh was the cause of all
the ANSI escape codes.

Change-Id: I43b745115f4672230bf28469e03fdfbaec602b9a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209041
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-04-30 17:05:42 +00:00
Ben Wagner
23935888a1 Check event log for all Windows tasks
Change-Id: Ie72515f5b9c64bb156fee81a0f28d6335b528978
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210240
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-04-29 16:03:35 +00:00
Brian Osman
83cecb5a85 Turn off warnings as errors in SwiftShader
Might fix the roll?

Change-Id: Ia041e7ee1fe5a3a8740dc3ad06c1e4bf36d0853b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210426
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-04-25 19:18:19 +00:00
Ben Wagner
a0dbedf089 [recipes] Fix Windows pathsep; add Windows tests
Change-Id: Ie74bc321dcd1a9150b55b36278e94acf1df34139
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210220
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-04-24 19:53:28 +00:00
Mike Klein
ba201aea74 make -Werror or /WX optional, off by default
Most external users complain about -Werror,
and I've heard anecdotally that devs find it annoying too.

This turns it off by default, but keeps it on the bots.

Change-Id: I6e87c92215261ebf6e961f816177386d5d58f28e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209787
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-04-23 20:39:34 +00:00
Ben Wagner
1875353110 Add LenovoYogaC630 (Win arm64 bot)
Change-Id: I70f4e01a2c55e85ee5e17a29f7f05a4a4aff2ae2
Bug: skia:8569 skia:8976
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204264
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-04-15 15:35:48 +00:00
Ben Wagner
53eab013f5 Factor common SSH logic into a new flavor.
Change-Id: I3e9acc3f8e2690169b3c76f9aec1ac22f6dfc93a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/205620
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-04-12 17:37:25 +00:00
Kevin Lubick
09d022cbb8 [pathkit] build with newer emscripten
Bug: skia:
Change-Id: I5576ec94cae42dd0e03079321e61f71292350808
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206389
Reviewed-by: Eric Boren <borenet@google.com>
2019-04-08 13:56:18 +00:00
recipe-roller
edf562397e Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/80e1d4b24dded35128a888c2de959ccd0dd8d140 Remove step exit code from test expectations. (iannucci@chromium.org)
  https://crrev.com/5c579aefde72744956934c8805273cd43f53cd1d Move StepConfig and friends to their own module, engine_step. (iannucci@chromium.org)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idcb76229ca11e137b200f5712617008d34490d3a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204286
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-28 13:15:52 +00:00
Ravi Mistry
d37e1b0fad [Recipe Modules] Make DefaultFlavor.step signature match the other step funcs
Bug: skia:8901
Change-Id: Ibe14ed88c0cd937eae2d91eb6e90391466098a2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203341
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 14:21:19 +00:00
Ravi Mistry
2719dff87a [Recipe Modules] remove_file_on_device was in all flavors except DefaultFlavor
Bug: skia:8901
Change-Id: Idde99d943c31ae62fcd0bc3f3b8cfc0ebc07e896
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 13:58:49 +00:00
Ravi Mistry
7dba6526bb [Recipe_Modules] read_file_on_device was in all flavors except the DefaultFlavor
Bug: skia:8901
Change-Id: Ieca2a053223434a0b6f49e9d9ef47a359b751dfe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202905
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-22 19:02:09 +00:00
Ravi Mistry
b804856c60 Add new AndroidOne SkottieTracing bot
Bug: skia:8884
Change-Id: Iff6e8da803c0cf76d4d2888af12e97b7491b0993
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201473
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-21 17:52:28 +00:00
Kevin Lubick
27ba7032be Add GN args for GL/GLES interface
Bug: skia:
Change-Id: I8445a6f3641aa43e7b18832c7c228b66dd321f2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201616
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-21 12:57:27 +00:00
Ravi Mistry
8d1956edd8 Add ability to skip adb binary push
This saves lots of time when we need to run dm/nanobench repeatedly and the binary is already on the device.

Bug: skia:8884
Change-Id: Ie0afbefbb350b5d3f57c39948b9483e8e2faa0e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201471
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-20 17:48:16 +00:00
Eric Boren
2a889a84a2 [infra] Remove bookmaker bots
We've decided to move in a different direction for Skia documentation.

Bug: skia:
Change-Id: I4acfe06e412006cdd3d692d017e51ecf3e98f4c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/198162
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2019-03-06 15:40:36 +00:00
Kevin Lubick
867da4b96e Allow system harfbuzz.
This should allow shaper to run on the no-deps bot.

Change-Id: I2515875d4e9b428681c20877630b904c3229ecc5
Reviewed-on: https://skia-review.googlesource.com/c/194420
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-23 12:14:30 +00:00
Ben Wagner
b1f5d619e8 Upgrade MacBookAir7.2 to macOS 10.14; rename jobs to include OS version
Also add a NativeFonts job for this bot so we have coverage of 10.14.

Change-Id: I8536d7725eb3492b59318695dd3ecadad76b68ff
Reviewed-on: https://skia-review.googlesource.com/c/194022
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2019-02-22 16:25:05 +00:00
Kevin Lubick
1ba9c4df77 [canvaskit] JS API in place for shaped text
Depends on https://skia-review.googlesource.com/c/skia/+/186870

It's optional at build time, which is good given that
it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB)

Bug: skia:
Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe
Reviewed-on: https://skia-review.googlesource.com/c/187924
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:39:55 +00:00
Robert Iannucci
f4d4b87269 [recipes] Manual roll.
Update package_repo_resource usage.

depot_tools:
  https://crrev.com/2b14855de938012c055713a2943dc10ca1a730d3 [cipd] Update CIPD 2.2.15 -> 2.2.16. (vadimsh@chromium.org)
  https://crrev.com/efc7e91fa76494f7f134926a384f4c0101ae982c [recipes] Manual roll. (iannucci@chromium.org)
  https://crrev.com/6344e8c6379b7eb5f05676e5489fff0c19eff894 [recipes] Manual roll (iannucci@chromium.org)
  https://crrev.com/9255c4f22809b69d9ca6c75727d3cc472c1e5518 Manual roll to unstick autoroller (iannucci@chromium.org)

recipe_engine:
  https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org)
  https://crrev.com/a30783346dbde9e790f38cab3d2bb132382e9341 [recipe_deps] Fix slash-separated recipe names on windows. (iannucci@chromium.org)
  https://crrev.com/7e953fd1856282691c74d0b32791e2cdd090803e [recipe_engine] Fix autoroll json output. (iannucci@chromium.org)

R=rmistry@google.com

Bug: 914992
Change-Id: I600be66b7a2663375f3e823e9a1fd4a2acfda65b
Reviewed-on: https://skia-review.googlesource.com/c/192922
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Robbie Iannucci <iannucci@google.com>
2019-02-17 21:24:01 +00:00
Kevin Lubick
402bf74ea8 Build code size treemaps for skottie_tool
Bug: skia:
Change-Id: I3364fa6b89674f65bf493467198740e1862d215e
Reviewed-on: https://skia-review.googlesource.com/c/191291
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-02-12 13:54:00 +00:00
Mike Klein
17593ae5aa add a -Wuffs bot
Change-Id: Idec98e922e81e062b78403bb83473e20a49dd13e
Reviewed-on: https://skia-review.googlesource.com/c/191292
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-02-11 21:02:33 +00:00
Ben Wagner
6c30e74dd0 Add DDL jobs for Intel
To work around skia:8709, I'm moving the DDL tests to IntelIris640. The
ASAN jobs still show memory leaks in the driver, but at least I can
identify which calls are leaking and suppress the LSAN warnings.

Adds an SK_ENABLE_SCOPED_LSAN_SUPPRESSIONS define that indicates that
the LSAN header files are available, which is set in recipes for the
Linux ASAN builds. Adds __lsan::ScopedDisabler in four locations for
two Vulkan API calls:
 - CreateGraphicsPipelines in GrVkPipeline::Create and
   GrVkCopyPipeline::Create
 - CreateDescriptorSetLayout in
   GrVkDescriptorSetManager::DescriptorPoolManager::DescriptorPoolManager
   constructor (2 calls)

Also adds a regular suppression for libxcb.so.

See bugs listed below for more details on the leaks.

Bug: skia:8710, skia:8712, skia:8713
Change-Id: I55c6e5d483b4aeed5cd44c64219539ca7214187f
Reviewed-on: https://skia-review.googlesource.com/c/184071
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
2019-02-06 15:53:32 +00:00
Brian Osman
5b4f2d5364 Add "MSRTC" bots that build/test with MSVC runtime checks enabled
Bug: skia:
Change-Id: I125466990b01b2fb1c9c30b2437a6bac134dda96
Reviewed-on: https://skia-review.googlesource.com/c/189302
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-05 17:13:24 +00:00
Kevin Lubick
9a2bb09202 CMake: distinguish between file and dir copies by presence of '.' in src path
ANGLE's build requires a file copy. Nema's build requires a dir copy. CMake
uses a different command for each. gn does not distinguish which. We make
a guess that happens to work for these two use cases based on the whether
the base file name of the src contains a '.'


Change-Id: I3503fd9d632abda3f8f952d0eef964019d932bea
Reviewed-on: https://skia-review.googlesource.com/c/188626
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-01 18:58:46 +00:00
Kevin Lubick
3105238ed5 Add CMake bot
It uses a docker container to handle the installation of CMake.

Depends on https://skia-review.googlesource.com/c/skia/+/188305/

Bug: skia:8732
Change-Id: Ib84a46b4f0ca7f88fca4e6123c1517a84f3444b2
Reviewed-on: https://skia-review.googlesource.com/c/188036
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-01-31 22:05:22 +00:00
Ben Wagner
71e0197a3c [infra] Increase post-ASAN-setup sleep time.
Pixels are still failing after ASAN setup, e.g.:
https://chromium-swarm.appspot.com/task?id=42b050e90e06a210
https://chromium-swarm.appspot.com/task?id=42b054a2d05dec10

Change-Id: Ife04b894ad01de69fa4639e97eba578f058cad0c
Reviewed-on: https://skia-review.googlesource.com/c/187788
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-01-29 17:59:58 +00:00
Ben Wagner
325778b888 Update android-skqp Docker image to accept licenses
Set DOCKER_CONFIG env var for all docker commands so that the Swarming
task uses the config created here:
https://skia.googlesource.com/buildbot/+/06aaf21b5d91a68de7c02aafc0fdee8531ba0c21/scripts/run_on_swarming_bots/install_docker.py#65

Bug: skia:8698
Change-Id: I731a99abc274caa498af8dde5142a7e6a6b6eca3
Reviewed-on: https://skia-review.googlesource.com/c/185690
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2019-01-22 23:34:58 +00:00
Ben Wagner
64b894b98c Try a workaround for the Pixel ASAN push failure
There have been many recent instances where ASAN tasks running on Pixel
devices have failed to push resources to the device due to
"secure_mkdirs failed: No such file or directory." The theory is that
because the "Setting up device to run ASAN" step reboots the device, the
device isn't actually ready at the time it reports being ready. This CL
adds a sleep to the ASAN setup to work around this problem.

Here are recent examples of this failure:
https://chromium-swarm.appspot.com/task?id=4279aeb78961de10
https://chromium-swarm.appspot.com/task?id=42765d9f44ca4610
https://chromium-swarm.appspot.com/task?id=427a66499846e910
https://chromium-swarm.appspot.com/task?id=4276d85a8f270d10
https://chromium-swarm.appspot.com/task?id=42765cb3ff062a10

Change-Id: Iddf78622de3cd88ea28a532380762baafe479eb7
Reviewed-on: https://skia-review.googlesource.com/c/185320
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2019-01-18 19:58:11 +00:00
Mike Klein
98dea7b11c remove superfluous skia_vulkan_sdk
We don't actually need the SDK to build anymore.

If you previously set skia_vulkan_sdk or relied on VULKAN_SDK
in the environment, now set skia_use_vulkan = true instead.

We still need the linux_vulkan_sdk asset for Test/Perf bots.

Change-Id: I70ad9c5181ae61725b9dc25cc887dd0640beeed6
Reviewed-on: https://skia-review.googlesource.com/c/184065
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-01-15 18:53:02 +00:00
Ben Wagner
1cefc0990d Reland "Remove win_vulkan_sdk."
This reverts commit 532c05fec1.

Reason for revert: Fixed by https://skia-review.googlesource.com/c/skia/+/181163

Original change's description:
> Revert "Remove win_vulkan_sdk."
>
> This reverts commit 876dc81f2a.
>
> Reason for revert: Breaking everything
>
> Original change's description:
> > Remove win_vulkan_sdk.
> >
> > We only needed this for the Vulkan headers, which we now have in
> > src/third_party.
> >
> > Change-Id: I453ed73c73b3304520b628527102607d848bcd37
> > Reviewed-on: https://skia-review.googlesource.com/c/180775
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,benjaminwagner@google.com
>
> Change-Id: I0ae35fddfc112631a47db9775d790f999abf26f8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/180779
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=egdaniel@google.com,benjaminwagner@google.com

Change-Id: I11a96646cd8f5d9ba9b617243ad4375c6037dbb8
Reviewed-on: https://skia-review.googlesource.com/c/181173
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2019-01-04 17:07:27 +00:00
Greg Daniel
7d06735443 Set skia_use_vulkan on our vulkan bots.
Bug: skia:
Change-Id: Ia7cdab1223ae3eb788e46e2cc4af552b03a2065f
Reviewed-on: https://skia-review.googlesource.com/c/181163
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2019-01-04 15:49:09 +00:00
Ben Wagner
532c05fec1 Revert "Remove win_vulkan_sdk."
This reverts commit 876dc81f2a.

Reason for revert: Breaking everything

Original change's description:
> Remove win_vulkan_sdk.
> 
> We only needed this for the Vulkan headers, which we now have in
> src/third_party.
> 
> Change-Id: I453ed73c73b3304520b628527102607d848bcd37
> Reviewed-on: https://skia-review.googlesource.com/c/180775
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,benjaminwagner@google.com

Change-Id: I0ae35fddfc112631a47db9775d790f999abf26f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/180779
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2019-01-03 22:32:07 +00:00
Ben Wagner
876dc81f2a Remove win_vulkan_sdk.
We only needed this for the Vulkan headers, which we now have in
src/third_party.

Change-Id: I453ed73c73b3304520b628527102607d848bcd37
Reviewed-on: https://skia-review.googlesource.com/c/180775
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-01-03 21:51:25 +00:00
Ben Wagner
2e342cd52c [infra] Uninstall ASAN when cleaning up Android device.
Change-Id: I417f87aefe3c5684366d05703f1065c6e7c77ea0
Reviewed-on: https://skia-review.googlesource.com/c/180379
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2019-01-02 20:49:23 +00:00
Ben Wagner
bb7d3813d3 [infra] Set GOCACHE in tasks that use go.
Bug: skia:8423
Change-Id: If079c958cb9d0d82fe13da44aaebd5913b40b9d1
Reviewed-on: https://skia-review.googlesource.com/c/179065
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-12-19 15:09:59 +00:00
Ben Wagner
435880277e [infra] Use go_deps asset for Bookmaker tasks
Fix PATH to point to go_deps/bin.

Bug: skia:8423
Change-Id: I853a0741238442e7fd5b3c23cacb3d2f9c6893fa
Reviewed-on: https://skia-review.googlesource.com/c/179064
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-12-19 14:41:32 +00:00
Mike Klein
fe64e00997 bump NDK packages to r19-beta2
Originally this started as a bump to r18, the latest stable release.
That's why each packages goes up two versions, from r17 -> r18 ->
r19-beta2.

But our ASAN bots started failing with r18, and despite quite a bit of
investigating, I've been unable to find anything wrong with our code.

Luckily, r19 is coming soon, and it looks like its beta2 works fine.
I think we should just skip r18.

Original change's description:
> bump NDK packages to r18
>
> Newer Clang, GCC is gone.
>
> Clang now supports half-float math on ARMv8, which is pretty neat.
>
> They've dropped support for everything below NDK version 16,
> which happens to be what we target for 32-bit ARM.
>
> Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
> Reviewed-on: https://skia-review.googlesource.com/157260
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Cq-Include-Trybots: skia.primary:Test-Android-Clang-Pixel-CPU-Snapdragon821-arm64-Release-All-Android_ASAN
Change-Id: I0736558fc9b732113854b1b295642e1708b04581
Reviewed-on: https://skia-review.googlesource.com/c/157761
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-17 20:07:36 +00:00
recipe-roller
32def82f12 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/143872d11b6f4faa095be0f8c2615bd681eb485b Update git recipes to use buildbucket API. (jsca@google.com)
recipe_engine:
  https://crrev.com/5e53d73e9bcec42830e10b835bc328eb75c9423f [path] Use 'cleanup' dir in mkdtemp and mkstemp (sergeyberezin@google.com)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9e038e4eedad70f1d4133c98c591a09459823a84
Reviewed-on: https://skia-review.googlesource.com/c/177077
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-17 12:46:15 +00:00
Ravi Mistry
a067690acf Revert "[infra] Flutter bot should sync to origin/skia-master"
This reverts commit 8061053b73.

Reason for revert: skia-master branch no longer exists

Original change's description:
> [infra] Flutter bot should sync to origin/skia-master
> 
> Bug: skia:
> Change-Id: I223bef522ff8605674f4ecabcbd0624cfc92cb06
> Reviewed-on: https://skia-review.googlesource.com/c/173224
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: I3a40a0c6f4a354650d354f2eb4f9d20defe70a0a
Reviewed-on: https://skia-review.googlesource.com/c/178023
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-12-16 22:09:11 +00:00
Brian Osman
ef3d04e796 Use descriptive path name for win_toolchain on the bots
Also includes an update of the go_deps asset from
https://skia-review.googlesource.com/c/skia/+/176996

Bug: skia:
Change-Id: I3b7abf746793d6a4883e1703d705847cadfe97e9
Reviewed-on: https://skia-review.googlesource.com/c/176973
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-12 19:03:08 +00:00
Mike Klein
8a0d0460e6 add -Tidy bot
Change-Id: Ia8d942735cdd1c52a78be02b53f532433abacbc4
Reviewed-on: https://skia-review.googlesource.com/c/176977
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-12 17:13:10 +00:00
Brian Osman
044044f5a2 Update win_toolchain, and refactor how it's built
The old win_toolchain script required a Chromium checkout, and
extracted portions of the win_toolchain from that to build the
Skia asset. Instead, use the depot_tools script that assembles
a toolchain from a locally installed MSVC.

The create script doesn't do that, but relies on the user to
run that script first. Automating everything would be a nice
follow-up.

With the new strategy, the toolchain directory is simpler, and
no longer contains the depot_tools kruft or extra directories.
Adjust the bot scripts accordingly. (Renaming the directory to
win_toolchain from 't' would be a nice touch, too).

Finally, I built the new toolchain with the updated process,
and included the ARM64 compiler and libraries, so we can set
up a bot to build Windows ARM64.

Docs-Preview: https://skia.org/?cl=176968
Bug: skia:8569
Change-Id: I4bdf3cfb29d50f4464853445d0226241e70c33b4
Reviewed-on: https://skia-review.googlesource.com/c/176968
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-12-12 15:50:16 +00:00
recipe-roller
d5cf51da90 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/793d8faa696f62fa2c774b8c854bbf4d64dff24e Separate InfraFailure behavior from StepFailure behavior. (jchinlee@chromium.org)


R=jcgregorio@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I324b1d8b7a0d4c0fb8bc4c059a34b3e75ccbd8fd
Reviewed-on: https://skia-review.googlesource.com/c/173434
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-12-04 21:43:35 +00:00
Ben Wagner
9e9723137f Add jobs for GalaxyS9
Change-Id: I039eb2050edc2570287c331a3f7743b4a3748f3e
Reviewed-on: https://skia-review.googlesource.com/c/173239
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-11-29 19:32:04 +00:00
Eric Boren
8061053b73 [infra] Flutter bot should sync to origin/skia-master
Bug: skia:
Change-Id: I223bef522ff8605674f4ecabcbd0624cfc92cb06
Reviewed-on: https://skia-review.googlesource.com/c/173224
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-11-28 17:34:05 +00:00
Mike Klein
66fec0e289 remove -Mini bot, enabled effects in -NoDEPS bot
Now that we've got Flutter builds I'm not very interested in the old
-Mini bot, which was always a proxy for something like Flutter's build.

The NoDEPS bot shouldn't have to disable effects, I think.

Change-Id: I57abca5935b7da3917eb804cda10967af0a18f41
Reviewed-on: https://skia-review.googlesource.com/c/169221
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 16:59:56 +00:00
Kevin Lubick
e70c6b13dd Update emsdk-release image
Bug: skia:
Change-Id: I780912e1c481765d2d17d2ce66a27470ee8b4912
Reviewed-on: https://skia-review.googlesource.com/c/168483
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-06 13:21:34 +00:00
recipe-roller
96ea340182 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/9afc6490c14847e5d73fb041f0def4d95f36821b Manual roll for new run logic (martiniss@google.com)
recipe_engine:
  https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08 Always use new run logic (martiniss@google.com)


R=jcgregorio@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6d406af7bc8f38e95a98b046b5d0719b4adeac7
Reviewed-on: https://skia-review.googlesource.com/c/166622
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-31 16:38:00 +00:00
Kevin Lubick
3d99b1e347 Add Correctness tests for CanvasKit
Also make a CPU only and GPU only build (although
the latter still has a lot of CPU logic).

Bug: skia:
Change-Id: I857c2300021c2adb5344865c28e4ad3e8d332954
Reviewed-on: https://skia-review.googlesource.com/c/162022
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-16 14:32:28 +00:00
Kevin Lubick
3655e4059e Have BuildStats use Flutter's stripped lib
That's what their treemap says and we should try to match it.

Bug: skia:
Change-Id: Iefa95c0440eb6b45a94a72c1beffb8a1199152a4
Reviewed-on: https://skia-review.googlesource.com/c/161825
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 21:32:54 +00:00
Kevin Lubick
a60a1945eb Add Vulkan to BuildStats-Mini
Bug: skia:
Change-Id: I320b7945e5e2939404e039cb83831b2bb408aaac
Reviewed-on: https://skia-review.googlesource.com/c/161842
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-12 18:37:37 +00:00
Kevin Lubick
37baac128f Remove old code size analysis
Was replaced with:
https://skia-review.googlesource.com/c/skia/+/160220
https://skia-review.googlesource.com/c/skia/+/160765
https://skia-review.googlesource.com/c/skia/+/160920

Bug: skia:
Change-Id: Ia87f4d548cd33dcd6c21c3711aef65ac2dab9f60
Reviewed-on: https://skia-review.googlesource.com/c/160940
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-10-10 14:25:17 +00:00
Kevin Lubick
2626104520 Track Skia's Code size in Flutter
This creates a nice readable display, since Bloaty
doesn't allow filtering through the CLI.

Additionally, rename the flutter job to accurately
represent what settings it actually is (32 bit ARM built
with clang).

Bug: skia:
Change-Id: Iaed313caf43a31105adc8c85c545cc6cb2bcbe30
Reviewed-on: https://skia-review.googlesource.com/c/160920
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-10 14:24:57 +00:00
Ravi Mistry
eea245c896 Turn down CT_* bots
Specifically, turn down:
* Perf-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Release-All-CT_BENCH_1k_SKPs
* Perf-Ubuntu14-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-CT_BENCH_1k_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_DM_100k_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_DM_1m_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_IMG_DECODE_100k_SKPs

Also deletes the no longer needed recipe_modules:
* ct
* isolate
* skia_swarming
* swarming
* swarming_client

Bug: skia:8455
Bug: skia:6704
Change-Id: Ia4912830909081d060f7361706d16fd751b3bda0
Reviewed-on: https://skia-review.googlesource.com/c/160764
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-09 15:05:24 +00:00
Kevin Lubick
8e9750d3c5 Add CanvasKit build
Building CanvasKit uses very similar logic to PathKit, so there
was a fair amount of copy/paste/customize.

Fixes the name of skia.js/wasm -> canvaskit.js/wasm and
adds a package.json to formally track versions.

Also move PathKit helper scripts to align better.

Docs-Preview: https://skia.org/?cl=160463
Bug: skia:
Change-Id: Ie75b30592dcc4d520dca41f6f5579006aaa8849b
Reviewed-on: https://skia-review.googlesource.com/c/160463
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-09 13:56:56 +00:00
Kevin Lubick
35b87a5b44 Add Build and Test jobs for SKQP using docker.
Uses Docker to compile an APK and then run it on an emulator.

We use a specialized image for build (includes Clang, etc)
And then the 3rd party base image for just the test (which
has the emulator and SDK on it).

Bug: skia:7578, skia:7692
Change-Id: I948e0b091868e7173b00e3affd7c3d59a5cd1ec2
Reviewed-on: https://skia-review.googlesource.com/c/159681
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-10-08 19:17:25 +00:00
Kevin Lubick
4968843293 Add BuildStats pipeline for PathKit binaries
This should be extensible to do something similar
for libskia and other outputs.

Bug: skia:
Change-Id: Id9f30a82f4eb0e7ce868a32409b1be429917e7f6
Reviewed-on: https://skia-review.googlesource.com/c/160220
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 18:15:32 +00:00
Nodir Turakulov
473b40b7ca Populate repo_path_map
checkout/api.py populates patch_projects mapping which has no effect.
All of its usages were migrated to repo_path_map mapping.
Populate repo_path_map instead.

R=rmistry@chromium.org

Bug: 694348
Change-Id: I4fc6fe86565f75f4b4b5b5ca041f584d30fcd8a5
Reviewed-on: https://skia-review.googlesource.com/155632
Auto-Submit: Nodir Turakulov <nodir@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-09-19 19:59:21 +00:00
Eric Boren
858f648bda [infra] Update recipe deps, fix usage of bot_update
Bug: skia:
Change-Id: I3829035a33a3bf147dd4ca90a0a45443a5b28eb6
Reviewed-on: https://skia-review.googlesource.com/154042
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-09-12 18:58:29 +00:00
Kevin Lubick
1b5ece0f06 Add mesa_intel_driver asset and dockerfile for creating
This deletes the previous hand-built drivers and the
distinction between a debug and non-debug driver.

Bug: skia:
Change-Id: Ia733783d703da803f76361c61b938d9ce70c88f0
Reviewed-on: https://skia-review.googlesource.com/150163
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-09-11 21:30:33 +00:00
Eric Boren
3867d59050 [infra] Revert broken recipe rolls, add test for missing patch_ref
A recent upstream CL caused our trybots to stop providing the
--patch_ref flag to bot_update:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1174988

Unfortunately, we did not have a "normal" trybot as part of our tests,
so we did not catch it during the roll:
https://skia-review.googlesource.com/c/skia/+/151984

Bug: skia:
Change-Id: I2a02a2e1923715a685448ce5f4d58a93de51c3ef
Reviewed-on: https://skia-review.googlesource.com/152741
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Edward Lemur <ehmaldonado@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-09-07 19:54:48 +00:00
Mike Klein
5b741e19c2 remove -k 0 from builds
We added this a while ago while debugging some many-files-failing
build failures, but keeping -k 0 now just makes single failures
harder to find in the log.  Now the first failure will stop the
build and be at the bottom of the log.

Change-Id: I1ed2825f2c64702a228903067230356f09b90046
Reviewed-on: https://skia-review.googlesource.com/152589
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-09-07 18:48:55 +00:00
recipe-roller
33dc0dc9f6 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/01f0c698fb898168940718c5616ed3f6bb6c1b18 bot_update: Specify the target branch for patch_refs. (ehmaldonado@chromium.org)


R=rmistry@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibd4e7c583706b717ab2b0db68d619ed914bf8c5d
Reviewed-on: https://skia-review.googlesource.com/151984
Reviewed-by: Edward Lemur <ehmaldonado@google.com>
2018-09-05 22:39:40 +00:00
Kevin Lubick
82999c037e Add docker-based infrastructure for Gold/lottie-web integration
This adds 2 docker containers (based on the ones used for PathKit
added in https://skia-review.googlesource.com/c/skia/+/147042)
which bundle Chrome and puppeteer to allow the lottiecap.js
to be run anywhere.

This adds a recipe (test_lottie_web.py) to drive the docker
container and do a little bit of set-up (and a few docs/bug
fixes discovered in the test_pathkit.py that it was based on).

Additionally, this modifies lottiecap.js to support POSTing
output to a running go server (again, the same as PathKit)
which has the image data hashed and the metadata added to
a large JSON output.

This re-works driver.html to avoid re-loading the JSON object
25 times. The performance boost is important because, right now,
the lottie files are processed individually.

In a future CL, I want to address the two TODOs in
lottie-web-aggregator.go

Bug: skia:8108
Change-Id: I100c9ce23dcc5033a27287211cbf0db898960da9
Reviewed-on: https://skia-review.googlesource.com/149282
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-28 15:16:22 +00:00
Ben Wagner
31629a8a32 [infra] Rename PowerVR jobs to be consistent.
Add "PowerVR" to GT7600, GT7800, and GX6450 (iOS jobs).

Add model number G6430 to NexusPlayer.

Change-Id: Id0beb9e25ac793378fcd353836a43b2ea9db1aef
Reviewed-on: https://skia-review.googlesource.com/148668
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-23 12:21:19 +00:00
Ben Wagner
7ea54289d2 Remove extra Mac CPU jobs.
This is a followup to
https://skia-review.googlesource.com/c/skia/+/145431

Also clean up old job names in recipe expectations.

No-Try: true
Change-Id: Ic63a64a98fb39076680941bb2415b7bb64415179
Reviewed-on: https://skia-review.googlesource.com/148671
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-22 18:44:24 +00:00
Kevin Lubick
f14a3c059f [PathKit] Add asm.js build and test jobs
Consolidates the karma files into one for docker/asmjs/wasm and all
combinations.

The asm.js build seems to have some small imprecisions that we didn't
see as much as with WASM, probably due to JS limitations/differences
to c++'s floats.

To address these, I've marked some (5) tests in PathOps* as flaky
because they fail on Release, Debug or Test versions of the asm.js build.

Other then that, asm.js seems basically identical to the WASM.

WASM is much smaller, 416k vs 877k and seems to load faster (not
measured).

Note to reviewers:
example.html was copied from npm-wasm version, so doesn't need
further review.

Bug: skia:8216
Change-Id: Ib92b90fa6c598de85a0be319d46b25693ae5aaa4
Reviewed-on: https://skia-review.googlesource.com/148396
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-22 17:19:10 +00:00
recipe-roller
16c8c54cec Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/7de5f08c459c9d66880cacb1253961009d7feee3 bot_update: remove --gerrit_repo and --gerrit_ref. (jbudorick@chromium.org)


R=benjaminwagner@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I94c3a040ec5a9606a75a6dc9856e1de686772820
Reviewed-on: https://skia-review.googlesource.com/147811
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
2018-08-17 19:10:16 +00:00
Kevin Lubick
a0ba612bb2 [PathKit] Adding test infrastructure to support Gold output
To get the gold images out of the browser tests, this adds
testReporter.js and pathkit_aggregator.go.  testReporter bundles
up the output as a base64 encoded PNG and sends it over the local
network to pathkit_aggregator.  pathkit_aggregator will keep
a list of test results reported in this way and write the PNGs
to /OUT of the container (which is the swarming output directory).
Finally, after all the tests are run, the helper script "test_pathkit.sh"
makes a POST request that creates the JSON file that gold expects
(following the schema https://github.com/google/skia-buildbot/blob/master/golden/docs/INGESTION.md)

pathkit_aggregator takes many command line arguments which control
the keys that Gold needs in order to ingest and handle the data.
Of note, this creates a new set (i.e. source_type) of gold images
called "pathkit", which will distinguish it from "gm", "image", etc.

There will be at least 2 sub-sets of "pathkit" images, "canvas" and "svg",
(representing the 2 output types of PathKit).  This CL doesn't
quite handle SVG yet, as it needs a way to convert SVG to PNG in the
browser and will be addressed in a follow up CL.

A "standard" gm is sized at 600x600. This was arbitrarily picked.

Note that the functions in testReporter.js return Promises based
on the fetch requests to post the data. This eliminates the race
condition between the /report_gold_data and /dump_json since
running the karma tests won't return until all reports are done.

Other changes of note:
 - Adds go to karma-chrome-tests container.
 - renames recipe_modules/build/wasm.py -> pathkit.py to be consistent with
the name of test_pathkit.py and make for easier grepping.
 - Increases the JS test timeout to 10s (up from 5) to hopefully avoid
the flakes seen in the Debug Test.

Bug: skia:8216
Change-Id: Ic2cad54f3d19cc16601cf2e9a87798db1e6887a2
Reviewed-on: https://skia-review.googlesource.com/147042
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-15 19:25:42 +00:00
Ben Wagner
30a4e3da4b Add Win OpenCL Build job.
Bug: skia:8081
Change-Id: Ibcb82389668bd9ea7395e498696417d5701761c0
Reviewed-on: https://skia-review.googlesource.com/140782
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-08 00:27:48 +00:00
Kevin Lubick
641bf8745d [PathKit] Add more Path2D functionality and move some methods to be members
Adds arc, arcTo, rect and Path2D names for quadTo, cubicTo, close.

Adds conic verb support (approximated with 2 quads).

Breaking changes:
Some functions have been moved to be member functions:
PathKit.Simplify(path) -> path.simplify()
PathKit.ToCanvas(path, ctx) -> path.toCanvas(ctx)
PathKit.ToSVGString(path) -> path.toSVGString()
PathKit.ToPath2D(path) -> path.toPath2D()
PathKit.ToCmds(path) -> path.toCmds()
PathKit.ResolveBuilder(builder) -> builder.resolve()
PathKit.GetBoundaryPathFromRegion(region) -> region.getBoundaryPath()

Pathkit.ApplyPathOp(pathOne, pathTwo, op) still exists, but there's
now also pathOne.op(pathTwo, op) for cases when that's easier.

As per custom with version 0.x.y projects, I'm bumping the
minor version (in npm) for these breaking changes instead of the
major version (which will happen when we are version >= 1.0.0).

This also has some small improvements to the output code size.
The biggest jump was from enabling the closure compiler on the
helper JS, which trimmed it down by about 40%. Using the closure
compiler requires the JRE on the bots, which prompted the emsdk-base
image change.

Bug: skia:8216
Change-Id: I40902d23380093c34d1679df0255bcb0eaa77b01
Reviewed-on: https://skia-review.googlesource.com/145420
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-08-06 19:07:12 +00:00
Eric Boren
9d834581da [infra] Add new go_deps asset
This contains the Go code dependencies of our infra repo and will be
used to insulate us from upstream changes which break us due to API
changes, etc.

Bug: skia:
Change-Id: I6ce36a4e41b6d7686fe2598ba980640854cd4f11
Reviewed-on: https://skia-review.googlesource.com/145158
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-08-03 18:33:24 +00:00
Ben Wagner
cdfa16d086 Use XCode from CIPD. Include xSAN dylibs in Build task isolated output.
Change-Id: I0eb3dcc4d38eb2aeab22d1df1515e499cf21dc62
Reviewed-on: https://skia-review.googlesource.com/144608
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-03 17:14:14 +00:00
Kevin Lubick
b3d0e3e1d9 Add Debug version of PathKit
This adds a job to build it and adds it to the npm
under /bin/debug.

The debug build is useful for clients because it
has all the debug symbols, which makes it possible to
see which WASM calls are taking the longest when using
DevTools' Performance testing.

Bug: skia:8216
Change-Id: I3068cb395f29c1de927508cf15c419f5af284eb7
Reviewed-on: https://skia-review.googlesource.com/145337
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-08-03 16:54:20 +00:00
Kevin Lubick
30cc00c642 Add job for building PathKit to WASM using Docker
This creates a new named cache docker for this and future
docker-based jobs to use, to avoid permission snafus with
the normal "work" named cache.

Remove old WASM build, which was using the janky CIPD
emsdk asset and wasn't really exercising what we needed.

Bug: skia:8216
Change-Id: I993bba38b4978ca5eebb97e5b5b21729d55a072d
Reviewed-on: https://skia-review.googlesource.com/145140
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-03 15:08:42 +00:00
recipe-roller
da77c7f91f Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5300616351f523c605de80f5ece8c29321a78847 bot_update: expose patch_refs as an option to ensure_checkout. (jbudorick@chromium.org)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3719ebfe726d6662c0e3b8a9f4e21ca62000a292
Reviewed-on: https://skia-review.googlesource.com/145144
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-08-03 11:20:51 +00:00
Ben Wagner
e0e41efe44 [infra] Ensure Mac xSAN backfill tasks can find Xcode.
This CL prepares for installing Xcode in a Swarming cache dir from a
CIPD package. https://skia-review.googlesource.com/c/skia/+/144608

After that, I hope to isolate the xSAN libs in the Build task so that
we don't need Xcode on the xSAN test bots. Baby steps.

Change-Id: I61dbe9474eceff42cbfd824c429db382b68a8c35
Reviewed-on: https://skia-review.googlesource.com/145143
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-08-02 15:35:12 +00:00
Ben Wagner
174d7f61ba [infra] Ensure Build-Mac backfill tasks can find Xcode.
This CL prepares for installing Xcode in a Swarming cache dir from a
CIPD package. https://skia-review.googlesource.com/c/skia/+/144608

Change-Id: I123a409f97397cc0e87de0dcd05d7ea08d3c0524
Reviewed-on: https://skia-review.googlesource.com/144903
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-02 11:08:30 +00:00
Eric Boren
8c172ba397 [infra] Add infra support for Lottie
Bug: skia:8136
Change-Id: I18c4ad549c52346ebfe23d172597d5da205e5c4d
Reviewed-on: https://skia-review.googlesource.com/142105
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-07-19 17:53:25 +00:00
Cary Clark
eb1d9004f5 build for gdb on linux
build debug on linux for gdb

Building with this define enables additional
checks for standard library functions when
running gdb, and allows printing std::string.

R=halcanary@google.com

Bug: skia:
Change-Id: I7f2dc12336f9239443328f13264be7a6b285c4b5
Reviewed-on: https://skia-review.googlesource.com/140786
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-on: https://skia-review.googlesource.com/141083
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-07-17 18:09:41 +00:00
Eric Boren
d7425b1465 [infra] Determine Android device location based on bot ID
Bug: skia:
Change-Id: Ic68bbca59c2fd5d0ffd9bae29fe0f90e090e8b06
Reviewed-on: https://skia-review.googlesource.com/140342
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-07-10 19:54:58 +00:00
Ben Wagner
a5e703043f Add OpenCL test job that runs hello-opencl.
Add NEO driver to opencl_linux asset.

Bug: skia:8081
Change-Id: Ic36c670f3cabd73119845e94fcb2f54525e83443
Reviewed-on: https://skia-review.googlesource.com/138264
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-29 13:25:17 +00:00
Ben Wagner
55a7d22beb Add OpenCL build.
Bug: skia:8081
Change-Id: I8b2a88cc25970398511aa078d456ca8a1182792b
Reviewed-on: https://skia-review.googlesource.com/136594
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-29 13:06:57 +00:00
Ben Wagner
2b3808eda2 Add hello-opencl to BUILD_PRODUCTS_ISOLATE_WHITELIST
Split from https://skia-review.googlesource.com/c/skia/+/136594 for
easier review.

hello-opencl was added in
https://skia-review.googlesource.com/c/skia/+/136223

Bug: skia:8081
Change-Id: I6535be8b51e95f0f481d48648c5327dc92a02d3b
Reviewed-on: https://skia-review.googlesource.com/138266
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-06-28 20:34:27 +00:00
Mike Klein
54d7b314c8 rename Chromecast bots to Clang
We updated them to use Clang a while ago but forgot to rename the bots.

Change-Id: I01c353b48d5aff7a30d63d382bdf6bdfb3e0b196
Reviewed-on: https://skia-review.googlesource.com/137887
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-06-27 18:51:58 +00:00
Stephan Altmueller
978b0bb173 [infra] Remove PixelC bot
No-Tree-Checks: true
Bug: skia:
Change-Id: Ib0a5ad3df31f4fca9ab0085a5ba1d174419eee57
Reviewed-on: https://skia-review.googlesource.com/136220
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-06-21 15:02:18 +00:00
Eric Boren
cd0a98c0d1 [recipes] Simplify test/perf dirs
Bug: skia:6473
Change-Id: Iee2f195ddf4bbcdabc1580f2a021d2e9a07ff0b2
Reviewed-on: https://skia-review.googlesource.com/133441
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-06-20 17:50:18 +00:00
Eric Boren
ea290808b0 Add Chromium to DEPS for CommandBuffer bots
Bug: skia:6951
Change-Id: I094b542c6930e0789db71474650235b3ce991054
Reviewed-on: https://skia-review.googlesource.com/136022
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-20 13:55:18 +00:00
Ben Wagner
96aa535b78 Remove .bat and .exe from commands where possible.
We expect .BAT and .EXE to be on PATHEXT. Also, although Python
CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most
commands to be platform-independent, and also resolves the issue with
the cpython package not including python.bat.

No-Tree-Checks: true
Docs-Preview: https://skia.org/?cl=135626
Bug: chromium:852581
Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
Reviewed-on: https://skia-review.googlesource.com/135626
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-19 17:29:15 +00:00
recipe-roller
2c8bc68a41 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/cd8d4a659a2b622f4cc2674896ace670c57e9ad3 gclient recipe: use env_suffixes insetad of custom ENV manipulation. (tandrii@chromium.org)


R=benjaminwagner@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I668725d3215e19b55b86900edb2813cade6a1dbc
Reviewed-on: https://skia-review.googlesource.com/134662
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-06-14 14:48:17 +00:00
Ben Wagner
47fd204aa6 Remove remaining references to G930A.
Jobs were removed in https://skia-review.googlesource.com/c/skia/+/131524

Change-Id: I9d6d484c25ee6af325adf6089f8a1c3acafd22e5
Reviewed-on: https://skia-review.googlesource.com/134020
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
2018-06-12 12:53:23 +00:00
Ben Wagner
57f8fcd422 When compiling SwiftShader, set BUILD_TESTS=OFF.
After https://swiftshader-review.googlesource.com/c/SwiftShader/+/19228,
SwiftShader fails to build without third_party/googletest unless
BUILD_TESTS is disabled.

Bug: skia:8054
Change-Id: If365fbbfc42dd3c41cc57be0fd7d494e7f83589d
Reviewed-on: https://skia-review.googlesource.com/133832
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-11 17:13:54 +00:00
Eric Boren
e8b38ab432 [recipes] Make ct_skps use binaries from a build task
Bug: skia:6473
Change-Id: I10a169dd47cb76839fd401254eaeb4c46b2ece8f
Reviewed-on: https://skia-review.googlesource.com/128549
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-08 21:14:02 +00:00
Brian Osman
2d7678d61f Update MSVS toolchain for bots:
MSVC 14.14.26428
SDK  10.0.17134.0

Docs-Preview: https://skia.org/?cl=132409
Change-Id: I02686531804ac026b92bceed29dc28d246fe4902
Reviewed-on: https://skia-review.googlesource.com/132409
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-06 16:59:04 +00:00
Mike Klein
a3750b2aa0 build for Chromecast with clang
I don't think this switches to libc++... just from GCC to Clang.

Change-Id: I755464161d030668e34ab79f4a77d9807ddc8e3f
Reviewed-on: https://skia-review.googlesource.com/131520
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-06-01 19:41:56 +00:00
Eric Boren
322a859bda Reland [recipes] Isolate build outputs with no subdirs
Bug: skia:6473
Change-Id: I730cb860abc72473aaa9af98527fd220b9a55120
Reviewed-on: https://skia-review.googlesource.com/131389
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 15:18:46 +00:00
Eric Boren
fbe7166685 Revert "[recipes] Isolate build outputs with no subdirs"
This reverts commit 0c9d2805e8.

Reason for revert: Broke iOS and SwiftShader (and maybe others)

Original change's description:
> [recipes] Isolate build outputs with no subdirs
> 
> Bug: skia:6473
> Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c
> Reviewed-on: https://skia-review.googlesource.com/130942
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: Icf9490f2f88dc454c6d971f35258e219137b0c0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:6473
Reviewed-on: https://skia-review.googlesource.com/131400
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 11:53:46 +00:00
Eric Boren
0c9d2805e8 [recipes] Isolate build outputs with no subdirs
Bug: skia:6473
Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c
Reviewed-on: https://skia-review.googlesource.com/130942
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 11:45:15 +00:00
Brian Osman
6dce0a72e0 Enable GPU support in MSAN builds
Don't want to test GPU with MSAN, but I'd like to make GPU support
required for DM and other internal tools.

Bug: skia:
Change-Id: I5f1a7669242be9767aa3b579b39740a1741977f3
Reviewed-on: https://skia-review.googlesource.com/131143
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-05-31 18:01:14 +00:00
Eric Boren
4184608344 [recipes] Add parameters to checkout module
Pass in the behavioral switches, rather than deriving them from the
builder name inside the module.

Bug: skia:6473
Change-Id: I2cbf67d5c450ae7e0fa319d983431d26505f0b67
Reviewed-on: https://skia-review.googlesource.com/130846
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-30 19:02:18 +00:00
Mike Klein
6857df77b0 remove EmbededResouces bot
The skia_embed_resoucres flag in GN is gone.

(Both misspellings sic, seriously.)

Change-Id: Ic4424fcea264010ff1cce390b4fd260897c15677
Reviewed-on: https://skia-review.googlesource.com/130147
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-25 18:55:42 +00:00
Ben Wagner
e7e6e22912 Retry ADB commands on all devices.
Change-Id: Ieb289043bd871ec45c70339787ae45f09d3ac1dc
Reviewed-on: https://skia-review.googlesource.com/130128
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-25 15:24:22 +00:00
Ben Wagner
ef839a96ff Use EGL and GLES headers from Khronos.
Bug: skia:7671
Change-Id: Idae96b08f02768f180c7223bdcddb4dead3a5a1b
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123588
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-24 19:45:49 +00:00
Eric Boren
90f050387a [recipes] Rename some modules and files
- Move doxygen and binary size out of core and into their own modules.
- Rename core -> checkout since that's all it does, shorten method names.
- Rename flavors:
  - Everything is GN, so remove GN/gn_ everywhere.
  - Merge gn_flavor into default.
  - Shorten file / module names.

Bug: skia:6473
Change-Id: I8ac9ff9c9a267f366206b9991adfa5eb37126ca7
Reviewed-on: https://skia-review.googlesource.com/129176
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-24 14:06:55 +00:00
Robert Phillips
b4303caa98 Add a Win10/QuadroP400 SKPBench bot
This will be the baseline (aka non-DDL) bot with which we can compare the DDL times

Change-Id: I9a949447845d31560136d591a0c1a17e7be57ac9
Reviewed-on: https://skia-review.googlesource.com/129506
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-23 13:19:21 +00:00
Ben Wagner
d26e446927 Rename SwiftShader bots from CPU to GPU.
Bug: skia:7671
Change-Id: I1d6b2a07ca93acbe53c1e93d70335f5284cd494e
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129500
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-22 16:33:05 +00:00
Kevin Lubick
0e42586036 Make ASAN setup of Android bots more fault tolerant
Bug: skia:7975
Change-Id: I3f123337913870a921d1c09714873eaf2949e88f
Reviewed-on: https://skia-review.googlesource.com/129364
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-21 20:14:08 +00:00
Eric Boren
dd8b1fc41b [recipes] Remove a bunch of unnecessary expectations
Bug: skia:6473
Change-Id: Ic2eee8074476c449cc9bed4701105609e91ea12b
Reviewed-on: https://skia-review.googlesource.com/128929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 14:26:44 +00:00
Eric Boren
72f6668eb7 [recipes] Move a lot of logic out of vars module
In general, vars should only contain variables which are the same for
all tasks.  Variables specific to compilation belong in the build
module (or compile recipe), and those specific to running tests belong
in the flavor module, or the individual recipe which uses them.

Bug: skia:6473
Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a
Reviewed-on: https://skia-review.googlesource.com/128545
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 11:58:14 +00:00
Kevin Lubick
7673f3ba9e Specify the ADB keys to use for ADB
In the golo, specifically, the adb keys used by swarming
are different than those used in the docker instance, unless
configured otherwise.

This means swarming can think a device is ready (authorized)
but the adb we called was not (authorized)

BUG: 843284
Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0
Reviewed-on: https://skia-review.googlesource.com/128930
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-17 19:28:43 +00:00
Chris Dalton
2b937f54c2 Add MoltenVK_Vulkan bots
Adds a prebuilt MoltenVK framework asset from:

KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec

And creates bots that use it.

Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-17 17:35:23 +00:00
Eric Boren
2fbde26018 [recipes] Normalize SwiftShader build dir
Bug: skia:6473
Change-Id: If145e2c29ddafdafaf9b8ed3fecbd6a6de31ac0a
Reviewed-on: https://skia-review.googlesource.com/128481
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 14:37:44 +00:00
Ravi Mistry
fedc8476cf Use Chromium ToT instead of lkcr
https://chromium.googlesource.com/chromium/src/+/lkcr has not been
updated in months now.
CT uses Chromium ToT and has rarely run into problems because of that.

Bug: skia:7917
Change-Id: I007b8f29b2320ffbc45ab5c5a75b081fbb8d7afa
Reviewed-on: https://skia-review.googlesource.com/128319
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-16 14:36:54 +00:00
Eric Boren
f3a21d0540 [recipes] Move 'gclient runhooks' from flutter build to core
Bug: skia:6473
Change-Id: I89b384668a6a45eaae9995ad8f7b404a1b7f9824
Reviewed-on: https://skia-review.googlesource.com/128318
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 12:56:54 +00:00
Eric Boren
0f69010549 [recipes] BUILDTYPE and SKIA_OUT are no longer used
Bug: skia:6473
Change-Id: I67b0dbf6dba26233df1d8e44f3e2f69ca0cc9d3e
Reviewed-on: https://skia-review.googlesource.com/128320
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:36:23 +00:00
Ravi Mistry
5ab841f18b Add chromium first to .gclient
Bug: skia:7917
Change-Id: Ie76c73c5b8ea24ca0ac54e79ad7597fdac19d860
Reviewed-on: https://skia-review.googlesource.com/128011
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-15 19:28:43 +00:00
Mike Klein
77bc821b03 asan_device_setup has moved
Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f
Reviewed-on: https://skia-review.googlesource.com/128016
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 19:44:40 +00:00
Eric Boren
9030b94c60 [recipes] Separate build and test flavors
Bug: skia:6473
Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a
Reviewed-on: https://skia-review.googlesource.com/125947
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-14 17:27:49 +00:00
Eric Boren
b702316d9a [recipes] Remove core.setup()
Each recipe now includes its own setup steps.

Bug: skia:6473
Change-Id: I97eab2cd63f5004c07408e844cbbed735aac355f
Reviewed-on: https://skia-review.googlesource.com/125660
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-04 18:23:13 +00:00
Eric Boren
44a68b3b3b [infra] Remove PDFium bot and associated recipe code
Bug: skia:7890
Change-Id: I8322b145800dc41ac59322e89804ff9356d8e767
Reviewed-on: https://skia-review.googlesource.com/125864
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-04 14:59:32 +00:00
Eric Boren
2f62de01d3 [recipes] Mostly remove bot_update patch_ref hack
We need to do some refactoring to remove the repository hack for
cross-repo tryjobs.

Bug: skia:6473
Change-Id: Ie96fba75f6f1752575a4c7cc5b0208a37f0bd73d
Reviewed-on: https://skia-review.googlesource.com/125724
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-03 14:37:31 +00:00
Eric Boren
5cb5c74efd Reland "[recipes] Use named caches for git and workdirs"
This reverts commit 01d3eb64e7.

Bug: skia:
Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f
Reviewed-on: https://skia-review.googlesource.com/124260
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-27 18:18:48 +00:00
Ben Wagner
01d3eb64e7 Revert "[recipes] Use named caches for git and workdirs"
This reverts commit e8615f969e.

Reason for revert: Causing CommandBuffer builds to time out

Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

----------------

Revert "[infra] Fix missing cache for Bookmaker"

This reverts commit d19f039a16.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

----------------

Revert "Fix missing/duplicate named caches"

This reverts commit 0820a6fb69.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

----------------

TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com

Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 22:21:04 +00:00
Eric Boren
e8615f969e [recipes] Use named caches for git and workdirs
Bug: skia:
Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
Reviewed-on: https://skia-review.googlesource.com/123929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 18:51:13 +00:00
Kevin Lubick
88611a1a71 Update test expectations for Debian9
The removal of the blacklists is really a no-op because of
https://skia-review.googlesource.com/c/skia/+/9339

Bug: skia:7840
Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909
Reviewed-on: https://skia-review.googlesource.com/123925
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-26 17:16:53 +00:00
Adrienne Walker
6f719aeeae Add CheckGeneratedFiles recipe check for gpu workarounds
Followup to https://skia-review.googlesource.com/122800

Bug: chromium: 829614
Change-Id: Idde753e0f8943290208625ba5b6332a5fdc07184
Reviewed-on: https://skia-review.googlesource.com/123536
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 19:26:27 +00:00
Ben Wagner
122b38560f Add SwiftShader Test jobs.
Bug: skia:7671
Change-Id: I29134929071ba6c59de948e5f579d33e973f9baa
Reviewed-on: https://skia-review.googlesource.com/122541
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-23 15:01:40 +00:00
Eric Boren
5c2ed720ec [infra] Fast-forward recipes, re-enable roller
Bug: skia:
Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1
Reviewed-on: https://skia-review.googlesource.com/122300
Auto-Submit: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 14:06:50 +00:00
Eric Boren
7817931a5c Switch RecreateSKPs and Bookmaker bots to use service accounts
Bug: skia:
Change-Id: I59aefe7c7e7a6861b00f0e22310e7ceaff3d6d0e
Reviewed-on: https://skia-review.googlesource.com/122944
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 13:00:19 +00:00
Ben Wagner
bbdee1befa Add SwiftShader Build jobs.
Bug: skia:7671
No-Try: true
Change-Id: I34015cceca538c84d87a77b6688fa1490c620d04
Reviewed-on: https://skia-review.googlesource.com/121425
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-20 16:45:25 +00:00
Kevin Lubick
bc54533b2b Fix Chromecast bots
The psuedo-tty allocation seems to have been wrong and switching
to Kitchen exacerbated the matter.

Bug: skia:
Change-Id: Ie44d3952383d89d398722837e7bbc51798e5833e
Reviewed-on: https://skia-review.googlesource.com/122304
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-19 14:39:56 +00:00
Eric Boren
9599b0fd91 Reland "[infra] Run recipes through Kitchen"
Bug: skia:7050
Change-Id: Icf0bcfbbc505c90a4e8cee7437037a3037bdf33b
Reviewed-on: https://skia-review.googlesource.com/121781
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-19 11:27:46 +00:00
Eric Boren
8ff86a6f38 [infra] Support recursive configs in builder_name_schema
This fixes problems with Upload- tasks which just prefix other types of
task names.

Bug: skia:
Change-Id: Icdbcfc5a889e821c6923f635eae0744c3cb0133c
Reviewed-on: https://skia-review.googlesource.com/121786
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-17 18:56:24 +00:00
Eric Boren
bd2e1f1ca6 Revert "Reland "[infra] Run recipes through Kitchen""
This reverts commit f39bbe5a31.

Reason for revert: Broke lots of bots

Original change's description:
> Reland "[infra] Run recipes through Kitchen"
> 
> Bug: skia:7050
> Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
> Reviewed-on: https://skia-review.googlesource.com/121481
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com

Change-Id: I4548c66a9cb0b4f105e2bc3b1c7185d14549172f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/121463
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-17 11:28:54 +00:00
Eric Boren
f39bbe5a31 Reland "[infra] Run recipes through Kitchen"
Bug: skia:7050
Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
Reviewed-on: https://skia-review.googlesource.com/121481
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-17 11:13:53 +00:00
Eric Boren
276886160b Revert "[infra] Run recipes through Kitchen"
This reverts commit 7bbb26fee0.

Reason for revert: uploads broke task scheduler

Original change's description:
> [infra] Run recipes through Kitchen
> 
> Bug: skia:7050
> Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4
> Reviewed-on: https://skia-review.googlesource.com/82500
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,rmistry@google.com

Change-Id: Ic3a5404fde844f01eca551d50039a84a20e84e11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/121423
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-16 13:21:07 +00:00
Eric Boren
7bbb26fee0 [infra] Run recipes through Kitchen
Bug: skia:7050
Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4
Reviewed-on: https://skia-review.googlesource.com/82500
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-16 12:07:05 +00:00
Ben Wagner
9bd736b9b4 Add loongson3a Build jobs.
Change-Id: I4a0259f82272099e08df0e7dea91489f6d641ca4
Reviewed-on: https://skia-review.googlesource.com/113670
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-04-04 20:37:28 +00:00
Mike Klein
378679cc47 add Mac ASAN bots
Change-Id: I783c0ad51a33e4731470f457132a1d20025a3431
Reviewed-on: https://skia-review.googlesource.com/118342
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-04 16:42:18 +00:00
Mike Klein
21aa7b8f24 limit cpu features of skcms on bots we limit skia
Valgrind doesn't support half<->float x86 conversion instructions,
so we build those bots with SK_CPU_LIMIT_SSE41.  We now also need
to limit skcms on those same bots.

Easiest thing to do is build completely portable scalar code, using
the existing -DSKCMS_PORTABLE.  We can get fancier later if needed.

Change-Id: Icf14c72a220818be9df7b97bcf203e4412c3c6b7
Reviewed-on: https://skia-review.googlesource.com/118264
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-04-03 19:57:20 +00:00
Mike Klein
a48caa5601 remove CC,CXX,CPPFLAGS from compile environment
I don't believe any of these have any effect now that all
builds are done through GN.  My best recollection is that
they used to affect GYP-based builds.

Change-Id: Ifde9f7c4d531dab43e8d407fc779d2ab6e38411c
Reviewed-on: https://skia-review.googlesource.com/118263
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-03 19:25:31 +00:00
Mike Klein
e7d5bb7493 update Ubuntu14 CT bots to Clang
To run on these older bots, looks like we need to statically link
libstdc++ and libgcc.  Luckily that is straightforward.

Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd
Reviewed-on: https://skia-review.googlesource.com/115743
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-03-22 23:53:09 +00:00
Ben Wagner
ed4ff9c9d0 Reland "Switch Win Exceptions Build to Clang."
This reverts commit 2f2419b936.

Reason for revert: Creating CL to reland

Original change's description:
> Revert "Switch Win Exceptions Build to Clang."
> 
> This reverts commit e1cb4778c7.
> 
> Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093
> 
> Original change's description:
> > Switch Win Exceptions Build to Clang.
> > 
> > No-Try: true
> > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
> > Reviewed-on: https://skia-review.googlesource.com/113673
> > Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@google.com,benjaminwagner@google.com
> 
> Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/114420
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=mtklein@google.com,benjaminwagner@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1
Reviewed-on: https://skia-review.googlesource.com/114822
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 20:54:37 +00:00