Commit Graph

41003 Commits

Author SHA1 Message Date
Brian Osman
4cd0734f4c Remove bookmaker sources and data files
We're moving in a different direction for Skia documentation. We no
longer run bookmaker on the bots, and things have already degraded such
that it can't be run. This leaves the generated markdown in place for
the last set of docs that were generated (which are still useful until
the Doxygen docs catch up).

See also: https://skia-review.googlesource.com/c/skia/+/198162

Docs-Preview: https://skia.org/?cl=203464
Bug: skia:
Change-Id: I2f967a9c17dbc1cc899947d365071ef69cfb8ad7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203464
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 18:56:29 +00:00
Mike Klein
171284fb1a clean up stray libpng deps
I don't know why libpng is all over the place like this,
but it really only is used by SkPngCodec, by DM, and by
a few unit tests.

Change-Id: I60908d9412cbac819c9e29154c5aba6e924f099a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203192
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-25 18:52:49 +00:00
Greg Daniel
bb792aae8c Add option to disable vsync on viewer unix.
This also fixes an issue where vulkan would crash any time we change a
display param on unix.

Bug: skia:
Change-Id: Ic6c3843e04bc77c2e9c5301ee38fcc58a409495d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203380
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-25 18:24:29 +00:00
Brian Osman
65f3344294 Clean up texture domain effect GM, wrt proxy creation
Bug: skia:
Change-Id: I114daee3b3f8ffeeec36a3355a53750604ca1038
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203389
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 18:16:05 +00:00
Brian Osman
f2ae6af713 Stop flooding perf with uninteresting GPU stats
We only care about two things: RT binds and shader compiles. RT binds
should be constant frame-to-frame, and shader compiles should always be
zero on frame 2, so just measure on frame 1.

Bug: skia:
Change-Id: I4defa0a6dc79413b375ec60b5024fa57e768b127
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203391
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 18:04:44 +00:00
Greg Daniel
a51e93c9a0 Fix up readPixels, writePixels, and copies when dealing with ycbcr textures in vulkan.
In general this makes sure we never directly read or write pixels or use one of
the vk image copy functions if we are dealing with a VkImage that requires a Ycbcr texture.

Bug: b/129037735
Change-Id: Ib3bbac8bcddb643942e08d2b2ae3381fda6758a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203388
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-25 17:49:28 +00:00
Mike Klein
c6142d855c de-common the rest of the flags
Turns out lots of tools had two copies of many of these flags.

Some GN and .cpp file refactoring to make sure when flags are
present in a binary, they do something in that binary.

I think this finally finishes the flag refrag.

Change-Id: I01488e37ab73a5c4361786863ddb137a7f1095b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203420
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-25 17:39:58 +00:00
Kevin Lubick
0223bd01d8 Delete in favor of autogenerated file
Follow up to https://skia-review.googlesource.com/c/skia/+/203386

Change-Id: I841ecfc3b7babc6c6bf9925b3bf0988f6b057dab
Bug: skia:8474
NOTRY: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203390
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-25 17:32:18 +00:00
skia-autoroll
a9fa7b87f3 Roll third_party/externals/angle2 eae464dd3092..9078c6a7199b (1 commits)
eae464dd30..9078c6a719


git log eae464dd3092..9078c6a7199b --date=short --no-merges --format='%ad %ae %s'
2019-03-25 jonahr@google.com Update necessary angle_end2end_tests to check the Android device name


Created with:
  gclient setdep -r third_party/externals/angle2@9078c6a7199b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Idb4590b68e7ff2d0d966a0e8e8fd61332f3348d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203331
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 16:58:48 +00:00
Brian Osman
dbe93221c2 Fix GM that was trying to create mip-mapped proxies without checking caps
Bug: skia:
Change-Id: Iafd6a7cc1288b7287bb5d127e542e530647d74d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203387
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 16:53:18 +00:00
Brian Salomon
41f9c3cde9 Avoid special shader for opaque alpha when drawing simple rectangles.
It's a wasted shader compiler and also seems to cause a rendering bug
in Windows Chrome on ANGLE.

Bug: chromium:942565
Change-Id: I56373ac596d4d1548d6c86cda7127bf12190a0ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203383
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-03-25 16:51:58 +00:00
skia-autoroll
d1630203fb Roll third_party/externals/swiftshader e24bc66dcda3..221459f4ecc9 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e24bc66dcda3..221459f4ecc9


git log e24bc66dcda3..221459f4ecc9 --date=short --no-merges --format='%ad %ae %s'
2019-03-25 headlessclayton@gmail.com Work around another MSVC bug with variadic macros.


Created with:
  gclient setdep -r third_party/externals/swiftshader@221459f4ecc9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I98392d77c530ab11d73511a5d07a01c9189011c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203330
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 16:26:48 +00:00
Kevin Lubick
7b1cf20d47 Delete old assembleInterface code
Was breaking Google3 roll

if https://skia.googlesource.com/skia.git/+/93b3dce89d0cada44fd619571d55a1c83b751f70
is reverted, this should also be reverted

Change-Id: Ic065d89a8a06f1752644e7b8453f50ae3934f68c
Bug: skia:8474
NOTRY: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203386
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
2019-03-25 16:08:48 +00:00
Brian Osman
42197c0bc6 Add support for 1010102 on ES2 devices with EXT_texture_type_2_10_10_10_REV
Bug: skia:8894
Change-Id: Id3dbc02894f87dcf81f65048945692e54cca38f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203059
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 15:32:18 +00:00
Ravi Mistry
e298294fc6 Add new Intel x86_64 CPU SkottieTracing bot
NoTry: true
Bug: skia:8901
Change-Id: I4bb90a37ee7afdfb3634e1b04e5a244a77d2b5ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202907
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 15:15:04 +00:00
Michael Ludwig
2839884b79 Respect stroke width in Android rrect clip optimization
Bug: b/113636985
Change-Id: I80df664a077751e9ce5c735694e7ba283e93bcc1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203170
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-03-25 15:09:59 +00:00
Ravi Mistry
1a3c397dcc [Recipe] Add CPU bot capability to perf_skottietrace.py
Bug: skia:8901
Change-Id: I6e0f2b57987a60c1d4f2d2dc0d92df640d15e08d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202906
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-03-25 15:09:58 +00:00
Kevin Lubick
93b3dce89d Generate GrGLInterface and GrGlAssembleInterface* from table
This CL creates a go program that takes a JSON file of
GPU functions and creates the assemble and validate code
based on that.

This approach will hopefully will lessen the need for
"shotgun surgery" anytime a new function/extensions is added.

Additionally, it should be easier to add a new standard
(concretely, WebGL) using this technique.

There are a few potential bugs/mismatches in the current
implementation that this has identified, for example,
Requiring GL 3.x for adding a feature, but only verifying
it is there on GL 4.x - I did not attempt to correct these
bugs in the old version, as we will hopefully be able to delete
that version and use the generated files.

Bug: skia:8474, skia:8378
Change-Id: Ie8144bbab8e03f2c815fd942fa9f7f91dedba101
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202137
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-25 15:03:48 +00:00
Brian Osman
7dcc616279 Reland "Simplify two more clients of proxy provider (mipped vs. non-mipped)"
Adds fix for mip-mapped requests on devices with no mip support.

This reverts commit ab4c138c0e.

Bug: skia:
Change-Id: I85350ae32081253448cbd2f636ea3044eb9df453
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203057
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-25 14:46:28 +00:00
Brian Osman
ddba4e646a SkBaseDevice::drawAtlas doesn't antialias either, so remove fallback
Also, fix the trace marker name.

Bug: skia:8903
Change-Id: Ibf43efbdf73e406482ed4442639e22aec1d93e9f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203058
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-25 14:24:19 +00:00
Ravi Mistry
d37e1b0fad [Recipe Modules] Make DefaultFlavor.step signature match the other step funcs
Bug: skia:8901
Change-Id: Ibe14ed88c0cd937eae2d91eb6e90391466098a2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203341
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 14:21:19 +00:00
skia-autoroll
36c5ed7a03 Roll third_party/externals/swiftshader 62f62a6efa2c..e24bc66dcda3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/62f62a6efa2c..e24bc66dcda3


git log 62f62a6efa2c..e24bc66dcda3 --date=short --no-merges --format='%ad %ae %s'
2019-03-25 sugoi@google.com Fixed erroneous filtering


Created with:
  gclient setdep -r third_party/externals/swiftshader@e24bc66dcda3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I2070c01e14e0f88d4a6d78c3912ce49fb2acd5cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203325
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 14:18:59 +00:00
Ravi Mistry
2719dff87a [Recipe Modules] remove_file_on_device was in all flavors except DefaultFlavor
Bug: skia:8901
Change-Id: Idde99d943c31ae62fcd0bc3f3b8cfc0ebc07e896
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-03-25 13:58:49 +00:00
Kevin Lubick
cd54466473 Expose gpu cache knobs
Change-Id: I5911593812ebf6fd235c6a3fc2acfa740c7687aa
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203164
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-25 11:48:25 +00:00
skia-recreate-skps
554bec1fff Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I470e438a2714a389cffd148643387b43125670c0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203114
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-03-25 11:46:27 +00:00
skia-autoroll
2e2fa9e3a0 Roll third_party/externals/swiftshader e276f52bb4c9..62f62a6efa2c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e276f52bb4c9..62f62a6efa2c


git log e276f52bb4c9..62f62a6efa2c --date=short --no-merges --format='%ad %ae %s'
2019-03-25 swiftshader.regress@gmail.com Regres: Update test lists @ e276f52b


Created with:
  gclient setdep -r third_party/externals/swiftshader@62f62a6efa2c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: Iaeafc188dc82a2b3a3ff641baa56f77cb67a2647
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203313
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 08:55:24 +00:00
skia-autoroll
c9f746cfb9 Roll ../src 0a4f8d5b63f5..40ce19f3a56f (30 commits)
0a4f8d5b63..40ce19f3a5


Created with:
  gclient setdep -r ../src@40ce19f3a5

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stani@google.com

Change-Id: I201269164846b6e99b5178867c39550a00814158
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203301
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-25 01:03:43 +00:00
recipe-roller
e9a53fe352 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ba35c7f8ce4bc9ae93607109b89199d3d9e0af2d Fix possible use of unassigned local variable in git_cl.py (raul@tambre.ee)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I87c5ef166d6ca84ebb04ad725d1a8332ee15ca7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203113
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-03-24 06:46:30 +00:00
skia-recreate-skps
d79c95e8bc Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4b9639ea5fdfb6fbb9db787d2d02be654a7af91e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203112
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-24 05:52:00 +00:00
skia-autoroll
c184c0f83b Roll third_party/externals/angle2 a88c1f9c8b34..eae464dd3092 (1 commits)
a88c1f9c8b..eae464dd30


git log a88c1f9c8b34..eae464dd3092 --date=short --no-merges --format='%ad %ae %s'
2019-03-23 jmadill@chromium.org D3D11: Fix reserved space with large dynamic buffers.


Created with:
  gclient setdep -r third_party/externals/angle2@eae464dd3092

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I2f8cfb15a2e5a889f3ebe83410a3f3ce790349d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203187
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-24 04:04:30 +00:00
Brian Osman
ab4c138c0e Revert "Simplify two more clients of proxy provider (mipped vs. non-mipped)"
This reverts commit 9f20ff6fdf.

Reason for revert: Regression in wacky_yuv_formats GMs (rows are missing?)

Original change's description:
> Simplify two more clients of proxy provider (mipped vs. non-mipped)
> 
> Bug: skia:
> Change-Id: Ic9a2e0e4afe96d916f9054cd7fbd66ee0147719e
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203162
> Auto-Submit: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: If496ff168cc236207458eecd9c120f89b7fd6690
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203054
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-24 01:33:00 +00:00
Brian Osman
4d92b89454 Revert "Remove GrDrawAtlasOp"
This reverts commit 97d957d1db.

Reason for revert: Looking at perf, desktop GPUs get better, many mobile GPUs get worse.

Original change's description:
> Remove GrDrawAtlasOp
> 
> The base device turns drawAtlas into drawVertices, which ends
> up being *faster* (in my tests) than our specialized code.
> 
> It's certainly possible to write a custom version that's better,
> but for now, it seems better to just do this.
> 
> Bug: skia:
> Change-Id: I247f0c0a24fb21c8206f4e3ea9fecac85679ba73
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203163
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=bsalomon@google.com,brianosman@google.com,reed@google.com

Change-Id: Idfb3dd7d33a3905644aafdefc99e7814b08d7c7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203053
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-24 00:53:33 +00:00
skia-autoroll
0cc0ae3777 Roll ../src 3d76aaf8edee..0a4f8d5b63f5 (139 commits)
3d76aaf8ed..0a4f8d5b63


Created with:
  gclient setdep -r ../src@0a4f8d5b63

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=brianosman@google.com

Change-Id: I2a3c3b05d9e4505bc5670c05aae04300e2b7e370
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203186
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-24 00:08:00 +00:00
Brian Osman
97d957d1db Remove GrDrawAtlasOp
The base device turns drawAtlas into drawVertices, which ends
up being *faster* (in my tests) than our specialized code.

It's certainly possible to write a custom version that's better,
but for now, it seems better to just do this.

Bug: skia:
Change-Id: I247f0c0a24fb21c8206f4e3ea9fecac85679ba73
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203163
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-23 23:11:00 +00:00
skia-autoroll
4c0b5c4b79 Roll third_party/externals/angle2 2660b5031f11..a88c1f9c8b34 (1 commits)
2660b5031f..a88c1f9c8b


git log 2660b5031f11..a88c1f9c8b34 --date=short --no-merges --format='%ad %ae %s'
2019-03-23 jmadill@chromium.org Revert "Force new displays on each Windows 7 end2end test."


Created with:
  gclient setdep -r third_party/externals/angle2@a88c1f9c8b34

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: Ibc094152a7cffbe6d732c2b589b31ba2d8a4dd72
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203185
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-23 19:04:00 +00:00
Hal Canary
25dd2c9fe9 SkPDF: runtime switch between subsetters
Bug: chromium:931719
Change-Id: I3199983d24a47b2b3921242a98ce83099ee869dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202956
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@skia.org>
2019-03-23 16:31:10 +00:00
Herb Derby
b1dbbc8509 Fix fallback problems for emoji
The remote glyph cache was not processing the fallbacks, because the
code was improperly gaurded against not having a processor.

Disable the test until I can figure out how to deal with GPU
variation.

Change-Id: I58faf5551a87c1df2f70cf10cbd5d1dee4cb89af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203173
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-23 16:16:10 +00:00
Ben Wagner
110c703b5d Move fontmgr_bounds label setting to checkbox.
The fontmgr_bounds gm has an option to show the name of the font and the
glyph ids of the glyphs with extreme bounds. This was previously done
with a command line flag label_fontmgr_bounds. However, this information
is generally only useful in the viewer application, so change this to a
control.

This also adds bool field handling in viewer.

Change-Id: Idbdbb08e9516ec49a96f9baa320acd6fe44e95ca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203175
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-03-23 14:37:59 +00:00
skia-autoroll
61bd912377 Roll third_party/externals/angle2 a8ff88143af6..2660b5031f11 (1 commits)
a8ff88143a..2660b5031f


git log a8ff88143af6..2660b5031f11 --date=short --no-merges --format='%ad %ae %s'
2019-03-23 syoussefi@chromium.org Vulkan: Restore CommandBuffer to namespace vk


Created with:
  gclient setdep -r third_party/externals/angle2@2660b5031f11

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I4e5ec4a78c88f60b09fbd6d10147c279138073b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203111
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-23 10:05:29 +00:00
skia-recreate-skps
ec1c6fdfdd Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ib4358becb0394a81740fcc0c7fd7d47f6f88ff6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203184
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-23 05:52:59 +00:00
skia-autoroll
e86cc50390 Roll third_party/externals/angle2 896e7811184e..a8ff88143af6 (1 commits)
896e781118..a8ff88143a


git log 896e7811184e..a8ff88143af6 --date=short --no-merges --format='%ad %ae %s'
2019-03-22 tobine@google.com Vulkan:Optimize SecondaryCommandBuffers


Created with:
  gclient setdep -r third_party/externals/angle2@a8ff88143af6

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=brianosman@google.com

Change-Id: I7c2d69e988ece3b200eee789aef16ec7e20db6b6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203110
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-23 01:04:09 +00:00
skia-autoroll
33332f1e10 Roll ../src 9aca4d1c479e..3d76aaf8edee (485 commits)
9aca4d1c47..3d76aaf8ed


Created with:
  gclient setdep -r ../src@3d76aaf8ed

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=brianosman@google.com

Change-Id: I8353a94401524a0b8cb959db4b5f416c7d61542b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203109
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-22 23:05:39 +00:00
Adrienne Walker
ca81196d4c Prevent overflow in Deserialize::ensureAtLeast
Bug: chromium: 935118
Change-Id: I4c11a763d257f0c44bc75bf0369ba76454c06673
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203176
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-03-22 21:48:39 +00:00
Jim Van Verth
a5b0b1eb5b Revert "Reland "Fix blurry edges on large ovals.""
This reverts commit 4dd7c1dae1.

Reason for revert: largeovals GM is busted on some configs
                   (Mali400MP2, Adreno405, ANGLE, e.g.)

Original change's description:
> Reland "Fix blurry edges on large ovals."
> 
> This is a reland of c7aed036c3
> 
> Changes the precision for the GrOvalOpFactory shaders to be float rather than half.
> In the medium-precision case, adds a scale factor to the shaders to ensure that the
> denominator of the distance calculation stays within range. If enough precision isn't
> available, falls back to a path renderer.
> 
> Original change's description:
> > Fix blurry edges on large ovals.
> >
> > Changes the precision for the GrOvalOpFactory shaders to be float rather than half. In the
> > low-precision case, it falls back to a path renderer for large ovals.
> >
> > Bug: b/110380864, skia:8873
> > Change-Id: I89e8dd067a2e0cab35b1bb515adaab4a2fb4f222
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201615
> > Commit-Queue: Jim Van Verth <jvanverth@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> Bug: b/110380864, skia:8873
> Change-Id: Ic72d819f589ffebf9c5250bb4df4de22ab23f282
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202718
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I3467da7e71a0f0dae4349f0f003b55c7db7dbb1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/110380864, skia:8873
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203174
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-03-22 21:06:50 +00:00
Mike Klein
19cc0f647c create a wrapper to manage --nativeFonts and --gdi
Put it in ToolUtils to avoid cyclic dependencies.

Change-Id: Ie0ad7eb5d1ba58be5ad8c668afdb7c74facd71dc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203181
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 21:06:29 +00:00
Mike Klein
629f5fc5ec de-common another batch of flags
These are only used by DM and nanobench,
and sometimes even do substantially different things...

Change-Id: I973f3938fbae1fd1b19d876fa6a90122fc55d48c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203167
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 20:43:39 +00:00
Mike Reed
1d0e68b839 add bench for drawAtlas
Bug: skia:
Change-Id: I00c86a99d3785eec67d9cc7dde31a7705e7d78cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203169
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-22 20:41:49 +00:00
Ethan Nicholas
5c46b72c86 fixed constructing matrices in SPIR-V when arguments cross column boundaries
Bug: skia:
Change-Id: I20550c0ebf2c4ee225552b66f41ad9dc886d5fc3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203161
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-03-22 20:35:29 +00:00
Brian Osman
9f20ff6fdf Simplify two more clients of proxy provider (mipped vs. non-mipped)
Bug: skia:
Change-Id: Ic9a2e0e4afe96d916f9054cd7fbd66ee0147719e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203162
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-22 20:13:49 +00:00
skia-autoroll
e74b31ca4b Roll third_party/externals/swiftshader 89c13815df2f..e276f52bb4c9 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/89c13815df2f..e276f52bb4c9


git log 89c13815df2f..e276f52bb4c9 --date=short --no-merges --format='%ad %ae %s'
2019-03-22 chrisforbes@google.com Remove extra stencil state from DrawData
2019-03-22 capn@google.com Remove top-level kokoro/ folder


Created with:
  gclient setdep -r third_party/externals/swiftshader@e276f52bb4c9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=brianosman@google.com

Change-Id: If4fc884d1805fdac140a9adba148c12b804bac8b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203107
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-22 19:45:19 +00:00