Commit Graph

37333 Commits

Author SHA1 Message Date
Ben Wagner
230a71b77f Work around FreeType type change.
FreeType is moving their memory APIs from 'long' to 'size_t'. This
generally uses the same number of bits, but these are usually different
types (signed vs. unsigned). Detect the actual type in use where needed.

Change-Id: Id85b9b874f7418fbe308739d23eb3d22ecd765a8
Reviewed-on: https://skia-review.googlesource.com/c/159840
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-09 14:56:19 +00:00
Kevin Lubick
8e9750d3c5 Add CanvasKit build
Building CanvasKit uses very similar logic to PathKit, so there
was a fair amount of copy/paste/customize.

Fixes the name of skia.js/wasm -> canvaskit.js/wasm and
adds a package.json to formally track versions.

Also move PathKit helper scripts to align better.

Docs-Preview: https://skia.org/?cl=160463
Bug: skia:
Change-Id: Ie75b30592dcc4d520dca41f6f5579006aaa8849b
Reviewed-on: https://skia-review.googlesource.com/c/160463
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-09 13:56:56 +00:00
Kevin Lubick
915b80bf39 Fix key in perf data
Bug: skia:
Change-Id: Ic65f6dd37b2fa16989e4c2f780672e3293ddbd5f
Reviewed-on: https://skia-review.googlesource.com/c/160762
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-09 13:31:11 +00:00
Ravi Mistry
32f547a418 Fix bookmaker bot
Bug: skia:
Change-Id: Ic625889ca58237e8da8ab964f29e303ceb493faf
Reviewed-on: https://skia-review.googlesource.com/c/160760
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-10-09 13:26:20 +00:00
Ethan Nicholas
010635190d Metal stencil support
Bug: skia:
Change-Id: I697a39bc756bb8f18ea2c6a1f8151dbc103bf9fe
Reviewed-on: https://skia-review.googlesource.com/c/157567
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-10-09 13:13:19 +00:00
Greg Daniel
a41a74ac79 Revert "In GrVkGpuCommandBuffer when setting bounds to full RT use proxy bounds instead of surface."
This reverts commit 9b7bfd0910.

Reason for revert: Looks like a blurs got broken, espcially on nvidia

Original change's description:
> In GrVkGpuCommandBuffer when setting bounds to full RT use proxy bounds instead of surface.
> 
> My guess is perf wise this will be a wash/nothing really changes, but it at least lets
> Vulkan know exactly what our intention is.
> 
> Bug: skia:
> Change-Id: I8ddeccc602154c793d8f7d7de087a655a136dc9c
> Reviewed-on: https://skia-review.googlesource.com/c/160620
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,robertphillips@google.com

Change-Id: I5bd09a4d9b7ee48e32c86fc8e42a3e27409907bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/160761
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-09 12:59:29 +00:00
skia-recreate-skps
817c01aecd Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Iac9423d563cd8a283bed7e0e54addac0b1d497db
Reviewed-on: https://skia-review.googlesource.com/c/160701
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-09 06:01:59 +00:00
Greg Daniel
9b7bfd0910 In GrVkGpuCommandBuffer when setting bounds to full RT use proxy bounds instead of surface.
My guess is perf wise this will be a wash/nothing really changes, but it at least lets
Vulkan know exactly what our intention is.

Bug: skia:
Change-Id: I8ddeccc602154c793d8f7d7de087a655a136dc9c
Reviewed-on: https://skia-review.googlesource.com/c/160620
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-08 21:43:02 +00:00
Michael Ludwig
7034f15b28 Improve modulation detection logic in ProcessorOptimizationValidationTest
Bug: skia:
Change-Id: I6896df2f46d530afbda752894a3fc414ade661df
Reviewed-on: https://skia-review.googlesource.com/c/159521
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-08 21:31:51 +00:00
Stan Iliev
733b265854 Match AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM HW buffer format
Match AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM to
kRGBA_8888_SkColorType instead of kRGB_888x_SkColorType.

Bug: b/116117654
Change-Id: Icde4773cf525bf7d5ce6c091c05de5ad8ba770cb
Reviewed-on: https://skia-review.googlesource.com/c/160600
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2018-10-08 21:23:56 +00:00
Michael Ludwig
076238f306 Add clear benchmark
Bug: skia:
Change-Id: I2cfc365e41942ad7cc3fbdf9b815df6e25b1f36f
Reviewed-on: https://skia-review.googlesource.com/c/160601
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-10-08 21:13:26 +00:00
Cary Clark
917d7cdf5c bookmaker fix build again
bookmaker fix build again

TBR=stani@google.com
NOTRY=true
Bug: skia:
Change-Id: I9a5f31512c7e696a900ea8c0a3b1364f0411f7ce
Reviewed-on: https://skia-review.googlesource.com/c/160602
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-10-08 21:10:46 +00:00
Cary Clark
a8df5563ed bookmaker fix Build-Debian9-GCC-x86_64 Debug
removed meaningless compare
TBR=caryclark@google.com

Bug: skia:
Change-Id: Id4ce81a71d03deaa528b5470c5e4336ca649629e
Reviewed-on: https://skia-review.googlesource.com/c/160561
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-10-08 20:24:48 +00:00
Jim Van Verth
8bbce0e29e More SkImage_GpuYUV updates
Bug: skia:7901
Change-Id: If5f747ff95c65ac95cfed8c1282cc08019d8006a
Reviewed-on: https://skia-review.googlesource.com/c/160024
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-10-08 20:22:58 +00:00
skia-autoroll
bada39a163 Roll third_party/externals/angle2 6d765b07f86f..3f21fcb9bd26 (2 commits)
6d765b07f8..3f21fcb9bd


git log 6d765b07f86f..3f21fcb9bd26 --date=short --no-merges --format='%ad %ae %s'
2018-10-08 courtneygo@google.com Set ANGLE default backend to Vulkan
2018-10-08 oetuaho@nvidia.com Clean up TCompiler members and style


Created with:
  gclient setdep -r third_party/externals/angle2@3f21fcb9bd26

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I0843fd5673dda83417e7e2cc5421f7c25753ac04
Reviewed-on: https://skia-review.googlesource.com/c/160540
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-08 19:34:04 +00:00
Cary Clark
61313f38e1 Generate bookmaker indices
First cut at splitting bookmaker documentation into reference
and overview. Reference starts with a hyperlinked index,
generated from a public include.

This moves towards typing once, minimizing the information
duplicated in the .h file and the .bmh file.

TBR=caryclark@google.com
Docs-Preview: https://skia.org/?cl=154630
Change-Id: I836622db9b1786bd28c0bce2536cd3caef6e5a32
Reviewed-on: https://skia-review.googlesource.com/c/154630
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-10-08 19:24:31 +00:00
Kevin Lubick
eba2624e2c Use right bucket for buildstats
Additionally, include the revision name in the json file name
to avoid collisions.

Bug: skia:
Change-Id: I6601c28679f82406721d740041a60077b460c0f4
Reviewed-on: https://skia-review.googlesource.com/c/160560
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 19:23:56 +00:00
Kevin Lubick
35b87a5b44 Add Build and Test jobs for SKQP using docker.
Uses Docker to compile an APK and then run it on an emulator.

We use a specialized image for build (includes Clang, etc)
And then the 3rd party base image for just the test (which
has the emulator and SDK on it).

Bug: skia:7578, skia:7692
Change-Id: I948e0b091868e7173b00e3affd7c3d59a5cd1ec2
Reviewed-on: https://skia-review.googlesource.com/c/159681
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-10-08 19:17:25 +00:00
Brian Osman
00de965d0d Remove a bunch of unused files and functions
Bug: skia:
Change-Id: I1f05014a6ab955f324e4cde4f7b7aebe8f7d72a1
Reviewed-on: https://skia-review.googlesource.com/c/160385
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-08 18:55:27 +00:00
Greg Daniel
0f70be81e9 Reland "Remove ability to sample textures in vertex or geometry shaders."
This reverts commit 6e2625d9ae.

Reason for revert: Chrome fix has landed. This should work now.

Original change's description:
> Revert "Remove ability to sample textures in vertex or geometry shaders."
> 
> This reverts commit d50d6579d1.
> 
> Reason for revert: chromes test gles test context is broken. Need to fix that then reland this
> 
> Original change's description:
> > Remove ability to sample textures in vertex or geometry shaders.
> > 
> > Bug: skia:
> > Change-Id: I69cd07a4bbe4879e855fb4aa6289a049adf4e059
> > Reviewed-on: https://skia-review.googlesource.com/c/160021
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Chris Dalton <csmartdalton@google.com>
> 
> TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com
> 
> Change-Id: I309dfa5f7118cb8d7280aaf6a88e1df232bd7099
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/160163
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Id2b5bdf883dbd0236f847649a30d15a492ab481e
Reviewed-on: https://skia-review.googlesource.com/c/160461
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-08 18:49:46 +00:00
Herb Derby
55bc0515a7 Fixup textblob benchmark
* Correctly translate glyphs
* Make subpixel
* Use subpixel positions

Change-Id: I0011fb6cc8b985c9a7bd058f8b2fbf4b525019de
Reviewed-on: https://skia-review.googlesource.com/c/160500
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-08 18:44:58 +00:00
Kevin Lubick
4968843293 Add BuildStats pipeline for PathKit binaries
This should be extensible to do something similar
for libskia and other outputs.

Bug: skia:
Change-Id: Id9f30a82f4eb0e7ce868a32409b1be429917e7f6
Reviewed-on: https://skia-review.googlesource.com/c/160220
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 18:15:32 +00:00
Hal Canary
b5ccf6f09b SkPDF: centralize procsets to remove duplication
Change-Id: I32dbb88c5c28a5c44f922826516eeb2221ae4b38
Reviewed-on: https://skia-review.googlesource.com/c/160384
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-10-08 18:05:31 +00:00
Mike Reed
2aa6475887 modify gm to avoid creating t-junctions between degernate curves and lines
Bug: skia:8453
Change-Id: Id9d4d2d02eb9db4d9af1832e506b3b39a507fe32
Reviewed-on: https://skia-review.googlesource.com/c/160460
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-08 18:05:21 +00:00
Robert Phillips
8ad991da4c Fix Chrome roll
Change-Id: Ie9d450965a8a912f4da292d8bd8ce62612e2485a
Reviewed-on: https://skia-review.googlesource.com/c/160382
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-08 15:44:15 +00:00
skia-autoroll
95320ee01f Roll third_party/externals/angle2 19b51d298334..6d765b07f86f (1 commits)
19b51d2983..6d765b07f8


git log 19b51d298334..6d765b07f86f --date=short --no-merges --format='%ad %ae %s'
2018-10-08 jiajia.qin@intel.com ES31: Fix some bugs in ShaderStorageBlockOutputHLSL


Created with:
  gclient setdep -r third_party/externals/angle2@6d765b07f86f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I89e5519bb5ec835e22590232e5626f480488a9fe
Reviewed-on: https://skia-review.googlesource.com/c/160322
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-08 10:45:04 +00:00
skia-recreate-skps
9aa3f90956 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I23924de66b66aec4b542b30f771c24b32386be7f
Reviewed-on: https://skia-review.googlesource.com/c/160321
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-08 05:53:01 +00:00
skia-autoroll
beb1559bc6 Roll third_party/externals/angle2 450bf36f7918..19b51d298334 (1 commits)
450bf36f79..19b51d2983


git log 450bf36f7918..19b51d298334 --date=short --no-merges --format='%ad %ae %s'
2018-10-08 jiawei.shao@intel.com ES31: Support textureGather[Offset] on shadow samplers


Created with:
  gclient setdep -r third_party/externals/angle2@19b51d298334

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I9e73ea5f640d4b6f9a36cdee3136b0c0b1712c0a
Reviewed-on: https://skia-review.googlesource.com/c/160320
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-08 01:59:00 +00:00
skia-recreate-skps
e9b61ef5aa Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I978db4bad062945807d64611f5b637c8b5ed20d2
Reviewed-on: https://skia-review.googlesource.com/c/160283
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-10-07 15:49:17 +00:00
skia-recreate-skps
71143d6cc0 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2d01f6b89a747c11d070b476ab77aff51e81fd70
Reviewed-on: https://skia-review.googlesource.com/c/160281
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-06 05:58:23 +00:00
skia-autoroll
623d2e4120 Roll third_party/externals/angle2 78df3362ac21..450bf36f7918 (1 commits)
78df3362ac..450bf36f79


git log 78df3362ac21..450bf36f7918 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 ynovikov@chromium.org Workaround Adreno driver not supporting unsized EXT_texture_rg formats


Created with:
  gclient setdep -r third_party/externals/angle2@450bf36f7918

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: I3a06ba55d204883e40942abbc3ad9a87cb381848
Reviewed-on: https://skia-review.googlesource.com/c/160280
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-06 04:58:59 +00:00
Chris Dalton
29b11d605f ccpr: Delete the stashed atlas texture before allocating a new one
Bug: skia:
Change-Id: I13c13c73f6065f2eababb174361f8bfa9e62b7e2
Reviewed-on: https://skia-review.googlesource.com/c/160200
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-10-05 21:59:30 +00:00
skia-autoroll
d037f4d204 Roll third_party/externals/angle2 0ca09753392d..78df3362ac21 (7 commits)
0ca0975339..78df3362ac


git log 0ca09753392d..78df3362ac21 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 oetuaho@nvidia.com Fix clearing out-of-range default FB drawbuffer
2018-10-05 geofflang@chromium.org Suppress EXTBlendFuncExtendedDrawTestES3.FragmentArrayOutputLocationsAP on MacOS
2018-10-05 jmadill@chromium.org GL back-end error refactor.
2018-10-05 syoussefi@chromium.org Vulkan: Safer struct initialization
2018-10-05 oetuaho@nvidia.com Fix constructing void array zero nodes
2018-10-05 jmadill@chromium.org Remove gl::ErrorOrResult.
2018-10-05 jmadill@chromium.org Remove gl::LinkResult.


Created with:
  gclient setdep -r third_party/externals/angle2@78df3362ac21

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=mtklein@google.com

Change-Id: Ia0f39a8d7d02a10085585ddef716f076963768bd
Reviewed-on: https://skia-review.googlesource.com/c/160180
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-05 20:10:59 +00:00
Brian Osman
ee8603c00f Cleanup bitmap/mipmap cache key structs
Use the same pattern (of just including the entire Desc) for both,
rather than manually doing all the same work in the MipMapKey. Remove
the assert about origin when making a desc from a bitmap - this can be
violated when coming in via the MipMap cache, now - and it's handled
correctly in get_bounds_from_bitmap, anyway.

This makes it simpler when I add new fields to the Desc struct.

Bug: skia:
Change-Id: I6b0bfc11a54f3a69a67e8fda7808f116080e61bb
Reviewed-on: https://skia-review.googlesource.com/c/160030
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2018-10-05 19:50:47 +00:00
Greg Daniel
6e2625d9ae Revert "Remove ability to sample textures in vertex or geometry shaders."
This reverts commit d50d6579d1.

Reason for revert: chromes test gles test context is broken. Need to fix that then reland this

Original change's description:
> Remove ability to sample textures in vertex or geometry shaders.
> 
> Bug: skia:
> Change-Id: I69cd07a4bbe4879e855fb4aa6289a049adf4e059
> Reviewed-on: https://skia-review.googlesource.com/c/160021
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Chris Dalton <csmartdalton@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com

Change-Id: I309dfa5f7118cb8d7280aaf6a88e1df232bd7099
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/160163
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-05 19:48:07 +00:00
Cary Clark
946a690d31 fix bookmaker
add a couple of undefined terms
and make the parameter descriptions
start lowercase

NOTRY=true
R=robertphillips@google.com

Docs-Preview: https://skia.org/?cl=160160
Bug: skia:
Change-Id: I45223943ce56d9ca13e818bc5e21607b8c4ee100
Reviewed-on: https://skia-review.googlesource.com/c/160160
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-10-05 19:31:38 +00:00
Herb Derby
f3a3864290 Remove old code by moving to new API in bitmap text
Change-Id: Ic997e40406bd0d7c298a7361ee1e42023cb3be38
Reviewed-on: https://skia-review.googlesource.com/c/160101
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-05 19:19:58 +00:00
recipe-roller
50fd023f9b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acbe9e3142610d958181460254565ef27ad47dc0 [StepPresentation] Remove all logs from memory during finalization. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifcf051520a5fe727bcd8efb6f4a3c2133e2a346b
Reviewed-on: https://skia-review.googlesource.com/c/160033
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 18:45:50 +00:00
Herb Derby
278b0675d0 Less stress for chromecast
Change-Id: Ib32ee8f556fc44fb2d4bad3d86b874eae0dafb23
Reviewed-on: https://skia-review.googlesource.com/c/160100
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-10-05 18:32:33 +00:00
Kevin Lubick
f4def34885 Move dumpJSON behind the SK_ENABLE_DUMP_GPU flag
This should trim the code size of a WASM CanvasKit by 10-20KB.

Bug: skia:
Change-Id: Ibf0f8596c04e891e8f7cbc2fa4f1d1852f7cb462
Reviewed-on: https://skia-review.googlesource.com/c/159261
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-05 18:18:30 +00:00
recipe-roller
b3d6145cb7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/85af45334ed48cc2e35ddaef0c428f701246260a [windows_sdk] Default to cache/windows_sdk. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icd03ebb284504b95863940440c415a84ae0bf3bd
Reviewed-on: https://skia-review.googlesource.com/c/160031
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 18:15:50 +00:00
Robert Phillips
51c89e41c0 Exercise newly exposed SkYUVIndex-based SkImage factories (take 2)
Bug: skia:7903
Change-Id: Ie7d0135f392b67085a23a59cb469429f9e2b0221
Reviewed-on: https://skia-review.googlesource.com/c/160029
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-05 18:04:58 +00:00
recipe-roller
6ddcd89248 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424 bot_update: Don't use apply_patch_on_gclient. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6af9ef4d5ec55f61581ecb0d05dce1fae77319e2
Reviewed-on: https://skia-review.googlesource.com/c/160028
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-05 17:46:34 +00:00
Mike Reed
360178920c trim unused SkDraw functions
Bug: skia:
Change-Id: I9fcb92c2d4057c45f6bad4594accafc1c6e31455
Reviewed-on: https://skia-review.googlesource.com/c/160025
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 17:24:53 +00:00
Greg Daniel
d50d6579d1 Remove ability to sample textures in vertex or geometry shaders.
Bug: skia:
Change-Id: I69cd07a4bbe4879e855fb4aa6289a049adf4e059
Reviewed-on: https://skia-review.googlesource.com/c/160021
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2018-10-05 17:19:50 +00:00
Greg Daniel
cfa39352c0 Remove debug only clearStencil virtual on GrGpu.
Bug: skia:
Change-Id: Ic68cd97675f554b60e84ec36d8068ce539cce6aa
Reviewed-on: https://skia-review.googlesource.com/c/159945
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-05 17:19:48 +00:00
Brian Osman
bd16a1bcb3 Revert "Exercise newly exposed SkYUVIndex-based SkImage factories"
This reverts commit e1c1d4d09c.

Reason for revert: Crashing on bots that abandon the GPU context

Original change's description:
> Exercise newly exposed SkYUVIndex-based SkImage factories
> 
> Bug: skia:7903
> Change-Id: I04630ebec37b087423e8305cc1716544fa00a403
> Reviewed-on: https://skia-review.googlesource.com/c/160020
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=jvanverth@google.com,robertphillips@google.com

Change-Id: I5cd5eca3aa55feb73737643dbe05a374a6fd7842
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7903
Reviewed-on: https://skia-review.googlesource.com/c/160026
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-05 17:10:16 +00:00
Mike Reed
d109503b69 split out SkDraw_text functions
Bug: skia:
Change-Id: I1cbce64fe137011e664133a1ec51feaa87898529
Reviewed-on: https://skia-review.googlesource.com/c/160023
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 16:30:52 +00:00
Robert Phillips
e1c1d4d09c Exercise newly exposed SkYUVIndex-based SkImage factories
Bug: skia:7903
Change-Id: I04630ebec37b087423e8305cc1716544fa00a403
Reviewed-on: https://skia-review.googlesource.com/c/160020
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-05 16:18:50 +00:00
Mike Reed
dee25ccb67 split SkPaint into separate impl files
Bug: skia:
Change-Id: If82d39be1f85f9c9487e232b56c72dde175243ab
Reviewed-on: https://skia-review.googlesource.com/c/160022
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-05 16:17:20 +00:00