Ben Wagner
cef57e94db
Remove Win2k8 GPU jobs.
...
Bug: skia:6734
Change-Id: Ia7e64fe8176f0997d36ef955cc598ba662c7a2e3
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/133304
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-06-08 14:40:11 +00:00
Eric Boren
cb0b98b263
Update gen_tasks.go to use unforked glog
...
Required after https://skia-review.googlesource.com/130562
Bug: skia:
Change-Id: I6409622b5124422906e7acfae96acab46305e1f7
Reviewed-on: https://skia-review.googlesource.com/133042
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-08 12:55:41 +00:00
Mike Klein
6120164138
remove "srgb" config from DM,nanobench
...
Now that "srgb" is broken I don't want to accidentally run it.
"srgbnl" if of course identical, and not broken so much as
simply not yet working. :)
While here, simplify the configs we run in nanobench too, eliminating
565 and moving F16 to GCE-only (i.e. fast, abundant machines).
Similarly, remove "adobe" VIA that doesn't use Adobe RGB correctly...
Change-Id: Ic295dec97a2caadadbe8500655243db36dd2c43d
Reviewed-on: https://skia-review.googlesource.com/132932
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-06-07 19:12:11 +00:00
Ben Wagner
ece4306025
Update Windows to v1803 in Skolo.
...
Change-Id: I6b19e7851cb9a99725fd80bdfaeec2efab81c524
Reviewed-on: https://skia-review.googlesource.com/132263
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-06 20:28:24 +00:00
Brian Osman
2d7678d61f
Update MSVS toolchain for bots:
...
MSVC 14.14.26428
SDK 10.0.17134.0
Docs-Preview: https://skia.org/?cl=132409
Change-Id: I02686531804ac026b92bceed29dc28d246fe4902
Reviewed-on: https://skia-review.googlesource.com/132409
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-06 16:59:04 +00:00
Ben Wagner
8d8f45d29e
Update MotoG4.
...
No-Try: true
Change-Id: I0e8715e7e7a0f884c653e4888459a185b0870065
Reviewed-on: https://skia-review.googlesource.com/131925
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-06-05 13:50:19 +00:00
recipe-roller
9856c3dd39
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/b9907703867525b9a082b83d8397f8a5bbf0bf02 Revert "Reland "Expand variables in gclient flattened output."" (jbudorick@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ffc6361ec4073e11cde001b759623ed4958efb5
Reviewed-on: https://skia-review.googlesource.com/132080
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-05 05:38:00 +00:00
recipe-roller
4588ff3b4f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/ff6222444366463e2e86fd8b9c26580f689f78d6 Reland "Expand variables in gclient flattened output." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8d1535daa245edf6b7d56c88e5d3793e5a239f0
Reviewed-on: https://skia-review.googlesource.com/132040
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-05 02:47:00 +00:00
recipe-roller
ddd92dc70b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/01cb51055e127b1f846838d14761ca716511d63a Revert "Expand variables in gclient flattened output." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1cca19ba0183a21fcbfbbbb0c09f45c99c45b04a
Reviewed-on: https://skia-review.googlesource.com/131929
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-06-05 02:07:00 +00:00
recipe-roller
0e49cb9a39
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/cf4aced37e993525b9e21856c0d1acec682edab1 Update windows git to 2.17.1 (agable@chromium.org )
https://crrev.com/af43f40eb22d7ceedf2b48ba79ca8cc1b0a0c761 Fix git cl format --python --full (nodir@google.com )
https://crrev.com/0ae14e9aad83c1387df8dd565cce3748fce3dec7 [presubmit] Add python formatting check (nodir@google.com )
https://crrev.com/621fe6f9b56a04d06b4a730cd2867d50282a6490 Add ability to whitelist bot accounts as valid authors (sergiyb@chromium.org )
https://crrev.com/88087bad47fb55e5e783ef678faddf6174a29a13 [led] Roll to 7ba61969ccbe1f9679661555f72ca947da508a70 (smut@google.com )
https://crrev.com/518bb6847a6e29b2bc23a2b7b3a39d9aa5adc166 Include "fuchsia" as a known "deps_os" value (sergiyb@chromium.org )
https://crrev.com/9ac59795af3a5a7a3dac572867d2cfce7dc6c21e Fix buildbucket bug filing instructions (nodir@google.com )
https://crrev.com/23d75d2db4444e3e61c91dd78a09c977c88a3083 [git-cl-try] Handle absence of builds (nodir@google.com )
https://crrev.com/a32f98e652d5e151f70d571cf046c3d83ae2f486 Expand variables in gclient flattened output. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78cbd48d7f6bf9b752cebc732c84682c7051bcc5
Reviewed-on: https://skia-review.googlesource.com/131926
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-06-05 01:27:20 +00:00
smut
503438477e
[Isolate] Update clients to hit /_ah/api instead of /api
...
The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.
https://chromium.googlesource.com/infra/infra revision:
d8ec646a9503426a5018cf5bc251abe4a842357f
https://chromium.googlesource.com/infra/luci/luci-go revision:
928030a644473add1ca1bd044d13f48fee569c1a
linux64/isolate.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-trusty-64/12546
mac64/isolate.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-mac-10.13-64/4878
windows64/isolate.exe.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-win-64/12934
Bug: 805543
Change-Id: I1e15f69908a8c7c7a2300d3e37b0e53607613cbc
Reviewed-on: https://skia-review.googlesource.com/131701
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Auto-Submit: smut <smut@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-06-04 22:14:49 +00:00
Brian Salomon
7258e97e8e
C++14
...
Change-Id: I4bbf3e5e6d9d4e11e968a0bc88ce43444047a382
Reviewed-on: https://skia-review.googlesource.com/130903
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-04 13:22:49 +00:00
skia-recreate-skps
728b7f3cdd
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I80ef55d84988185265febee72195bd6f9f4afe10
Reviewed-on: https://skia-review.googlesource.com/131711
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-06-03 11:09:58 +00:00
skia-recreate-skps
257c1fb752
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I663912fb35f95ee852bd2db7ceac1834990e75b5
Reviewed-on: https://skia-review.googlesource.com/131660
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-06-01 22:12:46 +00:00
Mike Klein
a3750b2aa0
build for Chromecast with clang
...
I don't think this switches to libc++... just from GCC to Clang.
Change-Id: I755464161d030668e34ab79f4a77d9807ddc8e3f
Reviewed-on: https://skia-review.googlesource.com/131520
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-06-01 19:41:56 +00:00
Ben Wagner
ee56b834fc
Remove GalaxyS7 ATT jobs.
...
We no longer have bots to run them.
No-Try: true
Change-Id: Ia30acf064a12b46d56f6445cf8d6d610fa1cf5a4
Reviewed-on: https://skia-review.googlesource.com/131524
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-06-01 18:43:46 +00:00
Eric Boren
322a859bda
Reland [recipes] Isolate build outputs with no subdirs
...
Bug: skia:6473
Change-Id: I730cb860abc72473aaa9af98527fd220b9a55120
Reviewed-on: https://skia-review.googlesource.com/131389
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 15:18:46 +00:00
Eric Boren
fbe7166685
Revert "[recipes] Isolate build outputs with no subdirs"
...
This reverts commit 0c9d2805e8
.
Reason for revert: Broke iOS and SwiftShader (and maybe others)
Original change's description:
> [recipes] Isolate build outputs with no subdirs
>
> Bug: skia:6473
> Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c
> Reviewed-on: https://skia-review.googlesource.com/130942
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
TBR=borenet@google.com ,benjaminwagner@google.com
Change-Id: Icf9490f2f88dc454c6d971f35258e219137b0c0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:6473
Reviewed-on: https://skia-review.googlesource.com/131400
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 11:53:46 +00:00
Eric Boren
0c9d2805e8
[recipes] Isolate build outputs with no subdirs
...
Bug: skia:6473
Change-Id: If243b6afb748529d2bdb212e360cd4338edc929c
Reviewed-on: https://skia-review.googlesource.com/130942
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-01 11:45:15 +00:00
Brian Osman
6dce0a72e0
Enable GPU support in MSAN builds
...
Don't want to test GPU with MSAN, but I'd like to make GPU support
required for DM and other internal tools.
Bug: skia:
Change-Id: I5f1a7669242be9767aa3b579b39740a1741977f3
Reviewed-on: https://skia-review.googlesource.com/131143
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-05-31 18:01:14 +00:00
Robert Phillips
65eb4fba7e
Add DDL skpbench bot for just DDL recording time
...
Change-Id: If75799bfd719ccc47c2064571723e6852c07bfaa
Reviewed-on: https://skia-review.googlesource.com/131144
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-31 17:56:26 +00:00
Robert Phillips
dbe89bb031
Add a DDL Skpbench bot
...
This adds a 9 threads 3x3 grid of tiles DDL SKPBench bot that reports the total time. We will
eventually want a 4x4 bot, a 1x1 bot and a 0x1 bot. Additionally, we will want another whole set
that only emits the DDL record time.
So the ultimate naming scheme would be:
DDLTotal_9x9 DDLRecord_9x9
DDLTotal_4x4 DDLRecord_4x4
DDLTotal_1x1 DDLRecord_1x1
DDLTotal_0x1
Change-Id: Ia96c79ec05602077f4112c69cb344bd8c9b2b4b1
Reviewed-on: https://skia-review.googlesource.com/130923
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-31 16:34:43 +00:00
Eric Boren
4184608344
[recipes] Add parameters to checkout module
...
Pass in the behavioral switches, rather than deriving them from the
builder name inside the module.
Bug: skia:6473
Change-Id: I2cbf67d5c450ae7e0fa319d983431d26505f0b67
Reviewed-on: https://skia-review.googlesource.com/130846
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-30 19:02:18 +00:00
Robert Phillips
21ca04348b
Allow CCPR in DDL1 images (since DDL itself now supports CCPR)
...
Bug: skia:7988
Change-Id: I5a626f7c2cece7aa553eb7a754ebd5d73a701759
Reviewed-on: https://skia-review.googlesource.com/130561
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-30 10:15:18 +00:00
Chris Dalton
aec79e6f85
Update MoltenVK to 43130ab27a8b2e9eaf9e28b70b64f14b20c3b7bb
...
Bring in the stencil buffer fix that just landed.
Bug: skia:7961
Change-Id: I9eb12836678dcb2e25b58f88e0bf27b40d77c2b1
Reviewed-on: https://skia-review.googlesource.com/130454
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-05-29 18:54:47 +00:00
Joe Gregorio
1d1edc192a
Upgrade node to 8.11.2
...
This should contain npm version 6 which supports "npm ci".
Bug: skia:
Change-Id: I631dba2b6aca7794ec6ef960a256f275e4dfd04f
Reviewed-on: https://skia-review.googlesource.com/130240
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-29 12:54:05 +00:00
skia-recreate-skps
6e71f393b6
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I74127276c2cdb62c3ef5bed78549cad1f1c81165
Reviewed-on: https://skia-review.googlesource.com/130350
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-05-27 08:41:33 +00:00
Mike Klein
6857df77b0
remove EmbededResouces bot
...
The skia_embed_resoucres flag in GN is gone.
(Both misspellings sic, seriously.)
Change-Id: Ic4424fcea264010ff1cce390b4fd260897c15677
Reviewed-on: https://skia-review.googlesource.com/130147
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-25 18:55:42 +00:00
recipe-roller
975c93194c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/10f67fe223a7973a95bc5fff219d1a7a3d95a326 [recipe_modules] Create Tricium module (juliehockett@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3382e6cb4629cb1c6a8597b5351f3612ab7c2424
Reviewed-on: https://skia-review.googlesource.com/130145
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-25 18:09:12 +00:00
Ben Wagner
e7e6e22912
Retry ADB commands on all devices.
...
Change-Id: Ieb289043bd871ec45c70339787ae45f09d3ac1dc
Reviewed-on: https://skia-review.googlesource.com/130128
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-25 15:24:22 +00:00
recipe-roller
c5715041be
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/af2ffd933d0e6d8b5bd8c48be7a2b2d568a5eea2 Remove cq_client from depot_tools (agable@chromium.org )
recipe_engine:
https://crrev.com/c51413ab9d4c5ed5c3db8117b80afe64e54016b4 [recipe_api] Add content type for source manifests (mknyszek@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id1ee59cc3adc8bd30a70fc579af9437c38c766e8
Reviewed-on: https://skia-review.googlesource.com/130142
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-25 04:59:51 +00:00
Ben Wagner
308010af93
Revert "Temporarily remove iOS bot from CQ."
...
This reverts commit 3a2cb1accd
.
Reason for revert: skia:8013 has been resolved
Original change's description:
> Temporarily remove iOS bot from CQ.
>
> Bug: skia:8013
> No-Try: true
> Change-Id: I2a377a6249366ed947bba50fe89ac218e5e3c87c
> Reviewed-on: https://skia-review.googlesource.com/130060
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
TBR=benjaminwagner@google.com ,herb@google.com
Change-Id: I8e734415b05c2951508b5c9a763c098696365a91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8013
Reviewed-on: https://skia-review.googlesource.com/130180
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-24 21:58:19 +00:00
recipe-roller
d05e51c17b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/48fe70296f2fe41e64bf2573ae9ff7a938eda7d2 Remove old git-cherry-pick-upload documentation (agable@chromium.org )
https://crrev.com/0115c356f67563d749974293d81b3adeb00b1086 Roll mac_toolchain to 478dc9dbb (justincohen@google.com )
https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168 Remove more Rietveld support from presubmit (agable@chromium.org )
https://crrev.com/b09e03ecb190822b030a63f8be5dc40fa3c13c0d Remove Rietveld-only apply_issue (agable@chromium.org )
recipe_engine:
https://crrev.com/611cfbdc328b50144e2790ed1e4b9db24adb9eea [raw_io] Make it succeed even with read only files. (maruel@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02f0473b60d76c00a4b2ecd73009429d5ade0505
Reviewed-on: https://skia-review.googlesource.com/130123
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-24 21:04:08 +00:00
Ben Wagner
ef839a96ff
Use EGL and GLES headers from Khronos.
...
Bug: skia:7671
Change-Id: Idae96b08f02768f180c7223bdcddb4dead3a5a1b
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123588
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-24 19:45:49 +00:00
Ben Wagner
3a2cb1accd
Temporarily remove iOS bot from CQ.
...
Bug: skia:8013
No-Try: true
Change-Id: I2a377a6249366ed947bba50fe89ac218e5e3c87c
Reviewed-on: https://skia-review.googlesource.com/130060
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-24 19:18:18 +00:00
Eric Boren
90f050387a
[recipes] Rename some modules and files
...
- Move doxygen and binary size out of core and into their own modules.
- Rename core -> checkout since that's all it does, shorten method names.
- Rename flavors:
- Everything is GN, so remove GN/gn_ everywhere.
- Merge gn_flavor into default.
- Shorten file / module names.
Bug: skia:6473
Change-Id: I8ac9ff9c9a267f366206b9991adfa5eb37126ca7
Reviewed-on: https://skia-review.googlesource.com/129176
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-24 14:06:55 +00:00
Ravi Mistry
84a4e5c000
Remove PerCommit bookmaker from CQ
...
Requested by Cary.
NoTry: true
Bug: skia:
Change-Id: I4e7ec842c5c52b6f548d7528a339cdaa3ee58fc1
Reviewed-on: https://skia-review.googlesource.com/129926
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-24 12:41:53 +00:00
recipe-roller
8517631bf4
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/4e9b50ab86b9b9f8ebf0b9ba6bd4954217ebeff9 Revert recent gclient.py changes to fix Chrome releases. (mmoss@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia0c8cba2b76d939d8e6f94dbbb836eb6d83ae594
Reviewed-on: https://skia-review.googlesource.com/129922
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-24 06:07:23 +00:00
recipe-roller
27f5a0df4a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/083eb25f9acbe034db94a1bd5c1659125b6ebf98 gclient: Don't allow URL to be None. (ehmaldonado@chromium.org )
https://crrev.com/428e7c14de188f6b5cab6908e24e41165628dd1b roll-dep: Add tests. (ehmaldonado@chromium.org )
https://crrev.com/398fb44e286670871e4a9bd6b84c3f29ede23d00 Print access errors using logging.error (rharrison@chromium.org )
https://crrev.com/54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9 gclient: Refactor PrintRevInfo (ehmaldonado@chromium.org )
https://crrev.com/ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a gclient: Remove URLs from hierarchy. (ehmaldonado@chromium.org )
https://crrev.com/1f156687a2014f50548eacfffb825fb4f38c44d7 gerrit/api.py: Add get_revision() helper. (agrieve@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I366d059eff87e530d1d5863eeaf8920c353e46e8
Reviewed-on: https://skia-review.googlesource.com/129920
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-24 03:01:21 +00:00
Ben Wagner
3de510a20a
Upgrade Pixel devices.
...
No-Try: true
Change-Id: Icb326a4b49ad945046d5e471d1f6e8a2a22d4d86
Reviewed-on: https://skia-review.googlesource.com/129641
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-23 15:07:51 +00:00
Robert Phillips
b4303caa98
Add a Win10/QuadroP400 SKPBench bot
...
This will be the baseline (aka non-DDL) bot with which we can compare the DDL times
Change-Id: I9a949447845d31560136d591a0c1a17e7be57ac9
Reviewed-on: https://skia-review.googlesource.com/129506
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-23 13:19:21 +00:00
Greg Daniel
e81f7b393a
Add more blacklists for intel 405 vulkan perf bot.
...
Bug: skia:
Change-Id: I39cae17623e1b186607258cdd6929d797fcd6e15
Reviewed-on: https://skia-review.googlesource.com/129511
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-22 18:08:35 +00:00
Ben Wagner
d26e446927
Rename SwiftShader bots from CPU to GPU.
...
Bug: skia:7671
Change-Id: I1d6b2a07ca93acbe53c1e93d70335f5284cd494e
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129500
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-22 16:33:05 +00:00
Kevin Lubick
0e42586036
Make ASAN setup of Android bots more fault tolerant
...
Bug: skia:7975
Change-Id: I3f123337913870a921d1c09714873eaf2949e88f
Reviewed-on: https://skia-review.googlesource.com/129364
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-21 20:14:08 +00:00
Ben Wagner
8e3bf09e8e
Omit failing test.
...
Bug: skia:7046
Change-Id: Iea1ec862adedeabe05d227c0bd8e635e42fab27d
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129362
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-21 18:54:48 +00:00
Brian Salomon
be3c1d22c7
Add perspective support to GrTextureOp.
...
Bug: skia:
Change-Id: Idea4ffae37dc2c2f339af60a2b74ded476091758
Reviewed-on: https://skia-review.googlesource.com/127600
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-21 18:21:08 +00:00
skia-recreate-skps
435282162e
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I86e4a692f30ef9f6455216c68602b88070d68e85
Reviewed-on: https://skia-review.googlesource.com/129331
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-05-21 15:55:48 +00:00
Eric Boren
dd8b1fc41b
[recipes] Remove a bunch of unnecessary expectations
...
Bug: skia:6473
Change-Id: Ic2eee8074476c449cc9bed4701105609e91ea12b
Reviewed-on: https://skia-review.googlesource.com/128929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 14:26:44 +00:00
Eric Boren
72f6668eb7
[recipes] Move a lot of logic out of vars module
...
In general, vars should only contain variables which are the same for
all tasks. Variables specific to compilation belong in the build
module (or compile recipe), and those specific to running tests belong
in the flavor module, or the individual recipe which uses them.
Bug: skia:6473
Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a
Reviewed-on: https://skia-review.googlesource.com/128545
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 11:58:14 +00:00
recipe-roller
c16559ee35
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3 gclient: Actually fix roll-dep. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78e4093faa596bc197e9777aad7d851e7b5e9d85
Reviewed-on: https://skia-review.googlesource.com/129040
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-17 21:01:46 +00:00
Kevin Lubick
7673f3ba9e
Specify the ADB keys to use for ADB
...
In the golo, specifically, the adb keys used by swarming
are different than those used in the docker instance, unless
configured otherwise.
This means swarming can think a device is ready (authorized)
but the adb we called was not (authorized)
BUG: 843284
Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0
Reviewed-on: https://skia-review.googlesource.com/128930
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-17 19:28:43 +00:00
recipe-roller
12997b051e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/b496b6a0570bd4c9be2c1034ae1b5ae4360b327b gclient: Fix roll-dep. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1c636a7657412e3a45fbcfc20b6b4eb5bd069bb
Reviewed-on: https://skia-review.googlesource.com/128933
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-17 18:41:23 +00:00
Chris Dalton
2b937f54c2
Add MoltenVK_Vulkan bots
...
Adds a prebuilt MoltenVK framework asset from:
KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec
And creates bots that use it.
Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-17 17:35:23 +00:00
recipe-roller
0b82a71c4c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339 gclient: Fix getdep and setdep and add tests. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib044ca18ad05a485c779f94cf32484ce826bd731
Reviewed-on: https://skia-review.googlesource.com/128882
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-17 16:21:13 +00:00
recipe-roller
bd74e6a02a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7 gclient: Merge hook_os with hooks and deps_os with os. (ehmaldonado@chromium.org )
https://crrev.com/ed1bb34fc59e5539ea29def4d68cd94a8e17e71b gclient: Remove condition_value. (ehmaldonado@chromium.org )
https://crrev.com/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b gclient: Fix for extra custom_deps. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ba63046af4d1d1824c7e8850ef46103b1de781d
Reviewed-on: https://skia-review.googlesource.com/128740
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-17 06:47:53 +00:00
recipe-roller
15f8f433c8
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/babd098f3684f1bc965a0f72f96cb701eec91e52 gclient: Simplify GetScmName and CreateSCM. (ehmaldonado@chromium.org )
https://crrev.com/cbf0204555fe07fda96d20456e03f105e2922005 do not try collecting issues information for an empty issues list (vbendeb@chromium.org )
https://crrev.com/8de3800ce55ba459ffcbedcfa52ef5e6e59caab6 print access errors separately (vbendeb@chromium.org )
https://crrev.com/3f0591d4f12991ed39bae2dca96d3593879be382 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id709515589c521a2896f4ecbf50385b936773930
Reviewed-on: https://skia-review.googlesource.com/128686
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-16 20:39:12 +00:00
Ben Wagner
eeeb32847e
Add MacBookPro11,5 jobs.
...
Bug: chromium:807743
Change-Id: Iafd826c97ceaee745a70bdb1cb52f3cf9f6c1ebf
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/116461
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-16 15:29:14 +00:00
Ravi Mistry
5a12d0578a
Run RecreateSKPs bot on SkiaCT pool which has more disk space
...
Should not take up much capacity since it only runs once a day.
Bug: skia:7917
Change-Id: I6e489341032ef40df8cedae4e92c5f00d9a2df91
Reviewed-on: https://skia-review.googlesource.com/128405
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-16 14:42:57 +00:00
Eric Boren
2fbde26018
[recipes] Normalize SwiftShader build dir
...
Bug: skia:6473
Change-Id: If145e2c29ddafdafaf9b8ed3fecbd6a6de31ac0a
Reviewed-on: https://skia-review.googlesource.com/128481
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 14:37:44 +00:00
Ravi Mistry
fedc8476cf
Use Chromium ToT instead of lkcr
...
https://chromium.googlesource.com/chromium/src/+/lkcr has not been
updated in months now.
CT uses Chromium ToT and has rarely run into problems because of that.
Bug: skia:7917
Change-Id: I007b8f29b2320ffbc45ab5c5a75b081fbb8d7afa
Reviewed-on: https://skia-review.googlesource.com/128319
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-16 14:36:54 +00:00
Eric Boren
f3a21d0540
[recipes] Move 'gclient runhooks' from flutter build to core
...
Bug: skia:6473
Change-Id: I89b384668a6a45eaae9995ad8f7b404a1b7f9824
Reviewed-on: https://skia-review.googlesource.com/128318
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 12:56:54 +00:00
Ben Wagner
4c9b700bb5
Run only canonical configs for 32-bit Test tasks.
...
https://skia-review.googlesource.com/c/skia/+/127325 added a couple new
configs that caused 32-bit MSVC Test bots to be quite a bit slower.
After discussion with mtklein, we probably only want to add the more
esoteric configs for 64-bit GCE bots.
No-Try: true
Change-Id: I04e78679c43b380173dce1ea718df5d897e875b7
Reviewed-on: https://skia-review.googlesource.com/128180
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:44:13 +00:00
Eric Boren
0f69010549
[recipes] BUILDTYPE and SKIA_OUT are no longer used
...
Bug: skia:6473
Change-Id: I67b0dbf6dba26233df1d8e44f3e2f69ca0cc9d3e
Reviewed-on: https://skia-review.googlesource.com/128320
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:36:23 +00:00
Ravi Mistry
5ab841f18b
Add chromium first to .gclient
...
Bug: skia:7917
Change-Id: Ie76c73c5b8ea24ca0ac54e79ad7597fdac19d860
Reviewed-on: https://skia-review.googlesource.com/128011
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-15 19:28:43 +00:00
Mike Klein
77bc821b03
asan_device_setup has moved
...
Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f
Reviewed-on: https://skia-review.googlesource.com/128016
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 19:44:40 +00:00
Mike Klein
8803ebb470
update to NDK r17
...
We haven't done this in a while.
The only interesting change I've noticed so far is that we no longer
need to link libandroid_support when targeting API 21+.
Change-Id: I6506fbe7bd02534f1ea136f2164acab7f44c29e0
Reviewed-on: https://skia-review.googlesource.com/128009
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 18:48:19 +00:00
Eric Boren
9030b94c60
[recipes] Separate build and test flavors
...
Bug: skia:6473
Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a
Reviewed-on: https://skia-review.googlesource.com/125947
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-14 17:27:49 +00:00
Ben Wagner
297e86b43e
[infra] Switch back to 16-core GCE VMs for Perf and Test.
...
This partially reverts
https://skia-review.googlesource.com/c/skia/+/124340
Bug: skia:7415, skia:7416
Change-Id: I2a838ff3c543ded54e962e905294811fbc97ef88
Reviewed-on: https://skia-review.googlesource.com/127965
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-14 17:14:19 +00:00
recipe-roller
06ba3fe323
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/d1de725e0b53f5f0bb331471e5673aee0e72a5b7 gclient: Prevent unprocessed deps from overriding processed ones in sync output. (jbudorick@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I42e385692bad3eece39dc1217c9e01f28e4ee5ab
Reviewed-on: https://skia-review.googlesource.com/127620
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-11 20:25:47 +00:00
Ben Wagner
9bcfcb32de
Roll clang for Windows to chromium's current.
...
This is mostly to pick up new warnings before chromium complains about
them.
Change-Id: I69a0c3da63398f98d3f45b0993ed3325c0edae27
Reviewed-on: https://skia-review.googlesource.com/127395
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-11 17:34:27 +00:00
recipe-roller
8fc73ed17d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e api.py: Check if to_leak directory exists before deleting it (charliea@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I94cbbfcc274f47f609710c5526361012cc3b7786
Reviewed-on: https://skia-review.googlesource.com/127392
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-11 15:11:27 +00:00
recipe-roller
03e7f36ee9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22 Reland "gclient: Get rid of parsed_url." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4aaefe70d029b40f62ecdf7624900227e3a498d2
Reviewed-on: https://skia-review.googlesource.com/127307
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-11 02:14:46 +00:00
recipe-roller
6c6ea2dabf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/3d894aa45e08b1d0d93483aa885df11e8156d93d bot_update: Fix manifest creation. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I015a27949f6212a96644755e840792a448b97b84
Reviewed-on: https://skia-review.googlesource.com/127382
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 23:23:16 +00:00
recipe-roller
959fc245a9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/2191308678e40e04930727589e11b26405afa165 Revert "gclient: Get rid of parsed_url." (jbudorick@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9cd80112f6de11d64c43304898de1f47efdc9a5f
Reviewed-on: https://skia-review.googlesource.com/127400
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 21:12:46 +00:00
recipe-roller
c153743d05
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/d3f2c8e7834616e48fbe7cef9286029361b043c5 win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain (kkinnunen@nvidia.com )
https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe gclient: Get rid of parsed_url. (ehmaldonado@chromium.org )
https://crrev.com/31a8da265a86aa3fec97edd5606cb443f633e6d7 bot_update: Assert no syncing of refs/remotes/* (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2981229dfec061e340bf75b3ad01fe63da4ebcb0
Reviewed-on: https://skia-review.googlesource.com/127339
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 20:08:56 +00:00
Mike Klein
ce4cf72e34
non-linear blending first steps
...
Code:
- Add a non-linear blending bit and makeNonlinearBlending()
to SkColorSpace
- remove enough F16=linear checks to make it possible to
create surfaces and encode pngs with nonlinear F16
Testing:
- add "esrgb" software config to DM, run it
- add "srgbnl" software config, run it
- deemphasize importance of "srgb" config on bots
- update unit tests to reflect relaxed F16 constraints
- add a new unit test file with _really_ basic tests,
and a new unit test that's not working yet
Bug: skia:7942
Change-Id: I8ac042bdf9f3d791765393b68fd9256375184d83
Reviewed-on: https://skia-review.googlesource.com/127325
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-10 18:26:22 +00:00
Ben Wagner
27d5a3661b
Switch machine-type for Coverage tasks.
...
Coverage doesn't seem to deal well with multiple threads. Using 2-core
VMs is faster than using 64-core VMs.
On the other hand, the Coverage Upload task performs much better on a
64-core VM.
Bug: skia:7415
No-Try: true
Change-Id: Ieb58fc47970dd66fa64cf6a8c9de1f9236e2f3a0
Reviewed-on: https://skia-review.googlesource.com/127053
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-05-10 15:45:45 +00:00
recipe-roller
563f264154
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/7c3ff1311a4568e3d369c35560ff77b6b2bdef96 Introduce GIT_TRACE_PERFORMANCE (tikuta@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6a25699d6434dee6f1aade3ff7f59842ba5334a0
Reviewed-on: https://skia-review.googlesource.com/127260
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 02:00:11 +00:00
recipe-roller
27c66e28e1
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/5623aeebe84fec98b7ae313368d1e57a6abfad65 Introduce GIT_TRACE for chromium/src in bot_update step (tikuta@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ief1196978f9bb1d5eca6bc255629588f9be77440
Reviewed-on: https://skia-review.googlesource.com/127240
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 01:27:11 +00:00
recipe-roller
1b6acd86fe
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/b61d387fa2d4e0ea7da1807d2922a4f946343d2d gclient: Make GetScmName and CreateSCM abstract methods. (ehmaldonado@chromium.org )
https://crrev.com/04065d39f743413a5dd57d8eb89c281454e03df8 Reland "bot_update: Fetch references to be synced." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6dbf9cd9367f1ccf6cce259c744b49bfbfd1cbb
Reviewed-on: https://skia-review.googlesource.com/127135
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-10 00:33:11 +00:00
recipe-roller
8094749628
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/afec759dca62d9239f75ec5643592331a6aa18a2 Revert "bot_update: Fetch references to be synced." (agrieve@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e64bc991f48cf6ba8c2cadf91949fb87a588c38
Reviewed-on: https://skia-review.googlesource.com/126927
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-09 15:19:45 +00:00
recipe-roller
499a9b2108
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/5ae86d2021277b545889959125e778820849cf15 Update canned PRESUBMIT checks to report that TBR does not apply to OWNERS. (jbroman@chromium.org )
https://crrev.com/276da0b4d90aad69aa0adcf3e6a792b5e364c1ee git cl: Do not set WIP when using no_squash. (jmadill@chromium.org )
https://crrev.com/3806b7fbd0ea6704d2c35d1eb64a2a505e29ca53 bot_update: Fetch references to be synced. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I651e8c1af3cb363b403cb921c1945028d1ebef4c
Reviewed-on: https://skia-review.googlesource.com/126827
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-09 01:36:04 +00:00
Kevin Lubick
e0b7f5cb0c
Trim down T8888 configs
...
Don't run them on non-GCE bots either.
Bug: skia:
Change-Id: I15f9a1b7e74eb89a5d580d4e5f82be6e27335600
Reviewed-on: https://skia-review.googlesource.com/126501
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-07 19:43:07 +00:00
recipe-roller
a3fde20002
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa Update windows git to 2.17.0 (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifbc1b41b9b4f0ddd86726c3094e439a5cf62b676
Reviewed-on: https://skia-review.googlesource.com/126504
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-07 18:32:39 +00:00
Robert Phillips
5575ffec63
Add Pixel2 DDL Vulkan bots
...
Change-Id: I396fef460cf2725993fad691c0187dcb724c0e23
Reviewed-on: https://skia-review.googlesource.com/126462
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-07 16:57:59 +00:00
Kevin Lubick
a585f73bbe
Remove T8888 from Windows CQ bot
...
This is a stop-gap measure.
Bug: skia:7838#c20
Change-Id: Ib9af9aefa4327d24f66f95d9a82ee53c19733524
Reviewed-on: https://skia-review.googlesource.com/126461
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-07 16:43:28 +00:00
Stephan Altmueller
beca172554
Add datastore emulator to gcloud asset
...
Bug: skia:
Change-Id: I2f0986e0ae3057e0a7fca479c0f3e062f10c3eba
Reviewed-on: https://skia-review.googlesource.com/126205
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-07 15:46:40 +00:00
recipe-roller
32d8f883bd
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/5e5f2d60353bb93898302458f37ae667d60c7b8e bot_update: attempt to disable GC completely on main repo. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id250c8aa094e19cae2658904fdffa9eb5517d5ab
Reviewed-on: https://skia-review.googlesource.com/126280
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-05 03:11:33 +00:00
recipe-roller
fb799af68b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/15759121361d022b84c2759281e024f94fb2e0d1 Update windows bleeding-edge git to 2.17.0 (tandrii@chromium.org )
https://crrev.com/142a92ce8b834a412c16c0451ed8d434ea323e58 auth: request refresh tokens with expiry <3 minutes. (tandrii@chromium.org )
https://crrev.com/ea240053f95686277bd86700d7a1209dc09474f4 gclient: Update catapult and custom-tab-client origin URLs (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If64a0f4c6b875e8a2043c1ee5923895b9026965d
Reviewed-on: https://skia-review.googlesource.com/126202
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-04 23:04:13 +00:00
Ben Wagner
e99a4b1099
[infra] Move GCE tasks to smaller/larger VMs.
...
Bug: skia:7415, skia:7416
Change-Id: Ibdd391dce62ff16bfc7fa8d860c3cbcaddab7c4d
Reviewed-on: https://skia-review.googlesource.com/124340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-04 19:13:43 +00:00
Eric Boren
b702316d9a
[recipes] Remove core.setup()
...
Each recipe now includes its own setup steps.
Bug: skia:6473
Change-Id: I97eab2cd63f5004c07408e844cbbed735aac355f
Reviewed-on: https://skia-review.googlesource.com/125660
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-04 18:23:13 +00:00
Eric Boren
44a68b3b3b
[infra] Remove PDFium bot and associated recipe code
...
Bug: skia:7890
Change-Id: I8322b145800dc41ac59322e89804ff9356d8e767
Reviewed-on: https://skia-review.googlesource.com/125864
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-04 14:59:32 +00:00
recipe-roller
76c01c930c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/ea50265aefdf0a262fdf315c2f4193345f6cefca Revert "Reland "bot_update: Patch on gclient by default."" (martiniss@chromium.org )
https://crrev.com/848c86e3e858154175944198db821e80ec7ebfc5 Make 'gclient_gn_args*' handling consistent between sync and flatten. (mmoss@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe7c8c848d0cf0344c33365e4b07370c7fcce808
Reviewed-on: https://skia-review.googlesource.com/125860
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-04 11:53:12 +00:00
recipe-roller
452c90256c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/8f20428bf4dc574b138a63ae705b74af3945cdda Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74277bb189edc7e22d8914beb71249184bd1d894
Reviewed-on: https://skia-review.googlesource.com/125824
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-04 11:04:03 +00:00
Eric Boren
2f62de01d3
[recipes] Mostly remove bot_update patch_ref hack
...
We need to do some refactoring to remove the repository hack for
cross-repo tryjobs.
Bug: skia:6473
Change-Id: Ie96fba75f6f1752575a4c7cc5b0208a37f0bd73d
Reviewed-on: https://skia-review.googlesource.com/125724
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-03 14:37:31 +00:00
recipe-roller
2ea8470941
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/1037c743e33821d9aebda2624be4cc2a9a35c21d presubmit: Don't overwrite cwd when running tests. (ehmaldonado@chromium.org )
https://crrev.com/6c692edf010ce9e43737406c53f399b13631ac4f Reland "bot_update: Set user.{name,email} when applying patch refs." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1dd2e86a516f88e156b2b216bcbc241d291441cd
Reviewed-on: https://skia-review.googlesource.com/125291
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-02 17:06:37 +00:00
Kevin Lubick
e467d4e656
Update all remaining Chromebooks to m67
...
Bug: skia:
Change-Id: Ice96cc476b8f022fea250c88c1ec16de6482c704
Reviewed-on: https://skia-review.googlesource.com/124984
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-01 17:37:34 +00:00
recipe-roller
abd51ad92a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/166bc4ceedaf972ed01b8ea5cb5f453e4b7e2f18 Add mojom and fidl files to DEFAULT_WHITE_LIST (sergeyu@chromium.org )
https://crrev.com/1eb58e1f8892bdc23060b37265ef4941de3965ba Add a recipe config to enable the bot_update "--with_tags" flag. (mmoss@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I793d171d7bc1ba6ab886ccde42eab2e07197c235
Reviewed-on: https://skia-review.googlesource.com/124980
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-01 17:32:14 +00:00
Kevin Lubick
ff8387fae4
Update SamsungChromebook2012 to m67
...
Bug: skia:
Change-Id: Icf90148fadb2293c300962bdf3551c0a9cf1aee0
Reviewed-on: https://skia-review.googlesource.com/124811
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 15:12:34 +00:00
Kevin Lubick
e114e59f37
Update MaliT764 Chromebooks
...
Bug: skia:
NOTRY=true
Change-Id: I739e3596e1266df6c533f552b5583de2a5f5f9f5
Reviewed-on: https://skia-review.googlesource.com/124808
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 13:17:48 +00:00
recipe-roller
d5750b6b33
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/e86fe982e811360b8e9dcb3688c543efd153fff4 bot_update: Set user.{name,email} when applying patch refs. (ehmaldonado@chromium.org )
https://crrev.com/43d72759fed16f6666fa08efb54400ff7887fd9e Revert "bot_update: Set user.{name,email} when applying patch refs." (martiniss@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibb4e9d0204158c1203fc8f447342e047e3de6203
Reviewed-on: https://skia-review.googlesource.com/124764
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-30 23:31:34 +00:00
recipe-roller
0b34edaa39
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/c6e57bb748380489c67d7f680627f09734c01845 bot_update: really check whether repo is pinned at an actual sha1 revision. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4a76dfee0a1bb17be954dd3e075747c6544ae7df
Reviewed-on: https://skia-review.googlesource.com/124642
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-04-30 19:59:03 +00:00
Eric Boren
eb00f0796a
[infra] Use new GS bucket for assets
...
Bug: skia:
Change-Id: I9e75a703c7063e8a74b7469507f87b44a52c07b3
Reviewed-on: https://skia-review.googlesource.com/124641
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-30 19:36:13 +00:00
Chris Dalton
117d9729c1
skpbench: Add support for Pixel 2
...
Bug: skia:
Change-Id: Ic0901ca84bf8e3fda29b3bd7a0504396445ca0f4
Reviewed-on: https://skia-review.googlesource.com/124282
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-30 15:29:13 +00:00
Eric Boren
82cb619314
[infra] Calmbench: fix path to nanobench executable
...
Bug: skia:7883
Change-Id: Id363d59d2466c3f4fae8a79e6ad9e6c270e445ae
Reviewed-on: https://skia-review.googlesource.com/124403
Commit-Queue: Eric Boren <borenet@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Auto-Submit: Eric Boren <borenet@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2018-04-30 13:34:00 +00:00
skia-recreate-skps
efb4d08dd4
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: Icceb22e4d0f70ab18b0648eaa73dafe14cb49702
Reviewed-on: https://skia-review.googlesource.com/124376
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-04-29 08:15:36 +00:00
recipe-roller
34a388edbd
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c17eef1bc11c5f44462101e8ceaa0f76c9e872bf file: method for creating temporary files (phosek@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie6864985ab23d8e5f70f550c7216531990abbcc3
Reviewed-on: https://skia-review.googlesource.com/124346
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-27 20:29:48 +00:00
Yuqian Li
cb31248132
Reland "Reland "Reland "Exercise the threaded backend in test bots"""
...
This reverts commit 47f2b7b089
.
Reason for revert: try to fix the issue by reducing the set of bots
Original change's description:
> Revert "Reland "Reland "Exercise the threaded backend in test bots"""
>
> This reverts commit 7ddad479e4
.
>
> Reason for revert: bots failure
>
> Original change's description:
> > Reland "Reland "Exercise the threaded backend in test bots""
> >
> > This reverts commit 0f5972604c
.
> >
> > Reason for revert: ASAN/MSAN should have been fixed
> >
> > Original change's description:
> > > Revert "Reland "Exercise the threaded backend in test bots""
> > >
> > > This reverts commit 654ca8a340
.
> > >
> > > Reason for revert: ASAN,MSAN failures
> > >
> > > Original change's description:
> > > > Reland "Exercise the threaded backend in test bots"
> > > >
> > > > This reverts commit ea51393ba9
.
> > > >
> > > > Reason for revert: try again after many fixes of the threaded backend
> > > >
> > > > Original change's description:
> > > > > Revert "Exercise the threaded backend in test bots"
> > > > >
> > > > > This reverts commit a39991ebd7
.
> > > > >
> > > > > Reason for revert: Random bots timeout
> > > > >
> > > > > Original change's description:
> > > > > > Exercise the threaded backend in test bots
> > > > > >
> > > > > > We can't draw everything correctly now, but it's at least not crashing.
> > > > > >
> > > > > > The draw_to_canvas is modified by adding flush because now the raster
> > > > > > canvas also needs flush like GPU canvases because of the threaded
> > > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > > > > > and that's why it was not crashing.)
> > > > > >
> > > > > >
> > > > > > Bug: skia:
> > > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > > > > > Reviewed-on: https://skia-review.googlesource.com/118886
> > > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > > > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > > > >
> > > > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > > > >
> > > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: skia:
> > > > > Reviewed-on: https://skia-review.googlesource.com/119100
> > > > > Reviewed-by: Yuqian Li <liyuqian@google.com>
> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > > >
> > > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: skia:7838
> > > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
> > > > Reviewed-on: https://skia-review.googlesource.com/121680
> > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > > > Reviewed-by: Yuqian Li <liyuqian@google.com>
> > >
> > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > >
> > > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: skia:7838
> > > Reviewed-on: https://skia-review.googlesource.com/123360
> > > Reviewed-by: Mike Klein <mtklein@google.com>
> > > Commit-Queue: Mike Klein <mtklein@google.com>
> >
> > TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: skia:7838
> > Change-Id: I205d579f2959ea726b447993314c1326b731730e
> > Reviewed-on: https://skia-review.googlesource.com/123660
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > Reviewed-by: Yuqian Li <liyuqian@google.com>
>
> TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
>
> Change-Id: I1d3986cc2af12836dd7acbcbba713081a88301a6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:7838
> Reviewed-on: https://skia-review.googlesource.com/124200
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
Change-Id: I2d4d0c172849a86b37c60b32938a7a2b828258fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7838
Reviewed-on: https://skia-review.googlesource.com/124201
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2018-04-27 19:53:48 +00:00
recipe-roller
134acf7944
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/179dd1e01695137c08ac1ccc49e3b909bb5f75e0 input_api.DEFAULT_BLACK_LIST should not block third_party/blink. (tkent@chromium.org )
recipe_engine:
https://crrev.com/8bb8a8eddc83b7110083f1fef2aaafaf7bd25d90 Handle long paths on Windows part 2 (martiniss@google.com )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id21781592e46ea2e1d1e286527344b2531cc16b8
Reviewed-on: https://skia-review.googlesource.com/124342
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-04-27 19:47:18 +00:00
Eric Boren
5cb5c74efd
Reland "[recipes] Use named caches for git and workdirs"
...
This reverts commit 01d3eb64e7
.
Bug: skia:
Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f
Reviewed-on: https://skia-review.googlesource.com/124260
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-27 18:18:48 +00:00
Ravi Mistry
3057325116
Revert "Remove Android compile bot from the CQ"
...
This reverts commit e033e969ca
.
Reason for revert: Should be fast now
Original change's description:
> Remove Android compile bot from the CQ
>
> NoTry: True
> Bug: skia:7834
> Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72
> Reviewed-on: https://skia-review.googlesource.com/122945
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Auto-Submit: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>
TBR=borenet@google.com ,rmistry@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
NoTry: true
Bug: skia:7815
Change-Id: I55bba2de4bbff904b92b99802f13c9de55bc9191
Reviewed-on: https://skia-review.googlesource.com/124300
Auto-Submit: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-04-27 13:42:17 +00:00
Ben Wagner
82a3342516
[infra] Specify machine_type dimension for Linux GCE bots.
...
This is in preparation of assigning bots either "small" or "large" GCE
machines.
Bug: skia:7415, skia:7416
Change-Id: I82b6fe454ba3622ef8a9d515dc3e72362dd30ee5
Reviewed-on: https://skia-review.googlesource.com/124183
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-27 12:51:47 +00:00
Chris Dalton
414be9b332
Blacklist filltypespersp on IntelHD405 vulkan
...
Bug: skia:
Change-Id: Ie5840216ed0f34cf55bac9d720a2f78069022eb3
Reviewed-on: https://skia-review.googlesource.com/123916
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-27 00:38:13 +00:00
recipe-roller
6c71feaae7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/97ce05851cb5559459058706a69e81ddaed54f1e gclient_scm: Try to rebase after printing what was wrong. (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id9b641b97bdf3693ec4d47e2495af038c41c728c
Reviewed-on: https://skia-review.googlesource.com/124184
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 22:46:24 +00:00
Ben Wagner
01d3eb64e7
Revert "[recipes] Use named caches for git and workdirs"
...
This reverts commit e8615f969e
.
Reason for revert: Causing CommandBuffer builds to time out
Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
----------------
Revert "[infra] Fix missing cache for Bookmaker"
This reverts commit d19f039a16
.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
----------------
Revert "Fix missing/duplicate named caches"
This reverts commit 0820a6fb69
.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>
----------------
TBR=borenet@google.com ,benjaminwagner@google.com,rmistry@google.com
Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 22:21:04 +00:00
Yuqian Li
47f2b7b089
Revert "Reland "Reland "Exercise the threaded backend in test bots"""
...
This reverts commit 7ddad479e4
.
Reason for revert: bots failure
Original change's description:
> Reland "Reland "Exercise the threaded backend in test bots""
>
> This reverts commit 0f5972604c
.
>
> Reason for revert: ASAN/MSAN should have been fixed
>
> Original change's description:
> > Revert "Reland "Exercise the threaded backend in test bots""
> >
> > This reverts commit 654ca8a340
.
> >
> > Reason for revert: ASAN,MSAN failures
> >
> > Original change's description:
> > > Reland "Exercise the threaded backend in test bots"
> > >
> > > This reverts commit ea51393ba9
.
> > >
> > > Reason for revert: try again after many fixes of the threaded backend
> > >
> > > Original change's description:
> > > > Revert "Exercise the threaded backend in test bots"
> > > >
> > > > This reverts commit a39991ebd7
.
> > > >
> > > > Reason for revert: Random bots timeout
> > > >
> > > > Original change's description:
> > > > > Exercise the threaded backend in test bots
> > > > >
> > > > > We can't draw everything correctly now, but it's at least not crashing.
> > > > >
> > > > > The draw_to_canvas is modified by adding flush because now the raster
> > > > > canvas also needs flush like GPU canvases because of the threaded
> > > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > > > > and that's why it was not crashing.)
> > > > >
> > > > >
> > > > > Bug: skia:
> > > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > > > > Reviewed-on: https://skia-review.googlesource.com/118886
> > > > > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > > >
> > > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > > >
> > > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: skia:
> > > > Reviewed-on: https://skia-review.googlesource.com/119100
> > > > Reviewed-by: Yuqian Li <liyuqian@google.com>
> > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > >
> > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: skia:7838
> > > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
> > > Reviewed-on: https://skia-review.googlesource.com/121680
> > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > > Reviewed-by: Yuqian Li <liyuqian@google.com>
> >
> > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> >
> > Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: skia:7838
> > Reviewed-on: https://skia-review.googlesource.com/123360
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Commit-Queue: Mike Klein <mtklein@google.com>
>
> TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: skia:7838
> Change-Id: I205d579f2959ea726b447993314c1326b731730e
> Reviewed-on: https://skia-review.googlesource.com/123660
> Commit-Queue: Yuqian Li <liyuqian@google.com>
> Reviewed-by: Yuqian Li <liyuqian@google.com>
TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
Change-Id: I1d3986cc2af12836dd7acbcbba713081a88301a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7838
Reviewed-on: https://skia-review.googlesource.com/124200
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-04-26 21:34:14 +00:00
Ben Wagner
0820a6fb69
Fix missing/duplicate named caches
...
Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
No-Try: true
Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
Reviewed-on: https://skia-review.googlesource.com/124180
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-26 21:14:43 +00:00
Yuqian Li
7ddad479e4
Reland "Reland "Exercise the threaded backend in test bots""
...
This reverts commit 0f5972604c
.
Reason for revert: ASAN/MSAN should have been fixed
Original change's description:
> Revert "Reland "Exercise the threaded backend in test bots""
>
> This reverts commit 654ca8a340
.
>
> Reason for revert: ASAN,MSAN failures
>
> Original change's description:
> > Reland "Exercise the threaded backend in test bots"
> >
> > This reverts commit ea51393ba9
.
> >
> > Reason for revert: try again after many fixes of the threaded backend
> >
> > Original change's description:
> > > Revert "Exercise the threaded backend in test bots"
> > >
> > > This reverts commit a39991ebd7
.
> > >
> > > Reason for revert: Random bots timeout
> > >
> > > Original change's description:
> > > > Exercise the threaded backend in test bots
> > > >
> > > > We can't draw everything correctly now, but it's at least not crashing.
> > > >
> > > > The draw_to_canvas is modified by adding flush because now the raster
> > > > canvas also needs flush like GPU canvases because of the threaded
> > > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > > > and that's why it was not crashing.)
> > > >
> > > >
> > > > Bug: skia:
> > > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > > > Reviewed-on: https://skia-review.googlesource.com/118886
> > > > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > >
> > > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> > >
> > > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: skia:
> > > Reviewed-on: https://skia-review.googlesource.com/119100
> > > Reviewed-by: Yuqian Li <liyuqian@google.com>
> > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> >
> > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: skia:7838
> > Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
> > Reviewed-on: https://skia-review.googlesource.com/121680
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > Reviewed-by: Yuqian Li <liyuqian@google.com>
>
> TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
>
> Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:7838
> Reviewed-on: https://skia-review.googlesource.com/123360
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com ,kjlubick@google.com,stephana@google.com,liyuqian@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7838
Change-Id: I205d579f2959ea726b447993314c1326b731730e
Reviewed-on: https://skia-review.googlesource.com/123660
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2018-04-26 21:03:13 +00:00
Ben Wagner
be9aa8d006
Update Win2016 bots.
...
Change-Id: I6b8a16dd6aa1d188a46ca1bdf82c4023d6bab21a
Reviewed-on: https://skia-review.googlesource.com/124043
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-26 19:55:29 +00:00
Eric Boren
d19f039a16
[infra] Fix missing cache for Bookmaker
...
Bug: skia:
Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
Reviewed-on: https://skia-review.googlesource.com/124052
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 19:53:53 +00:00
recipe-roller
8f379d4d64
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/990148ed24f058d28c3abc12eb9b3ef7ffc3c56e gclient: Fix logic to match --patch-ref with dependencies. (ehmaldonado@chromium.org )
https://crrev.com/7580f9dac98552b038f9644cf9712f09712c7858 Revert "Reland "bot_update: Patch on gclient by default."" (bpastene@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic19122334c0dea7318b8238df286b1040df765d5
Reviewed-on: https://skia-review.googlesource.com/124049
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 19:46:23 +00:00
Eric Boren
e8615f969e
[recipes] Use named caches for git and workdirs
...
Bug: skia:
Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
Reviewed-on: https://skia-review.googlesource.com/123929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 18:51:13 +00:00
skia-recreate-skps
329694260c
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I3d3d0fb933915f79bf993bf6734e1bdf0dfd52f9
Reviewed-on: https://skia-review.googlesource.com/123909
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 18:49:13 +00:00
recipe-roller
f04c73f414
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/e38cf570fc8c0df53b576c179701efe6d683f7d2 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I132f51f6f407c8a2e77abef4b0adc7a2f9d5ced9
Reviewed-on: https://skia-review.googlesource.com/123938
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 18:20:53 +00:00
Kevin Lubick
88611a1a71
Update test expectations for Debian9
...
The removal of the blacklists is really a no-op because of
https://skia-review.googlesource.com/c/skia/+/9339
Bug: skia:7840
Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909
Reviewed-on: https://skia-review.googlesource.com/123925
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-26 17:16:53 +00:00
Eric Boren
e7950e3923
[infra] RecreateSKPs and Bookmaker need the Git packages
...
Bug: skia:7833, skia:7050
Change-Id: I8272e4b0beaed2a56260546f4a599a4586c71792
Reviewed-on: https://skia-review.googlesource.com/123921
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:28:53 +00:00
Eric Boren
c2a8870316
[infra] Enable retries for Windows compiles
...
They're flaky due to https://github.com/golang/go/issues/21376
Bug: skia:
Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8
Reviewed-on: https://skia-review.googlesource.com/123932
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:18:23 +00:00
Eric Boren
1178ea0f7b
[infra] Make the Android_Framework bot run on demand
...
This causes it to never get triggered automatically, so it will only run
as a try job or when force-triggered.
Caveat: if the job is defined on non-master branches, it will still
trigger for those branches.
Bug: skia:
Change-Id: Idff63bd22536b21ec21eb4b569cc392642297d7b
Reviewed-on: https://skia-review.googlesource.com/123923
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 13:22:43 +00:00
Kevin Lubick
72d92a0b42
Move Braswell HD 405 bots to Debian 9.4
...
Bug: skia:7840
Change-Id: I36114c55322a886a02d5588cc403984ea3c09aca
Reviewed-on: https://skia-review.googlesource.com/123745
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-26 12:29:07 +00:00
recipe-roller
5c9369eb14
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/3cb0767ac14e06a63a6e90d34c1c139b128dd87b recipes: cache destination branch of a Gerrit change. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia51e2e05c41b375483ab88b5a99f8973f7de9690
Reviewed-on: https://skia-review.googlesource.com/123868
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 08:24:00 +00:00
recipe-roller
643ab1bf52
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c93ee0e7a9941356e1a7489af1abc2dca43f2c97 Add OWNERS to LUCI recipe modules. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9eb65fd8b6d65c7a5116cf9800e8bb455d977875
Reviewed-on: https://skia-review.googlesource.com/123867
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 07:11:00 +00:00
recipe-roller
5b1bc694a6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/0a82af179bce717e9be1240286497312309487d0 service_account: remove ability to vary lifetime and set it to 180s. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I953b7f1a8ddb6b9f289f580e79dbdf01d6700001
Reviewed-on: https://skia-review.googlesource.com/123863
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 06:29:30 +00:00
recipe-roller
e56ced15da
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/355b11a31f0d2bd2fcc4e14f8abc8681edbf3b2d bot_update: Patch on gclient by default. (ehmaldonado@chromium.org )
https://crrev.com/cab00ccf8edb80933cd74612c232959fc3beae05 CQ: switch to 100% LUCI builders. (tandrii@chromium.org )
https://crrev.com/2acf4957984643d8ac1a856afed0730c4449e190 Revert "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org )
recipe_engine:
https://crrev.com/e315ab3c7742e21b293911eb61e0c0a2e877acab cq: switch to 100% LUCI. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I764502e99af4388c917db514f55763ff031e15d2
Reviewed-on: https://skia-review.googlesource.com/123861
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 05:58:10 +00:00
Eric Boren
b66099b9fb
[infra] Run presubmit like a normal bot
...
Bug: skia:
Change-Id: If01c10c21477bd61c4ec1d4f59921745eb3bf494
Reviewed-on: https://skia-review.googlesource.com/123622
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-25 19:36:47 +00:00
Adrienne Walker
6f719aeeae
Add CheckGeneratedFiles recipe check for gpu workarounds
...
Followup to https://skia-review.googlesource.com/122800
Bug: chromium: 829614
Change-Id: Idde753e0f8943290208625ba5b6332a5fdc07184
Reviewed-on: https://skia-review.googlesource.com/123536
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 19:26:27 +00:00
Kevin Lubick
cfd650e43f
Move Baytrail to stretch
...
Bug: skia:
Change-Id: Ib7fe82df428038e1be773446c121010665fe7472
Reviewed-on: https://skia-review.googlesource.com/123628
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-25 18:52:07 +00:00
Ben Wagner
f8f1839cc8
Upgrade Win Radeon driver.
...
Bug: skia:7809
Change-Id: I9266a16acee92f5a5fcb8e723890c1793c957bf3
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123589
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-25 16:45:57 +00:00
Kevin Lubick
d9b414f37d
Migrate ShuttleA bots to Debian9 stretch
...
Bug: skia:
Change-Id: I0f405b7aed7b90dbeb18e6a419b2eb67725148d0
Reviewed-on: https://skia-review.googlesource.com/123624
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-25 15:41:57 +00:00
Kevin Lubick
ec4e7358ba
Migrate NUC7i5BNK to Debian 9
...
Bug: skia:
Change-Id: Icd537f098742a89469e9165e14b230e769247e54
Reviewed-on: https://skia-review.googlesource.com/123563
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-25 13:13:07 +00:00
Ben Wagner
e1c37a7b8f
[infra] Add image dimension for Win GCE bots
...
Change-Id: Ib7a8205992c6c1f4d93448afe54468f77511f1f0
Reviewed-on: https://skia-review.googlesource.com/123585
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 11:19:46 +00:00
Eric Boren
fb20ac4578
[infra] internal_hardware_label is a string now
...
Thanks, Python.
Bug: skia:7050
Change-Id: I71434effc5da31967190e2eb06bbba2010061e80
Reviewed-on: https://skia-review.googlesource.com/123502
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-24 19:14:16 +00:00
Eric Boren
e9a670045f
[infra] Fix missing internal_hardware_label property
...
Bug: skia:7050
Change-Id: I9fd99f63886c29b42c22d108b5ae29392827dc77
Reviewed-on: https://skia-review.googlesource.com/123427
Auto-Submit: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-24 17:50:56 +00:00
recipe-roller
01bc273bc5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/cb62e48b5424c4bc36b919cc7ed61484599bbc70 Check format of OWNERS files in PRESUBMIT and PanProjectChecks. (ehmaldonado@chromium.org )
https://crrev.com/4d0f2a33269e456e4897c8ee0b8c750a8c5d8284 cq: start using LUCI downstream testers as an experiment. (tandrii@chromium.org )
recipe_engine:
https://crrev.com/480046798daeca78c14e4514b25da0c50cf2b680 cq: start using LUCI downstream recipe rollers as an experiment. (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d28eaff9e6165724d848febf48e907a8cfb45ff
Reviewed-on: https://skia-review.googlesource.com/123244
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-24 03:09:06 +00:00
Mike Klein
0f5972604c
Revert "Reland "Exercise the threaded backend in test bots""
...
This reverts commit 654ca8a340
.
Reason for revert: ASAN,MSAN failures
Original change's description:
> Reland "Exercise the threaded backend in test bots"
>
> This reverts commit ea51393ba9
.
>
> Reason for revert: try again after many fixes of the threaded backend
>
> Original change's description:
> > Revert "Exercise the threaded backend in test bots"
> >
> > This reverts commit a39991ebd7
.
> >
> > Reason for revert: Random bots timeout
> >
> > Original change's description:
> > > Exercise the threaded backend in test bots
> > >
> > > We can't draw everything correctly now, but it's at least not crashing.
> > >
> > > The draw_to_canvas is modified by adding flush because now the raster
> > > canvas also needs flush like GPU canvases because of the threaded
> > > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > > and that's why it was not crashing.)
> > >
> > >
> > > Bug: skia:
> > > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > > Reviewed-on: https://skia-review.googlesource.com/118886
> > > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > > Commit-Queue: Yuqian Li <liyuqian@google.com>
> >
> > TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
> >
> > Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: skia:
> > Reviewed-on: https://skia-review.googlesource.com/119100
> > Reviewed-by: Yuqian Li <liyuqian@google.com>
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
>
> TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: skia:7838
> Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
> Reviewed-on: https://skia-review.googlesource.com/121680
> Commit-Queue: Yuqian Li <liyuqian@google.com>
> Reviewed-by: Yuqian Li <liyuqian@google.com>
TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
Change-Id: Id1b273e22a1d0cbc15a2155252909f576b401fa4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7838
Reviewed-on: https://skia-review.googlesource.com/123360
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-04-23 23:58:37 +00:00
Yuqian Li
654ca8a340
Reland "Exercise the threaded backend in test bots"
...
This reverts commit ea51393ba9
.
Reason for revert: try again after many fixes of the threaded backend
Original change's description:
> Revert "Exercise the threaded backend in test bots"
>
> This reverts commit a39991ebd7
.
>
> Reason for revert: Random bots timeout
>
> Original change's description:
> > Exercise the threaded backend in test bots
> >
> > We can't draw everything correctly now, but it's at least not crashing.
> >
> > The draw_to_canvas is modified by adding flush because now the raster
> > canvas also needs flush like GPU canvases because of the threaded
> > backend. (Previously, AndroidCodecSrc vetoed GPU (non-raster) sink
> > and that's why it was not crashing.)
> >
> >
> > Bug: skia:
> > Change-Id: I222d706c33e15326e1b97d6bef6c46b8c35cebfd
> > Reviewed-on: https://skia-review.googlesource.com/118886
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
>
> TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
>
> Change-Id: Ib1089d937b6e25cc39d90ad4de35b3a4c406f6b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/119100
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
TBR=kjlubick@google.com ,stephana@google.com,liyuqian@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7838
Change-Id: I1405212204bf694b2f31dfc38154759e1d3e363f
Reviewed-on: https://skia-review.googlesource.com/121680
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2018-04-23 23:22:46 +00:00
Robert Phillips
9ad12134c9
Suppress BlurMaskBiggerThanDest on NexusPlayer for Vulkan
...
Bug: skia:7837
Change-Id: Ic7348268da5d131504e5a6cf53534d3a982422c7
Reviewed-on: https://skia-review.googlesource.com/123101
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 19:13:20 +00:00
Robert Phillips
a96a101071
Disable BlurMaskBiggerThanDest unit test on ANGLE
...
Bug: skia:7835
Change-Id: Iec9469799121f435670c5a3841707fe6199066c5
Reviewed-on: https://skia-review.googlesource.com/122954
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 15:07:00 +00:00
Ben Wagner
122b38560f
Add SwiftShader Test jobs.
...
Bug: skia:7671
Change-Id: I29134929071ba6c59de948e5f579d33e973f9baa
Reviewed-on: https://skia-review.googlesource.com/122541
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-23 15:01:40 +00:00
recipe-roller
c4d6a001cd
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f presubmit: don't attempt to verify nonexistent vpython specs. (jbudorick@chromium.org )
https://crrev.com/98824231fc49c39ec47005c1e580684fc34d3026 [git-cl] make more informative error message. (tandrii@chromium.org )
https://crrev.com/5c62ed59d2a3901931d01b27388d7c0037178a8e owners: Add support for comments at the end of the line. (ehmaldonado@chromium.org )
https://crrev.com/733d4ec8e3364f9491291963475aee2a137bb2f1 [gerrit_util] learn about and use LUCI_CONTEXT when available. (tandrii@chromium.org )
https://crrev.com/b3c4441c8176780f5f58e22c1ffb9406f9934799 [auth] cache LUCI_CONTEXT local_auth parameters. (tandrii@chromium.org )
https://crrev.com/741afe8c930f988eb8d2b715540cfc598b12c38a [auth] cleanup old code.google.com oauth scope usage. (tandrii@chromium.org )
https://crrev.com/067ef5d8941a59ca176f5ee63bb02d0e3df947c4 Add support for checking that OWNERS files are correctly formatted. (ehmaldonado@chromium.org )
https://crrev.com/94580ab035eb3d05e352dc9c16b4908e9f744579 [auth] Fix typo introduced in https://crrev.com/c/1018488/13/auth.py#514 (tandrii@chromium.org )
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I98cd3d3913f1289be562add4d7170ff2b8ac7263
Reviewed-on: https://skia-review.googlesource.com/122950
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-04-23 14:38:40 +00:00
Eric Boren
5c2ed720ec
[infra] Fast-forward recipes, re-enable roller
...
Bug: skia:
Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1
Reviewed-on: https://skia-review.googlesource.com/122300
Auto-Submit: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 14:06:50 +00:00