Commit Graph

11749 Commits

Author SHA1 Message Date
commit-bot@chromium.org
60b5dce199 expose CGImage -> SkBitmap
BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243463005

git-svn-id: http://skia.googlecode.com/svn/trunk@14315 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 20:24:33 +00:00
commit-bot@chromium.org
945ec3a2be Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)
Reason for revert:
need to test more the code-path where we don't opt into the new virtuals

Original issue's description:
> make drawText calls non-virtual, to ease SkFont and TextBlob
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14307

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/247983003

git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 20:07:30 +00:00
commit-bot@chromium.org
d10ec40031 gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja
BUG=skia:2442
R=caryclark@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/247143003

git-svn-id: http://skia.googlecode.com/svn/trunk@14313 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 20:05:35 +00:00
bsalomon@google.com
d7ee4b6699 Change valgrind suppresion names for bug 2455.
BUG=skia:2455

Review URL: https://codereview.chromium.org/248063002

git-svn-id: http://skia.googlecode.com/svn/trunk@14312 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:58:58 +00:00
robertphillips@google.com
6fa0e32705 Reverting Skia r14299 ( Remove guards Chromium no longer needs - https://codereview.chromium.org/246403004)
git-svn-id: http://skia.googlecode.com/svn/trunk@14311 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:53:25 +00:00
commit-bot@chromium.org
35ffc446b7 Adding the ability to click on the images in the history and have that load the code and image back into the editor space.
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14310 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:32:06 +00:00
bsalomon@google.com
f7ad002b3e Update valgrind suppression names for bug 2453
BUG=skia:2453

Review URL: https://codereview.chromium.org/246653004

git-svn-id: http://skia.googlecode.com/svn/trunk@14309 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:30:16 +00:00
bsalomon@google.com
6419ee64ee Mark bench suppressions with bug #
BUG=skia:2452

Review URL: https://codereview.chromium.org/246513005

git-svn-id: http://skia.googlecode.com/svn/trunk@14308 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:17:54 +00:00
commit-bot@chromium.org
4325d114a5 make drawText calls non-virtual, to ease SkFont and TextBlob
BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243853006

git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:03:02 +00:00
bsalomon@google.com
f1eba21838 Add Valgrind suppression file for bench
BUG=skia:2450
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/246313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14306 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 18:47:02 +00:00
commit-bot@chromium.org
16307bd650 Fix build: Windows has dibs on IGNORE
Also, make sure to undef macros after we're done with them.

BUG=skia:

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247573003

git-svn-id: http://skia.googlecode.com/svn/trunk@14305 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 18:32:58 +00:00
bsalomon@google.com
c8f16c72dd Increase range for skp that triggers a perf regression periodically
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/247073004

git-svn-id: http://skia.googlecode.com/svn/trunk@14304 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 18:31:55 +00:00
reed@google.com
dcacd5fd5a eliminate config param -- it was always self's config
BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/246513002

git-svn-id: http://skia.googlecode.com/svn/trunk@14303 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 18:22:30 +00:00
commit-bot@chromium.org
dcecb16896 fix size_t/int warnings in pictures
BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/244273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14302 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 17:54:29 +00:00
bungeman@google.com
c18ba27a8b Remove SK_IGNORE_FREETYPE_ROTATION_FIX and guarded code.
Chromium/Blink have removed this define and rebaselined.
The guarded code is no longer used.


git-svn-id: http://skia.googlecode.com/svn/trunk@14301 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 17:37:34 +00:00
commit-bot@chromium.org
88c3e279ab Refactor SkRecord opts, converting playback optimizations where possible.
This adds back two optimizations from SkPicture: drawPosText strength reduction to drawPosTextH, and pointless save-foo-restore blocks are noop'd away.

The small-T optimization in SkRecord gets in the way of implementing replace(), so I removed it.

Just to keep the API focused, I removed the methods on SkRecord that iterate over i for you; it's just as efficient to do it yourself, and all of the interesting code does its own custom iteration.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/245853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14300 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 16:57:20 +00:00
commit-bot@chromium.org
e221a7f5c7 Remove guards Chromium no longer needs
Note: Android still needs these guards.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/246403004

git-svn-id: http://skia.googlecode.com/svn/trunk@14299 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 16:26:29 +00:00
commit-bot@chromium.org
6c5aea2f10 Use GradFlags for gradient Flags in SkGradientShader
This is done to avoid confusion with other Flag variable used for alpha
type in shader

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/247433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14298 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 16:25:15 +00:00
commit-bot@chromium.org
aec143824c Add asADash entry point into SkPathEffect to allow extracting Dash info from PathEffects
BUG=skia:
R=bsalomon@google.com, reed@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/212103010

git-svn-id: http://skia.googlecode.com/svn/trunk@14297 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 15:21:18 +00:00
commit-bot@chromium.org
fd4ee4dea1 NewRasterDirect should *not* erase the pixels -- direct means the client is in-charge
BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/246493002

git-svn-id: http://skia.googlecode.com/svn/trunk@14296 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 15:02:43 +00:00
commit-bot@chromium.org
02a094c3aa SK_API-export SkBBHFactory & friends.
R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/243333008

git-svn-id: http://skia.googlecode.com/svn/trunk@14295 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 13:33:16 +00:00
skia.committer@gmail.com
d3b28e8847 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14294 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 03:05:17 +00:00
bsalomon@google.com
db904d3967 rebase flaky skp bench range on win7
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/245563006

git-svn-id: http://skia.googlecode.com/svn/trunk@14293 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 21:43:41 +00:00
commit-bot@chromium.org
4bbe2e552a Add --runOnce flag to run benchs once in release or to force convergence in debug
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/242103013

git-svn-id: http://skia.googlecode.com/svn/trunk@14292 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 21:12:32 +00:00
commit-bot@chromium.org
811f20de4d Add missing scale value to fix SkGradientShader memory error
BUG=skia:2446
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/245623005

git-svn-id: http://skia.googlecode.com/svn/trunk@14291 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 21:09:49 +00:00
commit-bot@chromium.org
6b4aaa77dc add optional origin parameter to accessTopLayerPixels
BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/244763004

git-svn-id: http://skia.googlecode.com/svn/trunk@14290 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 21:09:38 +00:00
commit-bot@chromium.org
2c4e75cc3c Remove offset to SkMallocPixelRef::NewWithData - use SkData::NewSubset instead.
R=scroggo@google.com, mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/243483002

git-svn-id: http://skia.googlecode.com/svn/trunk@14289 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 21:08:14 +00:00
commit-bot@chromium.org
855e88edfa Fixes for SkPictureShader.
Update comment in header to make it more clear that the picture
should be unaltered after creating the shader. We want our shaders
to be immutable, and this supports that.

Make the factory return NULL if the shader would have never drawn
anyway i.e. for a null picture or picture with no width/height.

Addresses comments I brought up in
https://codereview.chromium.org/221923007/#msg16.

BUG=skia:1976
R=reed@google.com, fmalita@chromium.org, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/238253005

git-svn-id: http://skia.googlecode.com/svn/trunk@14288 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 19:33:12 +00:00
commit-bot@chromium.org
07b7462e16 warn that docs/quickstart.md is out of sync with official docs
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com, hcm@google.com, mtklein@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/245283002

git-svn-id: http://skia.googlecode.com/svn/trunk@14287 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 19:18:46 +00:00
bsalomon@google.com
af565049e3 Update flaky bench range for tabl_hsfi.skp_simple_viewport_1000x1000_gpu_ on Win7
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/242453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14286 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 19:08:30 +00:00
commit-bot@chromium.org
aae6e6f043 git-sync-deps verifies that directory is a top-level git directory.
NOTRY=true
R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/245503003

git-svn-id: http://skia.googlecode.com/svn/trunk@14285 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 19:03:05 +00:00
bsalomon@google.com
f1e9d4719f Increase ranges for flaky skp benches
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/245433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14284 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 17:45:28 +00:00
commit-bot@chromium.org
c3b738af50 Move to using HTML templates when filling out the workspace history.
This is a pre-step to having a history list that you can click on
and having the code moved back into the textarea, which will come
as a follow-up CL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14283 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 17:36:44 +00:00
commit-bot@chromium.org
4333751843 Add a .gypi to insulate Chrome from refactorings in src/record.
Rather than listing out sources explicitly in skia_library.gypi, I'll add this new .gypi to its includes.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/242733005

git-svn-id: http://skia.googlecode.com/svn/trunk@14282 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 17:08:19 +00:00
bsalomon@google.com
3273dd4a49 Mark mixedxfermodes as ignored on Ubunutu12 Release 64 bit for nvprmsaa4 config
BUG=skia:2443

Review URL: https://codereview.chromium.org/245263003

git-svn-id: http://skia.googlecode.com/svn/trunk@14281 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:47:17 +00:00
bsalomon@google.com
c25cec5f9a SkDELETE() -> SkDELETE_ARRAY() in gradients_many test
Attempt to fix valgrind failure:
http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/builds/489/steps/GenerateGMs/logs/stdio

TBR=reed@google.com

Review URL: https://codereview.chromium.org/245273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14280 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:30:45 +00:00
bsalomon@google.com
66d3d3a8c2 Update baseline for mixed_xfermodes on nvprmsaa4
Review URL: https://codereview.chromium.org/243583007

git-svn-id: http://skia.googlecode.com/svn/trunk@14279 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:13:19 +00:00
commit-bot@chromium.org
fcbf1a1594 Update DESIGN, forgot to add new perms for the new tables.
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/243013005

git-svn-id: http://skia.googlecode.com/svn/trunk@14278 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:10:56 +00:00
commit-bot@chromium.org
ad8ce572f6 anticipate more optimizations by renaming some files and methods
also, call the new SkRecordOptimize in bench_playback

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243243003

git-svn-id: http://skia.googlecode.com/svn/trunk@14277 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 15:03:36 +00:00
commit-bot@chromium.org
5da5b59764 Add --match to bench tools, extra decimal to bench_pictures.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14276 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:59:59 +00:00
commit-bot@chromium.org
1bc6ecc470 Picking from the wrong end of the workspace history list.
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244133002

git-svn-id: http://skia.googlecode.com/svn/trunk@14275 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:57:50 +00:00
commit-bot@chromium.org
b3fbe42c71 bench rebase test f7927dd
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/245223002

git-svn-id: http://skia.googlecode.com/svn/trunk@14274 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:48:53 +00:00
commit-bot@chromium.org
ec68ee9d56 Allow running gyp_to_android without SkUserConfig.
The old code requires that include/config/SkUserConfig.h exists,
to ensure that it gets copied into Android's
include/core/SkUserConfig.h when we do a merge. However, if a
developer wants to make changes and rerun the script, they
should not have to recreate include/config/SkUserConfig.h just
to rerun the script. By default, allow the original to not
exist and just skip the copy.

Update tests to pass. Also add tests to support this use case.

Make gyp_to_android.py executable.

R=robertphillips@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/242203008

git-svn-id: http://skia.googlecode.com/svn/trunk@14273 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:45:01 +00:00
commit-bot@chromium.org
1d0b68c495 Support clip to layer flag on Android framework.
This flag is being transitioned out, but the Android framework
still needs it.

R=reed@google.com, fmalita@google.com, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/243843002

git-svn-id: http://skia.googlecode.com/svn/trunk@14272 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 14:42:38 +00:00
commit-bot@chromium.org
44d83c1e81 Add flipped gradient branch to two point conical gradient
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14235

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/227623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14271 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 13:10:25 +00:00
skia.committer@gmail.com
f7927dd607 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14270 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-20 03:04:55 +00:00
reed@google.com
0ed84ce1df remove sizeof check -- triggers warning in chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@14269 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-20 00:56:50 +00:00
commit-bot@chromium.org
0f1fef834c inline SkMulDiv now that 64bit mul is inlineable
TBR=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242493006

git-svn-id: http://skia.googlecode.com/svn/trunk@14268 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-19 22:12:35 +00:00
commit-bot@chromium.org
2cfa3200fd fix warnings around size_t/int
fix warnings around undeclared (non-static) functions

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242643008

git-svn-id: http://skia.googlecode.com/svn/trunk@14267 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-19 22:00:40 +00:00
commit-bot@chromium.org
2dceedaa1e Add support for serving up a view that can be iframed.
Also add support for creating the <iframe /> code needed for embedding.

This CL must land after https://codereview.chromium.org/240773003/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/242613005

git-svn-id: http://skia.googlecode.com/svn/trunk@14266 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-19 14:50:23 +00:00