Commit Graph

295 Commits

Author SHA1 Message Date
robertphillips@google.com
f1df61c243 Rebaseline lingering RoundRect RHB images
https://codereview.chromium.org/52713011/



git-svn-id: http://skia.googlecode.com/svn/trunk@12060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 19:36:42 +00:00
vandebo@chromium.org
e4e5cabb48 Rebaseline for r12034
xfermodes changed in all configs - added more src types.
The following gms changed only for pdf configs:
xfermodes2, xfermodes3, aarectmodes, colormatrix, lumafilter, mixed_xfermodes

R=edisonn@google.com

Review URL: https://codereview.chromium.org/54763003

git-svn-id: http://skia.googlecode.com/svn/trunk@12053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 15:46:38 +00:00
robertphillips@google.com
d5743ed263 Remove suppression of morphology image diffs
git-svn-id: http://skia.googlecode.com/svn/trunk@12050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:42:30 +00:00
robertphillips@google.com
0bef50638c Rebaselines of morphology GM for r11966
https://codereview.chromium.org/54353004/



git-svn-id: http://skia.googlecode.com/svn/trunk@12049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:25:18 +00:00
vandebo@chromium.org
3b416216d1 [PDF] Improve complex xfer mode support.
Xfer mode applies only to the shape of the source drawing, not everything in the clip as in currently implemented.  It's just that the current gm examples draw a shape that fills the visible layer.

R=edisonn@google.com, reed@google.com

Review URL: https://codereview.appspot.com/4631078

git-svn-id: http://skia.googlecode.com/svn/trunk@12034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 20:48:05 +00:00
edisonn@google.com
b38d4e1584 Mark GMs that are not preserving the perspective for the canvas passed
Review URL: https://codereview.chromium.org/52443005

git-svn-id: http://skia.googlecode.com/svn/trunk@12028 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:57:09 +00:00
edisonn@google.com
dc370e213d update results for Nexus4 gms that run in perspespective mode
Review URL: https://codereview.chromium.org/48623004

git-svn-id: http://skia.googlecode.com/svn/trunk@12026 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:46:31 +00:00
epoger@google.com
6b288d116b semi-blindly rebaseline some GM results, keeping them marked as unreviewed
(they were unreviewed in the first place, so there's no particular reason
to think they are either better or worse than they were before)

As discussed live with bsalomon
TBR=bsalomon

Review URL: https://codereview.chromium.org/53023002

git-svn-id: http://skia.googlecode.com/svn/trunk@12024 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:14:29 +00:00
epoger@google.com
1f87465aa7 rebaseline GM results on Android-IntelRhb and Valgrind bots which were not running for a while
Mostly tiny diffs due to roundrect implementation changes.  Also a couple of
GM tests that are known to have changed.

Visually reviewed by bsalomon and epoger

BUG=skia:1771
TBR=bsalomon

Review URL: https://codereview.chromium.org/52963002

git-svn-id: http://skia.googlecode.com/svn/trunk@12023 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 17:56:17 +00:00
robertphillips@google.com
0b7ab3bb49 Fix bug in erosion filtering
https://codereview.chromium.org/50813002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 13:59:31 +00:00
bsalomon@google.com
ef923d4b80 rebase msaa4 tests that haven't run in a long time
Review URL: https://codereview.chromium.org/48183006

git-svn-id: http://skia.googlecode.com/svn/trunk@11989 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 21:12:50 +00:00
epoger@google.com
2ce9c215ce mass-committing another round of GM results, marked as reviewed-by-human=false
BUG=skia:1759
TBR=bsalomon

Review URL: https://codereview.chromium.org/46653003

git-svn-id: http://skia.googlecode.com/svn/trunk@11971 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 14:44:22 +00:00
senorblanco@chromium.org
cc17673032 New baselines for imagefiltersgraph GM.
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/44323002

git-svn-id: http://skia.googlecode.com/svn/trunk@11964 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-25 17:04:56 +00:00
bsalomon@google.com
79bf912051 Rebaseline strokes_round and strokes3 on SGX devices
BUG=skia:1752

Review URL: https://codereview.chromium.org/41083003

git-svn-id: http://skia.googlecode.com/svn/trunk@11953 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 20:03:27 +00:00
bsalomon@google.com
af562b437e Tile large bitmaps that are clipped.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/31033002

git-svn-id: http://skia.googlecode.com/svn/trunk@11951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 17:52:07 +00:00
vandebo@chromium.org
81c67001f2 [PDF] Rebaseline mac expectations after fixing image unpremtuliplication in r11945
Review URL: https://codereview.chromium.org/40263003

git-svn-id: http://skia.googlecode.com/svn/trunk@11948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 16:40:12 +00:00
epoger@google.com
97769bb9bc Add note to ignored-tests.txt
BUG=skia:1748
(SkipBuildbotRuns)

R=scroggo@google.com

Review URL: https://codereview.chromium.org/40353002

git-svn-id: http://skia.googlecode.com/svn/trunk@11943 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 14:42:19 +00:00
edisonn@google.com
a8be6d772c update pdf-mac gms, after adding duport for perspective shaders in pdf
Review URL: https://codereview.chromium.org/40313002

git-svn-id: http://skia.googlecode.com/svn/trunk@11942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 14:24:59 +00:00
commit-bot@chromium.org
bbfe4541ef Apply matrix early in draw bitmap
Committed: http://code.google.com/p/skia/source/detail?r=11930

Reverted: https://code.google.com/p/skia/source/detail?r=11932

R=robertphillips@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/30593003

git-svn-id: http://skia.googlecode.com/svn/trunk@11933 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 01:46:11 +00:00
scroggo@google.com
e9821871ec Revert "Apply matrix early in draw bitmap"
This reverts commit 4c446c8eb50b7a6e6f917fae7b4c4ffe5658a949.

Fix build.

git-svn-id: http://skia.googlecode.com/svn/trunk@11932 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 22:19:06 +00:00
commit-bot@chromium.org
25e5a20e65 Apply matrix early in draw bitmap
R=robertphillips@google.com, senorblanco@chromium.org

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/30593003

git-svn-id: http://skia.googlecode.com/svn/trunk@11930 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 21:06:51 +00:00
humper@google.com
0794dcd2c0 rebaseline scaled tilemodes gms on the GPU
git-svn-id: http://skia.googlecode.com/svn/trunk@11927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 19:41:08 +00:00
sugoi@google.com
afba64434d New gm expectations for imagemagnifier
git-svn-id: http://skia.googlecode.com/svn/trunk@11911 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 19:42:10 +00:00
bsalomon@google.com
7ce564cccb Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance."
This reverts commit r11904

Review URL: https://codereview.chromium.org/35543002

git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 16:54:15 +00:00
bsalomon@google.com
a5f30e9675 Add strokerect to ignored tests list
Review URL: https://codereview.chromium.org/35223003

git-svn-id: http://skia.googlecode.com/svn/trunk@11906 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 13:52:47 +00:00
bsalomon@google.com
ad254fee73 If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
Committed: http://code.google.com/p/skia/source/detail?r=11842

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23484007

git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 13:19:12 +00:00
scroggo@google.com
5187c4313c More work to integrate skimage with rebaseline tools.
tools/skimage_main.cpp:
Add the ability to write the results to checksum based filenames,
much like GM uses. This will allow using the skpdiff server to
rebaseline images.
Write the keys in the JSON file as <original image>_<pref config>.png,
so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with
'-' in the original file name, to avoid confusing the pattern matcher.
The '_' to '-' replacement also happens on the output filename.
Read the keys in a similar manner.
In make_outname, no longer remove a suffix. This fixes a bug where
subset decoding writes multiple subsets to the same file.

tools/rebaseline.py:
Since the filenames written to json files now match
gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based
on configs/tests when rebaselining skimage.

test json files:
Update to match the new format of output.

gm/gm_expectations:
Add a constructor that takes a BitmapAndDigest as input.

tools/tests/skimage_self_test.py:
Test that reading the expectations file just created by skimage with
the same file actually compares to the original file (rather than just
succeeding because expectations were missing).

Change the expectations files to match the new format.

Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/

BUG=1466
R=epoger@google.com

Review URL: https://codereview.chromium.org/26297004

git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 00:42:46 +00:00
senorblanco@chromium.org
380355eff3 Xoom rebaselines.
Note: Some of these had no base versions in GS corresponding to the hashes in the JSON, causing the svndiff script to barf. I hacked it up to let me finish, but it should probably handle the case of a missing hash more gracefully.

TBR=epoger

Review URL: https://codereview.chromium.org/33303007

git-svn-id: http://skia.googlecode.com/svn/trunk@11900 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 22:00:47 +00:00
senorblanco@chromium.org
8204743fdb ChromeOS and IntelRhb rebaselines.
TBR=robertphillips

Review URL: https://codereview.chromium.org/32533004

git-svn-id: http://skia.googlecode.com/svn/trunk@11891 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 18:46:49 +00:00
senorblanco@chromium.org
ad6d35bbf9 Third round of matrixconvolution rebaselines, and removal from ignored-tests.txt.
"We have normality. I repeat, we have normality. Anything you still can't cope with is therefore your own problem."

TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/33323002

git-svn-id: http://skia.googlecode.com/svn/trunk@11889 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 18:23:30 +00:00
senorblanco@chromium.org
9f51d16b54 Second round of matrixconvolution rebaselines.
TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/33103002

git-svn-id: http://skia.googlecode.com/svn/trunk@11885 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 17:04:11 +00:00
commit-bot@chromium.org
f642f8cf90 Magnifier gpu path fix
The y axis was inverted for the offset, which should have been computed on the other side of the magnifying rectangle.

BUG=
R=bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/28273005

git-svn-id: http://skia.googlecode.com/svn/trunk@11883 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:59:26 +00:00
senorblanco@chromium.org
718f5e2b7c First round of matrixconvolution rebaselines.
TBR=robertphillips

Review URL: https://codereview.chromium.org/32823002

git-svn-id: http://skia.googlecode.com/svn/trunk@11882 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 15:41:55 +00:00
robertphillips@google.com
466ea91886 A few stragglers for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31333002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11875 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 00:15:15 +00:00
robertphillips@google.com
7c4d5124d1 More rebaselines for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31323002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:53:11 +00:00
robertphillips@google.com
d8b0a148c5 rebaselines after r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/31313002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11873 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-20 23:06:40 +00:00
senorblanco@chromium.org
7938bae14a Implement crop rect support for SkMatrixConvolutionImageFilter.
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/27471002

git-svn-id: http://skia.googlecode.com/svn/trunk@11863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 20:08:14 +00:00
bsalomon@google.com
de7de5638f rebaseline gpu complex clip tests
Review URL: https://codereview.chromium.org/29303002

git-svn-id: http://skia.googlecode.com/svn/trunk@11856 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 15:47:28 +00:00
robertphillips@google.com
e0d7277b59 Revert 11839 (rebaseline images after r11835) due to performance regression in 11835
git-svn-id: http://skia.googlecode.com/svn/trunk@11840 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 16:28:11 +00:00
robertphillips@google.com
01c51b76bf rebaseline images after r11835
https://codereview.chromium.org/27722002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11839 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 15:23:26 +00:00
robertphillips@google.com
3f1588482f Added nested_bw to suppression list
git-svn-id: http://skia.googlecode.com/svn/trunk@11838 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 13:17:04 +00:00
mtklein@google.com
e4b500b0bc rebaseline stragglers from repeated radial gradient tweak
BUG=

Review URL: https://codereview.chromium.org/27700002

git-svn-id: http://skia.googlecode.com/svn/trunk@11837 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:34:54 +00:00
robertphillips@google.com
6b1b248bbe Fix typo in ignored-tests file
git-svn-id: http://skia.googlecode.com/svn/trunk@11836 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:27:55 +00:00
robertphillips@google.com
1cc385b7a4 Replace cubic round rect corners with quads
https://codereview.chromium.org/26372006/



git-svn-id: http://skia.googlecode.com/svn/trunk@11835 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-17 12:17:27 +00:00
bsalomon@google.com
3ae71b6b2e Initial baselines for skbug1719
Review URL: https://codereview.chromium.org/27212004

git-svn-id: http://skia.googlecode.com/svn/trunk@11832 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:27:18 +00:00
mtklein@google.com
6065d36bb8 tools/rebaseline.py --tests xfermodes3 drawbitmaprect scaled_tilemode_gradient tilemode_gradient
BUG=

Review URL: https://codereview.chromium.org/26233006

git-svn-id: http://skia.googlecode.com/svn/trunk@11831 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 21:23:18 +00:00
edisonn@google.com
d117910239 update drawbitmap gm (part 2)
Review URL: https://codereview.chromium.org/26435005

git-svn-id: http://skia.googlecode.com/svn/trunk@11830 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 20:45:00 +00:00
edisonn@google.com
29a2d35bd2 Updates to SkPDFDevice and SkDocument classes.
Update the SkDocument interface to allow for 1) abort won't emit pdf, 2) close can report success/failure, 3) SkCanvasSimplifier interface that will be used to simplify perspective for SkpDFDevice, 4) prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. 	modified:   gm/gmmain.cpp 	modified:   gyp/core.gyp 	modified:   gyp/core.gypi 	new file:   include/core/SkCanvasSimplifier.h 	modified:   include/core/SkDocument.h 	new file:   include/pdf/SkPDFCallbacks.h 	modified:   include/pdf/SkPDFDevice.h 	new file:   src/core/SkCanvasSimplifier.cpp 	modified:   src/doc/SkDocument.cpp 	modified:   src/doc/SkDocument_PDF.cpp 	modified:   src/pdf/SkPDFDevice.cpp 	modified:   src/pdf/SkPDFShader.cpp 	modified:   src/utils/SkLua.cpp 	modified:   tools/PdfRenderer.cpp 	modified:   tools/PdfRenderer.h 	modified:   tools/render_pdfs_main.cpp 	modified:   tools/skhello.cpp

BUG=

Review URL: https://codereview.chromium.org/24615006

git-svn-id: http://skia.googlecode.com/svn/trunk@11829 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 19:49:17 +00:00
senorblanco@chromium.org
41345b6a4a More displacement GM rebaselines. Also remove displacement from ignored-tests.txt, since it should now be passing on all platforms.
TBR=

Review URL: https://codereview.chromium.org/27533003

git-svn-id: http://skia.googlecode.com/svn/trunk@11814 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 16:25:21 +00:00
bsalomon@google.com
e4d3d7ca70 Rebaseline complexclip tests on GPU and remove them from ignored-tests
Review URL: https://codereview.chromium.org/27515002

git-svn-id: http://skia.googlecode.com/svn/trunk@11806 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 14:15:32 +00:00