Commit Graph

38531 Commits

Author SHA1 Message Date
Ben Wagner
ce7a16b318 Upgrade NVIDIA driver on Win10 QuadroP400 bots.
Bug: 905062
Change-Id: Ib5e742003b64ad8314544605590f5b0bf09742c7
Reviewed-on: https://skia-review.googlesource.com/c/171009
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-11-15 19:30:43 +00:00
Mike Reed
5fb83f94c1 create shared helper for strikecache and SkFont
Bug: skia:
Change-Id: Ie6ffca1f4e2fc41474eb30d27503b0b76631d077
Reviewed-on: https://skia-review.googlesource.com/c/171202
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-11-15 18:38:28 +00:00
Mike Klein
082eaeb08e commit to alpha bitmap procs
The alpha procs differ from the opaque ones only in a very isolated,
branch-predictable place.  If we need to make any of these care about
whether alphaScale == 256, we can probably just put a branch in there.

More refactoring to follow...

For now I've kept Clamp_S32_opaque_D32_nofilter_DX_shaderproc() around.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2739b6fc7d36c1adf6c702b271b20986f86e413f
Reviewed-on: https://skia-review.googlesource.com/c/171040
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-11-15 18:26:17 +00:00
skia-autoroll
005fdd4ec8 Roll third_party/externals/swiftshader 3fc6893c8b24..8f20452b0219 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3fc6893c8b24..8f20452b0219


git log 3fc6893c8b24..8f20452b0219 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 sugoi@google.com Added missing frameworks on MacOs for vertex routine fuzzer


Created with:
  gclient setdep -r third_party/externals/swiftshader@8f20452b0219

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=rmistry@google.com

Change-Id: I7d326b15d524aab387d506709d95cfc8c953aa79
Reviewed-on: https://skia-review.googlesource.com/c/171281
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-15 17:38:00 +00:00
skia-autoroll
ec04bcc16f Roll third_party/externals/angle2 f3acb8c133fa..666818eacf79 (1 commits)
f3acb8c133..666818eacf


git log f3acb8c133fa..666818eacf79 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 jmadill@chromium.org Use angle::Result in front-end (Part 8)


Created with:
  gclient setdep -r third_party/externals/angle2@666818eacf79

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=rmistry@google.com

Change-Id: I494efc99b815027d37476b356c49802042553405
Reviewed-on: https://skia-review.googlesource.com/c/171280
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-15 17:28:09 +00:00
Chris Dalton
dba7aabcef sksl: Add support for 2x2 matrix inversions in Metal
Bug: skia:
Change-Id: I524319ede491be4884c42d89f485ed98cff0cd29
Reviewed-on: https://skia-review.googlesource.com/c/171221
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-11-15 17:21:35 +00:00
Greg Daniel
2268ad23fe Add flag to force purge resources from cache as soon as possible.
Bug: skia:
Change-Id: Ibd636b9e1bf932033c3161c862523f841cb85e79
Reviewed-on: https://skia-review.googlesource.com/c/171005
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-11-15 16:45:30 +00:00
Mike Klein
08c891a20a remove mention of 16-bit shader procs
This is all dead.

Change-Id: Ifef5edb5c2402118cb289bbe31923f8de56bab23
Reviewed-on: https://skia-review.googlesource.com/c/171240
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-15 16:37:43 +00:00
Brian Osman
c3064e7c51 Use GrVertexWriter in GrLatticeOp
Adds TriStripPoint helpers to replace usage of SetRectTriStrip

Bug: skia:
Change-Id: Iced3dd4474caafb0a3c6ef057e30e227dbee88e0
Reviewed-on: https://skia-review.googlesource.com/c/171004
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-11-15 14:38:36 +00:00
Cary Clark
abaffd85ab bookmaker does deprecated
Bookmaker does not require documentation for public symbols
described as "deprecated", "private", or "experimental".
Adding one of these words (case-insensitive) to the symbol
description in the include file tells bookmaker that the bmh file
should not include documentation, and the generated markdown
should omit it in its indices and descriptions.

Symbols marked as "to be deprecated" or "may be deprecated"
are still regarded as public and documented.

Private notes in the includes that start with TODO: are
omitted as well.

This CL updated generated includes to describe its symbols
accordingly. The includes will be fully regenerated in a future
CL. The corresponding documentation has been deleted from the
bmh files, and the web markup has been regenerated.

TBR=reed@google.com
Docs-Preview: https://skia.org/?cl=169830
Bug: skia:
Change-Id: Ie6ec3ccdadb7be9ac15db4811823a30948c4af25
Reviewed-on: https://skia-review.googlesource.com/c/169830
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-11-15 14:08:45 +00:00
Mike Klein
72098a44ff lookup received factories directly
Instead of mapping int -> name -> factory, map int -> factory.

The counterpart of https://skia-review.googlesource.com/c/skia/+/168264,
this time for the receiver.

Change-Id: I8c7756b1e5519611e72cba7d4aa88976169375af
Reviewed-on: https://skia-review.googlesource.com/c/171044
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-15 14:08:35 +00:00
skia-recreate-skps
1315333b6b Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I00eddd5c9b63c0ec023e6924a92e2dff7e1cf0b3
Reviewed-on: https://skia-review.googlesource.com/c/171205
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-15 05:53:17 +00:00
recipe-roller
e36f46461d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/91de11099dcd8c37e308992ccfe26dd14cee5f64 autoninja: fix shellcheck warnings (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8d2c85a025372f4b560f53ef363afd1bfbf5e265
Reviewed-on: https://skia-review.googlesource.com/c/171012
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-15 04:27:29 +00:00
recipe-roller
db12309ae3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/43a35d299bbc044957eea5f82eae5a2f189a2b3c autoninja: quote the arguments when needed. (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I610b410bfefe8e71721b8a14c97eae0493dc9f72
Reviewed-on: https://skia-review.googlesource.com/c/171011
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-15 03:57:17 +00:00
skia-autoroll
2eccd58916 Roll third_party/externals/angle2 fca8fd620190..f3acb8c133fa (4 commits)
fca8fd6201..f3acb8c133


git log fca8fd620190..f3acb8c133fa --date=short --no-merges --format='%ad %ae %s'
2018-11-15 jmadill@chromium.org Retool perf test running.
2018-11-15 fjhenigman@chromium.org Refactor instancing tests.
2018-11-14 geofflang@chromium.org GL: Work around driver returning negative GL_MAX_SERVER_WAIT_TIMEOUT
2018-11-14 syoussefi@chromium.org Vulkan: Implement EXT_texture_filter_anisotropic


Created with:
  gclient setdep -r third_party/externals/angle2@f3acb8c133fa

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=rmistry@google.com

Change-Id: Idb843599b80ce73b06c56f9e66677c3bacbf94df
Reviewed-on: https://skia-review.googlesource.com/c/171092
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-15 03:17:39 +00:00
Alexander Khovansky
3e11933765 [canvaskit] Exposed SkPath::arc. Exposed SkEncodedImageFormat enum. Exposed SkImage::encodeToData overload with arguments
These changes expose the arc function for SkPath. The ApplyAddArc function is a copy from the PathKit bindings.

Also exposed the PNG and JPEG formats from the SkEncodedImageFormat enum and the SkImage::encodeToData overload that accepts format and quality options. The direct binding of encodeToData was replaced with a pre-js wrapper that calls the appropriate private overload

We are working on a PostCSS conic gradient polyfill plugin and want to use the CanvasKit to generate it.
Problem is - it lacks the arc function that technically exists but isn't exposed. And it would be really great to have encodeToData with options since generated PNGs are quite large.
More details on the issue can be found here: https://github.com/jonathantneal/postcss-conic-gradient/issues/10

R=kjlubick@google.com

Bug: skia:
Change-Id: I3f1dc88ad308369fe62004080bcc196c4fbbf742
Reviewed-on: https://skia-review.googlesource.com/c/171046
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-11-15 02:52:02 +00:00
recipe-roller
3da725065a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f66e5510327b30b53454dfed0f6edb40286a67a2 autoninja: support -j100 and -tclean. (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2412dd033d36ade26eaf1cdacc98880edc0bba0
Reviewed-on: https://skia-review.googlesource.com/c/171008
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-15 01:14:49 +00:00
skia-autoroll
7d2aae3165 Roll third_party/externals/swiftshader d5f1489286b8..3fc6893c8b24 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d5f1489286b8..3fc6893c8b24


git log d5f1489286b8..3fc6893c8b24 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 sugoi@google.com Prevent glDeleteQueries from deleting a live Query


Created with:
  gclient setdep -r third_party/externals/swiftshader@3fc6893c8b24

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=rmistry@google.com

Change-Id: Ia5f4c96c52aa4962ed4155043e411eec64ed976b
Reviewed-on: https://skia-review.googlesource.com/c/171120
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-14 21:40:39 +00:00
Leon Scroggins III
44764000b4 Add SafetyNetLogging and use in SkPngCodec
Bug: b/117838472
Change-Id: I463f8b2c11c07098e9ec24448f66fcafcf6cd76b
Reviewed-on: https://skia-review.googlesource.com/c/170354
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-11-14 20:06:03 +00:00
Brian Salomon
588cec7f91 Reenable GrOp chaining.
GrRenderTargetOpList maintains an array of op chains. When it receives a
new op it tries to add it to an existing chain, working backwards from
the end of the current array. If the op can be added to a chain it
additionally tries to merge the new op with ops already in the chain
before adding it to the tail of the chain.

In forward combining it tries to concatenate chains. If chains can
concatenate it also attempts to merge ops between the two chains.

Now op chaining results reported by Op subclasses must be transitive.
Moreover, if op A is able to merge with B then it must be the case that
any op that can chain with A will either merge or chain with any op that
can chain to B.

Bug: skia:8491

Change-Id: Ib6a2a669acd4257134a37d271289b8b3f247cd3f
Reviewed-on: https://skia-review.googlesource.com/c/170351
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-11-14 19:20:59 +00:00
Mike Klein
7c353112b5 Revert "remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc"
This reverts commit bf1a82aa22.

Reason for revert: UBSAN.

Original change's description:
> remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc
> 
> This is a warmup to removing all _opaque_ shader procs.
> 
> Oddly this shows up as mostly performance-positive:
> 
> just-that-one (compared to master) is likely
>    24.11% slower in bitmap_RGBA_8888_scale
>     5.23% faster in shadermaskfilter_picture_ff
>     5.73% faster in shadermaskfilter_picture_80
>    10.02% faster in maskshader
>    40.24% faster in bitmap_RGBA_8888_A_source_stripes_three
>    40.88% faster in bitmap_RGBA_8888_A_source_stripes_two
>    54.40% faster in bitmap_RGBA_8888_A
>    60.87% faster in top25desk_weather_com.skp_1
>    62.39% faster in bitmap_RGBA_8888_A_source_opaque
>    62.95% faster in bitmap_RGBA_8888_update
>    63.15% faster in bitmap_RGBA_8888_update_volatile
>    63.34% faster in bitmap_RGBA_8888
>    71.40% faster in bitmap_RGBA_8888_A_source_transparent
>    86.13% faster in bitmaprect_FF_nofilter_trans
>   412.43% faster in constXTile_CC
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ifef92a1efcb6c35b8519da7599d31ea3bb41c3a4
> Reviewed-on: https://skia-review.googlesource.com/c/171041
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
> Auto-Submit: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: Ibb08f590d18054e7886600e79cc23f951dc0cbb8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/171043
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-14 19:11:49 +00:00
Mike Reed
93439b73a6 don't use nested form of FontMetrics
Bug: skia:
Change-Id: I80294c33671552ff0b484acd8d7e144d2f13eb51
Reviewed-on: https://skia-review.googlesource.com/c/171082
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-14 19:07:26 +00:00
Mike Klein
bf1a82aa22 remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc
This is a warmup to removing all _opaque_ shader procs.

Oddly this shows up as mostly performance-positive:

just-that-one (compared to master) is likely
   24.11% slower in bitmap_RGBA_8888_scale
    5.23% faster in shadermaskfilter_picture_ff
    5.73% faster in shadermaskfilter_picture_80
   10.02% faster in maskshader
   40.24% faster in bitmap_RGBA_8888_A_source_stripes_three
   40.88% faster in bitmap_RGBA_8888_A_source_stripes_two
   54.40% faster in bitmap_RGBA_8888_A
   60.87% faster in top25desk_weather_com.skp_1
   62.39% faster in bitmap_RGBA_8888_A_source_opaque
   62.95% faster in bitmap_RGBA_8888_update
   63.15% faster in bitmap_RGBA_8888_update_volatile
   63.34% faster in bitmap_RGBA_8888
   71.40% faster in bitmap_RGBA_8888_A_source_transparent
   86.13% faster in bitmaprect_FF_nofilter_trans
  412.43% faster in constXTile_CC

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifef92a1efcb6c35b8519da7599d31ea3bb41c3a4
Reviewed-on: https://skia-review.googlesource.com/c/171041
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-11-14 18:52:44 +00:00
skia-autoroll
6297054aa7 Roll third_party/externals/angle2 d1a55e393e65..fca8fd620190 (2 commits)
d1a55e393e..fca8fd6201


git log d1a55e393e65..fca8fd620190 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 syoussefi@chromium.org Vulkan: Refix cleanup race condition on Context destroy
2018-11-14 syoussefi@chromium.org Vulkan: prepare for ES3


Created with:
  gclient setdep -r third_party/externals/angle2@fca8fd620190

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=rmistry@google.com

Change-Id: I3bbdd98fd8faceb7c918be34fbe777e6578b614c
Reviewed-on: https://skia-review.googlesource.com/c/171060
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-14 18:30:04 +00:00
Ben Wagner
bb9844ef69 Add client code search to docs.
Also, history seems to be available for internal code search.

No-Try: true
Docs-Preview: https://skia.org/?cl=171003
Change-Id: I13707664b88e3d84760f11f43d2bd7c35c2a8969
Reviewed-on: https://skia-review.googlesource.com/c/171003
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-11-14 17:37:44 +00:00
Mike Reed
07f93f2999 impl SkFont::getPath
Replacement for SkPaint::getTextPath and getPosTextPath
- only works with glyphIDs
- doesn't try to do positioning
- doesn't force caller to consolidate all the glyphs into one giant path

Much of the time is spent transforming the path from the cache's size to the callers.
Might consider passing the raw path + matrix rather than scaling it for them???

Bug: skia:
Change-Id: Ie13015c61ebe410eaec084282d600338cfccb51a
Reviewed-on: https://skia-review.googlesource.com/c/170881
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-14 17:28:10 +00:00
skia-autoroll
f152130ef9 Roll third_party/externals/swiftshader 02ce5830e7db..d5f1489286b8 (7 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/02ce5830e7db..d5f1489286b8


git log 02ce5830e7db..d5f1489286b8 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 capn@google.com Refactor physical device feature query.
2018-11-14 capn@google.com Fix feature query infinite loop.
2018-11-14 capn@google.com Remove unsupported functionality.
2018-11-14 capn@google.com Define generic memory type.
2018-11-14 capn@google.com Base the driver version on Version.h.
2018-11-14 capn@google.com Export Vulkan API entry functions.
2018-11-14 capn@google.com Fix debugger wait dialog.


Created with:
  gclient setdep -r third_party/externals/swiftshader@d5f1489286b8

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=rmistry@google.com

Change-Id: I6a82f8d96d1afef39188351804f3e1e9869e2cfe
Reviewed-on: https://skia-review.googlesource.com/c/171020
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-14 16:21:40 +00:00
Hal Canary
f6462c4321 SkPDF: store indirect references in object
Change-Id: Ia127247fd2d680dc6d06a04161bdf1da6701762e
Reviewed-on: https://skia-review.googlesource.com/c/170728
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-11-14 16:21:30 +00:00
Greg Daniel
d7157b2ccf Revert "Reland "Have a GrBackendFormat be stored on gpu proxies.""
This reverts commit 2f9a5ea639.

Reason for revert: breaking fuchsia

Original change's description:
> Reland "Have a GrBackendFormat be stored on gpu proxies."
> 
> This reverts commit 919c9e77c3.
> 
> Reason for revert: Flutter change has landed and fixed memory issue.
> 
> Original change's description:
> > Revert "Have a GrBackendFormat be stored on gpu proxies."
> >
> > This reverts commit 51b1c12bbc.
> >
> > Reason for revert: reverting till flutter gets to 1.1 to fix build issues.
> >
> > Original change's description:
> > > Have a GrBackendFormat be stored on gpu proxies.
> > >
> > > Bug: skia:
> > > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> > > Reviewed-on: https://skia-review.googlesource.com/c/168021
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> >
> > TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> >
> > Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:903701 chromium:903756
> > Reviewed-on: https://skia-review.googlesource.com/c/169835
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> 
> TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> 
> Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d
> Bug: chromium:903701 chromium:903756
> Reviewed-on: https://skia-review.googlesource.com/c/170104
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: Ia0556355e5775b2100901b7bfa37f97bb6ccd90f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:903701 chromium:903756
Reviewed-on: https://skia-review.googlesource.com/c/171002
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-11-14 15:28:15 +00:00
Mike Klein
9341952756 skip alpha scale if 256
It's free performance!

Seriously, though, it's a perfectly predictable branch.
On opaque content I'm seeing a small speedup and two
extra instructions in the hot path:

      + cmpl $256, %regs
      + je <to write-it-out>
        pmullw %xmm, %xmm
        psrlw $8, %xmm
        pmullw %xmm, %xmm
        psrlw $8, %xmm
  write-it-out:

Change-Id: I1c19a9efac62df2bb901ca9eb2679c967729d863
Reviewed-on: https://skia-review.googlesource.com/c/170901
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-11-14 15:08:36 +00:00
Greg Daniel
2f9a5ea639 Reland "Have a GrBackendFormat be stored on gpu proxies."
This reverts commit 919c9e77c3.

Reason for revert: Flutter change has landed and fixed memory issue.

Original change's description:
> Revert "Have a GrBackendFormat be stored on gpu proxies."
>
> This reverts commit 51b1c12bbc.
>
> Reason for revert: reverting till flutter gets to 1.1 to fix build issues.
>
> Original change's description:
> > Have a GrBackendFormat be stored on gpu proxies.
> >
> > Bug: skia:
> > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> > Reviewed-on: https://skia-review.googlesource.com/c/168021
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
>
> Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:903701 chromium:903756
> Reviewed-on: https://skia-review.googlesource.com/c/169835
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d
Bug: chromium:903701 chromium:903756
Reviewed-on: https://skia-review.googlesource.com/c/170104
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-11-14 14:52:44 +00:00
Cary Clark
7f2b6fa665 fix pathops fuzzes
Turn asserts into early exits.

R=kjlubick@google.com

Bug: skia:
Change-Id: I5da57e510774038f04381571aa2cebfbd26f03a1
Reviewed-on: https://skia-review.googlesource.com/c/171000
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-14 14:00:05 +00:00
skia-bookmaker
b45b53f01c Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I53cfa8794ddfc5fd1045be62b4ea58afeeec5814
Reviewed-on: https://skia-review.googlesource.com/c/170943
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-14 05:58:57 +00:00
skia-recreate-skps
e347abd4f5 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2be54775127584a9f0985da135173357095d546b
Reviewed-on: https://skia-review.googlesource.com/c/170942
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-14 05:54:35 +00:00
skia-autoroll
ccc31e9e32 Roll third_party/externals/angle2 2778029563f2..d1a55e393e65 (2 commits)
2778029563..d1a55e393e


git log 2778029563f2..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions.
2018-11-13 geofflang@chromium.org Only use CompositorNativeWindow11 when the window is non-null.


Created with:
  gclient setdep -r third_party/externals/angle2@d1a55e393e65

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=rmistry@google.com

Change-Id: I9738b0eb7158c5bf0bc6fa0e446df942642bbc76
Reviewed-on: https://skia-review.googlesource.com/c/170920
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-14 03:15:03 +00:00
Cary Clark
1e00aebd9a fix pathops fuzz
this fixes the SkOpSegment.cpp fuzz break.

R=kjlubick@google.com

Bug: skia:
Change-Id: Ia22a7b3066592969257f10ff7b593f3caecbf988
Reviewed-on: https://skia-review.googlesource.com/c/170840
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-11-14 00:08:16 +00:00
Mike Reed
53f091f224 cubicmap should pin its input -- I guess
Bug: skia:
Change-Id: I9abf6deb26f702186c6468cb20d0ec79d9bcab8a
Reviewed-on: https://skia-review.googlesource.com/c/170882
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-13 22:55:37 +00:00
Mike Reed
d723ee1a1a change SkTextEncoding to enum class
Bug: skia:
Change-Id: I3ea2792a49ca93fdd4bba686c63047727372f88b
Reviewed-on: https://skia-review.googlesource.com/c/170880
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-13 22:51:38 +00:00
skia-autoroll
e942629356 Roll third_party/externals/swiftshader b3c4d88a647a..02ce5830e7db (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3c4d88a647a..02ce5830e7db


git log b3c4d88a647a..02ce5830e7db --date=short --no-merges --format='%ad %ae %s'
2018-11-13 sugoi@google.com Fixed lineWidth and pointSize limits


Created with:
  gclient setdep -r third_party/externals/swiftshader@02ce5830e7db

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=rmistry@google.com

Change-Id: I862b52a864c8cc46ce5e05d5d8a6e69148311c83
Reviewed-on: https://skia-review.googlesource.com/c/170860
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-13 22:34:36 +00:00
Brian Osman
f9aabff61a Move new WriteVertexData utility to a GrVertexWriter helper struct
Encapsulates the pointer storage and advancement, shortens usage.

Bug: skia:
Change-Id: Id06cd273ed638395d1fd53b3b66f87d4d33a4f3b
Reviewed-on: https://skia-review.googlesource.com/c/170727
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-13 21:40:41 +00:00
Mike Klein
14b9f537c5 refactor SkBitmapProcState_opts_SSSE3
Change-Id: Ied07a15b891e5b94fad14056ddfdffc52facf242
Reviewed-on: https://skia-review.googlesource.com/c/170764
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-11-13 21:08:00 +00:00
Chris Dalton
09212197d7 sksl: Support fwidth()
Adds fwidth() to SkSL, and adds a gm that draws an AA squircle to test
it.

Bug: skia:
Change-Id: Ida306cc535a1d4b4568d0ad5cc9a5f235098f4e8
Reviewed-on: https://skia-review.googlesource.com/c/170726
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-11-13 20:52:47 +00:00
Brian Osman
6c24245912 Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS from Skia's Chromium GN
This was moved to Chrome so we can rebaseline and remove it entirely.
https://chromium-review.googlesource.com/c/chromium/src/+/1334091

See also: https://codereview.chromium.org/1130883003

Bug: skia:
Change-Id: Iaf5f6e0cf2c978bff60cffc562a97784e22b24c8
Reviewed-on: https://skia-review.googlesource.com/c/170723
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-13 20:44:01 +00:00
Leon Scroggins III
97f455a39a Remove unused SkPath::unique()
It was only supported for ANDROID_FRAMEWORK, which no longer uses it.
(It looks like the last use was removed with
ag/I18bfe51896672272ce7d471eaead69b651399368.)

Change-Id: Ia0811a8625d6a20ae7411a7578a5358ff1cc1a37
Reviewed-on: https://skia-review.googlesource.com/c/170480
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-11-13 20:22:11 +00:00
skia-autoroll
14fd89962a Roll third_party/externals/swiftshader 6ed398b46847..b3c4d88a647a (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6ed398b46847..b3c4d88a647a


git log 6ed398b46847..b3c4d88a647a --date=short --no-merges --format='%ad %ae %s'
2018-11-13 sugoi@google.com Disabling the debugger wait dialog by default with Vulkan


Created with:
  gclient setdep -r third_party/externals/swiftshader@b3c4d88a647a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=rmistry@google.com

Change-Id: I1a0a4e5173145a023659e1d43b8737cb9ef516f8
Reviewed-on: https://skia-review.googlesource.com/c/170803
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-13 20:17:11 +00:00
Leon Scroggins III
be85c19a74 Build custom empty SkFontMgr for Android Framework
Bug: b/118742766

The Android Framework does not need SkFontMgr_android*. Switch it to
using SkFontMgr_custom*. This will also be the SkFontMgr to use when
we're building Skia as a host-side library.

BUILD.gn:
- Rename fontmgr_fuchsia to fontmgr_custom_empty so it can be selected
  specifically by the Android Framework build. Default condition is
  unchanged, so fuchsia will still build it.
- Similarly, create a new argument for fontmgr_android and
  fontmgr_custom, so they can be omitted by the Android Framework build.
  Again, default condition is unchanged, so no other builds should be
  affected.

gn_to_bp.py:
- Set the new arguments to build the files we want.

Change-Id: Ic85db8acd64f625b00fe2c9bc451ae8814d97a59
Reviewed-on: https://skia-review.googlesource.com/c/170725
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-11-13 20:17:10 +00:00
Jim Van Verth
275cffbd60 Avoid overflow in bufferOffset calculations
Bug: skia:8530
Change-Id: I64a7fd9087c237894dd6370ae586de79eabf9759
Reviewed-on: https://skia-review.googlesource.com/c/170724
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-11-13 19:01:42 +00:00
Brian Osman
9d958b54af Update several more oval ops to use WriteVertexData
Use shared octagon vertex data, remove some vertex structs
entirely.

Bug: skia:
Change-Id: Ia717bac85de7084a982f0d10d932ea91f04f36f4
Reviewed-on: https://skia-review.googlesource.com/c/169820
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-13 18:45:29 +00:00
skia-autoroll
5a0dddc3d4 Roll third_party/externals/angle2 cd47a379f960..2778029563f2 (2 commits)
cd47a379f9..2778029563


git log cd47a379f960..2778029563f2 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 ynovikov@chromium.org Vulkan: refactor WrappedObject descendants
2018-11-13 syoussefi@chromium.org Vulkan: Enable end2end tests for ES2_VULKAN everywhere


Created with:
  gclient setdep -r third_party/externals/angle2@2778029563f2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=rmistry@google.com

Change-Id: I57363b7605e6e6c8ca1babc54fe23fdd389eb097
Reviewed-on: https://skia-review.googlesource.com/c/170802
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-13 18:23:37 +00:00
Mike Klein
abde1adc5f remove opaque/alpha distinction in SSSE3 code
Just always use the alpha path.  Some microbenchmarks
get a little slower, but no .skps do, even ones that are
using S32_opaque_D32_filter_DX_SSSE3 heavily.

Change-Id: I4aa5f52165e504b4fcd00fff28b0a649ad4f0716
Reviewed-on: https://skia-review.googlesource.com/c/170763
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-13 17:59:18 +00:00