Commit Graph

44083 Commits

Author SHA1 Message Date
Florin Malita
e359aa35d1 [sksg] Fix mask/context overrides interaction
We're currently letting render context overrides (opacity, color
filters, blend mode, etc) spill down the descendent/mask content
tree.

This is not ideal, as mask content isolation breaks atomicity
assumptions for deferred overrides.  Case in point: motion blur uses
SkBlendMode::kPlus to accumulate content "layers" - but since mask
content gets rendered into a separate layer, it fails to produce the
expected result.

The fix is to realize all context overrides on the top-level mask layer
(we already allocate this layer, so there's no reason to defer
downstream anyway).

Change-Id: Icbb7e403f90feecfae5846697f559a03d8aa4097
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239036
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-09-04 14:09:44 +00:00
Hal Canary
45812a1faa gn: try to fix flutter roll
Change-Id: I8503ee596b35a45b5b0269cd6af98569115212cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239116
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-09-04 13:26:02 +00:00
skia-recreate-skps
86c39c7126 Update Go deps
Change-Id: I3a4438b1917f57ba2267aaab9d962098af3c2444
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239033
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-04 05:24:12 +00:00
skia-autoroll
2fba41ba31 Roll third_party/externals/angle2 31b524cf60b7..a1bf69967a32 (8 commits)
31b524cf60..a1bf69967a

git log 31b524cf60b7..a1bf69967a32 --date=short --no-merges --format='%ad %ae %s'
2019-09-04 teisenbe@google.com Fuchsia: Migrate to new libasync-loop API
2019-09-03 lujc@google.com Use TransformFeedbackID in place of GLuint handle
2019-09-03 lujc@google.com Use VertexArrayID in place of GLuint handle
2019-09-03 syoussefi@chromium.org Reland "Vulkan: Debug overlay"
2019-09-03 mihu@microsoft.com ANGLE test fixture leaking.
2019-09-03 syoussefi@chromium.org Update status of ES3.1 on Vulkan
2019-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 92f5afdee0ab..56f61ccceffa (1 commits)
2019-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 65e362b7ae2a..2c5ed16ba97d (1 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@a1bf69967a32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=jlavrova@google.com
Change-Id: I9a49cd5e7bb2edc5ad58004cc95d9e12738c554d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239028
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-04 05:23:11 +00:00
skia-autoroll
59a7351f00 Roll third_party/externals/swiftshader 920100cd4246..fbc146e97f30 (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/920100cd4246..fbc146e97f30

git log 920100cd4246..fbc146e97f30 --date=short --no-merges --format='%ad %ae %s'
2019-09-03 digit@google.com [yarn]: Add yarn_unittests GN target to BUILD.gn
2019-09-03 digit@google.com [yarn]: Fix Fuchsia build.
2019-09-03 bclayton@google.com Yarn: Add blocking_call.
2019-09-03 chrisforbes@google.com Add BindImageMemory2 support for swapchain images
2019-09-03 chrisforbes@google.com Add support for vkAcquireNextImage2KHR
2019-09-03 swiftshader.regress@gmail.com Regres: Update test lists @ 920100cd

Created with:
  gclient setdep -r third_party/externals/swiftshader@fbc146e97f30

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=jlavrova@google.com
Change-Id: I1b3d99859e44ca8b25119a1c828c52c02f192197
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239056
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-04 05:05:02 +00:00
skia-autoroll
e054ff2683 Roll ../src 050ceed1f1d7..248662b1b84a (455 commits)
050ceed1f1..248662b1b8


Created with:
  gclient setdep -r ../src@248662b1b8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=jlavrova@google.com
Change-Id: I201d9fa561661cbe02e0c7fa317af6e3bd1c7c64
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239029
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-04 04:46:22 +00:00
Ben Wagner
6be3ea7a7d [pdf] Disable default width calculation.
Unfortunately, poppler does not currently appear to handle DW.

Change-Id: I394f0f28fab194275016ce70f0ae254254c7b3d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238964
Auto-Submit: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-09-04 00:42:19 +00:00
recipe-roller
aeba7fa1fd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f38bc1796282c61087dcf15abc61b8fd18a68402 git-cl: Clean up a bit (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5a078e42367e71fc8e3c52449103dce767e504db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239003
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-03 21:27:39 +00:00
recipe-roller
7ffef1e8cc Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a877ee62b1fcd52c590d466ffdd0b2df5bd3e74e depot_tools: Run some tests on Python 3 on the bots. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icbc0bb29c8aa7ed0f58ab4c7edfa1da45f9205d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238997
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-03 20:49:08 +00:00
Brian Osman
a66081d943 Move SkSL caching out of GR_TEST_UTILS, trim persistent cache options
Combines the two boolean options into a single tri-state enum. Old GLSL
option is still present (temporarily) until Chrome is switched over.

Also add a type tag for cached program binaries, so we can safely
detect cache entries of the wrong type.

Change-Id: I0ddeefa9180b27bc2c46e2e7b77e6c9cdf4a730a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238856
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-03 20:18:48 +00:00
Mike Reed
18a8df6cc1 update gm to better show the unclipped layers
Change-Id: I7dd19befda85bf2f89f317d190b7296ded91c00e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238957
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-09-03 20:10:48 +00:00
recipe-roller
445505e541 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/1db68ea0ba175a62889d15dc420c4bd481db2513 Add ANGLE issue tracker to my_activity.py. (jmadill@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I46a57d44f62af6df47f80eb916d374a736b4e58d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238925
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-03 20:09:08 +00:00
Jim Van Verth
86c498319e Fix argument path for dsymutil
Change-Id: Iad8dd9135aadd77ffa7cdbd53dbb1e97a5fdf8d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238956
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-09-03 20:03:08 +00:00
Brian Osman
e9d9a3278f Remove GrGLProgram cache stats, remove spurious declarations/includes
Change-Id: I5f3c17fc008a5ec92803000f17d7db65af1b4cfa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238901
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-03 19:12:07 +00:00
Hal Canary
c7b263b603 gn: move all skia_* declare_args to skia.gni
motivation:  put them all in one place.

Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 18:29:22 +00:00
Greg Daniel
b20d7e5412 Track all sampled textures in GrOpsTask and pass them to GrOpsRenderPass.
In Vulkan we use this list to set the layout for these surface to be
VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL at GrOpsRenderPass creation
instead of at submit. This gets us closer to being able to run with
primary or secondary command buffers.

Change-Id: I6e307485987e2c024ed9ecba3e41f588047c5f07
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238444
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-09-03 18:22:32 +00:00
Ben Wagner
e91f2235bb [pdf] Only compute needed advances.
The previous code computed all advances in the font up front, not just
the ones in the subset. This can take a long time. Instead, only compute
the advances in the subset.

This replaces the previous state machine with slightly easier to
understand look ahead. There is never a need to look ahead more than two
positions, so this isn't too bad.

This also calculates the most common advance width in the subset and
uses it as the default (the default was previously always zero). Other
than ommiting the defaults, this code should produce the equivalent
output to the previous code.

On my local Windows 10 box this reduces Chromium's
IsolateOriginsPrintBrowserTest.PrintIsolatedSubframe test runtime
(standalone) from 20 seconds to 15.

Bug: chromium:996185
Change-Id: I40d8b27ab1344d546de3958b3198b675bda81b76
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238596
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2019-09-03 18:08:02 +00:00
Kevin Lubick
2e5fe35044 [canvaskit] Add rrect support
Change-Id: Ic9f2c0224b95e277df93a1d46e59a1096d8005b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238896
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-09-03 18:00:16 +00:00
Mike Reed
a5b0769647 update test to allow dumping images
Change-Id: Ib6f9b7a02c222623498e59bb5cdef659e6096ae2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238897
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-09-03 17:48:15 +00:00
recipe-roller
7774349241 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5aeddeb96eb917db25ee1ac7c668927a716e79ad [lucicfg] Bump lucicfg to v1.8.6. (vadimsh@chromium.org)
  https://crrev.com/355e97e300e8baceae8353287ad59b915dbb8196 OWNERS: add tandrii@google.com. (tandrii@google.com)
  https://crrev.com/d9cbe7ad6916bb800c3b88d011fbcfe94b5cf3e0 [git-cl] Lint and clean-up git-cl, test, and related modules (qyearsley@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I59215a541344b3bdfe6d5f5e745f04cf4543aa42
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238885
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-03 17:20:18 +00:00
Brian Salomon
7a7ddc447f Add parens to assert
TBR= robertphillips@google.com

Change-Id: Id0d7cee8a9b5f28e28e073928b29055b2efaae1c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238858
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-09-03 16:00:16 +00:00
Greg Daniel
4fe92577c5 Comment out assert in onClear in GrVkOpsRenderPass.
Change-Id: I65d8bf85749ee543e392d406cb2c976199e3856c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238857
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-09-03 15:44:36 +00:00
Florin Malita
a3d88db57f [svgcanvas] Skip redundant clip-rule attributes
- when nonzero (default)
 - when applied to <rect> (no effect)

TBR=
Bug: skia:9344
Change-Id: I1162c4a9c93177fc5c1eadde8901eb888d16bfc6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236342
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2019-09-03 15:31:16 +00:00
Florin Malita
2e4c283f78 [skottie] Clean up TextAdapter
Convert to DiscardableAdaptorBase, drop unneeded TextAnimatorList
wrapper, switch to raw pointer lambda captures.

TBR=
Change-Id: Idd43ad89a299ff344ff539b87cfb7790fef10b2f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238441
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-09-03 15:29:36 +00:00
Florin Malita
f49cd70119 [skottie] Plumb square selector "smoothness" prop
Requires https://github.com/bodymovin/bodymovin-extension/pull/22

Change-Id: I2614aeefce18f4b3e6c6373cd5503a7696253a76
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238436
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-09-03 15:08:14 +00:00
Robert Phillips
cf39f375d1 Remove maxCount resource cache limit
Change-Id: I0f1064c8433d69e24ca3d5b970c99d539dc1dadd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238442
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-03 14:59:51 +00:00
Brian Salomon
beb7f525c8 Make GrSurfaceProxy constructors take arg that determines participation in
GrResourceAllocator.

Removes LazyInstantiationType. All callbacks can be invoked one time (if successful).
Lazy callbacks indicate whether their lifetime should be extended, which is used by
promise image proxy callbacks.

Promise image proxies are no longer deinstantiated at the end of flush and
GrDeinstantiateProxyTracker is removed. They will be instantiated the first time
they are encountered in GrResourceAllocator::addInterval (without actually adding
an interval) and then remain instantiated.

Also removes some "helper" versions of proxy factory functions that took fewer
params. They weren't much used outside of test code and as the total number of params
has grown their relative utility has diminished. We could consider a params struct
or radically simpler helpers that take only a few params if desired.

Change-Id: Ic6b09e7b807b66cb9fcbb7a67ae0f9faf345485f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238216
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-09-03 14:58:41 +00:00
Ben Wagner
edcce3145a [gn] Add pool for dsymutil
dsymutil seems to kill the machine when too many processes are run in
parallel, so we need to use a pool to limit the concurrency when
passing large -j to Ninja (e.g. Goma build).

Change-Id: I84404291db4781f86268256ab888cef8d07c770e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234477
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-09-03 14:08:09 +00:00
Jim Van Verth
e58d532bc3 Get Metal running on iOS viewer.
Adds MetalWindowContext_ios and hooks it up to Window_ios.
Also includes some minor clean up in other iOS code.

Bug: skia:8737
Change-Id: I2e8a0c755310fbc4ed534f975815c60f8eca130b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238438
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-09-03 14:07:39 +00:00
Ben Wagner
d51ea41ce4 [gn] Move dsymutil from link command to a separate action
Change-Id: I18a3bd5e845305e3b2521d076fd641bd5175b618
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234327
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-09-03 14:02:49 +00:00
Brian Osman
61e17c51ad Particles: Change effect lifetime logic to work like particles
Change-Id: I9f71bfbd506b56eae4fe6a430b70f8f9a31d7009
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238445
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-03 13:56:39 +00:00
Hal Canary
452ce044f0 iOS toolchain: no -soname for is_component_build=true
Change-Id: I81835ffdd1fbdaa12d662527e38b42532f2ea8e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238756
Commit-Queue: Hal Canary <halcanary@skia.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-09-03 13:52:49 +00:00
skia-recreate-skps
8050d94ae2 Update Go deps
Change-Id: Ibb100c497f370a23e2a928162a0714663bb7ed31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238790
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-03 05:23:39 +00:00
skia-autoroll
dea6ac7ee4 Roll third_party/externals/angle2 791ad7b8774a..31b524cf60b7 (9 commits)
791ad7b877..31b524cf60

git log 791ad7b8774a..31b524cf60b7 --date=short --no-merges --format='%ad %ae %s'
2019-09-02 jmadill@chromium.org Roll Chromium DEPS.
2019-09-02 jmadill@chromium.org Re-enable -Wextra-semi-stmt.
2019-09-02 jmadill@chromium.org Vulkan: Update dEQP-GLES2 Android test expectations.
2019-09-02 lujc@google.com Use MemoryObjectID in place of GLuint handle
2019-09-02 jmadill@chromium.org Vulkan: Lift failing Wintel test expectation.
2019-09-02 cwallez@chromium.org Also skip ComputeShaderTest.UniformDirty/ES3_1_Vulkan on Win/NVIDIA
2019-09-02 cwallez@chromium.org Revert "Vulkan: Debug overlay"
2019-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 73422a0a5ee1..65e362b7ae2a (6 commits)
2019-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 796df2d74e05..92f5afdee0ab (2 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@31b524cf60b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=jlavrova@google.com
Change-Id: I302ba423e3a96feaff60b4bdfa788f8f9de3a563
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238781
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-03 05:19:18 +00:00
skia-autoroll
033c4014b7 Roll third_party/externals/swiftshader 39a9f1bdcd0e..920100cd4246 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/39a9f1bdcd0e..920100cd4246

git log 39a9f1bdcd0e..920100cd4246 --date=short --no-merges --format='%ad %ae %s'
2019-09-02 sugoi@google.com Enable fragmentStoresAndAtomics
2019-09-02 jmadill@chromium.org Fix GN Header checks.

Created with:
  gclient setdep -r third_party/externals/swiftshader@920100cd4246

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=jlavrova@google.com
Change-Id: I35b2eb510b29bc49159892429b58f0fc91b85864
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238782
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-03 04:36:08 +00:00
skia-autoroll
abe41c18e3 Roll ../src 4ad2798edb07..050ceed1f1d7 (150 commits)
4ad2798edb..050ceed1f1


Created with:
  gclient setdep -r ../src@050ceed1f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=jlavrova@google.com
Change-Id: I57028750afce4633b37c0b1b04b1bf7d1d6545de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238783
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-03 04:23:48 +00:00
Khushal Sagar
94c6647556 Revert "Only send the RemoteStrikes that have pending glyphs."
This reverts commit 3783375c4d.

Reason for revert: Glyph cache miss issues are back with this change (landed in 78.0.3898.0) : https://crash.corp.google.com/browse?q=product_name%3D%22Chrome%22+AND+expanded_custom_data.ChromeCrashProto.channel+IN+%28%22canary%22%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%22%5BDump+without+crash%5D+SkScalerContextProxy%3A%3AgenerateMetrics%22

Original change's description:
> Only send the RemoteStrikes that have pending glyphs.
> 
> Count the number of strikes in fRemoteStrikesToSend that have
> glyphs to send. The strike may not have glyphs to send, because they
> were sent previously. Then, send the strikes that have glyphs to send.
> Keep the bool in the serialization which indicates that strike
> has glyphs and should always be true now. The bool will be removed in the next CL.
> 
> Change-Id: I8b75d1bda574fd71adfd21cb20ff912340fc2e33
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237815
> Commit-Queue: Herb Derby <herb@google.com>
> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>

TBR=herb@google.com,khushalsagar@chromium.org,khushalsagar@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I910734d9db570784b73e108d7b5abedd2efc5ad7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238778
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
2019-09-03 00:55:44 +00:00
skia-autoroll
8203a180ea Roll third_party/externals/angle2 120b61d34ba8..791ad7b8774a (15 commits)
120b61d34b..791ad7b877

git log 120b61d34ba8..791ad7b8774a --date=short --no-merges --format='%ad %ae %s'
2019-08-31 syoussefi@chromium.org Vulkan: Enable more GLES3.1 dEQP tests
2019-08-31 syoussefi@chromium.org Vulkan: Storage image support
2019-08-31 syoussefi@chromium.org Fix build error
2019-08-31 syoussefi@chromium.org Vulkan: Debug overlay
2019-08-31 syoussefi@chromium.org Vulkan: revamp present semaphore management
2019-08-30 lujc@google.com Use SemaphoreID in place of GLuint handle
2019-08-30 jmadill@chromium.org Update docs on enum names.
2019-08-30 jmadill@chromium.org Vulkan: Generalize ICD decision for loader.
2019-08-30 syoussefi@chromium.org Vulkan: Make vk::ImageView pointers const
2019-08-30 jmadill@chromium.org Vulkan: Move loader defines into BUILD.gn.
2019-08-30 lujc@google.com Use FramebufferID in place of GLuint handle
2019-08-30 syoussefi@chromium.org Move timer functionality from util/ to common/
2019-08-30 syoussefi@chromium.org Vulkan: Split Vulkan docs from README.md into doc/
2019-08-30 jmadill@chromium.org SystemInfo: Add Google VendorID.
2019-08-30 timvp@google.com Support separate read and draw surfaces in eglMakeCurrent

Created with:
  gclient setdep -r third_party/externals/angle2@791ad7b8774a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=jlavrova@google.com
Change-Id: I96b9e74aeed79b0de594b81a5fbd582a99df22d6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238699
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-02 05:23:43 +00:00
skia-recreate-skps
e3ab45cb74 Update Go deps
Change-Id: I0eaf285be56abc6f3fa0d4d6d08233c92130a102
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238704
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-02 05:23:33 +00:00
skia-autoroll
990c3d8f26 Roll ../src a461132e64f5..4ad2798edb07 (456 commits)
a461132e64..4ad2798edb


Created with:
  gclient setdep -r ../src@4ad2798edb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=jlavrova@google.com
Change-Id: Ic801848e436b69b430ca781d923210a3c5f3e369
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238597
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-02 04:39:03 +00:00
skia-autoroll
86f50ff28f Roll third_party/externals/swiftshader 680d37610656..39a9f1bdcd0e (12 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/680d37610656..39a9f1bdcd0e

git log 680d37610656..39a9f1bdcd0e --date=short --no-merges --format='%ad %ae %s'
2019-08-31 chrisforbes@google.com Add input attachment support for VK_FORMAT_A1R5G5B5_UNORM_PACK16
2019-08-31 chrisforbes@google.com Add ROP support for VK_FORMAT_A1R5G5B5_UNORM_PACK16
2019-08-31 swiftshader.regress@gmail.com Regres: Update test lists @ 18c9ac49
2019-08-31 bclayton@google.com Update SPIRV-Tools to 65e362b7
2019-08-30 capn@google.com Optimize non-solid polygon rasterization
2019-08-30 bclayton@google.com Implement non-solid polygon rasterization
2019-08-30 chrisforbes@google.com Don't use bitcast+float path for integer constant values
2019-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 680d3761
2019-08-30 capn@google.com Fix version script renames
2019-08-30 capn@google.com Canonicalize Vulkan ICD library names
2019-08-30 jmadill@chromium.org Support Windows builds and ANGLE integration.
2019-08-30 capn@google.com Initialize the blend state using memset

Created with:
  gclient setdep -r third_party/externals/swiftshader@39a9f1bdcd0e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=jlavrova@google.com
Change-Id: Ia4b5602832302ff2d926bb30880cde36de547763
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238700
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-02 04:34:43 +00:00
Michael Ludwig
0a1e9efa39 Don't use AA convex path renderer if direction can't be determined
Without the changes to GrShape and GrAAConvexPathRenderer, this new GM
would not draw the red circle at the center when using Ganesh. Raster
drew the red circle. The difference came about because they checked
convexity after transforming by the view matrix, and Ganesh checked
before.

With this particular path construction and the very large scale factor
on the CTM, the convexity calculator in local space computed small
enough edge vectors that it thought the contour backtracked on itself
instead of winding in a consistent direction.

The GrAAConvexPathRenderer would claim it could draw the convex path,
but later when actually preparing to draw, it would do nothing if it
turned out the convex path didn't have a direction. This CL updates it
so that the convex path renderer's canDraw() function matches what it
is actually able to draw.

There is the separate issue of the convexity/direction checking
precision.

Bug: chromium:996140
Change-Id: I6f2af2d9ba6752663d97c8573deb2d767a3f1245
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238121
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-09-02 01:57:03 +00:00
skia-recreate-skps
7dfd4bd3fc Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I81be23f22c881e010294a503786b0a492417c2c9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238644
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-01 08:18:12 +00:00
skia-recreate-skps
7e45515fa3 Update Go deps
Change-Id: I598500727a4411a4b565462f4c0d1da83da69a9c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238639
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-01 05:25:42 +00:00
Mike Reed
6e637472eb remove legacy flag SK_SUPPORT_LEGACY_RECT_PARAMS
Change-Id: If44832593bfb3877e1fe7c68ec64c70f0d595ed5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238176
Reviewed-by: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-08-31 12:12:19 +00:00
skia-recreate-skps
c2ec9bfe1b Update Go deps
Change-Id: Id44616f7238302fd35be794d2e6983417a42e95e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238616
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-08-31 05:25:49 +00:00
recipe-roller
f46c8268bf Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/17016be940adee622232217f60df423ad555e82c README.git-cl.md: Remove reference to Rietveld (maruel@chromium.org)
  https://crrev.com/7542437eea41f579d1f87d78f6848db15e34070f git cl: get rid of builders-map. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c34c3f6a98bc33ed8c3328200b4859a1ecde2fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238559
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-08-30 23:19:09 +00:00
Florin Malita
93edd9eb44 [skottie] Discard unneeded static text animators
Change-Id: I8751b1b1193726849e6ed3f127e32c17b8a7ed6f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238443
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-08-30 21:09:08 +00:00
Andy Weiss
8ef18d359b Override operator delete for GrCCPathCache::Key
GrCCPathCache::Key allocates extra space for a buffer in Make but using sized
delete will then lead to UB as operator delete is not implemented.

This change overrides the delete operator to force the unsized variant
which gets rid of the UB at the cost of not taking advantage of sized
delete. Once P0722R1 is available to safely compute the full size of
the object inside delete, this code can change to use sized delete.

c.f. https://bugs.chromium.org/p/skia/issues/detail?id=6384
and http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0722r1.html

Change-Id: Id92edc71374be6880aa362e625bb9a5d20e07ac0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238116
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-08-30 20:08:21 +00:00
Greg Daniel
15ecdf94fd Just skip uninstantiated GrOps instead of delete them on flush.
Change-Id: I4e1755872979b635ad993cfba6b17d7b79ee2c54
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238179
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-08-30 20:01:41 +00:00