rmistry
8f74c160c3
Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1 of https://codereview.chromium.org/1221553003/ )
...
Reason for revert:
This should no longer be required due to Ned's fix in https://codereview.chromium.org/1217823005/
Original issue's description:
> Use page_set_module.PageSet instead of story.StorySet
>
> BUG=skia:3967
> NOTRY=true
> TBR=nednguyen
>
> Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd
TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3967
Review URL: https://codereview.chromium.org/1214903008
2015-06-30 08:22:25 -07:00
rmistry
7b971f0152
Use page_set_module.PageSet instead of story.StorySet
...
BUG=skia:3967
NOTRY=true
TBR=nednguyen
Review URL: https://codereview.chromium.org/1221553003
2015-06-30 05:03:05 -07:00
rmistry
dd3b12e270
Migrate PageSets to StorySets in buildbot page sets
...
BUG=skia:3967
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1203433002
2015-06-30 03:54:07 -07:00
rmistry
4c58e085b2
Remove separate SP enabled SKP run since it is now on by default
...
Yesterday's RecreateSKPs_Canary run looks good:
http://build.chromium.org/p/client.skia.fyi/builders/Housekeeper-Nightly-RecreateSKPs_Canary/builds/143
The generated SKPs look very reasonably sized:
gs://chromium-skia-gm/playback_386/skps
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1191113002
2015-06-18 07:52:14 -07:00
nednguyen
6bad28de52
Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets
...
BUG=487800
Review URL: https://codereview.chromium.org/1131113005
2015-05-16 15:47:02 -07:00
rmistry
23c5f51371
Handpick 16 Skia page sets to create SP enabled SKPs from
...
Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18
NOTRY=true
BUG=skia:3763
Review URL: https://codereview.chromium.org/1115003002
2015-04-29 10:15:07 -07:00
rmistry
385e88cc16
Create SP enabled SKPs from only the top_25_smooth page set.
...
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1111273003
2015-04-29 07:26:33 -07:00
rmistry
77772f3ca3
Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix.
...
Will only be committed after I get the go head in skia:3763.
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1065503007
2015-04-28 08:27:19 -07:00
rmistry
aa31ee78ee
Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py
...
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1066933006
2015-04-23 12:47:33 -07:00
rmistry
80bd3ae9d7
Delete no longer needed pagesets, add new pagesets and make names more readable
...
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1053253003
2015-04-03 08:22:51 -07:00
rmistry
2a3c8493af
Turn on Chromium's top 25 page set
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1045153004
2015-03-31 10:59:15 -07:00
rmistry
39383a1946
Fix cr SKPs naming
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1044193003
2015-03-31 08:03:02 -07:00
rmistry
5af9a3792f
Turn on key mobile sites cr page set and delete dashed desktop
...
#crskps
BUG=skia:3574
BUG=skia:3605
NOTRY=true
Review URL: https://codereview.chromium.org/1040233004
2015-03-31 06:22:55 -07:00
rmistry
009b069f52
Fix gs.upload_dir_contents arguments mismatch
...
Fixing bug introduced by https://codereview.chromium.org/737123005
BUG=skia:
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1041003003
2015-03-31 05:20:12 -07:00
rmistry
49d093cef9
Add ability to capture SKPs from Chromium's pagesets
...
Also added support for pagesets with multiple pages in them.
#crskps
BUG=skia:1723
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1047703003
2015-03-31 05:04:29 -07:00
kkinnunen
b4ee7ea834
webpages_playback.py: Support storing to local directories
...
Make webpages_playback support storing to local directories as an
alternative to Google Storage.
Rename argument --dest_gsbase to --data_store=<location>. Make this parameter
accept either gs:// url or directory for local file system storage.
Rename argument --upload_to_gs to --upload.
Implement file existence check, download and upload for the file
operation.
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/737123005
2015-03-31 00:18:27 -07:00
kkinnunen
f9310fe2be
webpages_playback.py: Avoid crash when retrying to capture skp
...
Move the .wpr files after recording, in the recording retry loop.
Previously they were moved in the skp capture retry loop.
Review URL: https://codereview.chromium.org/1033223005
2015-03-29 22:33:16 -07:00
rmistry
6776a538f9
Increase timeout of ukwsj to get more consistent SKP captures
...
BUG=skia:3574
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/1038443002
2015-03-24 10:58:37 -07:00
rmistry
ba98761320
Add pageset for theverge
...
BUG=skia:3234
TBR=robertphillips
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/994923002
2015-03-10 05:00:08 -07:00
rmistry
e1f630dc8b
* Add nytimes_desktop pageset.
...
* Delete cuteoverload, frantzen, transformice and nytimes_tabl.
* Increase wait time for forecastio.
BUG=skia:3320
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/808843004
2015-01-16 11:41:26 -08:00
rmistry
bb928a0c0a
Add pageset for ugamsolutions.com
...
BUG=skia:3306
NOTRY=true
Review URL: https://codereview.chromium.org/851743004
2015-01-13 11:52:28 -08:00
kkinnunen
7445aa7d27
webpages_playback.py: Page sets to use changed telemetry API (AddUserStory)
...
Make page sets to use telemetry.page.page_set.AddUserStory instead of
AddPage.
BUG=chromium:439512
BUG=skia:3196
NOTRY=true
Review URL: https://codereview.chromium.org/811003002
2014-12-17 04:06:54 -08:00
rmistry
e556089dd1
Increase timeout on sfgate pageset
...
TBR=scroggo
NOTRY=true
BUG=skia:3196
Review URL: https://codereview.chromium.org/800563002
2014-12-11 13:23:28 -08:00
rmistry
2f37ae17ea
Remove action_runner steps for worldjournal pageset to prevent crashes
...
BUG=skia:3196
NOTRY=true
Review URL: https://codereview.chromium.org/795173002
2014-12-11 10:24:27 -08:00
rmistry
43be354644
Increase timeouts for CSS3Gradients and GooglePlus pagesets
...
BUG=skia:3187
BUG=skia:3196
Review URL: https://codereview.chromium.org/786353002
2014-12-09 10:19:33 -08:00
kkinnunen
960fb50a1a
Make debugger not fail with webpages_playback script and multiple skp files
...
The debugger accepts either a single skp or a directory as a parameter.
The webpages_playback script used to pass multiple files using a '*'
glob.
Review URL: https://codereview.chromium.org/775073002
2014-12-03 06:18:12 -08:00
kkinnunen
fcf35c533b
Update webpages_playback documentation
...
Update the documentation on how to run webpages_playback. It was out of
date.
Review URL: https://codereview.chromium.org/778633002
2014-12-03 05:51:24 -08:00
kkinnunen
e75d2d2d99
Remove Google Storage scheme prefix correctly from gs base name in webpages_playback
...
In python, str.lstrip([chars]) means "lstrip any of the chars from str",
not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia".
Replace with custom function stripping the prefix from lstrip()ed gs
base name.
Review URL: https://codereview.chromium.org/780493002
2014-12-03 04:38:46 -08:00
kkinnunen
3a6aa86978
Make render_pdfs not crash webpages_playback script
...
The render_pdfs nowadays seems to input the skps from
the dir passed as '-r' parameter.
The app will not output anything, but it will not crash the
webpages_playback script either. Affects only runs that have
--skia_tools=<dir> argument.
Review URL: https://codereview.chromium.org/776873004
2014-12-03 04:22:06 -08:00
rmistry
fec29ecce8
Increase wait time for spreadsheetdashed pageset
...
BUG=skia:3049
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/692843002
2014-10-30 05:52:26 -07:00
Ravi Mistry
0e50262767
Increase timeout of blogger pageset and re-enable weather pageset
...
BUG=skia:3049
2014-10-30 07:37:07 -04:00
Ravi Mistry
7cf0294d51
Increase timeouts of wowwiki and youtube
2014-10-29 17:39:15 -04:00
Ravi Mistry
2c8371aea7
Moving weather pageset since it is crashing
2014-10-29 17:03:22 -04:00
Ravi Mistry
d50bbc7c05
Moving wikipedia pageset since it is crashing
2014-10-29 14:36:15 -04:00
Ravi Mistry
e951189f77
Change extension of crashing page set
2014-10-29 13:55:23 -04:00
Ravi Mistry
645132406a
Moving vnexpress pageset since it is crashing
2014-10-29 13:45:17 -04:00
Ravi Mistry
7b3afa646e
Increase wait times for androidpolice and nytimes
2014-10-29 12:25:34 -04:00
rmistry
7aa4d349be
pagesets are still crashing in RecreateSKPs bot, try adding waits to most pagesets
...
BUG=skia:3049
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/682573004
2014-10-29 08:19:05 -07:00
rmistry
6eea9e7871
Add wait to amazon page set to avoid tab crashes
...
BUG=skia:3049
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/686133002
2014-10-29 06:40:27 -07:00
rmistry
0ec28af1a7
Updated all page sets to capture new set of webpage archives.
...
Fixed the record_wpr retry mechanism in webpages_playback.py.
Updated all page sets to remove the no longer needed RunSmoothness and RunNavigateSteps.
Updated the key_silk_cases pagesets to point to a non svn location:
* skia_fontwipe_desktop.py
* skia_silkfinance_desktop.py
Removed mercurynews, record_wpr was timing out because of a popup.
Added back the following pagesets which were previously disabled but are now working again:
* skia_cnn_nexus10.py
* skia_wordpress_desktop.py
* skia_transformice_nexus10.py
BUG=skia:3049
Review URL: https://codereview.chromium.org/684863002
2014-10-28 14:25:17 -07:00
rmistry
7620bf0658
Fix ability to capture archives in webpages_playback.py
...
Updated all page sets to match the file name. This is to make it easier to call record_wpr with the page set class name.
Also updated the wait time for baidu to 60 seconds.
BUG=skia:3049
Review URL: https://codereview.chromium.org/683473002
2014-10-27 06:42:11 -07:00
rmistry
22b5ab644e
Add back page_sets/skia_googlespreadsheet_desktop
...
Absolutely could not get the old page to work so I just created a new page.
NOTRY=true
BUG=skia:3008
Review URL: https://codereview.chromium.org/671883002
2014-10-22 06:19:51 -07:00
rmistry
f802f326f4
Update webpages_playback script and all page_sets to use new skpicture_printer benchmark
...
The purpose of this CL is to turn the RecreateSKPs bot green after
https://codereview.chromium.org/665193002/ lands.
Description of changes in this CL:
* After https://codereview.chromium.org/665193002/ lands we will no longer need to copy the archives and pagesets to telemetry's data directory, I removed the code that did this in https://codereview.chromium.org/655313003/
* page_sets now need unique class names. Updated all page_sets to have unique class names.
* Using the new --page_set_name and --page_set_base_dir and --also-run-disabled-tests parameters
BUG=skia:3046
Review URL: https://codereview.chromium.org/671513009
2014-10-22 05:04:43 -07:00
borenet
25956ce430
Fix RecreateSKPs bot (again)
...
It's killing its own process...
BUG=skia:3008
TBR=rmistry
NOTRY=true
Review URL: https://codereview.chromium.org/661203002
2014-10-17 14:17:18 -07:00
borenet
783991585b
Fix recreate_skps?
...
run_measurement was removed in https://codereview.chromium.org/655563007 .
Based on the comments, I think the right thing to do is replace it with
run_benchmark. Hopefully this fixes the bot.
BUG=skia:
TBR=rmistry
NOTRY=true
Review URL: https://codereview.chromium.org/658513004
2014-10-17 12:15:46 -07:00
borenet
dc89ca56e6
Add recreate_skps script
...
BUG=skia:3008
Review URL: https://codereview.chromium.org/655313003
2014-10-17 07:37:05 -07:00