Commit Graph

915 Commits

Author SHA1 Message Date
Ravi Mistry
f06dae824b Stop CT_DM_1m bot from triggering on every commit
NoTry: true
Bug: skia:
Change-Id: I2d8039ad4105234f1079dd48a9d0fc0047eec9c6
Reviewed-on: https://skia-review.googlesource.com/60080
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-10-16 14:40:14 +00:00
Kevin Lubick
9ef6de7824 Add in test_filter to build configuration
The first "sharding" technique we will try is just by test config
(e.g. 8888, gles, etc).  Thus, for backwards compatibility,
the default "shard" is All, as in all configs

Bug: skia:
NOTRY=true
Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375
Reviewed-on: https://skia-review.googlesource.com/59563
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 11:09:49 +00:00
UpdateSKPs
22a43a36d8 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ie89dc6f872518191c0837f54cd2908db29f73be4
Reviewed-on: https://skia-review.googlesource.com/59900
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-10-15 07:55:05 +00:00
Chris Dalton
7a0ebfc033 Add a tooling flag for path mask caching
Adds the flag and a disables caching on the CCPR bots.

Bug: skia:
Change-Id: Icb85e77f89634dda1d419dacac5b8a93340723f0
Reviewed-on: https://skia-review.googlesource.com/59740
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2017-10-13 22:31:12 +00:00
Kevin Lubick
7c1eae5c90 Fix asset version detection
Since we went to retrying the adb commands, the return value
got lost, which was used to read the SKP_VERSIOn, etc.

This fixes it.

Bug: skia:
NOTRY=true
Change-Id: Ifc61ec4cbb13a61c571b2fb89a9c0ed215f8fbd3
Reviewed-on: https://skia-review.googlesource.com/59441
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-13 17:20:37 +00:00
recipe-roller
476bdfc3ee Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d08043c72c79aac41b4c9e26c29a6333935b103a Allow 'git cl patch' when not on a branch. (szager@chromium.org)
  https://crrev.com/9f20d020855c8ee87ba64d53ef94051c06aab860 Do not write gclient_gn_args_file too early. (dpranke@chromium.org)
  https://crrev.com/7de54ef0a25f546747ea9f2a536d5cb175abc566 Fix handling of potential empty gitiles result. (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2ae03882f4e311234abb043349cea20653a9c1a6
Reviewed-on: https://skia-review.googlesource.com/59561
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-13 15:17:27 +00:00
Ben Wagner
9d7f135599 Add Win Clang ANGLE test and perf jobs.
No-Try: true
Change-Id: I95a29b1abfd84e51f5a31d74644e5305779f0d15
Reviewed-on: https://skia-review.googlesource.com/57100
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-10-13 14:43:17 +00:00
Kevin Lubick
cccaef1667 Modify skpbench to use newer adb version
Bug: skia:
NOTRY=true
Change-Id: Ib630d352b6922280ef5772e6843f8f031baeffaf
Reviewed-on: https://skia-review.googlesource.com/59161
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-13 13:13:47 +00:00
Kevin Lubick
bd27d1de7a Adjust blacklist for IB2
Bug: skia:7160
NOTRY=true
Change-Id: I673d4655b91056954253f69fb4a25f1e190222fa
Reviewed-on: https://skia-review.googlesource.com/59380
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-13 12:10:27 +00:00
Kevin Lubick
02f709e416 Fix Chromebook output step and skpbench
They pull stuff of using scp, which does not perform well
if a directory does not exist.

Skpbench also needs to be updated to use new adb.

Bug: skia:
NOTRY=true
Change-Id: I1e9f2dbddaab05e1aeb4d71d97f1e6e4bfdd299a
Reviewed-on: https://skia-review.googlesource.com/59081
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-12 19:18:11 +00:00
Kevin Lubick
587afc9df0 Update to adb 1.0.35
The newer adb acts more like cp when pulling. We used to 
create the dm folder on the host machine before pulling.

This used to be fine, 
/device/dm_out/dm.json -> /host/dm/dm.json

However, with the update, adb would do
/device/dm_out/dm.json -> /host/dm/dm_out/dm.json

This breaks the upload step.  To make this transition
a smooth one, /usr/bin/adb on the RPI is staying the same
(for a while, at least) and /usr/bin/adb.1.0.35 is being added.

That way we can use the new adb on tests after this commit, but
when we backfill, we don't break because of the unexpected folder.

Bug: skia:
Change-Id: Icbed38594fca0e17af1f8d01d75c42ce03f710b9
Reviewed-on: https://skia-review.googlesource.com/58880
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-12 17:22:12 +00:00
recipe-roller
0237ab2d36 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/b3ce73d028b1d44137d533220fd41be31bc31801 More verbose output when .gclient file cannot be found (machenbach@chromium.org)
  https://crrev.com/8f572a579ae88523418d33594bd529b0e9bdddbd download_from_google_storage: call gsutil.py once before anything else happens (hinoka@google.com)
  https://crrev.com/b40a45149a73a6b00e92fd1d2df4c0b1543d0005 Allow specifying alternative "success" codes in gitiles requests. (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I25efe499db29ab2f08d8baf361db0c6e132383c4
Reviewed-on: https://skia-review.googlesource.com/58902
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-12 16:34:31 +00:00
recipe-roller
e60ca7eae4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/3f1ab05820af5b675682e9d9ad2bf2910801d768 Fix gclient config of slave.DEPS and internal.DEPS. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic0582b409595834cfbeb541406f3bdd899faf680
Reviewed-on: https://skia-review.googlesource.com/58721
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-12 02:33:32 +00:00
recipe-roller
0d851fdff9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/aacb2ad3c143f67b8f945469b1aca13db0a9f082 Add --repackage option to VS packaging script (brucedawson@chromium.org)
  https://crrev.com/8d72d02c670ef10eeca2d211c824e24ab199a6af Remove Rietveld CQ config. (tandrii@chromium.org)
  https://crrev.com/2d5f039dbf52d49ccfb81d3bd3c9d0479d7fc080 Support --nocommit option to git-cl-patch for gerrit. (szager@chromium.org)
recipe_engine:
  https://crrev.com/c07de907b2223efcacbf45d7b793fc0d8a964f31 Remove Rietveld CQ config. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9146246c06efa768c94cffb01da82fd6920d782
Reviewed-on: https://skia-review.googlesource.com/58700
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-12 01:42:12 +00:00
recipe-roller
ba1c7901a7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/cd27f01b1a49e4b02bad0640b6f4bd50930bcf74 Revert "git_cache: Remove locks" (hinoka@chromium.org)
recipe_engine:
  https://crrev.com/16a83eb5fd3d855a2bd41974fe7268d42fef3866 Update source_manifest (hinoka@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id3e4cf3249d613d7a310e38a3f6eb276627a9ce5
Reviewed-on: https://skia-review.googlesource.com/58502
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-11 20:24:39 +00:00
Brian Osman
019f91e123 Remove old ANGLE perf blacklists
I'm hoping that recent fixes to timing logic will prevent these problems.

Bug: skia:6534
Change-Id: Ia735e91887164c7a4882d5d3dd67df8c6115bfe9
Reviewed-on: https://skia-review.googlesource.com/54660
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-10-11 15:52:07 +00:00
Ben Wagner
a317a99807 Switch most Win Vulkan jobs to Clang.
Update examples in recipes.

Change-Id: I096f259e8daa46af8626158a820fe226e99cd159
Reviewed-on: https://skia-review.googlesource.com/58200
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-11 15:00:10 +00:00
recipe-roller
dd732d4810 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/08049e2db2ee6919df9a0bd4e9b18b0acdc378e7 Revert "git_cache: Remove locks" (vadimsh@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d1bab78f38b3feb8e3cd095453ab38502bae3e5
Reviewed-on: https://skia-review.googlesource.com/58141
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-11 00:52:59 +00:00
recipe-roller
e121789523 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/77b7687e4837223f820e1e98c369d36696f3f2b3 gclient conditionals are supposed to allow '!=', but don't currently. (dpranke@chromium.org)
  https://crrev.com/633a9830a9fce875d277b248c6e6fb14d72e8183 [gsutil.vpython] Update packages. (dnj@chromium.org)
  https://crrev.com/8db10a6fb1d4b86909b8cb32e3b53e35624c8979 gclient: Stop printing newline in front of "________ running hook" (thakis@chromium.org)
  https://crrev.com/87677e9830fec827c48d57d5dc764e0320282585 Make download_from_google_storage.py print nothing in the happy case where it needs to do nothing. (thakis@chromium.org)
  https://crrev.com/f6929a122f3be7d923228c0560db261f9bd8f87b [git-cl-try] handle -m luci.foo.bar (nodir@google.com)
  https://crrev.com/6bba5a9b4a01ba9e27b856108ff62f880a60fca3 Restore (unused) "verbose" paramter in download_from_google_storage.py (thakis@chromium.org)
  https://crrev.com/e83d02446d9e81ad3922f2f974326e766c0d84c5 Update roll_dep_svn for new DEPS syntax (phajdan.jr@chromium.org)
  https://crrev.com/9a81700f4ef503118fc570d378df80561ac6cd7e [cipd] Bump client version. (dnj@chromium.org)
  https://crrev.com/94652a37677488738626b96ff504fc07afbbaa87 Add CIPD manifest PRESUBMIT. (dnj@chromium.org)
  https://crrev.com/6fd24843867f7120b3e5083f820abcb597bef9d4 Allow cipd to interpret UNAME aarch64 as arm64 architecture (whesse@google.com)
  https://crrev.com/d4b5b1e68920294c40dc13efb73cf7cafdd3eb36 Attempt to set VCToolsInstallDir in SetEnv script. (thakis@chromium.org)
  https://crrev.com/27db3f2c01f86cc079b513e19e63a5527e820ba2 Add --issue option to 'git cl try-results' (szager@chromium.org)
  https://crrev.com/c3eb3fa33551c957d0179472c908864da016d95a git_cache: Remove locks (hinoka@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3aedeb0e5bc208fa35c6fea692809b0e93669fda
Reviewed-on: https://skia-review.googlesource.com/58121
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-10-11 00:31:39 +00:00
Kevin Lubick
e0240455a8 Add Linux GPU Coverage bot
Adds it for Vulkan and non-Vulkan

Bug: skia:7080
NOTRY=true
Change-Id: I5c4b30b91b96ad6ce9694c42550c4e909de4ba41
Reviewed-on: https://skia-review.googlesource.com/57560
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-10-10 15:15:22 +00:00
Ben Wagner
1c35e571c3 Revert "Revert "Fix a couple float-cast-overflow in SkScan*.""
This reverts commit b6abb9b4e0.

Reason for revert: It doesn't make sense that this CL would affect the tests implicated in the perf regression in skia:7143, and the revert had no effect on the perf of those tests. Seems like the perf alert was either noise or due to a different CL.

Original change's description:
> Revert "Fix a couple float-cast-overflow in SkScan*."
> 
> This reverts commit 3cd0bef0fd.
> 
> Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143
> 
> Original change's description:
> > Fix a couple float-cast-overflow in SkScan*.
> > 
> > Bug: skia:5060
> > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4
> > Reviewed-on: https://skia-review.googlesource.com/47422
> > Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=benjaminwagner@google.com,reed@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: skia:7143
> Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae
> Reviewed-on: https://skia-review.googlesource.com/57240
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,reed@google.com

Change-Id: I29ac47d6665e2e52ee2a6500488dc407c8d2af1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7143
Reviewed-on: https://skia-review.googlesource.com/57440
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-09 22:59:06 +00:00
Ben Wagner
63fd760a37 Remove trailing whitespace.
Also adds a presubmit to prevent adding trailing whitespace to source
code in the future.

Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6
Reviewed-on: https://skia-review.googlesource.com/57380
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-10-09 21:20:34 +00:00
Brian Salomon
7f56d3d2d8 Revert "Revert "Disable GL buffer mapping on TSAN/Mac.""
This reverts commit 4e7cdd5a00.

Bug: skia:7058
Change-Id: I3b92c35835cf7a8c04e9218194bf293b790413e0
Reviewed-on: https://skia-review.googlesource.com/57222
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-10-09 20:24:04 +00:00
Kevin Lubick
c795a4c886 Add Linux CPU Coverage Bot
This simply uploads the results of an LLVM coverage to GCS
for later ingestion/display.

Bug: skia:7080
Change-Id: I7dcfa2307a239734a614990aca899ea37129126b
Reviewed-on: https://skia-review.googlesource.com/53880
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-09 19:58:34 +00:00
Ben Wagner
7cf2fd6ff6 Cleanup jobs.
NUC6i7KYK with GTX960 is an experimental eGPU setup that will be
replaced with the NUC7i5BNK.

IntelHD4600 has been replaced with IntelHD4400.

Move remainder of *AbandonGpuContext jobs to QuadroP400.

No-Try: true
Change-Id: Ic81392ec162cb88500c9da7609471dbdc4a64f84
Reviewed-on: https://skia-review.googlesource.com/57320
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-09 19:15:05 +00:00
Ben Wagner
b6abb9b4e0 Revert "Fix a couple float-cast-overflow in SkScan*."
This reverts commit 3cd0bef0fd.

Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143

Original change's description:
> Fix a couple float-cast-overflow in SkScan*.
> 
> Bug: skia:5060
> Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4
> Reviewed-on: https://skia-review.googlesource.com/47422
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=benjaminwagner@google.com,reed@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:7143
Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae
Reviewed-on: https://skia-review.googlesource.com/57240
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-10-09 16:48:04 +00:00
Brian Salomon
4e7cdd5a00 Revert "Disable GL buffer mapping on TSAN/Mac."
This reverts commit c203e65265.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable GL buffer mapping on TSAN/Mac.
> 
> Also reverts 65e7063796 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer.
> 
> Bug: skia:7058
> Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341
> Reviewed-on: https://skia-review.googlesource.com/50100
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=mtklein@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: Icf0cf40ba4d6e7081971eee2eea0a41033790df7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7058
Reviewed-on: https://skia-review.googlesource.com/57220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-10-09 15:18:45 +00:00
Ben Wagner
c6b2e6b061 Omit flaky test.
Bug: skia:6857
No-Try: true
Change-Id: I32a2a867ee52f497b39b799053020e1b875dd1a6
Reviewed-on: https://skia-review.googlesource.com/57080
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-10-09 14:54:33 +00:00
Brian Salomon
c203e65265 Disable GL buffer mapping on TSAN/Mac.
Also reverts 65e7063796 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer.

Bug: skia:7058
Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341
Reviewed-on: https://skia-review.googlesource.com/50100
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-10-09 13:33:54 +00:00
Ben Wagner
92d3bc9c9f Fix merge conflict.
This resolves the conflict between
https://skia-review.googlesource.com/57120 and
https://skia-review.googlesource.com/57081.

No-Try: true
Change-Id: I45f47eb13dd7151b37b3b37f821232a02b9a43ff
Reviewed-on: https://skia-review.googlesource.com/57082
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-08 19:57:02 +00:00
Ben Wagner
2d861e9514 Add Win Clang Vulkan jobs.
No-Try: true
Change-Id: I0b9f07e9057892443934da399f60762005495bde
Reviewed-on: https://skia-review.googlesource.com/57081
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-08 19:09:21 +00:00
UpdateSKPs
c9cb9e8147 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I0e9f38de166cfb7823a943f28e525f0bb008f1e7
Reviewed-on: https://skia-review.googlesource.com/57120
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-10-08 07:54:56 +00:00
Ben Wagner
eeadcc1b5c Add Win Clang Vulkan builds.
Fix Clang compiler warning.

Change-Id: Ic6f5b161058d1ed2df45e12b72dbff3b486ec986
Reviewed-on: https://skia-review.googlesource.com/56740
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-07 18:27:40 +00:00
Ben Wagner
3cd0bef0fd Fix a couple float-cast-overflow in SkScan*.
Bug: skia:5060
Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4
Reviewed-on: https://skia-review.googlesource.com/47422
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-10-07 18:26:51 +00:00
Ben Wagner
9cb2cae635 Remove Perf SurfacePro2017 jobs.
Perf numbers track closely with IntelIris540, although Perf numbers from
SurfacePro2017 are more noisy.

No-Try: true
Change-Id: I9dfefd6daf69644a1c0850453334876269cd7942
Reviewed-on: https://skia-review.googlesource.com/56540
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-06 19:25:47 +00:00
recipe-roller
b3255260ef Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d325eb349608f54d84a74ce124331a3fa170e5dc gclient: make predefined variables native (phajdan.jr@chromium.org)
  https://crrev.com/3ba2a7cf3801c62ef583761493c5e4cd4f717c27 gclient config: add support for custom vars (phajdan.jr@chromium.org)
  https://crrev.com/a58f1dacf1574708c916ece68b7edf3a27251010 [vpython] Roll CIPD version. (dnj@chromium.org)
  https://crrev.com/b5807979e8a9515f57cece1df7b19808b83d24ab Use HTTPS links in CheckAuthorizedAuthor (xiaoyin.l@outlook.com)
recipe_engine:
  https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce Update source_manifest to e8149bf in luci-go (hinoka@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8f593e6f56863d34e11cff62643300dd336aa57
Reviewed-on: https://skia-review.googlesource.com/56300
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-06 00:46:34 +00:00
Robert Phillips
435db420bd Disable PinnedImageTest on Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Release-ANGLE bot
Bug: skia:7096
Change-Id: I536d81110c842da662b32a94a352a34a6854e3a9
Reviewed-on: https://skia-review.googlesource.com/55140
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-10-04 13:59:12 +00:00
recipe-roller
cf527d978d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/c634ba57059c1ff965ccbfa3277bf025fb1ae891 Allow gclient solution URLs to be |None|. (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I85619aa3a55202033ae02492d8d69a5b5810209c
Reviewed-on: https://skia-review.googlesource.com/54880
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-04 01:44:42 +00:00
recipe-roller
93b324dd31 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/3be96a83b875d29badb71a914b1342cb38935d99 roll-dep: Add comments indicating that --no-log needs to keep working (borenet@google.com)
  https://crrev.com/7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac Remove rietveld git cherry-pick-upload command (agable@chromium.org)
  https://crrev.com/e632e54438ad5d2b45ee9206c7fcf8babea0762c Remove rietveld commit queue command line client (agable@chromium.org)
  https://crrev.com/355b70412f8b725dcf6771967387cf4ba999c98b Update fetch config with new Syzygy location. (siggi@chromium.org)
  https://crrev.com/ecf53fecd6e42feeb2fad05f73240dbe6833317b gclient flatten: emit conditions for hooks (phajdan.jr@chromium.org)
  https://crrev.com/e0214743cb0150774ed9d766cd2031ffc38c0335 gclient: add support for native boolean variables (phajdan.jr@chromium.org)
  https://crrev.com/78ce24e38936b4423a02a7df02db5afe8bd7c452 gclient flatten: properly quote conditionals (phajdan.jr@chromium.org)
  https://crrev.com/a718c3ebd3caa2f336ab371fe8c0c8a7f0adfbca Simplify git-cl-diff for Gerrit (agable@chromium.org)
recipe_engine:
  https://crrev.com/4d872b88fb06006ec917c6d2a3324e26c0124319 Add 'service_account' recipe module. (vadimsh@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8f7587e38df45ba6d1e6d988f5ac8735419689f0
Reviewed-on: https://skia-review.googlesource.com/54860
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-04 01:12:32 +00:00
Ben Wagner
9fb285e322 Switch many jobs to Clang.
No-Try: true
Change-Id: Ie255d46ff50d13d25d045791c1c3066f06ab9243
Reviewed-on: https://skia-review.googlesource.com/53601
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-10-03 16:17:19 +00:00
Ben Wagner
5655ba4398 Add Linux nVidia Vulkan jobs.
Change-Id: Ib323136e4c6f660923433a2508e1e0965712d698
Reviewed-on: https://skia-review.googlesource.com/53460
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-10-02 15:08:28 +00:00
UpdateSKPs
3c83668862 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ibb9da81bde1bcab7ad463f64ed64f729d9fc1385
Reviewed-on: https://skia-review.googlesource.com/53740
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-10-01 07:40:56 +00:00
Kevin Lubick
bede88e727 Add coverage related binaries to clang_linux asset
Add --depth 1 to the git clone commands to speed up the creation,
since we don't need all of the history ever to build.

Bug: skia:7080
Change-Id: Idcde5657e2097c2dbc259ab29b24d596b5623364
Reviewed-on: https://skia-review.googlesource.com/53481
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-09-29 20:20:24 +00:00
recipe-roller
9729dcbcf1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/35c5b9ad1beb2550831fa1d39f5f12e354edd501 [depot_tools] Add "ensure_bootstrap" script. (dnj@chromium.org)
  https://crrev.com/0a1f3f6ab34fd2d14cab4dd7fdb86c9a5b77ffe4 Remove defunct Rietveld end-to-end tests (agable@chromium.org)
  https://crrev.com/f3b4f060e2a578420706275e858dc6a612dbaf8f Fix autoninja to allow compiling one source file (brucedawson@chromium.org)
  https://crrev.com/210ed0ebfe37fb563012778dcb04cb5855c5fd51 Expose new gclient.sync() arg in gclient.checkout(). (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaa9c4e62b3c6aa06865db3ff83343ce2d982c0b0
Reviewed-on: https://skia-review.googlesource.com/53523
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-09-29 19:03:26 +00:00
Ben Wagner
b268d23281 Add AVX512 jobs.
Bug: skia:6326
No-Try: true
Change-Id: Iaffc0cbbe14237e7ac2d83cc9da94a4c7bea3154
Reviewed-on: https://skia-review.googlesource.com/52764
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-29 14:19:34 +00:00
Ben Wagner
135db05fa1 Remove duplicate config for MacMini.
No-Try: true
Change-Id: I449c0fd435b233e9c9538c17295ef18348380658
Reviewed-on: https://skia-review.googlesource.com/53120
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-29 13:54:04 +00:00
recipe-roller
4e66d35fc3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a16ccaf11a5a0b145b166161b80d99eaef294f4b bot_update: use patch repo instead of project if it is mapped (agable@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5afc28d536d06546b1015d453dd49e33094622b6
Reviewed-on: https://skia-review.googlesource.com/52768
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-09-28 19:34:08 +00:00
Eric Boren
097900648b Fix path separators on Windows in zip_utils
Bug: skia:7077
Change-Id: I5119a7d6c7cd2317129d40ae3e0997dfc9978c25
Reviewed-on: https://skia-review.googlesource.com/52664
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-09-28 16:58:57 +00:00
recipe-roller
e85ab6924d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d86c80371561676c85680e80962733087607e1a3 Fix CheckPatchFormatted() when using inherit-review-settings-ok (agrieve@chromium.org)
  https://crrev.com/4145082558e22927a2dc85c8459533b106e1051f Roll "vpython". (dnj@chromium.org)
  https://crrev.com/2da7cbd767ab59dbe49171ad99bbae5b4e675e42 Add ability to pass extra flags to gclient.sync(). (mmoss@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib793caa190fe2ef095c2dee1d559ca486b8bd22c
Reviewed-on: https://skia-review.googlesource.com/52780
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-09-28 15:43:57 +00:00
Leon Scroggins III
e56774602c Fix truncated webp images
Bug: b/65290323

If a webp file is truncated such that no rows can be decoded,
WebPIDecGetRGB does not initialize its "last_y" parameter. We use
rowsDecoded (passed as last_y) to determine which remaining rows to
fill.

Check the return value of WebPIDecGetRGB. If it fails (returns null),
or rowsDecoded is <= 0 (matching Chromium's check), return
kInvalidInput, since there is nothing to draw.

Note that this is a change in behavior for Android. Previously we
would decode an empty webp to just a transparent/black rectangle,
whereas now we simply fail. I think this is a change for the better.

Add a test which truncates a file to have 0 rows available and attempts
to decode it. msan verifies that we no longer depend on the
uninitialized value.

Stop attempting to test decoding subsets from an incomplete webp (in
CodecTest.cpp). Unless we have decoded the portion covered by the
subset, this will fail.

Remove test images inc0.webp (from both dm/ and colorspace/) and
inc1.webp. These just decode to transparent rectangles. Replace them
with inc2.webp and inc3.webp, which decode part of the image and then
have to fill with transparent.

Change-Id: I64d40be91c574b45963f9a43d8dd8f4929dd2939
Reviewed-on: https://skia-review.googlesource.com/50303
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: James Zern <jzern@google.com>
2017-09-27 20:51:02 +00:00