Commit Graph

459 Commits

Author SHA1 Message Date
commit-bot@chromium.org
fd1fdfc3a5 rebaseline GM changes resulting from fast GPU blur algorithm
BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/150493005

git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 18:17:06 +00:00
commit-bot@chromium.org
fd191a135f rebaseline imagefiltersgraph_gpu GMs on Nexus10
BUG=skia:2106
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150113003

git-svn-id: http://skia.googlecode.com/svn/trunk@13241 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 17:59:22 +00:00
commit-bot@chromium.org
cf34bc0634 patch from issue 119343003
compile on 10.6, exclude failing gms

Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over.

NOTRY=true
R=bsalomon@google.com, epoger@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/148883005

git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 15:34:43 +00:00
senorblanco@chromium.org
09dd1abc54 Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure).
TBR=epoger
BUG=skia:

Review URL: https://codereview.chromium.org/149073008

git-svn-id: http://skia.googlecode.com/svn/trunk@13232 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 22:28:26 +00:00
senorblanco@chromium.org
200d75c074 New baselines for displacement GM.
This had a new test case added in r12773.

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/143263020

git-svn-id: http://skia.googlecode.com/svn/trunk@13231 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 21:41:39 +00:00
senorblanco@chromium.org
7824768e5e New baselines for GM tests affected by r13221.
The following tests were affected:

imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
dropshadowimagefilter
offsetimagefilter
spritebitmap
tileimagefilter

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148283008

git-svn-id: http://skia.googlecode.com/svn/trunk@13230 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 20:00:54 +00:00
commit-bot@chromium.org
6df2f2b539 Rebaslines for https://codereview.chromium.org/23835006/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/137833005

git-svn-id: http://skia.googlecode.com/svn/trunk@13229 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 11:48:31 +00:00
senorblanco@chromium.org
78cf11980d Give correct bounds to SkCanvas's AutoDrawLooper use for filter draws.
In conjuction with https://codereview.chromium.org/137423005/, this allows the canvas to tighten the bounds passed to saveLayer() only the affected region.

R=reed@google.com
BUG=100703

Review URL: https://codereview.chromium.org/141433017

git-svn-id: http://skia.googlecode.com/svn/trunk@13221 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 19:22:35 +00:00
commit-bot@chromium.org
a96176dc03 ARM Skia NEON patches - 20 - New improved BitmapProcState code
BitmapProcState: new factorised code

This one basically factorises the clamp and repeat transformations with
some performance improvements. It has the benefit of being faster, much
easier to maintain (nearly three times less code for more work
done :-)), and more complete (all persp transformations weren't optimised
in the previous version).

It also introduces the use of can_truncate_to_fixed_for_decal where
useful.

The effect on benchmarks ranges from a 5% penalty to a 25% gain on a
Cortex-A9 and from a 5% penalty to a 100% gain on a Cortex-A15.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/23835006

git-svn-id: http://skia.googlecode.com/svn/trunk@13218 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 15:18:54 +00:00
senorblanco@chromium.org
619ba7434a Trying once again to rebaseline IntelRhb bots.
This seems to be putting the hashes back to what they were at r13191, so if this doesn't work I'm going to call flake and suppress the failures.

TBR=epoger@google.com

Review URL: https://codereview.chromium.org/148573003

git-svn-id: http://skia.googlecode.com/svn/trunk@13205 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 20:47:11 +00:00
commit-bot@chromium.org
d15d469a6e Revert "Revert of nvpr baselines (https://codereview.chromium.org/132333008/)"
BUG=skia:2042

TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131513012

git-svn-id: http://skia.googlecode.com/svn/trunk@13202 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 19:45:02 +00:00
senorblanco@chromium.org
f532e01e4c Rebaseline imageblur on IntelRhb Debug.
TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148263004

git-svn-id: http://skia.googlecode.com/svn/trunk@13201 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:15:49 +00:00
commit-bot@chromium.org
be39f37e11 Revert of nvpr baselines (https://codereview.chromium.org/132333008/)
Reason for revert:
broke the build

Original issue's description:
> nvpr baselines
> 
> BUG=skia:2042
> 
> Committed: https://code.google.com/p/skia/source/detail?r=13195

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2042

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148013003

git-svn-id: http://skia.googlecode.com/svn/trunk@13198 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:05:21 +00:00
senorblanco@chromium.org
dd13af8449 New baselines for Win7 DirectWrite (shader2 and bezier_conic) and Intel Rhb (imagefiltersbase and imageblur). All failures are pixel intensity mismatch <= 3.
BUG=skia:2085,skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/138623007

git-svn-id: http://skia.googlecode.com/svn/trunk@13197 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:51:12 +00:00
bsalomon@google.com
0655389978 nvpr baselines
BUG=skia:2042

Review URL: https://codereview.chromium.org/132333008

git-svn-id: http://skia.googlecode.com/svn/trunk@13195 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:04:00 +00:00
senorblanco@chromium.org
b3bf362ce2 Rebaseline some GPU and ANGLE results which started failing on Win7.
BUG=skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/135593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13193 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 16:22:36 +00:00
senorblanco@chromium.org
83c39db913 Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.
New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.

R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:

Review URL: https://codereview.chromium.org/141033008

git-svn-id: http://skia.googlecode.com/svn/trunk@13191 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 15:05:39 +00:00
bsalomon@google.com
2865839f45 rebaselines from NVPR enable and nexus4 blur radius
BUG=skia:2042

Review URL: https://codereview.chromium.org/146593003

git-svn-id: http://skia.googlecode.com/svn/trunk@13186 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 17:51:22 +00:00
commit-bot@chromium.org
d8ed85101e Turn NVPR on by default (but off in tools).
BUG=skia:2042

Committed: http://code.google.com/p/skia/source/detail?r=13164

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:49:44 +00:00
halcanary@google.com
68c74884d0 Revert "Turn NVPR on by default (but off in tools)."
This reverts commit 83d81c96de.

Broke Windows build.  Autorevert didn't work.

TBR=bsalomon@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042

Review URL: https://codereview.chromium.org/146863003

git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 16:04:09 +00:00
senorblanco@chromium.org
0903c3473c Add new baselines for imagefiltersscaled GM.
TBR=borenet

Review URL: https://codereview.chromium.org/145993005

git-svn-id: http://skia.googlecode.com/svn/trunk@13166 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:02:11 +00:00
commit-bot@chromium.org
83d81c96de Turn NVPR on by default (but off in tools).
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:13 +00:00
bungeman@google.com
1b532f1231 Rebaselines for r13156.
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.


git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:34:38 +00:00
bungeman@google.com
3bfd12d881 Rebaselines for r13156.
The thing blurred in imageblur is actually text.
Who knew?


git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:25:19 +00:00
skia.committer@gmail.com
8f7ed2cfd8 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:26:04 +00:00
bungeman@google.com
5aa1116177 Rebaselines for r13156.
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.


git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:24:41 +00:00
bungeman@google.com
5a246719a5 Rebaseline for r13156.
git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:19:16 +00:00
commit-bot@chromium.org
4bd5177e4f ignore some verylargebitmap errors
BUG=skia:1978
NOTREECHECK=True
NOTRY=True
R=senorblanco@google.com
TBR=senorblanco

Author: epoger@google.com

Review URL: https://codereview.chromium.org/140643003

git-svn-id: http://skia.googlecode.com/svn/trunk@13124 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-17 20:16:05 +00:00
senorblanco@chromium.org
5fdaffdbcb Add new baselines for bitmapsource, dropshadowimagefilter, pictureimagefilter and resizeimagefilter GMs.
TBR=djsollen

Review URL: https://codereview.chromium.org/139513004

git-svn-id: http://skia.googlecode.com/svn/trunk@13096 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:28:53 +00:00
robertphillips@google.com
40299fe511 Rebaseline complexclip_aa_layer image for Nexus 4
https://codereview.chromium.org/138273008/



git-svn-id: http://skia.googlecode.com/svn/trunk@13085 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 14:52:03 +00:00
commit-bot@chromium.org
78f6ddc1a0 rebaseline blur related outputs
rebaseline for the differences introduced by https://codereview.chromium.org/105893003/

BUG=
R=senorblanco@chromium.org, reed@google.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/136483002

git-svn-id: http://skia.googlecode.com/svn/trunk@13080 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 02:37:57 +00:00
bsalomon@google.com
d0c53f1d51 Rebaseline bleed and simpleblurroundrect due to GPU blur changes. Also, misc blur GMs on N4.
BUG=skia:199s8

Review URL: https://codereview.chromium.org/138593002

git-svn-id: http://skia.googlecode.com/svn/trunk@13067 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:20:49 +00:00
commit-bot@chromium.org
df79acdbab Revert of Rebaselining bleed GMs due to recent GPU blur changes. (https://codereview.chromium.org/138353002/)
Reason for revert:
the bleed_gpu GM is failing on all the test builders.

Original issue's description:
> Rebaselining bleed GMs due to recent GPU blur changes.
>
> BUG=skia:1998
>
> Committed: https://code.google.com/p/skia/source/detail?r=13063

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1998

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/138133003

git-svn-id: http://skia.googlecode.com/svn/trunk@13064 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 16:21:31 +00:00
bsalomon@google.com
3f88f4d5ad Rebaselining bleed GMs due to recent GPU blur changes.
BUG=skia:1998

Review URL: https://codereview.chromium.org/138353002

git-svn-id: http://skia.googlecode.com/svn/trunk@13063 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 15:28:24 +00:00
commit-bot@chromium.org
3e62ebf93b make ignored-tests.txt specify full test name, not partial name
BUG=skia:2022
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/136883006

git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
bsalomon@google.com
3c0ccff35e Misc rebaselines related to recent GPU blur changes.
Review URL: https://codereview.chromium.org/130523003

git-svn-id: http://skia.googlecode.com/svn/trunk@13053 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 19:06:10 +00:00
bsalomon@google.com
cd9175eddb remove _gpu suffix from tests in ignored-tests.txt that are changed on all gpu configs (msaa, ...).
Review URL: https://codereview.chromium.org/136713005

git-svn-id: http://skia.googlecode.com/svn/trunk@13049 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:26:14 +00:00
robertphillips@google.com
a3961374fe Rebaseline NVPR roundrects images
https://codereview.chromium.org/136753004/



git-svn-id: http://skia.googlecode.com/svn/trunk@13048 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 17:15:33 +00:00
commit-bot@chromium.org
439ff1b9ca Use correct matrix to adjust blur radius for gpu
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/134973002

git-svn-id: http://skia.googlecode.com/svn/trunk@13047 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 16:39:39 +00:00
bsalomon@google.com
4db7a31678 Remove rects GM from ignored-tests.txt and rebaseline
BUG=skia:1882

Review URL: https://codereview.chromium.org/136803002

git-svn-id: http://skia.googlecode.com/svn/trunk@13045 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:54 +00:00
commit-bot@chromium.org
a7d89c83a4 Handle drawBitmapRect src_rect->dst_rect mapping as a local matrix rather than view matrix when there is a mask filter.
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131323004

git-svn-id: http://skia.googlecode.com/svn/trunk@13041 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:47:00 +00:00
commit-bot@chromium.org
c45ece5f7f NEON fast path for box blur
Calculate 8 channels in parallel by using 16-bits to store each channel. Due to the limitation of VQRDMULH, (int16 * int16 * 2 + 0x8000) >> 16, the fast path can only support kernelSize < 128.
8 significant bits are kept at least in each stage, the final error should less-equal than 1.

Pre-fetching memory for X-direction read. In fact pre-fetching memory doesn't help much for Y direction read, since it is a waste to load a cache line for only read 8 bytes.(I left it there to keep the symmetry. pre-fetch is cheap :) )

bench data on Nexus 10
before:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  25081.48
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  25038.04
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  25209.04
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  24928.01
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  17160.98
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  17924.11
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =  14609.19
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =  14625.91

after:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  14848.42
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  16037.29
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  14819.55
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  14563.69
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  11905.34
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  11883.85
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =   9576.51
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =   9793.84

BUG=
R=senorblanco@chromium.org, mtklein@google.com, reed@google.com, kevin.petit@arm.com, kevin.petit.arm@gmail.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/105893003

git-svn-id: http://skia.googlecode.com/svn/trunk@13036 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 08:16:45 +00:00
robertphillips@google.com
7095607705 Suppressing imagefiltersbase_gpu on RHB device
https://codereview.chromium.org/134093002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13018 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 15:28:19 +00:00
robertphillips@google.com
6791138dc0 Suppress imagefiltersgraph_msaa4 failure on Nexus10
https://codereview.chromium.org/133643003/



git-svn-id: http://skia.googlecode.com/svn/trunk@13011 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 13:50:23 +00:00
borenet@google.com
6f0f5b4aad Remove references to Skia's SVN repository
BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/132423002

git-svn-id: http://skia.googlecode.com/svn/trunk@13006 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:41:39 +00:00
reed@google.com
2e0f1ee593 remove bad gm expected images
BUG=skia:1986
R=epoger@google.com

Review URL: https://codereview.chromium.org/132023005

git-svn-id: http://skia.googlecode.com/svn/trunk@13004 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:05:59 +00:00
bsalomon@google.com
2b199e6d4d Mark imagefiltersgraph, IntelRhb, msaa4 config as ignore failure due to garbage on bottom line.
BUG=skia:2005

Review URL: https://codereview.chromium.org/132303002

git-svn-id: http://skia.googlecode.com/svn/trunk@12998 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:59:55 +00:00
robertphillips@google.com
6235b85b0b Update baselines for NVPR bot
git-svn-id: http://skia.googlecode.com/svn/trunk@12989 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 15:57:25 +00:00
senorblanco@chromium.org
efd0ff108e More rebaselines after r12895 for the mega-stragglers.
TBR=caryclark
BUG=1985

Review URL: https://codereview.chromium.org/126453007

git-svn-id: http://skia.googlecode.com/svn/trunk@12976 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 22:21:07 +00:00
bsalomon@google.com
a52209f162 one more filterbitmap ASAN ignore
BUG=skia:1984

Review URL: https://codereview.chromium.org/126813004

git-svn-id: http://skia.googlecode.com/svn/trunk@12960 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:46:19 +00:00