Commit Graph

53494 Commits

Author SHA1 Message Date
John Stiles
cd067feb1c Move the default inline threshold to SkSLDefines.h.
Change-Id: Idf3f95ce3d0467c8273c627227c2e6bb16d04614
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364837
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-03 14:46:09 +00:00
Julia Lavrova
045f87d27f Reasonable results for not styled text in findAllBlocks.
Bug: skia:11256
Change-Id: Ice964f722c3c9f15cf3feab3c74b1c7235bbea7f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364636
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-02-03 14:40:09 +00:00
Greg Daniel
87d784f1f9 Add new GrVkBuffer class to merge all types in one.
The goal here is remove the need for all the specialized vulkan buffer
subclasses and to not have the new class use GrVkResources for tracking
lifetime on command buffers.

This CL just makes the new class and it is not actually used by anything
yet.

Bug: skia:11226
Change-Id: I5f8d8d112af773ba1e8da17e07e75f6f4100e927
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364617
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2021-02-03 14:12:59 +00:00
Greg Daniel
aa14b751ec Update GrDrawVerticesOp to not read gpu vertex buffer.
Change-Id: Idb2f6a3131824ffe29275fe669b5c1688867d448
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364620
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-03 14:00:59 +00:00
skia-autoroll
798ae0d12a Roll Chromium from 2329a341cbd8 to 4e5b4f3a094d (520 revisions)
2329a341cb..4e5b4f3a09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: robertphillips@google.com
Change-Id: I11a97aa75e0236dcf93d20d2e3ebfa8c9f853092
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365158
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-03 09:28:19 +00:00
skia-autoroll
b7ba9713da Roll ANGLE from 7e81056a5469 to 6cc845bb0a60 (6 revisions)
7e81056a54..6cc845bb0a

2021-02-03 b.schade@samsung.com Vulkan: Add support for EXT_blend_func_extended
2021-02-02 jmadill@chromium.org testing: Add dEQP test merge script.
2021-02-02 amy.liu@arm.com Vulkan:Fix wrong outputCount of emulated RGB copies.
2021-02-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df5dee645ab5 to 51045556acd0 (3 revisions)
2021-02-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 532fea9e2fd2 to 3535b64d3f52 (466 revisions)
2021-02-02 cnorthrop@google.com Tests: Add Manhattan 3.1 trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: robertphillips@google.com
Test: Test: angle_end2end_tests --gtest_filter=EXTBlendFuncExtendedDrawTest*Test: Test: angle_perftests --gtest_filter="*manhattan_31*"
Change-Id: Ie805677b0cb5c9aa3618c0c266176e20bce5653e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365156
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-03 07:28:19 +00:00
skia-autoroll
828571455b Roll Dawn from d11f4c3d0577 to fd5fd05db039 (6 revisions)
https://dawn.googlesource.com/dawn.git/+log/d11f4c3d0577..fd5fd05db039

2021-02-02 rharrison@chromium.org Enable EntryPointTests
2021-02-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 222e09735e02 to c694d43c75f4 (11 revisions)
2021-02-02 yunchao.he@intel.com Implement 3D textures and views creation on D3D12 backend
2021-02-02 capn@google.com GN: add a default build target
2021-02-02 bclayton@google.com Simplify tint API usage
2021-02-02 cwallez@chromium.org Revert "Suppress RenderPipelineValidationTest.VertexAttribCorrectEntryPoint"

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 222e09735e02 to c694d43c75f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: cwallez@google.com
Change-Id: Ie48d732a1c0c7ae169c53bd0017a6338d798f3c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365157
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-03 05:53:19 +00:00
John Stiles
5a956ce54b Add more dm tests for the comma operator.
Change-Id: I37a95fd95c23a91c3510f922bab0569093e612a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364604
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-02-03 01:28:48 +00:00
Mike Reed
58a7d8520b Opt into new matrix imagefilter api
Bug: skia:7650
Change-Id: I6baac23026542a4fa7da5d2c3aadc936b1a8ae61
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364638
Reviewed-by: Mike Reed <reed@google.com>
2021-02-03 01:18:45 +00:00
Mike Klein
d1131b6aa0 fix FM svg harness
Without this we'd assert on empty container size.

Change-Id: I697d607af40ac6e62039be33aedb8ff1732d41b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364839
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-02-03 01:08:28 +00:00
John Stiles
f57207bfaf Remove SkSL ABORT() macro.
Existing call sites have been converted to the SK_ABORT macro.
The sksl_abort() function is no longer referenced and has been removed.

Change-Id: Idf94ce2523e37b62ce87b60afc5d121b9ad29627
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364858
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-03 00:34:28 +00:00
Edward Lesmes
5cf5b46e2b Move metadata in OWNERS files to DIR_METADATA files
Bug: 1113033
Change-Id: I8af15a165e85c149696dd87c448811324c36601b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364736
Commit-Queue: Edward Lemur <ehmaldonado@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-02-02 23:41:54 +00:00
John Stiles
eada7bc4e9 Replace SK_DEBUG-wrapped ABORT calls with SkDEBUGFAILF.
Change-Id: I4b11aaa8299a4aa2753097c26936e0176189f1db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364641
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-02 22:47:04 +00:00
John Stiles
1dd2b4b5e0 Replace SkSL-specific macros with Skia equivalents.
ABORT will be tackled in a followup CL since, unlike the others, it is
heavily used.

Change-Id: I96c092b6c07a3311cf8467b960b8f5e32c2074cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364640
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-02 22:46:53 +00:00
Chris Dalton
b8ed2bce50 Make simplifyStroke optional on GrStyledShape
For now we simplify every stroke at the beginning of drawShape*, but in
the future we will give the tessellator a chance to claim stroked shapes
before simplifying the stroke.

Bug: chromium:1172543
Change-Id: Ie90c20a1d342661b9006b16ab1fdad3ebe290ba3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362798
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-02-02 22:44:14 +00:00
Tyler Denniston
8ca4626a4b [svg] Implement <image> element
https://www.w3.org/TR/SVG11/struct.html#ImageElement

Supported reference types are data and non-local URIs. Resource loading
requires a ResourceProvider to have been set on the render context.

Not handled in this CL:
- preserveAspectRatio support
- SVG reference types (i.e. '<image xlink:href="file.svg" ...')

Bug: skia:10842
Change-Id: Ieec7569f60516b01fc847f4160d0733b1e3a1cf5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364576
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-02-02 22:36:05 +00:00
Mike Klein
027f7b35e7 move Mac FM bot
I don't really care what machine class it's running on right now, and
status.skia.org/capacity says these 10.14.6 bots are the least loaded
of any bot on the tree.

Change-Id: Ie49b2659e99d60e450235207bbbc018e565636b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364716
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-02-02 22:22:14 +00:00
skia-recreate-skps
f127e377d2 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I7876af5f8e3e613a4c153c0b5e2fd34720640d4c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364717
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2021-02-02 22:08:07 +00:00
Mike Klein
07fea19ca0 NEON libjpeg-turbo on iOS and Mac
Not sure why these are off... let's find out.

Cq-Include-Trybots: luci.skia.skia.primary:Build-Mac-Clang-arm64-Debug-iOS,Build-Mac-Clang-x64-Release-iOS,Build-Mac-Xcode11.4.1-arm64-Debug-iOS_Metal,Build-Mac-Xcode11.4.1-arm64-Release-iOS,Build-Mac-Clang-arm64-Release-iOS_Metal,Build-Mac-Clang-arm64-Debug,Build-Mac-Clang-arm64-Release
Change-Id: Ibeaa3707eca3df2cd41b91b06ed329568e5398f4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364498
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-02-02 22:07:54 +00:00
Ethan Nicholas
9ff7b8d675 Fixed DSLStatement imports
DSLStatement contained an unnecessary import of SkSLIRNode.h and
referenced SkSL::Expression without declaring it.

Change-Id: I88391276a1c3cd10430ee4c6c63f3e2093e338b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364603
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-02 21:23:54 +00:00
Ethan Nicholas
c3bb9e3bbd add Start/EndFragmentProcessor to DSLWriter
Change-Id: I6f9d414d55b3ba64c3f67f3a590f6b7b5642062a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364599
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-02-02 20:56:13 +00:00
Greg Daniel
dd520a3f7d Various vulkan buffer cleanups.
This is just a few miscellaneous buffer changes to make future changes
around switching buffer classes cleaner.

Bug: skia:11226
Change-Id: Icba3b9b5b357956d78f95398cdce9e8733080028
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364616
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-02-02 20:35:04 +00:00
Mike Klein
805eee00d9 don't td.FailStep() quite yet
Calling td.FailStep() as written here doesn't really do anything except
hide the more useful summary error, e.g. "484 runs of build/fm failed
after retries."  Maybe it'll become useful again if I add step nesting?

Change-Id: I23eb59afce8559f4b0e549f31873577939fc7ca7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364497
Reviewed-by: Mike Klein <mtklein@google.com>
2021-02-02 19:31:56 +00:00
Herb Derby
89acfe72ab add ATRACEs for text atlas and textures
Change-Id: I384f1da4775c6d09170996dd21689124efe2cc7c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/361358
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-02-02 19:12:23 +00:00
Brian Osman
28f702ca8f Disable SkSL node pooling on Adreno 530
This is an experiment to try and get better/different/earlier crashes on
two Android devices that appear to have driver memory corruption bugs.

Bug chromium:1147008, chromium:1164271

Change-Id: I163e045c4b0ec46e89891c24f3c10f7031e7e8db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364601
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-02-02 18:56:03 +00:00
Chris Dalton
a7f6e08976 Add conic support to GrStrokeTessellateShader
Bug: chromium:1172543
Bug: skia:10419
Change-Id: Ie14ab2a3933b96541ee0afa3149c23964ff09ea5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364001
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-02-02 18:45:04 +00:00
Mike Klein
3bf14aaf11 add MSAN/TSAN FM bots
Don't expect much out of TSAN given the process-based isolation,
but I'm curious to see how it goes.  MSAN should work sensibly.

Change-Id: If0b794805461b0ecd7092900f4412d73cd80d0d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364466
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2021-02-02 18:38:58 +00:00
Florin Malita
f3b1a751cb [skottie] Sphere layer effect
Implement CC Sphere.

No lighting support for now (matches AE's Light Intensity: 0,
Ambient: 100).

Change-Id: I7eb4d8f9c5dd4b4cb312321cefee0231a9901873
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362457
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
2021-02-02 18:36:23 +00:00
Brian Osman
5a7048c0fa Specifically identify Adreno 530 (vs other 5xx series)
Going to use this to enable some possible workarounds and investigatory
CLs for chromium crash bugs.

Bug: chromium:1147008, chromium:1164271
Change-Id: Ia7b23765d3ab14edf64d823b8a8adf1622b8ac62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364600
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-02-02 18:33:54 +00:00
Ethan Nicholas
ee9cb6aec3 Add shaderCompiler() to ProgramBuilders
This will be used by the DSL.

Change-Id: Iadc5d06fd463b08cf6edf954f03aaf8ffa1fa56b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364578
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-02-02 18:17:03 +00:00
Mike Reed
3d2291cd75 Reland "Remove unneeded flags for flutter"
This reverts commit 2bf7d6ff31.

Reason for revert: have updated flutter call-sites

Original change's description:
> Revert "Remove unneeded flags for flutter"
>
> This reverts commit 5c6c3be981.
>
> Reason for revert: something breaking in Flutter
>
> Original change's description:
> > Remove unneeded flags for flutter
> >
> > Change-Id: I0e5af51d56622918f1590ae05a0d88507213505c
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363797
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Mike Reed <reed@google.com>
>
> TBR=reed@google.com
>
> Change-Id: Ie4e50a1f5feb5798ad12cb82edc2d66bbaed4722
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364436
> Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com

# Not skipping CQ checks because this is a reland.

Change-Id: I44aa4f81b34acaff56249ff9392e9fb3acda5256
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364602
Reviewed-by: Mike Reed <reed@google.com>
2021-02-02 18:10:32 +00:00
Brian Osman
c81378624f Update all example particle data to new single-code-chunk format
Change-Id: Ic53dc7ecab1b44761fe06e6b528864d24cc5fa58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363940
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-02-02 18:07:53 +00:00
Robert Phillips
9c2ab4c467 Just skip corrupt JPEG image draws when rendering DDLs
Bug: skia:11243
Change-Id: Ia83b1a43c4e25d62a6f3170b8ddc7e4b5e543b52
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364577
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-02-02 17:06:22 +00:00
Mike Reed
c858554f38 Hide filter-quality from imagefilter::shader
Bug: skia:7650
Change-Id: Ia16f169efdb6be2ce381b9ab3b7f6fcecda26312
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363799
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-02-02 17:06:14 +00:00
Mike Klein
129bc16b56 fixup, fail on bots
td.FailStep() isn't enough to fail the bot,
so go back to a call to td.Fatal() when failures>0.

Change-Id: Ib2be7b15200376ab8a16e4a1b69d98fde0630673
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364471
Reviewed-by: Mike Klein <mtklein@google.com>
2021-02-02 16:44:33 +00:00
John Stiles
5d1b5a238e Move pooling implementation details out of IRNode class.
In theory, any class could be participate in our pool by subclassing
from Poolable. In practice, IRNode already serves as a good foundational
base class, but this gives us a cleaner division of responsibility.

Change-Id: I17e99caf08bce89bb4d089bf0157106001d5db46
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364118
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-02-02 16:06:05 +00:00
Kevin Lubick
e9e8e5d771 [canvaskit] Replace Postan value array with Float32Array.
Change-Id: Ie0e8a9271ef1b68551473fb9a1bcc9442f063efe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362477
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2021-02-02 15:22:07 +00:00
Kevin Lubick
d62738d094 [canvaskit] Remove deprecated PathMeasure
This will make cleaning up the PosTan value easier.

Change-Id: I13aa12f94c560bf8539aa2edb1f9e13779635692
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362458
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2021-02-02 15:22:07 +00:00
Kevin Lubick
f6040ef2a7 [canvaskit] Remove value_array for vector3
Also removes the size value_objects, which appear unused.

Change-Id: Iecfc05b6c285b981415121943b7b43e2216516cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362339
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2021-02-02 15:22:07 +00:00
Kevin Lubick
ed96264ad7 [canvaskit] Replace Point value_array with Float32Array
Using value_array (and value_object), while convenient,
adds a measurable overhead. This removes the Point value_object
and replaces it as a return value with Float32Array
(similar to rects). For inputs of a single point, I just
split it into x and y. For inputs with two points, I used
a _scratchFourFloats (formerly _scratchRect) bit of memory.

Two subtle decisions here:
 - Why not use scratch memory for a single point? The cost of
   having one extra param is a small/negligible price to pay
   for less complex code.
 - Why not accept Malloc objects? Again, simplicity. Accommodating
   Malloc would make the code harder to read and require more
   checks. I don't know if anyone wants to have malloced points;
   if they do, we can probably accommodate that.

Change-Id: I1b1c29f62e01c2f1c8c1218f58e3bad642214322
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362097
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2021-02-02 15:22:07 +00:00
Mike Klein
b97a9de755 silo away td when -local
Even with all the workarounds (deleted here), calling td methods still
costs a fair chunk of CPU work.  Instead of sneakily working around it,
just never call it when run locally.

Change-Id: I2e421a5d585c86a6315d56867a29bdcdc9d45479
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364461
Reviewed-by: Mike Klein <mtklein@google.com>
2021-02-02 15:07:22 +00:00
Mike Klein
d6c70d3f44 add ASAN FM bot
Change-Id: Ifa3215299b064e024acf4f7f64dda1c6345c67b0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364457
Reviewed-by: Mike Klein <mtklein@google.com>
2021-02-02 14:59:16 +00:00
John Stiles
d842feea48 Avoid comma usage in Operators test.
This works around a GLSL compilation bug on the Tecno Spark 3 Pro.

Change-Id: I516bd64745a8e99cccc87ee4bb2e1f5d5b26c130
Bug: skia:11255
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364116
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-02 14:34:24 +00:00
Adlai Holler
67a2000446 Handle fDeferredProxies in GrOpsTask merging
Bug: skia:10877
Change-Id: Ie5ff18cadcbd46b55b40935de74044c3e2136f71
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363939
Auto-Submit: Adlai Holler <adlai@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-02 14:17:34 +00:00
John Stiles
931cad1d74 Update function-type-matching tests to work as Runtime Effects.
Previously, our only test was invoking `sin(1)` which is a pretty
ineffective test. Now, we test args and return types for all the basic
scalars/vectors/matrices.

Change-Id: I7d335303eef8b9c9c6cfef2265a15bbd9bd73e0c
Bug: skia:11246
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363943
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-02-02 13:47:35 +00:00
Mike Reed
2bf7d6ff31 Revert "Remove unneeded flags for flutter"
This reverts commit 5c6c3be981.

Reason for revert: something breaking in Flutter

Original change's description:
> Remove unneeded flags for flutter
>
> Change-Id: I0e5af51d56622918f1590ae05a0d88507213505c
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363797
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: Ie4e50a1f5feb5798ad12cb82edc2d66bbaed4722
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364436
Reviewed-by: Mike Reed <reed@google.com>
2021-02-02 12:39:55 +00:00
skia-autoroll
98e11dfe48 Roll Dawn from d7aacdda1119 to d11f4c3d0577 (12 revisions)
https://dawn.googlesource.com/dawn.git/+log/d7aacdda1119..d11f4c3d0577

2021-02-02 hao.x.li@intel.com Query API: Non-precise occlusion query on Metal
2021-02-02 enga@chromium.org Pass the buffer size into DeserializeWGPUDeviceProperties
2021-02-02 hao.x.li@intel.com Query API: Non-precise occlusion query on Vulkan
2021-02-01 senorblanco@chromium.org SkipOpArrayLength.Vertex on all GLES.
2021-02-01 dsinclair@chromium.org Remove use_tint_inspector flag usage.
2021-02-01 senorblanco@chromium.org Moar testing on OpenGL ES backend.
2021-02-01 yunchao.he@intel.com Add validation rules for 3D texture view
2021-02-01 senorblanco@chromium.org Skip OpArrayLengthTest.Vertex on ANGLE.
2021-02-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from ad27ee8c1038 to 222e09735e02 (14 revisions)
2021-02-01 enga@chromium.org dawn_wire: Gracefully handle all invalid and unknown sTypes
2021-02-01 cwallez@chromium.org dawn_native: Turn the DisallowUnsafeAPIs toggle on by default.
2021-02-01 cwallez@chromium.org Suppress RenderPipelineValidationTest.VertexAttribCorrectEntryPoint

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from ad27ee8c1038 to 222e09735e02

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: cwallez@google.com
Change-Id: I1ddf41eb2ec3ccbc239003b12ac3d2d9226bc1d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364336
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-02 07:39:03 +00:00
Chris Dalton
319d020092 Move stroke-as-rect optimization from SkGpuDevice to GrSurfaceDrawContext
Bug: chromium:1172543
Change-Id: I442919070a70ed97d93cc66db81be3a67d615203
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/362796
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-02-02 05:51:02 +00:00
skia-autoroll
48045e5779 Roll Chromium from 0e1106877e42 to 2329a341cbd8 (432 revisions)
0e1106877e..2329a341cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: robertphillips@google.com
Change-Id: I6548540160edbe0bd86e583f4fe0b5ab2b7b8d7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364198
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-02 05:45:22 +00:00
skia-autoroll
e018a5164e Roll SwiftShader from df5dee645ab5 to 51045556acd0 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/df5dee645ab5..51045556acd0

2021-02-01 capn@google.com Clarify DepthGreater/Less/Unchanged execution modes are unused
2021-02-01 noreply@google.com Replace deprecated llvm::VectorType usage with FixedVectorType
2021-02-01 capn@google.com Silence dead code warning

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: robertphillips@google.com
Change-Id: I9d1f74d84006c1b8a5cd57f011877859c432222b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364201
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-02-02 05:24:32 +00:00