Commit Graph

7 Commits

Author SHA1 Message Date
Eric Boren
ffb48e1aaf Recipes: remove some pragma: no cover
These are the remaining instances, and they're harder to deal with:
$ git grep pragma
recipe_modules/swarming/api.py:    except self.m.step.StepFailure as e:  # pragma: no cover
recipe_modules/swarming/api.py:      if len(ids) > 1:  # pragma: nocover
recipes/ct_skps.py:  if api.path.exists(version_file):  # pragma: nocover
recipes/ct_skps.py:  if api.path.exists(blacklist_file):  # pragma: nocover
recipes/upload_nano_results.py:  if len(results) != 1:  # pragma: nocover

Bug: skia:6473
Change-Id: If75e2ffcf39a944b513b9005bbc4bd9c4fb031f6
Reviewed-on: https://skia-review.googlesource.com/13867
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 19:14:46 +00:00
Eric Boren
e16fb7584a Recipes: Use strict coverage, part 1
Shouldn't change any behavior.

Bug: skia:
Change-Id: I953e0da886a6d61096eba7915101f245a6cec741
Reviewed-on: https://skia-review.googlesource.com/13765
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 11:24:24 +00:00
Eric Boren
1b5b944f69 Roll recipe DEPS again
This time with coverage bypass

BUG=skia:

Change-Id: I7f51dcad7bad53c7209ac512876a0d72c6181b8e
Reviewed-on: https://skia-review.googlesource.com/8768
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-02-21 15:23:11 +00:00
Eric Boren
7e97dc0aa1 Copy modules back in from skia-recipes repo
BUG=skia:6070

Change-Id: I86b3f039c27bd8287516c1db8bd1cae62888171b
Reviewed-on: https://skia-review.googlesource.com/7890
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-02-02 14:31:45 +00:00
Eric Boren
6441a4645b Move recipe modules to shared repo
BUG=skia:6070

Change-Id: I6c487e77ddfddb6164b983981dff5ee8ae870376
Reviewed-on: https://skia-review.googlesource.com/6946
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2017-01-17 12:58:30 +00:00
Eric Boren
3b3bdafa8e Delete swarm_trigger recipe
Delete no-longer-used parts of swarming module and add "pragma: no
cover" where applicable.

BUG=skia:

Change-Id: I0f516d7be520a4d4b4efbfa97bd383a5f124e713
Reviewed-on: https://skia-review.googlesource.com/5790
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-12-13 12:53:00 +00:00
borenet
538d5b68e8 Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Review-Url: https://codereview.chromium.org/2215803002
2016-08-04 11:07:10 -07:00