ee62fad9a4
Organization v3.5, if we are keeping track :) This splits the "srcs" filegroup into "srcs" and "private_hdrs", and renames "hdrs" to "public_hdrs". To assist with the split, I created the macro split_srcs_and_hdrs. Rather than keep two separate lists of header and source files, I figured it would be easiest, at least for the common case, to keep one list of files and then have a for loop split them apart. I've tried to be consistent with having the list of files be named with a _FILES suffix - maybe we can use this as a marker to generate .gni files in the future? Suggested review order: - //bazel/macros.bzl. Note this needs a corresponding G3 change (http://cl/452279799) as well. The exports_files_legacy change is the better approach to something I manually handled yesterday when fixing the G3 roll. - //BUILD.bazel to see the new target skia_internal and the previous skia_core renamed to skia_public. - //src/core/BUILD.bazel to see a typical usage of split_srcs_and_hdrs. - //include/... to see the change to public_hdrs and private_hdrs - //src/... to see many more usages of split_srcs_and_hdrs - //tools/... to see changes to skia_internal where appropriate. - Everything else. Note that //modules/... might also need to be built with skia_internal instead of skia_public, but we can fix that up later, if necessary. Change-Id: Ie1cc969455d97b029b2d77faa222c4a9bad70671 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545716 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
39 lines
1.2 KiB
Python
39 lines
1.2 KiB
Python
load("//bazel:macros.bzl", "exports_files_legacy", "select_multi")
|
|
|
|
licenses(["notice"])
|
|
|
|
exports_files_legacy()
|
|
|
|
filegroup(
|
|
name = "public_hdrs",
|
|
srcs = [
|
|
"GpuTypes.h",
|
|
"GrBackendDrawableInfo.h",
|
|
"GrBackendSemaphore.h",
|
|
"GrBackendSurface.h",
|
|
"GrBackendSurfaceMutableState.h",
|
|
"GrConfig.h",
|
|
"GrContextOptions.h",
|
|
"GrContextThreadSafeProxy.h",
|
|
"GrDirectContext.h",
|
|
"GrDriverBugWorkarounds.h",
|
|
"GrDriverBugWorkaroundsAutogen.h",
|
|
"GrRecordingContext.h",
|
|
"GrSurfaceInfo.h",
|
|
"GrTypes.h",
|
|
"GrYUVABackendTextures.h",
|
|
"ShaderErrorHandler.h",
|
|
"//include/gpu/mock:public_hdrs",
|
|
# TODO(egdaniel, kjlubick) GrGLTypes.h is used unconditionally by GrBackendSemaphore.h
|
|
"//include/gpu/gl:public_hdrs",
|
|
] + select_multi(
|
|
{
|
|
"//bazel/common_config_settings:dawn_backend": ["//include/gpu/dawn:public_hdrs"],
|
|
"//bazel/common_config_settings:vulkan_backend": ["//include/gpu/vk:public_hdrs"],
|
|
# TODO(kjlubick) mtl and d3d backend
|
|
},
|
|
default = [],
|
|
),
|
|
visibility = ["//include:__pkg__"],
|
|
)
|