5420cbcf65
GLSL treats builtin types and user-defined types differently; `int` and `float` are keywords and cannot be used to name variables. However, it's fine for a user type like `struct xyz` to be hidden by a variable `int xyz` or even `xyz xyz` (i.e., a variable of type `struct xyz` named `xyz`). We now honor that distinction and include tests for it. This will fix several ES2 conformance tests (local_struct_variable_hides_struct_type, local_int_variable_hides_struct_type, etc.). Change-Id: I7a45c70707087f9f355ce5b06b032fed16683f3e Bug: skia:12527 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458721 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
72 lines
1.8 KiB
C++
72 lines
1.8 KiB
C++
/*
|
|
* Copyright 2021 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SKSL_DSL_SYMBOLS
|
|
#define SKSL_DSL_SYMBOLS
|
|
|
|
#include "include/core/SkStringView.h"
|
|
#include "include/private/SkSLString.h"
|
|
#include "include/sksl/DSLExpression.h"
|
|
|
|
#include <memory>
|
|
|
|
namespace SkSL {
|
|
|
|
class SymbolTable;
|
|
|
|
namespace dsl {
|
|
|
|
class DSLVar;
|
|
|
|
// This header provides methods for manually managing symbol tables in DSL code. They should not be
|
|
// used by normal hand-written DSL code, where we rely on C++ to manage symbols, but are instead
|
|
// needed when DSL objects are being constructed programmatically (as in DSLParser).
|
|
|
|
/**
|
|
* Pushes a new symbol table onto the symbol table stack.
|
|
*/
|
|
void PushSymbolTable();
|
|
|
|
/**
|
|
* Pops the top symbol table from the stack. As symbol tables are shared pointers, this will only
|
|
* destroy the symbol table if it was never attached to anything (e.g. passed into a Block
|
|
* constructor).
|
|
*/
|
|
void PopSymbolTable();
|
|
|
|
/**
|
|
* Returns the current symbol table. Outside of SkSL itself, this is an opaque pointer, used only
|
|
* for passing it to DSL methods that require it.
|
|
*/
|
|
std::shared_ptr<SymbolTable> CurrentSymbolTable();
|
|
|
|
/**
|
|
* Returns an expression referring to the named symbol.
|
|
*/
|
|
DSLPossibleExpression Symbol(skstd::string_view name, PositionInfo pos = PositionInfo::Capture());
|
|
|
|
/**
|
|
* Returns true if the name refers to a type (user or built-in) in the current symbol table.
|
|
*/
|
|
bool IsType(skstd::string_view name);
|
|
|
|
/**
|
|
* Returns true if the name refers to a builtin type.
|
|
*/
|
|
bool IsBuiltinType(skstd::string_view name);
|
|
|
|
/**
|
|
* Adds a variable to the current symbol table.
|
|
*/
|
|
void AddToSymbolTable(DSLVarBase& var, PositionInfo pos = PositionInfo::Capture());
|
|
|
|
} // namespace dsl
|
|
|
|
} // namespace SkSL
|
|
|
|
#endif
|