39edd521a2
`a || b` only evaluates b if a is false. `a | b` always evaluates both a and b. If a and b are of type bool, `||` is usually what you want, so clang now warns on `|` where both arguments are of type bool. In Skia, 3 of 3 uses of `|` were intentional as far as I can tell (one had an explicit comment, the other two didn't). Rewrite them slightly to make this intent more clear and to suppress the warning. There was also one use of `&`. That one looks like a (benign) typo for `&&`, so change it. Bug: chromium:1255745 Change-Id: I9ac37075311005c0a8fcb8d1379f516510929423 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459456 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Florin Malita <fmalita@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Florin Malita <fmalita@google.com> |
||
|---|---|---|
| .. | ||
| fuzz | ||
| gm | ||
| include | ||
| src | ||
| tests | ||
| utils | ||
| BUILD.gn | ||
| skottie.gni | ||