skia2/tools/viewer
Hal Canary 02738a86e5 Revert "hide hinting and flag enums with PAINT_FLAGS"
This reverts commit 5d052dac3a.

Reason for revert: BREAKS CHROMIUM ROLL.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc?l=49
|   FAILED: obj/third_party/blink/renderer/platform/platform/font_platform_data_win.obj
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(49,29):
|     error: no member named 'kLCDRenderText_Flag' in 'SkPaint'
|     if (text_flags & SkPaint::kLCDRenderText_Flag) {
|                      ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(51,36):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|     } else if (text_flags & SkPaint::kAntiAlias_Flag) {
|                             ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(56,52):
|     error: no member named 'kSubpixelText_Flag' in 'SkPaint'
|     font->setSubpixel(SkToBool(text_flags & SkPaint::kSubpixelText_Flag));
|                                             ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(64,29):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|     if (text_flags & SkPaint::kAntiAlias_Flag)
|                      ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(85,27):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|                  ? SkPaint::kAntiAlias_Flag
|                    ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(91,35):
|     error: no member named 'kLCDRenderText_Flag' in 'SkPaint'
|                          ? SkPaint::kLCDRenderText_Flag
|                            ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(93,27):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|       text_flags = SkPaint::kAntiAlias_Flag | lcd_flag;
|                    ~~~~~~~~~^
|   ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(101,28):
|     error: no member named 'kAntiAlias_Flag' in 'SkPaint'
|       text_flags |= SkPaint::kAntiAlias_Flag;
|                     ~~~~~~~~~^
|   8 errors generated.

Original change's description:
> hide hinting and flag enums with PAINT_FLAGS
> 
> A preflight for https://skia-review.googlesource.com/c/skia/+/185460
> 
> Bug: skia:2664
> Change-Id: I83f7f9cd500e8507b559462835477ba8ae7c11ab
> Reviewed-on: https://skia-review.googlesource.com/c/185540
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
> Auto-Submit: Mike Reed <reed@google.com>

TBR=reed@google.com

Change-Id: I4d1581a7e29267ad459ed31d4885b823fa00066f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:2664
Reviewed-on: https://skia-review.googlesource.com/c/185680
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-01-21 18:51:39 +00:00
..
BisectSlide.cpp Stop using SkTSwap. 2018-06-19 02:06:31 +00:00
BisectSlide.h test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
GMSlide.cpp Allow slides/gms to extend the UI 2018-05-15 14:29:43 +00:00
GMSlide.h Allow slides/gms to extend the UI 2018-05-15 14:29:43 +00:00
ImageSlide.cpp Add onBackendCreated callback to Viewer 2017-02-24 22:37:34 +00:00
ImageSlide.h Simplify viewer's handling of backbuffer surface and color space 2017-02-08 17:34:05 +00:00
ImGuiLayer.cpp Fix variable shadowing in Viewer's ImGui code 2019-01-17 14:52:30 +00:00
ImGuiLayer.h test,tools: whitespace changes for clang-format 2018-09-19 17:50:51 +00:00
NIMASlide.cpp Refactor Nima code 2018-10-30 19:32:52 +00:00
NIMASlide.h Refactor Nima code 2018-10-30 19:32:52 +00:00
SampleSlide.cpp Make Slide::getDimensions pure virtual. 2018-09-05 15:05:14 +00:00
SampleSlide.h Make Slide::getDimensions pure virtual. 2018-09-05 15:05:14 +00:00
SkottieSlide.cpp drawText Cleanup, part 2 2019-01-09 16:01:59 +00:00
SkottieSlide.h [skottie] Plumb external SkFontMgr 2018-08-23 13:13:30 +00:00
SKPSlide.cpp SkFontData to use smart pointers. 2016-09-16 06:24:20 -07:00
SKPSlide.h Add samples to Viewer. 2016-06-16 09:52:35 -07:00
Slide.h Make Slide::getDimensions pure virtual. 2018-09-05 15:05:14 +00:00
SlideDir.cpp [sksg] Consolidate Matrix node implementations 2019-01-10 21:50:54 +00:00
SlideDir.h Don't use MEM_MOVE=true with SkTArrays of sk_sp 2018-09-05 20:11:07 +00:00
StatsLayer.cpp drawText Cleanup, part 2 2019-01-09 16:01:59 +00:00
StatsLayer.h Add 'u' to zoom stats display on high DPI devices 2018-07-30 15:00:25 +00:00
SvgSlide.cpp Fix !defined(SK_XML) builds 2018-08-01 14:28:56 +00:00
SvgSlide.h Viewer SVG support 2018-04-05 16:34:22 +00:00
TouchGesture.cpp Move Views into Sample and Viewer. 2018-08-09 15:25:32 +00:00
TouchGesture.h Move Views into Sample and Viewer. 2018-08-09 15:25:32 +00:00
Viewer.cpp Revert "hide hinting and flag enums with PAINT_FLAGS" 2019-01-21 18:51:39 +00:00
Viewer.h expand flag to include all text-related paint fields 2019-01-10 20:06:07 +00:00