6ba9f702ba
To make the atomic rules a bit easier to work with, in many of the folders, this adds in cc_library rules to group together the sources from that folder (and subfolders where prudent). We only needs sources because those atoms should have their headers as deps. One issue that was pointed out is that there is currently no way to restrict the inclusion of certain packages, a la, `gn check`. For example, there is no mechanism from stopping a dev from adding #include "modules/canvaskit/WasmCommon.h" to something in //src/core (except circular dependencies). We can probably address that using Bazel's visibility rules as needed: https://docs.bazel.build/versions/main/visibility.html https://docs.bazel.build/versions/main/be/functions.html#package_group It is recommended to look at this CL patchset by patchset. PS1: Update gazelle command to generate rules in more folders. PS2: A few changes to make generation work better. PS3: The result of running make generate in //bazel PS4: Adding the rules to build sksllex, the simplest binary I could find in the Skia repo. PS5: Adding the rules to build skdiff, a more complex binary. I tried a few approaches, but ended up gravitating back towards the layout where we have each folder/package group up the sources. I imagine at some point, we'll have skdiff depend on skia_core or something, which will have things like //src/core, //src/codecs, //src/pathops all bundled together. PS7: Added in the groupings of sources, similar to what we had earlier. I liked these for readability. These helped fix up the //:skia_core build, and by extension, the CanvasKit build. Change-Id: I3faa7c4e821c876b243617aacf0246efa524cbde Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/476219 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> |
||
---|---|---|
.. | ||
src | ||
bad_gms.txt | ||
branch_skqp_dev.sh | ||
BUILD.bazel | ||
clean_app.sh | ||
create_apk.py | ||
cut_release.py | ||
docker_build_universal_apk.sh | ||
docker_run_apk.sh | ||
download_model | ||
download_model.py | ||
find_commit_with_best_gold_results.py | ||
gn_to_bp.py | ||
jitter_gms.cpp | ||
make_apk_list.py | ||
make_apk.sh | ||
make_skqp_model.cpp | ||
make_universal_apk | ||
make_universal_apk.py | ||
README_ALGORITHM.md | ||
README_GENERATING_MODELS.md | ||
README.md | ||
release.sh | ||
run_apk.sh | ||
run_skqp_exe | ||
setup_resources | ||
skqp_gn_args.py | ||
test_apk.sh | ||
upload_apk |
SkQP
SkQP (Skia Quality Program) is a component of the Android CTS (Compatablity Test Suite) that tests an Android device's GPU and OpenGLES & Vulkan drivers using Skia's existing unit & rendering tests.
See https://skia.org/dev/testing/skqp for pre-build APKs.
How to build and run the SkQP tests
-
Get the dependencies:
-
You will need Java JDK 8,
git
, andpython
. -
Install Chromium's depot_tools. Add it to your
PATH
.git clone 'https://chromium.googlesource.com/chromium/tools/depot_tools.git' export PATH="${PWD}/depot_tools:${PATH}"
-
Install the Android NDK.
( cd ~; unzip ~/Downloads/android-ndk-*.zip ) ANDROID_NDK=$(ls -d ~/android-ndk-*) # Or wherever you installed the Android NDK.
-
Install the Android SDK. Set the
ANDROID_HOME
environment variable.mkdir ~/android-sdk ( cd ~/android-sdk; unzip ~/Downloads/sdk-tools-*.zip ) yes | ~/android-sdk/tools/bin/sdkmanager --licenses export ANDROID_HOME=~/android-sdk # Or wherever you installed the Android SDK.
Put
adb
in yourPATH
.export PATH="${PATH}:${ANDROID_HOME}/platform-tools"
-
-
Get the right version of Skia:
git clone https://skia.googlesource.com/skia.git cd skia git checkout origin/skqp/dev # or whatever release tag you need
-
Build the APK:
tools/git-sync-deps tools/skqp/make_universal_apk
-
Build, install, and run.
adb install -r out/skqp/skqp-universal-debug.apk adb logcat -c adb shell am instrument -w org.skia.skqp
-
Monitor the output with:
adb logcat TestRunner org.skia.skqp skia "*:S"
Note the test's output path on the device. It will look something like this:
01-23 15:22:12.688 27158 27173 I org.skia.skqp: output written to "/storage/emulated/0/Android/data/org.skia.skqp/files/output"
-
Retrieve and view the report with:
OUTPUT_LOCATION="/storage/emulated/0/Android/data/org.skia.skqp/files/output" adb pull $OUTPUT_LOCATION /tmp/ bin/sysopen /tmp/output/skqp_report/report.html
Running a single test
To run a single test, for example gles_aarectmodes
:
adb shell am instrument -e class 'org.skia.skqp.SkQPRunner#gles_aarectmodes' -w org.skia.skqp
Unit tests can be run with the unitTest_
prefix:
adb shell am instrument -e class 'org.skia.skqp.SkQPRunner#unitTest_GrSurface -w org.skia.skqp
Run as a non-APK executable
-
Follow steps 1-3 as above.
-
Build the SkQP program, load files on the device, and run skqp:
ninja -C out/skqp/arm skqp python tools/skqp/run_skqp_exe out/skqp/arm