0251288112
In some cases, the allocated array into which the data will be read is using getArrayCount() to allocate itself, which should be safe, but some cases use fixed length arrays or compute the array size before reading, which could overflow if the stream is compromised. To prevent that from happening, I added a check that will verify that the number of bytes to read will not exceed the capacity of the input buffer argument passed to all the read...Array() functions. I chose to use the byte array for this initial version, so that "size" represents the same value across all read...Array() functions, but I could also use the element count, if it is preferred. Note : readPointArray and writePointArray are unused, so I could also remove them BUG= R=reed@google.com, mtklein@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/37803002 git-svn-id: http://skia.googlecode.com/svn/trunk@12058 2bbb7eff-a529-9590-31e7-b0007b416f81
179 lines
5.7 KiB
Python
179 lines
5.7 KiB
Python
# GYP file to build unit tests.
|
|
{
|
|
'includes': [
|
|
'apptype_console.gypi',
|
|
],
|
|
'targets': [
|
|
{
|
|
'target_name': 'tests',
|
|
'type': 'executable',
|
|
'include_dirs' : [
|
|
'../src/core',
|
|
'../src/effects',
|
|
'../src/image',
|
|
'../src/lazy',
|
|
'../src/pathops',
|
|
'../src/pdf',
|
|
'../src/pipe/utils',
|
|
'../src/utils',
|
|
'../tools/',
|
|
],
|
|
'includes': [
|
|
'pathops_unittest.gypi',
|
|
],
|
|
'sources': [
|
|
'../tests/AAClipTest.cpp',
|
|
'../tests/AndroidPaintTest.cpp',
|
|
'../tests/AnnotationTest.cpp',
|
|
'../tests/ARGBImageEncoderTest.cpp',
|
|
'../tests/AtomicTest.cpp',
|
|
'../tests/BitmapCopyTest.cpp',
|
|
'../tests/BitmapFactoryTest.cpp',
|
|
'../tests/BitmapGetColorTest.cpp',
|
|
'../tests/BitmapHasherTest.cpp',
|
|
'../tests/BitmapHeapTest.cpp',
|
|
'../tests/BitSetTest.cpp',
|
|
'../tests/BlitRowTest.cpp',
|
|
'../tests/BlurTest.cpp',
|
|
'../tests/CachedDecodingPixelRefTest.cpp',
|
|
'../tests/CanvasTest.cpp',
|
|
'../tests/CanvasStateTest.cpp',
|
|
'../tests/ChecksumTest.cpp',
|
|
'../tests/ClampRangeTest.cpp',
|
|
'../tests/ClipCacheTest.cpp',
|
|
'../tests/ClipCubicTest.cpp',
|
|
'../tests/ClipStackTest.cpp',
|
|
'../tests/ClipperTest.cpp',
|
|
'../tests/ColorFilterTest.cpp',
|
|
'../tests/ColorTest.cpp',
|
|
'../tests/DataRefTest.cpp',
|
|
'../tests/DeferredCanvasTest.cpp',
|
|
'../tests/DequeTest.cpp',
|
|
'../tests/DeviceLooperTest.cpp',
|
|
'../tests/DocumentTest.cpp',
|
|
'../tests/DrawBitmapRectTest.cpp',
|
|
'../tests/DrawPathTest.cpp',
|
|
'../tests/DrawTextTest.cpp',
|
|
'../tests/DynamicHashTest.cpp',
|
|
'../tests/EmptyPathTest.cpp',
|
|
'../tests/ErrorTest.cpp',
|
|
'../tests/FillPathTest.cpp',
|
|
'../tests/FitsInTest.cpp',
|
|
'../tests/FlatDataTest.cpp',
|
|
'../tests/FlateTest.cpp',
|
|
'../tests/FontHostStreamTest.cpp',
|
|
'../tests/FontHostTest.cpp',
|
|
'../tests/FontMgrTest.cpp',
|
|
'../tests/FontNamesTest.cpp',
|
|
'../tests/FrontBufferedStreamTest.cpp',
|
|
'../tests/GeometryTest.cpp',
|
|
'../tests/GifTest.cpp',
|
|
'../tests/GLInterfaceValidation.cpp',
|
|
'../tests/GLProgramsTest.cpp',
|
|
'../tests/GpuBitmapCopyTest.cpp',
|
|
'../tests/GpuColorFilterTest.cpp',
|
|
'../tests/GpuDrawPathTest.cpp',
|
|
'../tests/GrContextFactoryTest.cpp',
|
|
'../tests/GradientTest.cpp',
|
|
'../tests/GrMemoryPoolTest.cpp',
|
|
'../tests/GrSurfaceTest.cpp',
|
|
'../tests/HashCacheTest.cpp',
|
|
'../tests/ImageCacheTest.cpp',
|
|
'../tests/ImageDecodingTest.cpp',
|
|
'../tests/ImageFilterTest.cpp',
|
|
'../tests/InfRectTest.cpp',
|
|
'../tests/JpegTest.cpp',
|
|
'../tests/LListTest.cpp',
|
|
'../tests/LayerDrawLooperTest.cpp',
|
|
'../tests/MD5Test.cpp',
|
|
'../tests/MathTest.cpp',
|
|
'../tests/MatrixTest.cpp',
|
|
'../tests/Matrix44Test.cpp',
|
|
'../tests/MemoryTest.cpp',
|
|
'../tests/MemsetTest.cpp',
|
|
'../tests/MessageBusTest.cpp',
|
|
'../tests/MetaDataTest.cpp',
|
|
'../tests/MipMapTest.cpp',
|
|
'../tests/OnceTest.cpp',
|
|
'../tests/OSPathTest.cpp',
|
|
'../tests/PackBitsTest.cpp',
|
|
'../tests/PaintTest.cpp',
|
|
'../tests/ParsePathTest.cpp',
|
|
'../tests/PathCoverageTest.cpp',
|
|
'../tests/PathMeasureTest.cpp',
|
|
'../tests/PathTest.cpp',
|
|
'../tests/PathUtilsTest.cpp',
|
|
'../tests/PDFPrimitivesTest.cpp',
|
|
'../tests/PictureTest.cpp',
|
|
'../tests/PictureUtilsTest.cpp',
|
|
'../tests/PipeTest.cpp',
|
|
'../tests/PixelRefTest.cpp',
|
|
'../tests/PointTest.cpp',
|
|
'../tests/PremulAlphaRoundTripTest.cpp',
|
|
'../tests/QuickRejectTest.cpp',
|
|
'../tests/RandomTest.cpp',
|
|
'../tests/Reader32Test.cpp',
|
|
'../tests/ReadPixelsTest.cpp',
|
|
'../tests/ReadWriteAlphaTest.cpp',
|
|
'../tests/RefCntTest.cpp',
|
|
'../tests/RefDictTest.cpp',
|
|
'../tests/RegionTest.cpp',
|
|
'../tests/ResourceCacheTest.cpp',
|
|
'../tests/RoundRectTest.cpp',
|
|
'../tests/RTreeTest.cpp',
|
|
'../tests/SHA1Test.cpp',
|
|
'../tests/ScalarTest.cpp',
|
|
'../tests/SerializationTest.cpp',
|
|
'../tests/ShaderImageFilterTest.cpp',
|
|
'../tests/ShaderOpacityTest.cpp',
|
|
'../tests/Sk64Test.cpp',
|
|
'../tests/skia_test.cpp',
|
|
'../tests/SortTest.cpp',
|
|
'../tests/SrcOverTest.cpp',
|
|
'../tests/StreamTest.cpp',
|
|
'../tests/StringTest.cpp',
|
|
'../tests/StrokeTest.cpp',
|
|
'../tests/SurfaceTest.cpp',
|
|
'../tests/Test.cpp',
|
|
'../tests/Test.h',
|
|
'../tests/TestSize.cpp',
|
|
'../tests/TileGridTest.cpp',
|
|
'../tests/TLSTest.cpp',
|
|
'../tests/TSetTest.cpp',
|
|
'../tests/ToUnicode.cpp',
|
|
'../tests/Typeface.cpp',
|
|
'../tests/UnicodeTest.cpp',
|
|
'../tests/UnitTestTest.cpp',
|
|
'../tests/UtilsTest.cpp',
|
|
'../tests/WArrayTest.cpp',
|
|
'../tests/WritePixelsTest.cpp',
|
|
'../tests/Writer32Test.cpp',
|
|
'../tests/XfermodeTest.cpp',
|
|
|
|
# Needed for PipeTest.
|
|
'../src/pipe/utils/SamplePipeControllers.cpp',
|
|
],
|
|
'dependencies': [
|
|
'skia_lib.gyp:skia_lib',
|
|
'flags.gyp:flags',
|
|
'experimental.gyp:experimental',
|
|
'pdf.gyp:pdf',
|
|
'tools.gyp:picture_utils',
|
|
],
|
|
'conditions': [
|
|
[ 'skia_gpu == 1', {
|
|
'include_dirs': [
|
|
'../src/gpu',
|
|
],
|
|
}],
|
|
],
|
|
},
|
|
],
|
|
}
|
|
|
|
# Local Variables:
|
|
# tab-width:2
|
|
# indent-tabs-mode:nil
|
|
# End:
|
|
# vim: set expandtab tabstop=2 shiftwidth=2:
|