Go to file
senorblanco 06f989a61e Revert of Minor cleanup in GrTessellatingPathRenderer. (patchset #1 id:1 of https://codereview.chromium.org/1322023002/ )
Reason for revert:
Patch is incorrect -- floating point errors can cause zero-area monotone polys to be skipped, resulting in a smaller vertex count than estimated.

Reproduce as follows:

out/Debug/SampleApp --slide Fuzzer --msaa 4

switch to GPU mode. Result:

../../src/gpu/batches/GrTessellatingPathRenderer.cpp:1500: failed assertion "static_cast<int>(end - verts) == vertexCount"

Original issue's description:
> Minor cleanup in GrTessellatingPathRenderer.
>
> Vertex counts are always exact, so don't bother handling the case
> where they're different. Just assert.
> Rename variables to reflect.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9389b871c3b0f06bb34626cf9bdbfe0c93779327

TBR=bsalomon@google.com,senorblanco@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1321723006
2015-09-02 09:05:17 -07:00
animations
bench Clean up remaining users of SkPMFloat 2015-08-31 15:26:08 -07:00
bin Add instructions to authenticate for fetch. 2015-08-21 08:38:06 -07:00
cmake Cmake: fix to make linking work on Ubuntu 2015-09-01 10:11:44 -07:00
debugger Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
dm Various improvements to CodecSrc testing in dm 2015-09-01 14:57:57 -07:00
example Propagate SkSurfaceProps to more call sites 2015-06-23 06:26:08 -07:00
experimental Experimental: fix document 2015-09-01 13:44:22 -07:00
forth
gm Limit lifetime of GrDrawContext objects 2015-09-01 08:34:28 -07:00
gyp Remove GrAddPathRenderers_default 2015-09-02 08:42:16 -07:00
include add preroll to image, for chrome's warmup pass 2015-09-01 12:22:32 -07:00
infra Specify try_job_retry_config for Skia try jobs 2015-09-02 05:23:23 -07:00
platform_tools VisualBenchTest: Read nanobench_flags.txt 2015-09-02 06:04:29 -07:00
resources Add HangingS.ttf to test large flourish caps. 2015-08-26 10:44:48 -07:00
samplecode Rename flag from "distance field" to "device independent." 2015-08-31 12:39:41 -07:00
site Provide some detail about valentine password 2015-08-31 07:27:24 -07:00
src Revert of Minor cleanup in GrTessellatingPathRenderer. (patchset #1 id:1 of https://codereview.chromium.org/1322023002/ ) 2015-09-02 09:05:17 -07:00
tests C API: Add SK_API, also documentation of an example. 2015-09-01 10:01:38 -07:00
third_party Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin. (patchset #1 id:1 of https://codereview.chromium.org/1296253003/ ) 2015-08-17 11:15:00 -07:00
tools Rename flag from "distance field" to "device independent." 2015-08-31 12:39:41 -07:00
.gitignore Update Android Apps to use gradle 2015-07-24 13:15:59 -07:00
AUTHORS Optimize RGB16 blitV functions with NEON for ARM platform. 2015-07-15 07:07:30 -07:00
BUILD.public Update BUILD.public a bit. 2015-08-18 08:51:49 -07:00
codereview.settings Automatically add a docs preview link and NOTRY=true when there are only docs changes. 2015-02-26 10:16:13 -08:00
CONTRIBUTING Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
CQ_COMMITTERS Add benjaminwagner@ to CQ_COMMITTERS. 2015-06-08 10:22:34 -07:00
DEPS Update giflib to 5.1.1 (AOSP hash) 2015-08-24 12:00:15 -07:00
Doxyfile Documentation: SkCanvas API 2015-05-19 10:21:29 -07:00
gyp_skia Support SKIA_OUT on Mac and ChromeOS 2015-05-04 08:04:28 -07:00
gyp_skia.py Roll gyp deps from 1765 to 1796. 2013-11-21 18:11:14 +00:00
HASHTAGS Fix cr SKPs naming 2015-03-31 08:03:02 -07:00
LICENSE Add files added to Skia HEAD in google3 to the Git repo. 2015-08-17 12:58:10 -07:00
make.bat Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
make.py Fix make.py: BUILDTYPE 2015-08-05 11:30:28 -04:00
Makefile Remove experimental/PdfViewer 2015-08-04 14:08:44 -07:00
OWNERS
PRESUBMIT.py update presubmit to know about include/private 2015-07-28 08:54:12 -07:00
README Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
skia.gyp Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
SKP_VERSION Update SKP version 2015-08-30 00:19:11 -07:00
whitespace.txt Whitespace change to test Gerrit ACLs 2015-08-04 14:23:48 -07:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.