0795361b45
The use of __builtin_unreachable() and __assume(false) are actually injections of undefined behavior. They do not crash and they may allow the compiler to assume that any values which could cause that location to be reached cannot occur. They should only be used after code which cannot return but the compiler cannot know that (such as inline assembly which does not return and calls to functions which should have been declared noreturn but were not). Replace their use with __builtin_trap() and __failfast(). These are similar to __builtin_debugtrap() or __debugbreak() but also indicate that execution should not be resumed. Change-Id: I46c1362f4e86944cc8e03f6f5837875ac71b69f3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297024 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| build/fuchsia | ||
| build_overrides | ||
| client_utils/android | ||
| demos.skia.org | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| RELEASE_NOTES.txt | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.