8079ba688c
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.
For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.
I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'. By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.
Another good use case is a hypothetical Actually-Shippable-Release mode. Our
Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely. To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there
too, '-fomit-frame-pointer', etc.
There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest. This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003
Review-Url: https://codereview.chromium.org/2241263003
|
||
|---|---|---|
| .. | ||
| assets | ||
| ct | ||
| recipe_modules | ||
| recipes | ||
| tools/luci-go | ||
| android_bin.isolate | ||
| bootstrap_win_toolchain_json.py | ||
| compile_skia.isolate | ||
| coverage_skia.isolate | ||
| ct_skps_skia.isolate | ||
| housekeeper_skia.isolate | ||
| infrabots.isolate | ||
| ios_bin.isolate | ||
| perf_skia.isolate | ||
| README.md | ||
| recipes.py | ||
| resources.isolate | ||
| skia_repo.isolate | ||
| swarm_recipe.isolate | ||
| test_skia.isolate | ||
| test_utils.py | ||
| upload_skps.py | ||
| utils.py | ||
| win_toolchain_utils.py | ||
| zip_utils_test.py | ||
| zip_utils.py | ||
Skia Buildbot Scripts
The scripts in this directory are ported from Skia's buildbot recipes and are intended to run as standalone Python scripts either locally or via Swarming.
How to Run
The scripts can be run by hand, eg:
$ cd infra/bots $ python compile_skia.py Build-Ubuntu-GCC-x86_64-Debug ../../out
Or, you can run the scripts via Swarming:
$ isolate archive --isolate-server https://isolateserver.appspot.com/ -i infra/bots/compile_skia.isolate -s ../compile-skia.isolated --verbose --config-variable BUILDER_NAME=Build-Ubuntu-GCC-x86_64-Debug $ swarming.py run --swarming https://chromium-swarm.appspot.com --isolate-server https://isolateserver.appspot.com --dimension os Ubuntu --dimension pool Skia --task-name compile-skia --io-timeout=3600 --hard-timeout=3600 ../compile-skia.isolated