089f13f982
Switching some SkVM code from std::unordered_map to SkTHashMap caused the -MSRTC bot to barf unexpectedly, but in a way that makes sense in retrospect. The code to hash skvm::Builder::Instructions returns size_t to fit the unordered_map convention, and I forgot to change that to SkTHashMap's preferred uint32_t. So we began to implicitly truncate that size_t to uint32_t on 64-bit machines, one of the potential issues the -MSRTC bot exists to catch. This change simply masks any user-provided hash to 32 bits explicitly. We could alternatively update the Instruction hash code, but I think the mask here is so cheap (usually notional, zero-cost) that compatibility with std::unordered_map makes this approach more desirable. Cq-Include-Trybots: skia.primary:Test-Win2016-MSVC-GCE-CPU-AVX2-x86_64-Debug-All-MSRTC Change-Id: I0551e7590d5039962e213c6672927bd84e1a0856 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223136 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.