Go to file
Mike Klein 0ec2c7a2dc Revert "refresh image shader cs/at logic"
This reverts commit 4311f19158.

Reason for revert: layout test failures seemingly not having to do with bicubic+clamping+sRGB

Original change's description:
> refresh image shader cs/at logic
> 
> Was working on SkVM versions of these when I noticed the existing
> SkRasterPipeline code wasn't terribly tidy.  The main gist here is that
> we can let SkColorSpaceXformSteps::apply() handle almost all the
> final transformation on the way out of the shader.
> 
> I remain a little puzzled why I got a few significant diffs when I tried
> leaving the A8 color unpremul, letting the steps handle matching the
> alpha types instead of me manually with SkRasterPipeline::premul.  For
> now I've left that as-is.
> 
> Similarly I think we could transform that A8 color ahead of time rather
> than doing that over and over at runtime.  This is something I've left
> as a TODO, largely because I don't care enough about coloring A8 to
> investigate right now.
> 
> I've inlined all the logic of explaining src-is-normalized into this
> shader (which is its only user).  That makes it clearer that we can
> always set that bit when bicubic sampling, since we're clamping anyway.
> This causes some invisible diffs when switching to the optimized sRGB
> transfer function stages, which we may or may not be able to get away
> with without guarding...
> 
> Change-Id: Ie6670c6ca5c69958f41aac88324341a10eb3bee1
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261763
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: I9c414cb751d9e51219b18dc3d4f54c92d06664ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261815
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-31 01:33:51 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench starter bench for canvas matrix operations 2019-12-30 15:48:26 +00:00
bin [infra] Fix bin/try 2019-11-15 19:44:04 +00:00
build/fuchsia Notes on how to build SKQP for Fuchsia. 2019-12-04 15:14:14 +00:00
build_overrides Update Dawn backend to ToT. This is about 3 months of changes. 2019-10-15 22:26:38 +00:00
dm Remove an uncessary and unused parameter for partially generating the JSON command list 2019-12-13 19:30:03 +00:00
docker Make OUTPUT_DIRECTORY in ProdDoxyfile configurable 2019-12-18 16:46:25 +00:00
docs/examples hide/remove obsolete/tricky SkMatrix methods 2019-12-18 22:29:52 +00:00
example Revert "Revert "switch to new filltype for SkPath"" 2019-11-26 17:43:14 +00:00
experimental Debugger changes to make layer inspection interactive 2019-12-20 14:32:28 +00:00
fuzz Make it safe to include SkRuntimeEffect.h from client code 2019-12-30 21:06:56 +00:00
gm Revert "pass more information to shaders" 2019-12-31 01:28:48 +00:00
gn Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
include Rename GpuPathRenderers::kAll to kDefault 2019-12-31 01:01:17 +00:00
infra Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
modules Make it safe to include SkRuntimeEffect.h from client code 2019-12-30 21:06:56 +00:00
platform_tools Revert "GrGLMakeNativeInterface_{iOS,mac,win}: clean up" 2019-12-27 17:38:53 +00:00
resources Add more variation support on Mac. 2019-12-13 18:16:13 +00:00
samplecode SkBlurMaskFilter.h is only needed for (deprecated) emboss 2019-12-30 15:40:46 +00:00
site Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
specs [img-decode] Start on proposed new spec 2019-05-06 17:39:19 +00:00
src Revert "refresh image shader cs/at logic" 2019-12-31 01:33:51 +00:00
tests More SkRuntimeEffect tests 2019-12-30 19:26:06 +00:00
third_party Remove third_party warning suppression for MSVC:4244 2019-12-30 16:13:56 +00:00
tools Rename GpuPathRenderers::kAll to kDefault 2019-12-31 01:01:17 +00:00
.clang-format restore .clang-format 2019-03-21 15:52:32 +00:00
.clang-tidy add google-build-namespaces to clang-tidy checks 2018-12-12 16:33:59 +00:00
.gitignore clean up some .gitignores 2019-05-15 19:55:45 +00:00
.gn Basic standalone GN configs. 2016-07-21 12:25:45 -07:00
AUTHORS Optimize SkSL xor where one argument is constant 2019-12-20 14:50:46 +00:00
BUILD.gn Runtime SkSL: Reflect inputs in SkRuntimeEffect 2019-12-18 17:37:55 +00:00
codereview.settings Make uploading to Gerrit the default for Skia 2016-11-09 19:07:56 +00:00
CONTRIBUTING Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
CQ_COMMITTERS Moved committer list to chrome-infra-auth and deleted it from the repo 2015-09-02 13:37:54 -07:00
DEPS Roll third_party/externals/angle2 ebed85592533..fca5a005aa88 (1 commits) 2019-12-30 04:41:16 +00:00
go.mod [infra] Use "mod download" and "install", not "get" in chrome_release_branch 2019-12-06 11:16:41 +00:00
go.sum [infra] Use "mod download" and "install", not "get" in chrome_release_branch 2019-12-06 11:16:41 +00:00
LICENSE LICENSE file: clean up 2019-11-22 21:59:03 +00:00
OWNERS add OWNERS file 2017-12-01 19:50:19 +00:00
PRESUBMIT.py Use urllib_request instead of urllib2 in PRESUBMIT. 2019-10-22 20:30:56 +00:00
public.bzl public.bzl: add SKOTTIE_IOS_LIB_{SRCS,HDRS} 2019-12-19 15:34:19 +00:00
README Fix references to https://sites.google.com/site/skiadocs/. 2015-02-03 13:12:54 -02:00
README.chromium Update README.chromium. 2015-06-11 13:19:24 -07:00
RELEASE_NOTES.txt Add back door support for GLSL tessellation shaders 2019-12-27 22:34:10 +00:00
whitespace.txt Whitespace test 2019-05-18 13:05:29 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.