skia2/gm/imageblur2.cpp
mtklein dbfd7ab108 Replace a lot of 'static const' with 'constexpr' or 'const'.
'static const' means, there must be at most one of these, and initialize it at
compile time if possible or runtime if necessary.  This leads to unexpected
code execution, and TSAN* will complain about races on the guard variables.

Generally 'constexpr' or 'const' are better choices.  Neither can cause races:
they're either intialized at compile time (constexpr) or intialized each time
independently (const).

This CL prefers constexpr where possible, and uses const where not.  It even
prefers constexpr over const where they don't make a difference... I want to have
lots of examples of constexpr for people to see and mimic.

The scoped-to-class static has nothing to do with any of this, and is not changed.

* Not yet on the bots, which use an older TSAN.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005

Review-Url: https://codereview.chromium.org/2300623005
2016-09-01 11:24:54 -07:00

94 lines
2.4 KiB
C++

/*
* Copyright 2011 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "gm.h"
#include "SkBlurImageFilter.h"
#include "SkRandom.h"
// TODO deprecate imageblur
#define WIDTH 500
#define HEIGHT 500
constexpr float kBlurSigmas[] = {
0.0, 0.3f, 0.5f, 2.0f, 32.0f, 80.0f };
const char* kTestStrings[] = {
"The quick`~",
"brown fox[]",
"jumped over",
"the lazy@#$",
"dog.{}!%^&",
"*()+=-\\'\"/",
};
namespace skiagm {
class BlurImageFilter : public GM {
public:
BlurImageFilter() {
this->setBGColor(0xFFFFFFFF);
fName.printf("imageblur2");
}
protected:
SkString onShortName() override {
return fName;
}
SkISize onISize() override {
return SkISize::Make(WIDTH, HEIGHT);
}
void onDraw(SkCanvas* canvas) override {
const int sigmaCount = SK_ARRAY_COUNT(kBlurSigmas);
const int testStringCount = SK_ARRAY_COUNT(kTestStrings);
SkScalar dx = WIDTH / sigmaCount;
SkScalar dy = HEIGHT / sigmaCount;
const SkScalar textSize = 12;
for (int x = 0; x < sigmaCount; x++) {
SkScalar sigmaX = kBlurSigmas[x];
for (int y = 0; y < sigmaCount; y++) {
SkScalar sigmaY = kBlurSigmas[y];
SkPaint paint;
paint.setImageFilter(SkBlurImageFilter::Make(sigmaX, sigmaY, nullptr));
canvas->saveLayer(nullptr, &paint);
SkRandom rand;
SkPaint textPaint;
textPaint.setAntiAlias(false);
textPaint.setColor(sk_tool_utils::color_to_565(rand.nextBits(24) | 0xFF000000));
sk_tool_utils::set_portable_typeface(&textPaint);
textPaint.setTextSize(textSize);
for (int i = 0; i < testStringCount; i++) {
canvas->drawText(kTestStrings[i],
strlen(kTestStrings[i]),
SkIntToScalar(x * dx),
SkIntToScalar(y * dy + textSize * i + textSize),
textPaint);
}
canvas->restore();
}
}
}
private:
SkString fName;
typedef GM INHERITED;
};
//////////////////////////////////////////////////////////////////////////////
DEF_GM(return new BlurImageFilter;)
}