AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0f46450775
skia2/tests/sksl/inliner/golden
History
John Stiles 0f46450775 Reland "Remove inliner from IR generation stage." 
This reverts commit 4c412bce4c.

Reason for revert: investigating Pinpoint failure cases, if any

Original change's description:
> Revert "Reland "Remove inliner from IR generation stage.""
>
> This reverts commit e497a08065.
>
> Reason for revert: Pinpoint disagrees
>
> Original change's description:
> > Reland "Remove inliner from IR generation stage."
> >
> > This reverts commit 941fc7174f.
> >
> > Reason for revert: performance now seems to be roughly equal or better
> > (~1%) over several trials.
> > Nanobench: http://screen/A8e8sojaXBgbMgF
> >
> > Original change's description:
> > > Revert "Remove inliner from IR generation stage."
> > >
> > > This reverts commit 21d7778cb5.
> > >
> > > Reason for revert: Pinpoint absolutely hates this change
> > >
> > > Original change's description:
> > > > Remove inliner from IR generation stage.
> > > >
> > > > There is no need to inline code during IR generation, as the optimizer
> > > > can now handle this.
> > > >
> > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b
> > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971
> > > > Commit-Queue: John Stiles <johnstiles@google.com>
> > > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > > Auto-Submit: John Stiles <johnstiles@google.com>
> > >
> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
> > >
> > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976
> > > Reviewed-by: John Stiles <johnstiles@google.com>
> > > Commit-Queue: John Stiles <johnstiles@google.com>
> >
> > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
> >
> > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891
> > Reviewed-by: John Stiles <johnstiles@google.com>
> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> > Auto-Submit: John Stiles <johnstiles@google.com>
>
> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
>
> Change-Id: I79149467565f22f53b8c28868dd53b80f3421137
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626
> Reviewed-by: John Stiles <johnstiles@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 18:44:07 +00:00
..
DoWhileBodyMustBeInlinedIntoAScope.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
DoWhileTestCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
ExponentialGrowth.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ExponentialGrowthStandaloneSettings.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ForBodyMustBeInlinedIntoAScope.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ForInitializerExpressionsCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ForWithoutReturnInsideCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ForWithReturnInsideCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
IfBodyMustBeInlinedIntoAScope.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
IfElseBodyMustBeInlinedIntoAScope.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
IfElseChainWithReturnsCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
IfTestCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
IfWithReturnsCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlineKeywordOverridesThreshold.glsl Factor out Inliner candidate list assembly into its own function. 2020-10-02 20:39:24 +00:00
InlinerAvoidsVariableNameOverlap.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlinerCanBeDisabled.glsl Stop cloning builtin functions 2020-11-20 15:02:54 +00:00
InlinerCanBeDisabledStandaloneSettings.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlinerManglesNames.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlinerWrapsEarlyReturnsWithDoWhileBlock.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlinerWrapsEarlyReturnsWithDoWhileBlockStandaloneSettings.glsl Rename 'DefaultSettings' golden outputs to 'StandaloneSettings'. 2020-09-21 22:15:51 +00:00
InlineThreshold.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
InlineWithInoutArgument.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlineWithModifiedArgument.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlineWithNestedBigCalls.glsl Factor out Inliner candidate list assembly into its own function. 2020-10-02 20:39:24 +00:00
InlineWithNestedCalls.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
InlineWithUnmodifiedArgument.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
InlineWithUnnecessaryBlocks.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
ShortCircuitEvaluationsCannotInlineRightHandSide.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
SwitchWithCastCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
SwitchWithoutReturnInsideCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
SwitchWithReturnInsideCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
SwizzleCanBeInlinedDirectly.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
TernaryResultsCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00
TernaryTestCanBeInlined.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
TrivialArgumentsInlineDirectly.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
WhileBodyMustBeInlinedIntoAScope.glsl Reland "Remove inliner from IR generation stage." 2020-11-20 18:44:07 +00:00
WhileTestCannotBeInlined.glsl Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 15:16:37 +00:00