AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0fe311ac02
skia2/infra
History
Ravi Mistry 18ac3ef222 Revert "[infra] Use Python3 for our Presubmits" 
This reverts commit 094bcdb9e5.

Reason for revert: Breaking Housekeeper-PerCommit-InfraTests_Linux. The bot will have to be updated as part of this change.

Original change's description:
> [infra] Use Python3 for our Presubmits
>
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_support.py;l=319;drc=443d9135cc33f3156d5fe25ebec33f9adffbab65
>
> This also makes any errors from `make train -C infra/bots`
> look well formatted because check_output returns a bytestring
> in Python3 and when that is printed, the newlines et al are not
> rendered correctly. Thus we want the output of check_output
> to be encoded to UTF-8.
>
> Without setting the USE_PYTHON3 = True in PRESUBMIT.py,
> it appears that `git cl upload` would try to run our
> infra_tests.py in Python2 mode, which does not have
> the encoding argument for check_output.
>
> Apparently cipd_bin_packages/vpython3 does not have the
> "six" package installed (but cipd_bin_packages/vpython does)
> so I replaced the six.StringIO with io.StringIO, which
> is where that is located in Python3.
>
> Change-Id: Ic8f61bf943531583ba3d110a85260d69bdbf5eb2
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537677
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

Change-Id: I0becb25d155ce0b0281c25d83662f1b01aee8033
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537777
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ravi Mistry <rmistry@google.com>
2022-05-05 20:54:07 +00:00
..
bots Revert "[infra] Use Python3 for our Presubmits" 2022-05-05 20:54:07 +00:00
canvaskit [canvaskit] Disable dynamic execution 2022-02-01 13:15:22 +00:00
cmake
config Use download topics in recipe_modules/checkout. 2022-04-26 16:58:31 +00:00
cross-compile/docker/cross-linux-arm64
docker Fix Flutter bot by using vpython3 from cipd and setting env vars for it 2021-08-24 20:20:49 +00:00
gcc [infra] Update GCC Docker images to have Python3 2022-04-07 13:54:52 +00:00
lottiecap Reland "[infra] Roll Infra dep to update CIPD packages" with fix 2021-06-22 17:31:55 +00:00
pathkit [infra] Cleanup permissions in our docker build tasks 2021-08-05 12:33:10 +00:00
project-config
wasm-common [canvaskit] Disable dynamic execution 2022-02-01 13:15:22 +00:00
README.md Update references to master branch 2021-05-21 15:18:16 +00:00
skcq.json Use AUTHORS verification from SkCQ 2021-09-30 12:57:44 +00:00

README.md

This directory contains infra-specific files. The branch-config/ directory contains configs that are specific to the main branch (e.g. config for the CQ committing to the main branch), while project-config/ directory contains project-wide configuration (e.g. list of buckets for cr-buildbucket service and list of refs known to the infra services).