afd2c10c98
We used to rely solely on visual bounds for vertical alignment. That had the downside of leading/trailing empty lines being ignored. Then https://skia-review.googlesource.com/c/skia/+/220916 switched to using typographical bounds. This approach produces results in line with AE, but allows some glyphs to overflow the alignment boundary. This CL introduces a hybrid approach: 1) for standard AE text alignment, continue to use typographical bounds 2) for Skottie VAlign extensions (sk_vj), use the union of typographical and visual bounds - this should mitigate both issues mentioned above Change-Id: Ifd3ccae3d721728ce67942206160ebe92056d3a2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224188 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Avinash Parchuri <aparchur@google.com> |
||
---|---|---|
.. | ||
images | ||
skottie_sample_1.json | ||
skottie_sample_2.json | ||
skottie_sample_multiframe.json | ||
skottie_sample_nested.json | ||
skottie_sample_search.json | ||
skottie_sample_webfont.json | ||
skottie-3d-rotation-order.json | ||
skottie-bezier-extranormal.json | ||
skottie-camera-parent-1.json | ||
skottie-camera-parent-2.json | ||
skottie-camera-parent-3.json | ||
skottie-camera-rotation.json | ||
skottie-effects-tranform.json | ||
skottie-gradient-ramp.json | ||
skottie-hidden-shapes-layers.json | ||
skottie-levels-effect.json | ||
skottie-line-height.json | ||
skottie-mask-feather.json | ||
skottie-motiontile-effect-phase.json | ||
skottie-motiontile-effect.json | ||
skottie-radial-wipe-effect.json | ||
skottie-text-animator-1.json | ||
skottie-text-animator-2.json | ||
skottie-text-animator-3.json | ||
skottie-text-animator-4.json | ||
skottie-text-animator-5.json | ||
skottie-text-animator-6.json | ||
skottie-text-animator-7.json | ||
skottie-text-resize-to-fit.json | ||
skottie-text-valign-2.json | ||
skottie-text-valign-bottom.json | ||
skottie-text-valign.json | ||
skottie-transform-effect.json | ||
skottie-venetianblinds-effect.json |