ec9b4aab87
https://clang.llvm.org/extra/clang-tidy/checks/readability-const-return-type.html `const` on a non-pointer/reference return type typically doesn't add value and can have negative side effects. (i.e., returning a `const std::string` isn't meaningfully different from returning a `std::string`, but can sometimes inhibit move-related optimizations.) In Skia's case, the priv() functions are a notable exception where const return types are intentional and valuable. These calls have been marked with NOLINT to exclude them from the check. This check does not affect pointer and reference returns, where constness is important. Change-Id: I86cab92332f164e5ab710b4127182eec99831d7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308564 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| .. | ||
| app | ||
| include | ||
| src | ||
| BUILD.gn | ||
| README.md | ||
Editor
This is an experimental Editor layer that abstracts out SkShaper text layeout for easy embedding into an application. The Editor layer is agnostic about the operating system.
+--------------------------------+
|Application |
+-+----+-------------------------+
| |
| |
| +-v-------------------------+
| |Editor |
| +-+----+--------------------+
| | |
| | |
| | +-v--------------------+
| | |SkShaper |
| | +-+--------+-----------+
| | | |
| | | |
+-v----v----v--+ +-v-----------+
|Skia | |HarfBuzz, ICU|
+--------------+ +-------------+
The Application layer must interact with the:
- Windowing system
- File system
- Clipboard
- Keyboard/mouse input.
Try it out:
tools/git-sync-deps
bin/gn gen out/default
ninja -C out/default editor
out/default/editor resources/text/english.txt
cat resources/text/*.txt > example.txt
out/default/editor example.txt