08ece0c9a0
PS1 regenerates the Bazel files. Use it as the base change when comparing patchsets. IWYU seems to do a good job of working with MyFile.cpp and MyFile.h, but if there is just a MyHeader.h, it doesn't always seem to throw errors if the includes aren't correct. This was observed with include/sksl/DSL.h This might be due to the fact that headers are not compiled on their own, so they are never sent directly to the IWYU binary. This change sets enforce_iwyu_on_package() on the all sksl packages and then fixes the includes until all those checks are happy. There were a few files that needed fixes outside of the sksl folder. Examples include: - src/gpu/effects/GrConvexPolyEffect.cpp - tests/SkSLDSLTest.cpp To really enforce this, we need to add a CI/CQ job that runs bazel build //example:hello_world_gl --config=clang \ --sandbox_base=/dev/shm --features skia_enforce_iwyu If that failed, a dev could make the changes described in the logs and/or run the command locally to see those prescribed fixes. I had to add several entries to toolchain/IWYU_mapping.imp in order to fix some private includes and other atypical choices. I tried adding a rule there to allow inclusion of SkTypes.h to make sure defines like SK_SUPPORT_GPU, but could not get it to work for all cases, so I deferred to using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h) Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
298 lines
9.9 KiB
C++
298 lines
9.9 KiB
C++
/*
|
|
* Copyright 2020 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SKSL_DSL_EXPRESSION
|
|
#define SKSL_DSL_EXPRESSION
|
|
|
|
#include "include/private/SkTArray.h"
|
|
#include "include/sksl/SkSLPosition.h"
|
|
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <string_view>
|
|
|
|
#if defined(__has_cpp_attribute) && __has_cpp_attribute(clang::reinitializes)
|
|
#define SK_CLANG_REINITIALIZES [[clang::reinitializes]]
|
|
#else
|
|
#define SK_CLANG_REINITIALIZES
|
|
#endif
|
|
|
|
namespace SkSL {
|
|
|
|
class Expression;
|
|
class ExpressionArray;
|
|
|
|
namespace dsl {
|
|
|
|
class DSLPossibleExpression;
|
|
class DSLType;
|
|
class DSLVarBase;
|
|
template <typename T> class DSLWrapper;
|
|
|
|
/**
|
|
* Represents an expression such as 'cos(x)' or 'a + b'.
|
|
*/
|
|
class DSLExpression {
|
|
public:
|
|
DSLExpression(const DSLExpression&) = delete;
|
|
|
|
DSLExpression(DSLExpression&&);
|
|
|
|
DSLExpression();
|
|
|
|
/**
|
|
* Creates an expression representing a literal float.
|
|
*/
|
|
DSLExpression(float value, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an expression representing a literal float.
|
|
*/
|
|
DSLExpression(double value, Position pos = Position::Capture())
|
|
: DSLExpression((float) value) {}
|
|
|
|
/**
|
|
* Creates an expression representing a literal int.
|
|
*/
|
|
DSLExpression(int value, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an expression representing a literal int.
|
|
*/
|
|
DSLExpression(int64_t value, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an expression representing a literal uint.
|
|
*/
|
|
DSLExpression(unsigned int value, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an expression representing a literal bool.
|
|
*/
|
|
DSLExpression(bool value, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an expression representing a variable reference.
|
|
*/
|
|
DSLExpression(DSLVarBase& var, Position pos = Position::Capture());
|
|
|
|
DSLExpression(DSLVarBase&& var, Position pos = Position::Capture());
|
|
|
|
DSLExpression(DSLPossibleExpression expr, Position pos = Position::Capture());
|
|
|
|
explicit DSLExpression(std::unique_ptr<SkSL::Expression> expression);
|
|
|
|
static DSLExpression Poison(Position pos = Position::Capture());
|
|
|
|
~DSLExpression();
|
|
|
|
DSLType type();
|
|
|
|
/**
|
|
* Overloads the '=' operator to create an SkSL assignment statement.
|
|
*/
|
|
DSLPossibleExpression operator=(DSLExpression other);
|
|
|
|
DSLExpression x(Position pos = Position::Capture());
|
|
|
|
DSLExpression y(Position pos = Position::Capture());
|
|
|
|
DSLExpression z(Position pos = Position::Capture());
|
|
|
|
DSLExpression w(Position pos = Position::Capture());
|
|
|
|
DSLExpression r(Position pos = Position::Capture());
|
|
|
|
DSLExpression g(Position pos = Position::Capture());
|
|
|
|
DSLExpression b(Position pos = Position::Capture());
|
|
|
|
DSLExpression a(Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an SkSL struct field access expression.
|
|
*/
|
|
DSLExpression field(std::string_view name, Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Creates an SkSL array index expression.
|
|
*/
|
|
DSLPossibleExpression operator[](DSLExpression index);
|
|
|
|
DSLPossibleExpression operator()(SkTArray<DSLWrapper<DSLExpression>> args,
|
|
Position pos = Position::Capture());
|
|
|
|
DSLPossibleExpression operator()(ExpressionArray args,
|
|
Position pos = Position::Capture());
|
|
|
|
/**
|
|
* Returns true if this object contains an expression. DSLExpressions which were created with
|
|
* the empty constructor or which have already been release()ed do not have a value.
|
|
* DSLExpressions created with errors are still considered to have a value (but contain poison).
|
|
*/
|
|
bool hasValue() const {
|
|
return fExpression != nullptr;
|
|
}
|
|
|
|
/**
|
|
* Returns true if this object contains an expression which is not poison.
|
|
*/
|
|
bool isValid() const;
|
|
|
|
SK_CLANG_REINITIALIZES void swap(DSLExpression& other);
|
|
|
|
/**
|
|
* Invalidates this object and returns the SkSL expression it represents. It is an error to call
|
|
* this on an invalid DSLExpression.
|
|
*/
|
|
std::unique_ptr<SkSL::Expression> release();
|
|
|
|
private:
|
|
/**
|
|
* Calls release if this expression has a value, otherwise returns null.
|
|
*/
|
|
std::unique_ptr<SkSL::Expression> releaseIfPossible();
|
|
|
|
std::unique_ptr<SkSL::Expression> fExpression;
|
|
|
|
friend DSLExpression SampleChild(int index, DSLExpression coords);
|
|
|
|
friend class DSLCore;
|
|
friend class DSLFunction;
|
|
friend class DSLPossibleExpression;
|
|
friend class DSLType;
|
|
friend class DSLVarBase;
|
|
friend class DSLWriter;
|
|
template<typename T> friend class DSLWrapper;
|
|
};
|
|
|
|
DSLPossibleExpression operator+(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator+(DSLExpression expr);
|
|
DSLPossibleExpression operator+=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator-(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator-(DSLExpression expr);
|
|
DSLPossibleExpression operator-=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator*(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator*=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator/(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator/=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator%(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator%=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator<<(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator<<=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator>>(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator>>=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator&&(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator||(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator&(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator&=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator|(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator|=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator^(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator^=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression LogicalXor(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator,(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator,(DSLPossibleExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator,(DSLExpression left, DSLPossibleExpression right);
|
|
DSLPossibleExpression operator,(DSLPossibleExpression left, DSLPossibleExpression right);
|
|
DSLPossibleExpression operator==(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator!=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator>(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator<(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator>=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator<=(DSLExpression left, DSLExpression right);
|
|
DSLPossibleExpression operator!(DSLExpression expr);
|
|
DSLPossibleExpression operator~(DSLExpression expr);
|
|
DSLPossibleExpression operator++(DSLExpression expr);
|
|
DSLPossibleExpression operator++(DSLExpression expr, int);
|
|
DSLPossibleExpression operator--(DSLExpression expr);
|
|
DSLPossibleExpression operator--(DSLExpression expr, int);
|
|
|
|
/**
|
|
* Represents an Expression which may have failed and/or have pending errors to report. Converting a
|
|
* PossibleExpression into an Expression requires a Position so that any pending errors can be
|
|
* reported at the correct position.
|
|
*
|
|
* PossibleExpression is used instead of Expression in situations where it is not possible to
|
|
* capture the Position at the time of Expression construction (notably in operator overloads, where
|
|
* we cannot add default parameters).
|
|
*/
|
|
class DSLPossibleExpression {
|
|
public:
|
|
DSLPossibleExpression(std::unique_ptr<SkSL::Expression> expression);
|
|
|
|
DSLPossibleExpression(DSLPossibleExpression&& other);
|
|
|
|
~DSLPossibleExpression();
|
|
|
|
bool valid() const {
|
|
return fExpression != nullptr;
|
|
}
|
|
|
|
/**
|
|
* Reports any pending errors at the specified position.
|
|
*/
|
|
void reportErrors(Position pos);
|
|
|
|
DSLType type();
|
|
|
|
DSLExpression x(Position pos = Position::Capture());
|
|
|
|
DSLExpression y(Position pos = Position::Capture());
|
|
|
|
DSLExpression z(Position pos = Position::Capture());
|
|
|
|
DSLExpression w(Position pos = Position::Capture());
|
|
|
|
DSLExpression r(Position pos = Position::Capture());
|
|
|
|
DSLExpression g(Position pos = Position::Capture());
|
|
|
|
DSLExpression b(Position pos = Position::Capture());
|
|
|
|
DSLExpression a(Position pos = Position::Capture());
|
|
|
|
DSLExpression field(std::string_view name, Position pos = Position::Capture());
|
|
|
|
DSLPossibleExpression operator=(DSLExpression expr);
|
|
|
|
DSLPossibleExpression operator=(int expr);
|
|
|
|
DSLPossibleExpression operator=(float expr);
|
|
|
|
DSLPossibleExpression operator=(double expr);
|
|
|
|
DSLPossibleExpression operator[](DSLExpression index);
|
|
|
|
DSLPossibleExpression operator()(SkTArray<DSLWrapper<DSLExpression>> args,
|
|
Position pos = Position::Capture());
|
|
|
|
DSLPossibleExpression operator()(ExpressionArray args,
|
|
Position pos = Position::Capture());
|
|
|
|
DSLPossibleExpression operator++();
|
|
|
|
DSLPossibleExpression operator++(int);
|
|
|
|
DSLPossibleExpression operator--();
|
|
|
|
DSLPossibleExpression operator--(int);
|
|
|
|
std::unique_ptr<SkSL::Expression> release(Position pos = Position::Capture());
|
|
|
|
private:
|
|
std::unique_ptr<SkSL::Expression> fExpression;
|
|
|
|
friend class DSLExpression;
|
|
};
|
|
|
|
} // namespace dsl
|
|
|
|
} // namespace SkSL
|
|
|
|
#endif
|