cfbb56c6e1
Two issues: 1) For static keyframes (start_value == end_value) AE yields horizontal orientation (0 tangent). We technically have the same logic in Skottie, but our value deduplication logic interferes: the two consecutive equal values are consolidated, and the result ends up holding the spatial lerp info for the next frame => our hold frames auto-orient for the beginning of the next keyframe. Fix: skip value deduplication when spatial lerp is present. 2) The very last keyframe is always static and holds no spatial info. AE retains the orientation of the previous frame, but Skottie yields 0 tangent. Fix: the easiest way to accomplish AE semantics is to detect when we're dealing with the last keyframe, and swap with the previous keyframe with an adjust weight of 1 (to select the end value). This produces the same lerp result (because keyframed values are always contiguous) and also respects the orientation of the prev frame. TBR= Change-Id: Id661f7804533e95b747722457489a7ef759572a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/301176 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> |
||
|---|---|---|
| .. | ||
| android_fonts | ||
| diff_canvas_traces | ||
| empty_images | ||
| fonts | ||
| icc_profiles | ||
| images | ||
| invalid_images | ||
| lua | ||
| nima | ||
| particles | ||
| skottie | ||
| text | ||
| Cowboy.svg | ||
| crbug769134.fil | ||
| nov-talk-sequence.txt | ||
| pdf_command_stream.txt | ||
| README | ||
| SkVMTest.expected | ||
The resources directory includes some third party content used by Skia. Licenses for that code are included in this file. Openclipart Openclipart uses the Creative Commons Zero 1.0 Public Domain License every time an artist uploads a piece of clipart to Openclipart to make it clear the artist is releasing the creative work for anyone to use for any reason, even commercially. This act of "sharing" is the foundation Openclipart is based upon. More details on the license can be found at https://creativecommons.org/publicdomain/zero/1.0/. LGPL or compatible (as implied by inclusion in KDE SVN) http://websvn.kde.org/trunk/tests/ksvgtests/custom/cowboy.svg